From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D972AC0218F for ; Sun, 2 Feb 2025 13:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C243280002; Sun, 2 Feb 2025 08:51:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 473266B0092; Sun, 2 Feb 2025 08:51:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33BB9280002; Sun, 2 Feb 2025 08:51:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 158B96B008C for ; Sun, 2 Feb 2025 08:51:45 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 51D984A513 for ; Sun, 2 Feb 2025 13:51:44 +0000 (UTC) X-FDA: 83075142528.07.0357FF6 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf08.hostedemail.com (Postfix) with ESMTP id 53C68160002 for ; Sun, 2 Feb 2025 13:51:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mWh/euru"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of honggyu.km@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=honggyu.km@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738504302; a=rsa-sha256; cv=none; b=UTYwnJgC+xyuSOaRRG9b6ZqIZ5IOvIQrMvzQIQbEORmfOc2s3wFulpbs343ADZRC33IGKI 6KpjLeXPuvEsjFZ/g/6d72ktvicHnpHUc6RYlhnJiJ1iYO6Z/YMKnggAf8E4e7SlPrzxDB rR6+65Re0+njgbwzmdrx2f+J1hlASOk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mWh/euru"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of honggyu.km@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=honggyu.km@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738504302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fcPdAlmSrROAe9gGhBlGWoPyUgAHcTFNljv1EQXHqYY=; b=13AHchP4iJ4Q/Yhdet37a1jc61z0h6GRjrALJyWSM8ScrRCMuestnDcn4LrCvDoTPHKUs4 cdpCSSplDhykEyaUES1amNdSIkLRLKIPbnxdvyAVyLZ9FjQA6i6Tig/Jwi8U5+xYh76j7W F+bnLyRPIgAT/cGbEwwPBKwhgXfnUYA= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2165cb60719so62154125ad.0 for ; Sun, 02 Feb 2025 05:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738504301; x=1739109101; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fcPdAlmSrROAe9gGhBlGWoPyUgAHcTFNljv1EQXHqYY=; b=mWh/eurusAXD97jbQV1x7vdFVW8pwxsA91Hz8Yo5CaT4w1OF2W+3+54fggMNLtF1V5 TIXIkME0cC8wnnTuH+GfjWdqCZjyA+rwvlDiGZF9kwLhjMTg5u2YRY1dxOjdzaYkkhwh bSK1f7BtbgiEj/S/6cXd4I6T2KsbMHBKGRd3VA1UC6p9NMF+5T8tVU4YE/aBUMX4exeF QJv46Jrn7NUBNXGwFQD+0qytpvbuIDNMKThJlSHZ4ldFtJwfcSl5A5phWPd94fuF4LQK RJUQU4GdHfpqsD6HsB1qJJPahF78fGqbpVEyakKRo2Q66hcE26x3u0hD6tyHkjDcGq1w MrDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738504301; x=1739109101; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fcPdAlmSrROAe9gGhBlGWoPyUgAHcTFNljv1EQXHqYY=; b=GPv260DdDbR35Hqu/Nf+gmxHoOQUc9gV7MO4yyoK7UU6IA94V6JgJjOjdhjyK4F1yo 9Dp24pOLHGmZqePGW3w7uBEfOH1ROx1z/1l9vBFpjgJPmkU27CTeLDkmh0JEJytWFzLy tve/eBt7ZtXB6OJWiY6dcG2DWLKtTobuyb6ExlhkYncrwGEHQcNrR/A8MjU9M0Rmju9k zxqfB08EaqSHmHxMA/W/VDb7L81nZjVAV/9DbP6O6kUP9pShJsD40jBsZG5woB7p5RfC xisQvum4lEQA3nbcQDuNuhj8hx+c6p48y+ALa20BZPs8FvzUxdePXrY5Aacese8cP5nN QMxA== X-Forwarded-Encrypted: i=1; AJvYcCV65cmIH/PVhnN6gnVxe4/QBMTjo/taculHodT64xCgNCXgD9qvjB2CQXU/KUp9GKhHpKTogeCo/Q==@kvack.org X-Gm-Message-State: AOJu0YxHV42YJg0KLeONDiPRXbKlhjUk9EI/Yv8alC2taVe3vejkts1N x7Be8eFC5klRtV1+s/Yz7Ju67u6I+Df/VZaNZGMXxrtTN7eGyb67 X-Gm-Gg: ASbGncsAhI9T5jz367DQJVcQ32r/RmRLf2fEwpF8mSEbhWNJaUZyZPjhjCPiPgNZxUM yxta1LLBXUstcBms+lYgy5AxYl6Q4aLoxzkGI3JlPelT+MkWaAKTnuohm0s3WevcwAGTMmSUrfE Pl8liwe95KHGEUefvgPzZIUUxbeKH3wc62Mi/d1Wou2a7o4yXeLt1X1hdKhoCPtZSGSIri3TPEZ vmLQ+KpwkUB6re801zzZby64MpijMeg3sZCxi0uGT9+yvUhsnM3RsZLtpuiB/miAH1CmocGUmki Edkvxa8Qy/1m3ZfExY10zgij X-Google-Smtp-Source: AGHT+IGSrt5p3ZW1z1QTxJFz4FNWGjTmymX8g7rfyX1880uET2qfvQtym1j/XhhlXAUGGdw2/o+AFg== X-Received: by 2002:a17:902:f610:b0:216:4348:149d with SMTP id d9443c01a7336-21dd7dfb835mr324407195ad.53.1738504301080; Sun, 02 Feb 2025 05:51:41 -0800 (PST) Received: from [192.168.75.213] ([116.121.188.179]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de3303cdbsm58016825ad.199.2025.02.02.05.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Feb 2025 05:51:40 -0800 (PST) Message-ID: <9edfb12f-5e1d-4de0-b124-37053125a7e0@gmail.com> Date: Sun, 2 Feb 2025 22:51:34 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning To: Gregory Price Cc: Joshua Hahn , ying.huang@linux.alibaba.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, kernel_team@skhynix.com, 42.hyeyoo@gmail.com References: <20250128222332.3835931-1-joshua.hahnjy@gmail.com> <41ab5a11-f8d3-403c-9d68-33eb15aef8fa@gmail.com> Content-Language: en-US From: Honggyu Kim In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53C68160002 X-Stat-Signature: 5qd3ofyhhra7g145pctif4hc3myh1tsf X-HE-Tag: 1738504302-985902 X-HE-Meta: U2FsdGVkX1+VCgx5B990XkBC8z25pk8mnj/18+5lmhNVeMUqt1rqMKWLlmapseW9X9X+O3DHjnG7KeWpudbIkK+VYNJ0iuP+sBqe3Ppc7D5CSllYGci1EXsoBvT47rPbHuyjf2awO8vbHgx0MFuVfEybbYQi6DmQWLiawSbTFhgqksTpuS91g84v4EVeWZTXDxqJVIVv43WpS3k/4KddHQoXjnHJlIgKW3c532fibBXeVDnhn1Pdg/Gi6WiL45hVSF1lh1wdjsl+gQmb374ul45IneBa6a9OPxWxsxqFt0U6n0BUVfYZ1w+0qV/xjY3xZKY5JydVeqAQtxpmDJ02QvGdNptmDwxM1UuA8JD9zNiNKBery3hBZRwadFh6ogE++1xJ0Vodn20hB9C1fNOb6BiJE7uGQ2KQBeUkobsO5otj3EH1ys8LxgsDkyJW0jJnfVrdwbzMAK2lNCqeX3B+Oazsva9hbopf25TkzyXWzLgBo5BH1khj6yIIlog8YuOoSLRCodZFUWdnBMo2RgPzRARw9boVsHKFo5EqFvGEVWicuWmo43aqKOWBP1CBt5qkB+Rz7XhUM56mtkxbl7Z+sG407c5oB9I4CJnNI8YYVqo4viBUFJIZS49pIgLa+okh30vh1+G41eP9baECcLZTUMeks1zv1JL7F/O/qZsK0QoNWcTfSMQfIMhLDkRZfWel0x8KQv7d76qiDFBGb1nVlLOVGEnU2by0TkMG2eFiyOHh1fk439+FWYMUo2mJtfOMw4PyMFrPJuNXBH/1JN9BpgiIGBDdYmKItfFgBeCgL0TOsjxsj9LtwnsJLa2I5D1F+1ZQWQwuEhJFK+zf/EHrnNtJUAXJBqTlr9bvhM+dsqdPYdwantkKuU1yYYeQ6Pq7hUBAjV2Zv2PaFsAaP9twDpLOalZADs3tgpGtAtBm/txmWy2a0VnZSapADCbuPfu6Be1tWW6uQ0GD/CsegzZ Js0WximJ Q8TguoMFQyc4kSMxpFiRMiWDNfxwe+zGSljrd2MKyLkkYEy3rWOOsbH+/G9KpYCqthr++3hUYKEgV48XBSt9F49zHubW02VRWi1aP31aUSUVqIsl+Ebw5rqKt8pJTFYqbBFX3uZLXFrA6lNp0KSHFsYVSPbNbvmdhE9Gh0v9Vp8YhpflIDcmWSVPC9Om3Nnk0hF/9U0tMUVlKr9pfrNsdV9Ly6DstbfIOLqh0nkcUg1vc/0W/8uc2fPC44R6W9uKSyj3djAVs+ZLMoZZUNBuzceKMaZc6xd1dFCKjJHf4+rwh2908TiCZbN/3cOlwwEJrtNz4QnHlSSgKN/FiOFqnzxEWGksMSe7+BRYo7ACijBX/IpvreyiK7UeljpE+7q3aiQ4MDRgOSFa07ogW3If8g1342auM7BP1vJblDRxkblAClET/KT1ymcMJDsmWQ22hkJIwl5xhPediUEUDJOh5f9/MFkbfaiXKCwFhstc1dLW0T6VDTeLubdbXOe5NdjTAKf9b X-Bogosity: Ham, tests=bogofilter, spamicity=0.003307, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/2/25 01:53, Gregory Price wrote: > On Sat, Feb 01, 2025 at 11:49:31AM -0500, Gregory Price wrote: >>> 1. the auto mode set the weights as 10:5:1 for node{0-2}. >>> 2. node2 is offlined, then recalculation makes it as 2:1 for node{0,1}. > > Point of clarification here: a hot-unplug event won't cause > recalculation. > > What actually causes re-weight is hot-plug reporting new capacity. So do you mean re-weight is done only when a new node is onlined while offline doesn't trigger re-weight? I see node_set_perf_attrs() does recalculation by calling mempolicy_set_node_perf(), then reduce_interleave_weights(). But I'm not sure if the re-weight is done via node_set_perf_attrs() only when a new node is onlined. Could you please explain where I can find it? > > So in this scenario, the weight will remain the same for node2. If it's true, my scenario is wrong. Thanks, Honggyu > >>> 3. the auto sysfs interface is set to 0 to make it manual mode.