From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1827C4167B for ; Thu, 2 Nov 2023 12:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12EB380020; Thu, 2 Nov 2023 08:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF618D000F; Thu, 2 Nov 2023 08:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE7A580020; Thu, 2 Nov 2023 08:04:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E02FF8D000F for ; Thu, 2 Nov 2023 08:04:48 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A58044016F for ; Thu, 2 Nov 2023 12:04:48 +0000 (UTC) X-FDA: 81412882656.12.2097353 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id C264D1C0020 for ; Thu, 2 Nov 2023 12:04:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698926686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=27DdC+awEz/2U72C/spT7ytDMj+vQaI0h6ijVadu0Ig=; b=IpnDk6+kj/1pefQM2ZBxNueRU4H0DNm0yxCTxiZjmOyw3UR8loGba0UkMG+9071U1RXxNl Ga1S2fG5dGYY/NWhtJ/mYhiBF4lDFmuZnHHfhX0lZNQg/XDhs9BnikmLn9tT/Uvid+EB/4 moUDSbveXCy1I3TeeURKasfweQYH4F8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698926686; a=rsa-sha256; cv=none; b=bxydJFnORcvtjU/IVWi9HgbPdd2m/Q5Z+YVO0aW8A2QGmTvzeoRswGTSi9Zo+2nB4gvl63 rd7vTIktrOGB4vbk86hAFp2ij2ttxeb1Rs2yWLrtbfInufPnksdGAJdN2Mc0HMz5Dpoi1r xto3qUaT2rxvz1KVWbXMYMQznIavaNk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6C8B2F4; Thu, 2 Nov 2023 05:05:27 -0700 (PDT) Received: from [10.1.33.173] (XHFQ2J9959.cambridge.arm.com [10.1.33.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A1A93F67D; Thu, 2 Nov 2023 05:04:41 -0700 (PDT) Message-ID: <9edbf5f2-efce-40f1-ae7c-34607d9700ce@arm.com> Date: Thu, 2 Nov 2023 12:04:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests Content-Language: en-GB To: Muhammad Usama Anjum , Peter Xu , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman Cc: Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand References: <20230821141518.870589-1-usama.anjum@collabora.com> <20230821141518.870589-7-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C264D1C0020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: w6qwwhi44qax8mfkpxcguo97k95sa8qp X-HE-Tag: 1698926686-14981 X-HE-Meta: U2FsdGVkX1/oO3XGMdl4rUmwt61kR8RP75zspKvx1Xm2bAlwn9E/yQ5ettUk3u4hObMS0QIHcUxdUPGTD54Sd1sOlS3OZXm1Uhn/vQPQ3hEpcTP2uOpkSJetqK933ywUoceDf81wRbOQQZzoHnFKdQk3VLF1uK8uTy2pq4LKRqnPkYcQDfCKkTgUIOUj1Ez1WcgAQsRNFwT9AC78amfFR3LUIm1fN8ULQlnLDrm2J8U586ePQ/+EESgeJPlXAxofFkDzcPfu/YVUpMEgUfbJ+dmyBh3mNH3PbycGUxOBCGMXQDBKpYVEn9J/uh2BH7qXwb3WL4j1k4StBU99hLcAHiIROEC7fcf2vkD3DHepSBIExtLt1NvTjQ2y2+JklZzW8/Ttt3csqfYscYeEsSObSWoK/vw6upBxcAnkpnkRn5K9dCD3acEgoMNgGX9LXYt5aeZlwWN/NQlnMZUEOxKdNxsYezQLppP3dpwro42yrvupcusJmz/BN7z9boIlOr6MhjfS5IBsfvmSUCkkAaKA6/S2cMnjDLaHt62Q39StSxTkAscCn7wjT/MKL5ZdZiBo1hJtwEVR8CaWLxhtkdavTlhDry75Pa3pXF5oJ9qjaGRab+12IvmdMeMR2AdmF6mwpAfM20uWZuZo9u6kE2wRYLwmEz+M+yH41PqA60zsDCPN9f2ZJX62wimQLM4fq/N78REdnOiQhVc8ho4sqm14J5h8aZHqx11bu9q3rO0vZ+26OLw7zlC4dj2zf0gGVdutO4DHI9ChT4jkrotJe9+F+CybgYquZ9/S5UbwbGnQBvZZNNok8TULBLhoT5VTyqztqvpke+VhS1oEcvXHV4i1gkugcZDtUSXZ4Wnj80lVREbT0ROJzzrHlI+UtGqaZLmIz1hDmxlJOOJkCJEr/gr83u69pORo4FfDAlm6ENZAFSIFXXWuU1t6/dRQ40ePkVzAbMcgMatKnqmLHv7ECZm VrSP/aC7 TQ6TBEioynmLILQBHdwjPEmjriIyJTAsU65H6WhuSFcES/vkUwQtSiK//7KXxZkXpRgyCiaPa4hrIlUfU/wD297NjQSsgNw5/yjSD4yp1Yk3YNXROCM2f6NvBLl1x00dLGUyR/Ml80xu5K75A7kLixuVnpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/11/2023 11:49, Muhammad Usama Anjum wrote: > On 11/2/23 4:45 PM, Ryan Roberts wrote: >> On 21/08/2023 15:15, Muhammad Usama Anjum wrote: >> >> [...] >> >>> + >>> + >>> +int init_uffd(void) >>> +{ >>> + struct uffdio_api uffdio_api; >>> + >>> + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); >>> + if (uffd == -1) >>> + ksft_exit_fail_msg("uffd syscall failed\n"); >>> + >>> + uffdio_api.api = UFFD_API; >>> + uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | >>> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM; >>> + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) >>> + ksft_exit_fail_msg("UFFDIO_API\n"); >>> + >>> + if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) || >>> + !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) >>> + ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api); >> >> Hi, >> >> I've just noticed that this fails on arm64 because the required features are not >> available. It's common practice to skip instead of fail for this sort of >> condition (and that's how all the other uffd tests work). The current fail >> approach creates noise in our CI. >> >> I see this is already in mm-stable so perhaps we can add a patch to fix on top? > Yeah, we can add a patch to skip all the tests instead of failing here. Let > me send a patch this week. Thats great - thanks for the fast response! > >> >> Thanks, >> Ryan >> >> >