From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C602CC433F5 for ; Mon, 21 Mar 2022 15:38:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 229B96B0073; Mon, 21 Mar 2022 11:38:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B26E6B0074; Mon, 21 Mar 2022 11:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004DB6B0075; Mon, 21 Mar 2022 11:38:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id DF42C6B0073 for ; Mon, 21 Mar 2022 11:38:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 984AFA30AB for ; Mon, 21 Mar 2022 15:38:27 +0000 (UTC) X-FDA: 79268800254.24.39C1B22 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 09E20140009 for ; Mon, 21 Mar 2022 15:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647877106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IK56FkfaiX8vj6FFbros1BGgufggGCH6F0d0KCKn2Mk=; b=Cuu4h5nOgNPMzG/cWdEvPFthGvXBMJTufuXaPoDV4nGI+x2joA3IgMxtkZ7eZcUHdBpTng JydUUU/bNH8zSiaBaauQZM4p6yobRtICW9EsU4zmnZAEdtmzOiRGVkcDFzVWE8RSBJj/n/ IJdWMDuVzgJDkkXKhL5bn8YmZlqAEBw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-m4oMB5aTNYOF0yQrrb2niQ-1; Mon, 21 Mar 2022 11:38:25 -0400 X-MC-Unique: m4oMB5aTNYOF0yQrrb2niQ-1 Received: by mail-wm1-f71.google.com with SMTP id bg28-20020a05600c3c9c00b0038c8da4d9b3so5052823wmb.0 for ; Mon, 21 Mar 2022 08:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=IK56FkfaiX8vj6FFbros1BGgufggGCH6F0d0KCKn2Mk=; b=UCRwwbc/00qrg4NrhQk3iSGGp3wAeRqFrPbCG2tDe8H2aHUwuxnmTHKh1vbqkFoDm2 b14eAkmInNPax7DyhD5Wrka8EnD05f+CMEgjU/rm+R8Oq6ddLPRKLBX7DTqC52aBjImF 81iysS7oo1KLvzTZwqREprHuFjRTCQDib8wW0YAucE+NHcNquSIBPv7Y+mg8a/vCO63M KVFSyeLXImfModw6dKWnc0AWbt3MppPpKjarCh22AhwHKQ1yt/XZpo9EIGONvNELxvfS LkYFWdiF1P3zQLNY66Xnal9GzRm4EPZu4gSMPn7YsE+yj2bYrgUKYFTa3iW0NjWSjnHx DsoQ== X-Gm-Message-State: AOAM5301+8c+N9iuUroeEQbAa6BqyxedFIkgEPMGBsa1NB+oJoa1TOY+ i1M6g+4+LsfQ5SbTop2R9idyeCOCK0CneeoBxlrCw4lMtKRlli3eMpbwiEtxoukbhU8kep/TcrD bUjjgG+QQxr0= X-Received: by 2002:a5d:6da5:0:b0:1f1:f968:1a62 with SMTP id u5-20020a5d6da5000000b001f1f9681a62mr19118920wrs.227.1647877103962; Mon, 21 Mar 2022 08:38:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys4YpAtiVdUKa/+qbQgq/FGiMD5QA9HPxmGExmBsZMeDmqFq2njLygrGsf2E9s17Exez4gmQ== X-Received: by 2002:a5d:6da5:0:b0:1f1:f968:1a62 with SMTP id u5-20020a5d6da5000000b001f1f9681a62mr19118906wrs.227.1647877103667; Mon, 21 Mar 2022 08:38:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:4900:849b:f76e:5e1f:ff95? (p200300cbc7044900849bf76e5e1fff95.dip0.t-ipconnect.de. [2003:cb:c704:4900:849b:f76e:5e1f:ff95]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm21194402wmp.13.2022.03.21.08.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 08:38:23 -0700 (PDT) Message-ID: <9ece8da5-ae0c-fe1c-ff2f-961f641c00fe@redhat.com> Date: Mon, 21 Mar 2022 16:38:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 To: Matthew Wilcox Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Hugh Dickins , Alex Sierra , Alistair Popple , Miaohe Lin , Mike Rapoport , William Kucharski References: <9ae0a8e4-41b7-04f4-4435-17cbba9850fb@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [GIT PULL] Folio patches for 5.18 (MM part) In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 09E20140009 X-Stat-Signature: pyrxo5f4fxi3mfsndttjah79n16o58nz Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cuu4h5nO; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1647877106-598004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.03.22 16:31, Matthew Wilcox wrote: > On Mon, Mar 21, 2022 at 04:24:08PM +0100, David Hildenbrand wrote: >> On 21.03.22 16:16, David Hildenbrand wrote: >>> On 21.03.22 14:30, Matthew Wilcox wrote: >>>> Hi Linus, >>>> >>>> This is the first of two folio-related pull requests for this merge >>>> window. This is the MM side of things and we had some unfortunate >>>> complex merge conflicts to resolve. I decided to redo my changes on >>>> top of Hugh's and Christoph's patches, so I'm the one sending the >>>> pull request. >>>> >>>> The following changes since commit f71077a4d84bbe8c7b91b7db7c4ef815755ac5e3: >>>> >>>> Merge tag 'mmc-v5.17-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc (2022-02-16 12:09:22 -0800) >>>> >>>> are available in the Git repository at: >>>> >>>> git://git.infradead.org/users/willy/pagecache.git tags/folio-5.18 >>>> >>>> for you to fetch changes up to 5063f22c914e3e5f2239cf91f4986042dc705bde: >>>> >>>> mm/damon: minor cleanup for damon_pa_young (2022-03-16 10:09:50 -0400) >>>> >>>> ---------------------------------------------------------------- >>>> Folio changes for 5.18 >>>> >>>> Several of us had overlapping, conflicting changes to the MM this >>>> round, and I volunteered to send the pull request. >>>> >>>> - Hugh rewrote how munlock works to massively reduce the contention >>>> on i_mmap_rwsem: >>>> https://lore.kernel.org/linux-mm/8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com/ >>>> - Christoph sorted out the page refcount mess for ZONE_DEVICE pages: >>>> https://lore.kernel.org/linux-mm/20220210072828.2930359-1-hch@lst.de/ >>>> - I converted GUP to use folios and make pincount available for order-1 >>>> pages. >>>> - I converted a few more truncation functions to use folios >>>> - I converted page_vma_mapped_walk to use PFNs instead of pages >>>> - I converted rmap_walk to use folios >>>> - I converted most of shrink_page_list() to use a folio >>>> - I added support for creating large folios in readahead >>>> >>>> ---------------------------------------------------------------- >>>> Alex Sierra (10): >>>> mm: add zone device coherent type memory support >>>> mm: add device coherent vma selection for memory migration >>>> mm/gup: fail get_user_pages for LONGTERM dev coherent type >>>> drm/amdkfd: add SPM support for SVM >>>> drm/amdkfd: coherent type as sys mem on migration to ram >>>> lib: test_hmm add ioctl to get zone device type >>>> lib: test_hmm add module param for zone device type >>>> lib: add support for device coherent type in test_hmm >>>> tools: update hmm-test to support device coherent type >>>> tools: update test_hmm script to support SP config >>>> >>>> Alistair Popple (2): >>>> mm: remove the vma check in migrate_vma_setup() >>>> mm/gup: migrate device coherent pages when pinning instead of failing >>> >>> ... I thought DEVICE_COHERENT is still under development? >>> >> >> After verifying that I'm not daydreaming [1] (and realizing that I had >> review comments to some of these patches that have not been resolved >> yet) and also not spotting these change in your changelog above, I >> assume this stuff was included by mistake. NACK to merging >> DEVICE_COHERENT at this point. >> >> [1] https://lkml.kernel.org/r/20220310172633.9151-1-alex.sierra@amd.com > > That patch ("split vm_normal_pages for LRU and non-LRU handling") isn't > included in this pull request. The patches I have were those sent by > Christoph here: > > https://lore.kernel.org/linux-mm/20220210072828.2930359-1-hch@lst.de/ > > I can drop any patches that you have objections to, but I don't see > any objections from you to any patches in that list. Well, I was discussing with the original authors about how to proceed. Quoting from: https://lkml.kernel.org/r/1747447c-202d-9195-9d44-57f299be48c4@amd.com " Yes, it should be part of that series. Alex developed it on top of the series for now. But I think eventually it would need to be spliced into it. Patch1 would need to go somewhere before the other DEVICE_COHERENT patches (with minor modifications). Patch 2 could be squashed into "tools: add hmm gup test for long term pinned device pages" or go next to it. Patch 3 doesn't have a direct dependency on device-coherent pages. It only mentions them in comments. " I can understand that Christoph included a rebased version in his rework (to keep it working in -next and/or help the original authors?), but to me that doesn't mean that the feature is finally done. -- Thanks, David / dhildenb