Re: Default value of CMA_SYSFS

[David Hildenbrand <david@redhat.com>]

On 06.08.25 10:07, Jean Delvare wrote:
> Hi all,

Hi!

> 
> CMA_SYSFS looks like a generally useful and low footprint option. Is
> there any reason why it isn't enabled by default when its dependencies
> are met?

Looking at the introducing commit

commit 43ca106fa8ec7d684776fbe561214d3b2b7cb9cb
Author: Minchan Kim <minchan@kernel.org>
Date:   Tue May 4 18:37:28 2021 -0700

     mm: cma: support sysfs
     
     Since CMA is getting used more widely, it's more important to keep
     monitoring CMA statistics for system health since it's directly related to
     user experience.
     
     This patch introduces sysfs statistics for CMA, in order to provide some
     basic monitoring of the CMA allocator.
     
      * the number of CMA page successful allocations
      * the number of CMA page allocation failures
     
     These two values allow the user to calcuate the allocation
     failure rate for each CMA area.

I cannot really tell why we made this configurable.

> 
> I was wondering if it would make sense to add "default y" to this
> option. What do you think?

I'm wondering if we should remove the option completely -- or turn it into an
internal option only such that it's no longer user-selectable.

CCing Minchan Kim

-- 
Cheers,

David / dhildenb