From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCC5C5B543 for ; Thu, 5 Jun 2025 09:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11CBA6B0570; Thu, 5 Jun 2025 05:13:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F4E06B0572; Thu, 5 Jun 2025 05:13:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F26686B0575; Thu, 5 Jun 2025 05:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D1E3F6B0570 for ; Thu, 5 Jun 2025 05:13:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3FA6EE00F4 for ; Thu, 5 Jun 2025 09:13:48 +0000 (UTC) X-FDA: 83520784536.11.83E357D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A0100A0007 for ; Thu, 5 Jun 2025 09:13:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hC7RI5FW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749114825; a=rsa-sha256; cv=none; b=V68DYLyRswDIh4v9qLXmK4GJ/xU2KqHUWvKU8FMSVpligKX4U9b4xLtEpqIQU1yb0gZamg 2bltsXf6DiJGirKm6UtNoXuu2CJWpezhCDhkiUbEOIW0DcK/fdwFg9v3+hHmH9cMYevoNT s+Z23/5stWAz///kgBeZZAw50uLGSio= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hC7RI5FW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749114825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PU3FQpR1h3Dt+zEvCBTcAsStL66OO0crER4962yFxj4=; b=ucxmg+mnY8OmiZVFaNkpYnEsm4mcysLnjKxf7CBwvK8cwqLb9ezuDP+RXvGizN2qkHl1XT bl+SFgZiGKuY2A+TNHZYTUs3Qa25KC1ry83NqnxySDgnKAMy3jRdI8p6uEQoAxtVXuM0Ub 9qzyP+Jg7BX3PBUf+SJO4cVojZWPv8g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749114824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PU3FQpR1h3Dt+zEvCBTcAsStL66OO0crER4962yFxj4=; b=hC7RI5FWVwpPxNXcnWz7zkbfB0rObL9xjWbGW+7UxlSJZCHO8w4U7QyaIFfzd2KP6A+uOr CKveUik3HEh9vB+tezLUviS7BqPWF1E8Cl9pwdsefJVHrD3QzX3Td6R2JYIAZzJMLj8cn4 DH1TcfNtqDb53YBzdEqzyQq0+BHOY8o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-tlxUD3uMNUi6JRJFM5vQxw-1; Thu, 05 Jun 2025 05:13:43 -0400 X-MC-Unique: tlxUD3uMNUi6JRJFM5vQxw-1 X-Mimecast-MFC-AGG-ID: tlxUD3uMNUi6JRJFM5vQxw_1749114822 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4ee113461so278845f8f.1 for ; Thu, 05 Jun 2025 02:13:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749114822; x=1749719622; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PU3FQpR1h3Dt+zEvCBTcAsStL66OO0crER4962yFxj4=; b=K6aqUZ5fGd5ZXGvgwhgmzymjsvwcypfpVvyII+g91BH9VSSyNAgrBF2QYFkN+L1+RF mce5jGFMQ7P1wb0B43+NM0MYQ/r57bXpn85jGuZM0hz6DZKs3HHFhUtp+tTVHxKdJ8QJ B1kWSE5gi9Qv0QujcJpPovCCzG/YRrUDjfo2B9rzJaVT4zfqPKUZOqqZRnpQmpsCHpjC r/tWz+JO482MmexowP5B+/zUbSLSYVi2YP2LrhEaySq1twSOqauwaE8VOLT8g34gMnSF +VDjkw9P7EiDD0KEzMADds89aKBRao2anEZAH6oJ5T7fDexncjlYdGNC9AYv9c+I5nD4 zMxg== X-Forwarded-Encrypted: i=1; AJvYcCUVME0z3lkKfVtF2EPVQsZsDRISCsxt6I0TowONEZtKN1dLUEeBwMieF4hGbE6UsMcpG9dpXz4X7w==@kvack.org X-Gm-Message-State: AOJu0YySFaZHi3qYiZj8Xd5vwDpjjodVjR13WjPE82twfBdgrAIvzthg GB1F6FuqU+lFo49Tzwxg3C0nSxlrL5tduwJsmKJAeC818TlLjch8nbV/EcPSXe+r1w/FznxyutY GSJ1ttvKKkEnCoeJchg2jYMF+uyGjUhB+zCKs89guv60kFs0YMaNS X-Gm-Gg: ASbGncu7ccBpHIzhxDIn8kO04SFU41/ihQ+L+oV4zt/5qjpk7v08kO9v9qONI4axd5A W8Vf8YG4lgdnztYPyt1MZHUnq6WNI6I+W2uqZD4TNzznAdw7u4z/Qc4OaZqoa3n88N4bqgN4f6b R209rvBPqMyq+Rzmh5rLWPReYoOzm9TdjbISTQHboa10AY25eusPxxKh4FF04GhJ5pyjMl8ymeE yGC8kR69HwoN2HELz6MdaXAZV8Qdz0j9O4BKimlQciiOqGm6ttz07xlNzV8P2cSXPxKErtySZvE mjv6SK2ZykL3sWyVxSniigvOd4Qp2+p5+5uJgc5N/vWhfr6GxdAx4jlx2WXTTsS9NQxc+mZcaep 6GTOksvsPMq6352wscvGWuof+AE+b+k77aP6B X-Received: by 2002:a05:6000:310e:b0:3a3:64fb:304d with SMTP id ffacd0b85a97d-3a51d8f68c3mr4694419f8f.12.1749114822456; Thu, 05 Jun 2025 02:13:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYYWe9vV/todZ3+L6zve+3foocyt6f44lhpViRHk3WWV3k3ABwlYE9sP3wgBSKO8EuPWW/xA== X-Received: by 2002:a05:6000:310e:b0:3a3:64fb:304d with SMTP id ffacd0b85a97d-3a51d8f68c3mr4694396f8f.12.1749114822046; Thu, 05 Jun 2025 02:13:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f9813e5dsm17901785e9.12.2025.06.05.02.13.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 02:13:41 -0700 (PDT) Message-ID: <9eac8a3f-08c2-41f5-a468-1fe5c00a046c@redhat.com> Date: Thu, 5 Jun 2025 11:13:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] mm: gup: avoid CMA page pinning by retrying migration if no migratable page To: Hyesoo Yu , janghyuck.kim@samsung.com, zhaoyang.huang@unisoc.com, jaewon31.kim@gmail.com, Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605080436.3764686-1-hyesoo.yu@samsung.com> <20250605080436.3764686-2-hyesoo.yu@samsung.com> <20250605083916.GA3770753@tiffany> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605083916.GA3770753@tiffany> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _C81h-o2nu5obtiJKJJ_U-becaXrG9A5Elw5DQfjsvc_1749114822 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A0100A0007 X-Stat-Signature: 8c65czso9ug3qg9j89xd4ukzkta4c46t X-Rspam-User: X-HE-Tag: 1749114825-813518 X-HE-Meta: U2FsdGVkX19dF0T8WTxd/j2ZDGfwQ75tKSlMEp0mam46kBJydxuE1YRD/Me9rRrfudfoeSVtrnscDE4MZnlnTbwtajDUC6hPRJtA70Ya2Ebi+srgY9mGXzfP4ukwYdiYy4t5ugKvJKil0y41icQ086LWO2rCAtGfmsRK2EOwv4vQuBNyJRsaTxb6vgfDbx7o0W/WneNh5GLkdxDi3Jt/H5NekYVUtiD8xp8yo5bg370HoxJ6IUQuYTk4qn7ADIvXiYk5MZj/VcJxVEtOi7ja2MlcgvdCWEwAlJUAFUfN3SkdZC/q3cqiY8y/ZVEKmluFmiojOYtqU97O2wIjFuIgppercVFUahUs6DQb1r8EBpF0eg0yvy6T7B5BEoyfini7ThbFhS9VS8eOFqdsh0hu+KHQMaCEnftl6TrnyEgZ0If+/IvF2qWeuFRWFhvFvODqJQd+qxOE/s/DFsgmJYoIKa15Td7W4WK1iAop86fa/JAXx++9WQGBoistuYD0CJNc1e1LFm4r9uFsCGasImdPRb52RfnxA6gAUPIKAFCebju40KDoLVLWcBo7zdQSmsqc4EohFJDy1+hmyzsnFxNTrSQtTXyC0T5SZ1NqjaMGUSXXOvWMuMTFlYQ+/WvuCoLvixqkBfr+6nOWkUpFDZvekepnkOv5HSJ0RScBdaAhzX8dL63bTCdkgmir68I40YzadgRWdFfWWY9//GYJesU8OzUT8xwYe84dAM3tzhf+JCfM/OXEU1NYaXymAR92RNe+t6gYnxYCxqzixHiYbkR97ToaKFOopwMdLrphM03kGpyoy51SB2jLeGow97nvnFX4O01nK8droj6/B1Kp5XgTDbLwvek7aGIu6PHsdxHjei1InBiW6DC6eTEa+ukiiiXJJnx8r8ZwWlv2ZSsRdRVwn81piNEhN70ta8ier0FRoeuFtYnV+7e9RhNikHHPqP6+Ralh40ceB055Bu6kW3V quomS4fj +NBf6c+4sGF1wUjdvlH6PqobUZuErW4Qk2Tq20R6I+aRf7NUcUan4XOYd5QO1umk7P8vWSpYoGZLpgpd9T0HKQJiKTy6TVVk0nw9CtBfBxOGznO19bxguN/q+4PgyE1s9O4kDCP3NHRswdU6W1tkSpB05mKCqjyreNVqDwuqPp2TvjciuQl8ORN0F4xa1lr23gOBtti7bUgyiE3ZeHMuOBvjLQvG5aK90baD29yUGNVP6bJTxAwcWo7dbBxXFBdHgGBJP4WTuG0Tzo08c0eK4KoBO+wtgKgrlrx3AdDNIKn/EIB1/guGLYNqnL1oQd7inI2Otd91gpOklSBtBO14KJMY4BLNo26AO/Ndhri3avwf/trlaFZd+8tHtIX67O/uTRbN12dbWQS1F20qYmE3oc6HJnGEBgPOqvOrOaiK9f8bVPahG+ERHJhlynO2zjsgzPRJc7p/RZU7jma8abJyAJ5HaTf9J+YeorKENRcpbcC0roBovupg8/o0qLtkRpqOxDpBDMZpiisCkM9uk5GhpoEN7zk3cLUKggebUdRZIthWEjnRgTpcltM4Qo2lKCh4sct9F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 10:39, Hyesoo Yu wrote: > On Thu, Jun 05, 2025 at 05:04:31PM +0900, Hyesoo Yu wrote: >> Commit 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") >> introduced an issue where CMA pages could be pinned by longterm GUP requests. >> This occurs when unpinnable pages are detected but the movable_page_list is empty; >> the commit would return success without retrying, allowing unpinnable >> pages (such as CMA) to become pinned. >> >> CMA pages may be temporarily off the LRU due to concurrent isolation, >> for example when multiple longterm GUP requests are racing and therefore >> not appear in movable_page_list. Before commit 1aaf8c, the kernel would >> retry migration in such cases, which helped avoid accidental CMA pinning. >> >> The original intent of the commit was to support longterm GUP on non-LRU >> CMA pages in out-of-tree use cases such as pKVM. However, allowing this >> can lead to broader CMA pinning issues. >> >> To avoid this, the logic is restored to return -EAGAIN instead of success >> when no folios could be collected but unpinnable pages were found. >> This ensures that migration is retried until success, and avoids >> inadvertently pinning unpinnable pages. >> >> Fixes: 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") >> Acked-by: David Hildenbrand >> Signed-off-by: Hyesoo Yu >> >> --- >> We have confirmed that this regression causes CMA pages to be pinned >> in our kernel 6.12-based environment. >> >> In addition to CMA allocation failures, we also observed longterm GUP failures >> when repeatedly accessing the same VMA. Specifically, the first longterm GUP >> call would pin a CMA page, and a second call on the same region >> would fail the migration because the cma page was already pinned. >> >> After reverting commit 1aaf8c122918, the issue no longer reproduced. >> >> Therefore, this fix is important to ensure reliable behavior of longterm GUP >> and CMA-backed memory, and should be backported to stable. >> --- >> mm/gup.c | 28 ++++++++++++++++++++++------ >> 1 file changed, 22 insertions(+), 6 deletions(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index e065a49842a8..66193421c1d4 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -2300,14 +2300,12 @@ static void pofs_unpin(struct pages_or_folios *pofs) >> unpin_user_pages(pofs->pages, pofs->nr_entries); >> } >> >> -/* >> - * Returns the number of collected folios. Return value is always >= 0. >> - */ >> -static void collect_longterm_unpinnable_folios( >> +static bool collect_longterm_unpinnable_folios( >> struct list_head *movable_folio_list, >> struct pages_or_folios *pofs) >> { >> struct folio *prev_folio = NULL; >> + bool any_unpinnable = false; >> bool drain_allow = true; >> unsigned long i; >> >> @@ -2321,6 +2319,8 @@ static void collect_longterm_unpinnable_folios( >> if (folio_is_longterm_pinnable(folio)) >> continue; >> >> + any_unpinnable = true; >> + >> if (folio_is_device_coherent(folio)) >> continue; >> >> @@ -2342,6 +2342,8 @@ static void collect_longterm_unpinnable_folios( >> NR_ISOLATED_ANON + folio_is_file_lru(folio), >> folio_nr_pages(folio)); >> } >> + >> + return any_unpinnable; >> } >> >> /* >> @@ -2417,11 +2419,25 @@ migrate_longterm_unpinnable_folios(struct list_head *movable_folio_list, >> static long >> check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs) >> { >> + bool any_unpinnable; >> + >> LIST_HEAD(movable_folio_list); >> >> - collect_longterm_unpinnable_folios(&movable_folio_list, pofs); >> - if (list_empty(&movable_folio_list)) >> + any_unpinnable = collect_longterm_unpinnable_folios(&movable_folio_list, pofs); >> + > > Hi David, > > While re-reviewing the v3 patch, I realized that migrate_longterm_unpinnable_folios() > should always be called whenever unpinnable folios are present, regardless of whether > the movable_folio_list is empty. > > In collect_longterm_unpinnable_folios(), if folio_is_device_coherent() is true, > the folio is not added to movable_folio_list. However, such device-coherent folios > still need to be migrated later in migrate_longterm_unpinnable_folios(). Ohh, because we cannot isolate them ... and they are always longterm-unpinnable. > > I think the condition `list_empty(&movable_folio_list)` should be removed, > and it might be better to revert commit 1aaf8c122918 rather than adding a new patch. > > What do you think? Yeah, with that in mind, a revert might indeed be the better option. -- Cheers, David / dhildenb