From: zhiguojiang <justinjiang@vivo.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Barry Song <baohua@kernel.org>,
David Hildenbrand <david@redhat.com>,
opensource.kernel@vivo.com
Subject: Re: [PATCH v6] mm: shrink skip folio mapped by an exiting process
Date: Tue, 9 Jul 2024 20:34:20 +0800 [thread overview]
Message-ID: <9e91ca1d-dccb-4bf6-a3b9-9f19c482d6a0@vivo.com> (raw)
In-Reply-To: <Zo0ju0NAg2cAikU6@casper.infradead.org>
在 2024/7/9 19:49, Matthew Wilcox 写道:
> On Tue, Jul 09, 2024 at 12:10:50PM +0800, Zhiguo Jiang wrote:
>> + if ((!atomic_read(&vma->vm_mm->mm_users) ||
>> + check_stable_address_space(vma->vm_mm)) &&
>> + folio_test_swapbacked(folio) &&
>> + !folio_likely_mapped_shared(folio)) {
>> + pra->referenced = -1;
>> + page_vma_mapped_walk_done(&pvmw);
>> + return false;
>> + }
> You told me you'd fix the indentation. You cannot indent both the
> continuation lines of the condition and the body of the if by one tab
> each!
Thank you for pointing out this indentation issue again. It has been
modified in patch v7.
next prev parent reply other threads:[~2024-07-09 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 4:10 Zhiguo Jiang
2024-07-09 11:49 ` Matthew Wilcox
2024-07-09 12:34 ` zhiguojiang [this message]
2024-07-09 4:21 Zhiguo Jiang
2024-07-09 4:34 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e91ca1d-dccb-4bf6-a3b9-9f19c482d6a0@vivo.com \
--to=justinjiang@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox