From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 075D4C4332F for ; Tue, 31 Oct 2023 08:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91A646B02C2; Tue, 31 Oct 2023 04:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F09C6B02C3; Tue, 31 Oct 2023 04:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76A186B02C4; Tue, 31 Oct 2023 04:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 636316B02C2 for ; Tue, 31 Oct 2023 04:47:20 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 385B480E60 for ; Tue, 31 Oct 2023 08:47:20 +0000 (UTC) X-FDA: 81405127440.16.89870FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C8877160002 for ; Tue, 31 Oct 2023 08:47:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JrycCJ/+"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698742038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sCDwEeF9ciZSnQbhCdM1/zBzOj7Acze84Lk3y+xcTEM=; b=4kFvt8VJ02VUrseHv5zLBgWaGHAPfv2ngHLc5dFyKM/d9qU+v0tKZhRRZjze3enUJku7Mm QO7UtoVX46ibqbpwIvDiUyQd8GIF14s/Dcc/LRHYCBvV2m7P3sqK73f19EIfRIjU196MFS IfNdd43XND2JIwIKuLM1r4CxJepcOk8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JrycCJ/+"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698742038; a=rsa-sha256; cv=none; b=WO1tRRUzAR9pD4c5TjPCq0z3ca9Rc1FQcO4CRXrXRpZ+Df4wynzcSLDk6stgDBRx+2lrjY 7F0DgxcNedi321ferPuBr+FN2j8PQsCmg8igKQZ06T/8WHff7N/x54PTRrmlyLm0KOB8DX 1JarY7qf3V/QB4roZcIBMB5hmIcADHw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698742037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sCDwEeF9ciZSnQbhCdM1/zBzOj7Acze84Lk3y+xcTEM=; b=JrycCJ/+OjNhUNmditRQpzZc7e+j1p8P0aZqy7re7pY7X4O7QDlukJthG9ZPWcjtk2bcVn yH+IeIIsYuUVhALZZFGy3Y/vvlpYIvceMEi5rThDtKIOvs0n9n3y9OF5VQoKWGGDT9PDtt y9GZH7YeoyCsTLzFRSUpo57lChZylNc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-o42hMdy5O6iEnN7P5JMekg-1; Tue, 31 Oct 2023 04:46:58 -0400 X-MC-Unique: o42hMdy5O6iEnN7P5JMekg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4092164ee4eso39256755e9.3 for ; Tue, 31 Oct 2023 01:46:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698742017; x=1699346817; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sCDwEeF9ciZSnQbhCdM1/zBzOj7Acze84Lk3y+xcTEM=; b=rpmd0YPx7/08X8TsxN+PKIDe6tz/wCDCMUtEIyaA++EDOhJZnTfyAIhUneVzI6e/IA uLuejx2IjosXiF7aW61w0J+xk6gI1tgs3IxMcEY2SeqIC2UgQ6Kh6JU0k2T/Ue66r+2/ R88+UyEA3TnAavAvYwHQU9Lc0gTzqLZxcqnfgCZIOW6chpyodgYOHhw3MQDSHfk4D/r4 kzURcM60rwVKXbjR7+LOM7r2EXmkY5sV1l/RCOqg1tHpWKFkjDEBgC8KivLWb5DodK3n 5dDwSjzxctWei78IIA0WKQQRTHRyXvVRGE5Y5GvHMwmYnhKzT8cLRlKe4l5wwnAc/6R8 r6GA== X-Gm-Message-State: AOJu0YxbMOjrUApa3FkbO1JaugWNbdvLyGUkLsK8L6BMF2AEbkrV+t/8 JfdZtMkGoZRJpib8GIgvRcL8D8YTsooQDlBKMafoRZu1q56SklhjiUWSwvAIJ6SgalJlVTlajaI kql4jRqfeyl8= X-Received: by 2002:a05:600c:468e:b0:3fe:e7b2:c97f with SMTP id p14-20020a05600c468e00b003fee7b2c97fmr9371642wmo.36.1698742017436; Tue, 31 Oct 2023 01:46:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgE83XUkIDrRqqjUNlxdzyJJ3ixVUG9nOhnR8LDm1jWWRh2LM2ZNUxK/xCugIPRrsyxHa98Q== X-Received: by 2002:a05:600c:468e:b0:3fe:e7b2:c97f with SMTP id p14-20020a05600c468e00b003fee7b2c97fmr9371615wmo.36.1698742016998; Tue, 31 Oct 2023 01:46:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:8f00:43b0:1107:57d2:28ee? (p200300cbc7078f0043b0110757d228ee.dip0.t-ipconnect.de. [2003:cb:c707:8f00:43b0:1107:57d2:28ee]) by smtp.gmail.com with ESMTPSA id v19-20020a05600c471300b0040303a9965asm1093169wmo.40.2023.10.31.01.46.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 01:46:56 -0700 (PDT) Message-ID: <9e73d6af-47a8-43bf-8ffa-9525bc8c747b@redhat.com> Date: Tue, 31 Oct 2023 09:46:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 0/3] Reduce TLB flushes under some specific conditions To: Byungchul Park , Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <20231030072540.38631-1-byungchul@sk.com> <08c82a91-87d1-42c7-93c4-4028f3725340@intel.com> <20231030225548.GB900@system.software.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231030225548.GB900@system.software.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C8877160002 X-Stat-Signature: ptydfcbf4fdpgoeyyew8pfrsx9yit1zz X-Rspam-User: X-HE-Tag: 1698742037-433529 X-HE-Meta: U2FsdGVkX1/3DC8HxsLTva6IIknC7NZAyFdKMDzTl8Mj1+7utT86ixjokfjHcieE9YlgxRW5pyIyHO5hsIXm+GS0EXC7WoWU5oNkr394yhBDGdUy1eIRd/ncv2pGpCRBquqDeLHENP6qVeoshHaUlV8kD2DzH5SFzuRcjEoI/jUaD+Q/o/tieuTaUiaED3KS2H3EYbodjEGiGQygyjcFkjvUujYEGS9ptbKIYGg0251XTZCf0NpSngIUWqFLlL68WUb65odvcWh8rj30yHY7HYVsAPLM47tVdqoGJ05Pu49nLnEyXxWmQUEv9rc1cTHv9Vek9TWN8O7I0X2vugZpaB3CzdNLBGhQtkN+KX2gfVE65C405sbY5Bf8bIToR2fjEoZwCiOHGLEhrpxkd3bSFREbvxM2LRlPN2/SAkvmja6PBtiD+IsYPkMNAzkqORhYWhK5oDlSyCeshoc5HIFgbjXxXyzyAslIJJSM0SwM8q16B0amwm6PYkDlIhwkmWDtHSd0m9zlcPq0kM7wGjwxMS3OB+WP0OmNE4ewnVHD83f/Qsv0cMEdp0j0YQfE9O6chP+/Q7gbj67b9r0HfxW0PevosyTznZJgT4QNj16SMomkzrjCb2P4e2PN6uFXzv3LK4j3mz/w+5IaQzxB30IVcifb9Qe3Z2gi3indrpN/k3YaLY94ai1m+vIfgrIPMNqw4nJXHg5p2KqGfS03a0HTcXf77wv4KsLFXTDWQgLr/XcUtpY4YWhMmZOt4y/OSBzhC1i7Fqg+GAy+cYNhqDf+AdWEI0QH9JRvQ9bxa9w6wWXDpCCfVSbPS7JhcQEwgyj5e5sE09e/25eYJ3hpebBG6xSWYyptj5iHxXWNZ0Hin+1Ep47ezpSCPLT08R5muvH4EWlAcO7TdDDJo2rKZsc8JIkMhBfUb8Bgeok/r+tUrkb0KIHBFkiiLcqjKTZgUP6xRh8Bt070YlaGNqlncfw 5su87Sxz j+kN+/eTEZqjWI4fLUKaKE/1xmyUcGSq2Jzq2PuGeBnuMLAqUQ6VCgYZGkJktTZQvkvJ5MbJtfkJPahoSozFbWRmDkcHsD3JW45p5aUj6TOx8xdwcPp4EQN3XYAAoSDiuQfKJow3tabzI/e9OppzBqpEnRyav2m5ohi51igJwnNCzLqhdTYvYjQFfcemiNJYnJhXFuKNM/oc4RnWv7dEH6ctj3E8LU0RbD6tGZ2R1L5Z2CKE3+UlB6/nbLnCbdZT824zNISer77tIiMemF3iWfHGcboBVLsfQbLqobMLwxuwM8o9QzWGLftSRQJAoN4iuNo4bJH8FlGaBUVRjciggRSUmLsX/a32p2WnZuR5hWWKcAzadJvphooECsU9QTDsnA0+dFTMJgKwpOG3Xrd/GZUeY+TQTIEXOQoFwSOMoTQhjl2k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.10.23 23:55, Byungchul Park wrote: > On Mon, Oct 30, 2023 at 10:55:07AM -0700, Dave Hansen wrote: >> On 10/30/23 00:25, Byungchul Park wrote: >>> I'm suggesting a mechanism to reduce TLB flushes by keeping source and >>> destination of folios participated in the migrations until all TLB >>> flushes required are done, only if those folios are not mapped with >>> write permission PTE entries at all. I worked Based on v6.6-rc5. >> >> There's a lot of common overhead here, on top of the complexity in general: >> >> * A new page flag >> * A new cpumask_t in task_struct >> * A new zone list >> * Extra (temporary) memory consumption >> >> and the benefits are ... "performance improved a little bit" on one >> workload. That doesn't seem like a good overall tradeoff to me. >> >> There will certainly be workloads that, before this patch, would have >> little or no memory pressure and after this patch would need to do reclaim. > > 'if (gain - cost) > 0 ?'" is a difficult problem. I think the followings > are already big benefit in general: > > 1. big reduction of IPIs # > 2. big reduction of TLB flushes # > 3. big reduction of TLB misses # > > Of course, I or we need to keep trying to see a better number in > end-to-end performance. You'll have to show convincing, real numbers, for use cases people care about, to even motivate why people should consider looking at this in more detail. If you can't measure it and only speculate, nobody cares. The numbers you provided were so far not convincing, and it's questionable if the single benchmark you are presenting represents a reasonable real workload that ends up improving *real* workloads. A better description of the whole benchmark and why it represents a real workload behavior might help. -- Cheers, David / dhildenb