From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CB3C25B74 for ; Thu, 16 May 2024 16:31:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1DBF6B0085; Thu, 16 May 2024 12:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF4306B0089; Thu, 16 May 2024 12:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC456B008A; Thu, 16 May 2024 12:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BF6D16B0085 for ; Thu, 16 May 2024 12:31:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 40691122157 for ; Thu, 16 May 2024 16:31:19 +0000 (UTC) X-FDA: 82124799078.04.91D8A56 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 26AD9C0030 for ; Thu, 16 May 2024 16:31:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=iGYZ253z; spf=pass (imf28.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.49 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715877077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pDnoiv+aAilJOglosMLJSLeZ15PVLhndVRN5KP2yh64=; b=LN4GrPSQgkMCX9wXnE1lCBhKiD3L4xwLyQu4Fy4cRJoI1mRtQAL41hAK4oM9IlQzhjwrw7 yNDWcFtlWBFN/f21Z/vD6XKcISi8rooI4ZZ2VDdoJkVvQ5NbHH7/mMmG92FUeAxJYYz+FS htcHUMPsdRT4PvKf88pK7sJiCUPx+qk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=iGYZ253z; spf=pass (imf28.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.49 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715877077; a=rsa-sha256; cv=none; b=ftYnPDyaNXfwFbX7DJG7u9AkPlvqJ9fgzd+jmnHNF3VwR9wY4po5dwjK4Sd7PNjlAJ6xwE OcUtTDtl6vIpDDlciYIBFlNNAdZysrBVjdgIvn9zvKLuOCxpHG1EZ5BcB8RmjqytCzXvUo Am1sin6tBcoMxCQ4YhVa3sb1oh1tZ6k= Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7e1fb2a81fdso5729339f.1 for ; Thu, 16 May 2024 09:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715877076; x=1716481876; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pDnoiv+aAilJOglosMLJSLeZ15PVLhndVRN5KP2yh64=; b=iGYZ253zGFqK9JW8ceG6N9X6HbcwIKQ7EiYfcTCIDemY37xngYxU9fIJ2KJRhwDxTV Dj8O7hgssaTd88CPQfHjcOTQujsGWx3fQaX4g4ly0zOM9/i/Jk+LUTKFpGE9qE26sWLr lf18hfs39j8di33VxlXmAZciO8wwLVxmY1img= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715877076; x=1716481876; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pDnoiv+aAilJOglosMLJSLeZ15PVLhndVRN5KP2yh64=; b=agzMYKzPJ06eVR10700gUWO2Esul6ACF2T1rDmPxaO4fTIJwFPvCix+IOcYyQhEXMl z4SI3xyQoD4up0IfuDnTzYxUn5fo6150dFq0Gz/9QGUcyaozPY3rHa8yuYCXp54Hq0ZZ Yn/WuagtOCi+AtclsisqOV76Gx8oMpG66hPPJWykL9067QM6rSGMHh7riXyuopeuoFIT 54/3k6d49untOlmXplEU7nMvrz6/Q5a/8fqZ1BEsIfZErM/T9qpvrQIaLWTxbdQdTNvn tNrP9rQqwO3vHXWICNMYl+RRbpJnKDvQnLMbTl+YDu8aUY226zeJTZcFM2ZDP6fxVyhI aQ8w== X-Forwarded-Encrypted: i=1; AJvYcCXcMaNtcl/kh3GipZEGZKvah/rctTcAuBZBVtxzRqlIQ3BYEHG+VlD2YRR5M81+Kxy4I7cjMTGskNTB0q29a89HKnM= X-Gm-Message-State: AOJu0YyApiVbX8M4Z6s6yAvh93LiMuWcfjB/RPrDYpIMqxt1cUITyeMW MTAzFFC0tUXKBNu41VW57ND5peThiTWj79ZsLh7G+F7o0GFb7HF2Bj31a518aY8= X-Google-Smtp-Source: AGHT+IHC7NWHiVtGdW49HXEWLPpD9poqjpxpz8h5HFbktLyqnUrR9q12B55ixwuwmtZx24K1zeLkFg== X-Received: by 2002:a05:6e02:1c8b:b0:36c:c599:698a with SMTP id e9e14a558f8ab-36cc599af7dmr211295495ab.2.1715877075869; Thu, 16 May 2024 09:31:15 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-36dbbd191b0sm7514315ab.17.2024.05.16.09.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 09:31:15 -0700 (PDT) Message-ID: <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Date: Thu, 16 May 2024 10:31:13 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 26AD9C0030 X-Stat-Signature: m4dxjnq9u3j4h33wju9qpa75grcpt8mg X-Rspam-User: X-HE-Tag: 1715877076-49229 X-HE-Meta: U2FsdGVkX1/FRS8celqWGIxJhKottE99Aa/Hx/p7SZJcv2Pkke0GishmfWr0m/Xi1ZKbXNBacmzXyRwbepGWDm9nmAH7DiYGUhrc0HvIuLNj0Wl8OoxgOQy4R/YW10oYeTW8DkOFNqKpncHWBe0zGMiju7kTl+KTxw5r1RCl+2o7LxMo0vR5UYLtPWrM64SwQC7xIkLxUbglkTgm5ezoA1gGXaRneNPoAK2xNxJ+VkmXJiTw6hOB9nJReIPiHyOnlvDgkctZLbY+GZk06oaReX/JXuYWy41k8GH80XE2s5n2RDCF842q6zoMYTEeGmqYwY2agR632zHCTH4GXkBPIEUhZgl8L6M7gaACMYXtfJwBOib++4dVIGa+1C6VNwllOYe/peKXtB12Fs8OJHYZ6FMdYJCYQA585HV1nYVUXTW+6nE+3Bpe59Sy+8/AvamDYOFuBrDuL7li6k3upVuQUolTgTymDb6REUp4fbfjLtG3oRW63dNEv3bvuX37YvD+vrrmNrkZjGHDu6aEX4F7zi9zDAOBvS10CbysUcL41hunNRjwE3yybvzMzI9GwdTiKikRWJtMtszml552PQdXP3/JMCGgYaVPjLCtMLDOsr6oyWdH5RK+8vyOR9oUpW8PNqJwWTXnoTlqcOPtyFp/8zs1yEEkaJwYJKn7x4G+T3fDY18NrgPVAmg8yRdXO9aBtJCJZRxy8Hk4R8oh1FG/FVa2acyM4efAqip+3O0LY0cTWYEMKRyC1NZ1rR2cahMmhWi7/eDkmI99Mp85dJyUaCCXrDdtnIuxmwpi3nnRqCxA3IZVtpNxrvz1fTfX6u4ABkXnTIwgoPj6r14UeuZDxyeA9c/d73a2OPzwWJqfCFDtfV6lnvhFooHRcSymnviw0rVu1MS68h4Ezf1VsnRxl5FUmKioD++jnWAoB+C/0Y/AjP30o8YE62SOoCfMIREn6b5LPP2delW4fA9qg39 jkJmXEQ1 HbVcCaqzzftA59No2cK0CXQybcDknpAu+ekDNVGdbdsPdymGYGqEV+0F3I+YdF+5YCXTHSfq6Fg1TqS9SmHfD+eqBR3XTi6zCsVF18b5R+log7r4glAJ7lGFjsG9HzXFxQoF8OFKqpEc4KY1wKqD/axrr/bkN8nSULGrOobl6fkpMmehh1khTXvvJFX3pk6BDPfj/gGb/0haapROoTcjuKhEuwbf2H2NHw9ExjdByooimQouVNnSBMWNmI1PtGL6znbzvAdPw29DXuUM2TplHhUP2olsROgyDIq7/GcsbExD7taYpPYG3knii7GapWyKMx/yX6kkVu0rChdFNk4UZE2EO9EAoi6KSLMEBkSnycF6Vhz/trYUQbsAdTr1jY+SsSr3ohU3/1cUc2jWQUwcuT0qf5vg1Fkf7bmHz0Q+Zy4EPprVNMedKeeow7K8BZFXlJnFPGmPXhbziSj51j82fFdFy/AoTI7ZcGLvZYJ3R7eaJnSvcxsD84QyUv2c8PQFjsd4NV46PMIn4qdc3uVpV9V3sVSGVC3xuYhlCQ2kxhLtSJEREj858RzxbBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/24 10:21, Tejun Heo wrote: > On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote: >> On 5/13/24 11:02, Tejun Heo wrote: >>> On Fri, May 10, 2024 at 12:06:25AM +0000, Edward Liaw wrote: >>>> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent >>>> redefinition warnings. >>>> >>>> Signed-off-by: Edward Liaw >>> >>> Applied to cgroup/for-6.10. >>> >>> Thanks. >>> >> >> Hi Tejun, >> >> Please don't include this in your PR to Linus. This patch series needs >> to go together as it is causing several build warns and some errors. > > I'm afraid it's too late. The PR is too late. Do you want me to send an > amended PR with the commit reverted? If it's just temporary issues in > selftests, maybe we can just wait it out? > I am exploring options and leaning towards reverting the patch daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") Your amending the PR helps me if I have to send revert. I am sorry for the trouble. I can all of them together in a second update or after the merge window closes. thanks, -- Shuah