From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03B0C021BF for ; Tue, 25 Feb 2025 14:12:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 979976B008A; Tue, 25 Feb 2025 09:12:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94EF36B0095; Tue, 25 Feb 2025 09:12:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8167D6B0096; Tue, 25 Feb 2025 09:12:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 604176B008A for ; Tue, 25 Feb 2025 09:12:45 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 14006515A6 for ; Tue, 25 Feb 2025 14:12:45 +0000 (UTC) X-FDA: 83158657890.28.3430DF7 Received: from smtp-fw-52004.amazon.com (smtp-fw-52004.amazon.com [52.119.213.154]) by imf21.hostedemail.com (Postfix) with ESMTP id F324A1C000A for ; Tue, 25 Feb 2025 14:12:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=amazon.co.uk header.s=amazon201209 header.b=N8hUbOoF; spf=pass (imf21.hostedemail.com: domain of "prvs=1442951ce=roypat@amazon.co.uk" designates 52.119.213.154 as permitted sender) smtp.mailfrom="prvs=1442951ce=roypat@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.co.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740492763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCe9wqGieGFyiUCexYspDQYCKCk1CfumNTmeDIsPvqY=; b=FPKDm7iJIksgMaNrhg20oyvARAngwpPimfYGHGlZ/j4FUtLJoMzoqXRR2d1mpTykrD0oQX vLRDPPF+Gl8WN5fUb3m1qIS4/oKEAXizosUVmzqpzzcad+aLo0ykrLmzcGNjiTR2pbr2Fa xVqnuInxNQHbpL0U0Vy7KYyhVbHqx/0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=amazon.co.uk header.s=amazon201209 header.b=N8hUbOoF; spf=pass (imf21.hostedemail.com: domain of "prvs=1442951ce=roypat@amazon.co.uk" designates 52.119.213.154 as permitted sender) smtp.mailfrom="prvs=1442951ce=roypat@amazon.co.uk"; dmarc=pass (policy=quarantine) header.from=amazon.co.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740492763; a=rsa-sha256; cv=none; b=rDIUGUeVgWACe0LUfMB7nZfuR3IYE/bm6lw6P0RT7OEjqmg0xZhz7wTeuKAJxvwwSegCcW ZhHGcLUr6NZPqxZZJWeBPp4st8qadYr7A6P5Zyh2h1OyCsZmUSjhiW6OJ5SxYDv/Aihezh OM1aW8uLoUg0UWTngC+s/+KRlzcyo3c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1740492763; x=1772028763; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wCe9wqGieGFyiUCexYspDQYCKCk1CfumNTmeDIsPvqY=; b=N8hUbOoFdpmte9sp0P83+xTnZj3IGnq2tSeEiqORGS47BPbDwxrmXd4W 6vHv9CTcUvxSeOYYrpotWyWp0s836hJmMtVpdC6flyVMDLJ5L12paO04M 3pQsXp1mmF4YGGfqB16tft2F9dGjHwjYHsUDELPTOzIz/z3iGdjkZ6cN8 M=; X-IronPort-AV: E=Sophos;i="6.13,314,1732579200"; d="scan'208";a="274174113" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2]) by smtp-border-fw-52004.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 14:12:38 +0000 Received: from EX19MTAUWA001.ant.amazon.com [10.0.21.151:33203] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.69:2525] with esmtp (Farcaster) id 1760cb76-f2c7-41ad-bce5-bd5d082ea92a; Tue, 25 Feb 2025 14:12:37 +0000 (UTC) X-Farcaster-Flow-ID: 1760cb76-f2c7-41ad-bce5-bd5d082ea92a Received: from EX19D020UWA003.ant.amazon.com (10.13.138.254) by EX19MTAUWA001.ant.amazon.com (10.250.64.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Tue, 25 Feb 2025 14:12:37 +0000 Received: from EX19MTAUWA002.ant.amazon.com (10.250.64.202) by EX19D020UWA003.ant.amazon.com (10.13.138.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Tue, 25 Feb 2025 14:12:36 +0000 Received: from email-imr-corp-prod-pdx-all-2b-f5cd2367.us-west-2.amazon.com (10.25.36.210) by mail-relay.amazon.com (10.250.64.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14 via Frontend Transport; Tue, 25 Feb 2025 14:12:36 +0000 Received: from [127.0.0.1] (dev-dsk-roypat-1c-dbe2a224.eu-west-1.amazon.com [172.19.88.180]) by email-imr-corp-prod-pdx-all-2b-f5cd2367.us-west-2.amazon.com (Postfix) with ESMTPS id 46E31C7D57; Tue, 25 Feb 2025 14:12:29 +0000 (UTC) Message-ID: <9e60449b-0d2f-43ef-a0b0-3cc999fa9d99@amazon.co.uk> Date: Tue, 25 Feb 2025 14:12:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/12] KVM: selftests: Add guest_memfd based vm_mem_backing_src_types To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20250221160728.1584559-1-roypat@amazon.co.uk> <20250221160728.1584559-9-roypat@amazon.co.uk> From: Patrick Roy Content-Language: en-US Autocrypt: addr=roypat@amazon.co.uk; keydata= xjMEY0UgYhYJKwYBBAHaRw8BAQdA7lj+ADr5b96qBcdINFVJSOg8RGtKthL5x77F2ABMh4PN NVBhdHJpY2sgUm95IChHaXRodWIga2V5IGFtYXpvbikgPHJveXBhdEBhbWF6b24uY28udWs+ wpMEExYKADsWIQQ5DAcjaM+IvmZPLohVg4tqeAbEAgUCY0UgYgIbAwULCQgHAgIiAgYVCgkI CwIEFgIDAQIeBwIXgAAKCRBVg4tqeAbEAmQKAQC1jMl/KT9pQHEdALF7SA1iJ9tpA5ppl1J9 AOIP7Nr9SwD/fvIWkq0QDnq69eK7HqW14CA7AToCF6NBqZ8r7ksi+QLOOARjRSBiEgorBgEE AZdVAQUBAQdAqoMhGmiXJ3DMGeXrlaDA+v/aF/ah7ARbFV4ukHyz+CkDAQgHwngEGBYKACAW IQQ5DAcjaM+IvmZPLohVg4tqeAbEAgUCY0UgYgIbDAAKCRBVg4tqeAbEAtjHAQDkh5jZRIsZ 7JMNkPMSCd5PuSy0/Gdx8LGgsxxPMZwePgEAn5Tnh4fVbf00esnoK588bYQgJBioXtuXhtom 8hlxFQM= In-Reply-To: <20250221160728.1584559-9-roypat@amazon.co.uk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: F324A1C000A X-Stat-Signature: 5nnx1hn8qszc1thwuuc3kwpmjsms85kz X-HE-Tag: 1740492762-616061 X-HE-Meta: U2FsdGVkX196SmM1iOSmRgl3L3jg8/V8TMevkNMQvL/1e/iXVAItLoTuS+Prunm00D/P/c1ht0KPy4ZTt5t2V40oVFYdkLI0uwbFEF/PKsji9hUauJSdwZ9earCAIZ+0q0suGkpx8A9FD9XXSVpmkQENTRGVAA8nEk9EPZPeBZAx1vfs0Usp6JoCLYOnIzmvO+ZDdlTUaH1Ld2xZc9ZGSh/7SMrIKlwh0nw7fOEnvjwhu4hMhlV9AMi9uJhrUjcLBFYLAiKwOUzNz3u5J8etyBtoh10V6B7AdYUb2cJ+0l8MIKUseeZaev7szh8F0N7Snx3SRd0uVdICFm+6QD0SfpReE/82k1kdsQ1XI3wrST/21bS2HX0L4NzD3/l1LKhag+qWejBfputK+xpNJufhmB/hJRHC+PN96txzf7NmJXNhIT/9LeYiwff2Y/rKI0NO7cy4YwJL9185fL4tauD1WD+E4EnIeND4oNy94QSilISQGHJ5BCChA32T05rgzLBl3YG29q5xIbPYc/8nUaXB5aakNRVOFvJw9X+hPmN/6cDbUIR0xDefF4bsU+dH1/wuGT9Uo2yrNVGSXlkbpgHKQ0I+bvlHBCE7EezXQd2rSoVKw2KH5D4Af8fbmB49/CtDGgEp8xay/CcBq4Mhtp4SrynGjfQ7vzxCZIoHicMIkD/v6c33YTwdSTvg8HyJe7yeOUC/OrC+jzW3jigM/G5kfpfr/7CEnyXl56wxqbWSNcA+YWoCiksZ19JUF0wD+urTSCo/5/ptE6KH6mJWafgCiDH8PPbubsN7kr9LwCNUTPKHKrD3pb4MmS4t0kRuyIt3wIF/7vdqgrnd88P73Ub19EPaF7F51MmFV74IruW3+7+4UwTafpka4CDGPxZugAZKJ832tKZnuHSaTup3FTHZOacO/CPfvQXsHKXTgGSHsd/aZH3N3/4zIzxr9PXJJrf4i4Pt41WuoHbsKrSdOVm LJVj1wqv qv/pswYKwbDV22qo9y9pEJHJ5G+TvYx0mrYvKBnqzTybuiMhQwlpoRfDh5WbN2KI5Q4Sv1Ah16Y7zugrhbYg+8itRxancxOEuIsnBjQw40Zf+v6HdGyKcq9DmJqO7kJwU2UzvWSHQFawO/Pj7L2ChtqfSti8KCkvDf8VN2lSO8rQwp0TFvIEaM1BqXCsdxT2MSBIHvNqXjSZG7g9INNBsKZbNRXKsNmZNXkFpKueSmdBjJzcevVqr8bR1k/L8c7+OdQ/AtQMLsHvVnKnCcqf6DxyWOxelUUiuJMAD3IQ93ZT9rAmd1LX/9E174WfxUkEpKAtFroGCOuVmirOMCz8wZIObSZFbaBAGZPKAb1kCfce18yAQ9hyI1MWAdk2O4Ib31fub5SBDk08LUXtHpjHm8rvFYRWs7xq7eu/0Lou7ViWNzjm8Ru4bvo6naxUngD8uwSm2NEaSyqNtjjAONpQ18+6kN1oY7hFDdeoio5xBcXSCuSi7SscpZPw5rivt7DogKpLLUcEgCb1qKbdVcjk3sfnfJDHogxURNOXG3E0SO8XDVfiW9jv/q1899ERHKBas3fcN+J3Q7/eikbAK13cVXitQNY+ogYPOVff7ApgyUBKrxK/S4q0iGVEaxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-21 at 16:07 +0000, Patrick Roy wrote: ... > @@ -985,10 +1013,13 @@ void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type, > if (alignment > 1) > region->mmap_size += alignment; > > - region->fd = -1; > - if (backing_src_is_shared(src_type)) > + if (backing_src_is_guest_memfd(src_type)) > + region->fd = guest_memfd; > + else if (backing_src_is_guest_memfd(src_type)) Argh, this is nonsense. Should be + else if (backing_src_is_shared(src_type)) instead. > region->fd = kvm_memfd_alloc(region->mmap_size, > src_type == VM_MEM_SRC_SHARED_HUGETLB); > + else > + region->fd = -1; > > region->mmap_start = mmap(NULL, region->mmap_size, > PROT_READ | PROT_WRITE, ...