From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AE4C04FFE for ; Wed, 15 May 2024 01:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1908D005E; Tue, 14 May 2024 21:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 250ED8D004F; Tue, 14 May 2024 21:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11ADA8D005E; Tue, 14 May 2024 21:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6AE38D004F for ; Tue, 14 May 2024 21:48:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 854321211FF for ; Wed, 15 May 2024 01:48:40 +0000 (UTC) X-FDA: 82118946000.11.5C17E61 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf16.hostedemail.com (Postfix) with ESMTP id D34A3180002 for ; Wed, 15 May 2024 01:48:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715737718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qIL+lF8M4p3vESYx7PP0X2T6ofX3AJVlvUmIs7h/pRI=; b=lBkrrryNdw1RnxPeei+10WpwrACU5QiAqL1v9AtPhAe1Sr48LXpzB6OZ7EqjEeqyy4lXKr o+vy9f9C7G/hxvxeFQrrYIsGeGqp4etBmKgPxDVrewjOuCJsYWmKOqaUjU2IPwIi5bFeJe yPPLKchgY5Mn0+YNOwLjyrZra8YvW5U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715737718; a=rsa-sha256; cv=none; b=Gbhq+l0LaB1kW9foWj3RRWoAxLUZaAq+wI6X8KP122S7ykkfNZBjQhOyaiPMoa13pe8eyZ 4Vv6LocRejQPl3yX5kYcYwNzMxkFBeFrbw8eBg6zbPuwX+sFS1lkZloJ/d/20Ol5GzhstS MJVL9lT56G2dN7vzMn+uZvDAfqT5QRI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VfGHz47TNzvY1W; Wed, 15 May 2024 09:45:03 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 30B471804AA; Wed, 15 May 2024 09:48:32 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 09:48:31 +0800 Subject: Re: [PATCH -rc7] mm/huge_memory: mark huge_zero_page reserved To: Yang Shi , Andrew Morton CC: , , , References: <20240511035435.1477004-1-linmiaohe@huawei.com> <20240514141439.55fba39c81c1af55c9a100e1@linux-foundation.org> <20240514144204.88790f125b0275ef68acf6de@linux-foundation.org> From: Miaohe Lin Message-ID: <9e5e51d7-e5bf-8209-317e-6f03c548727f@huawei.com> Date: Wed, 15 May 2024 09:48:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D34A3180002 X-Rspam-User: X-Stat-Signature: 4sqch4cmc6majtrdycd5uewie9btbbun X-HE-Tag: 1715737716-148706 X-HE-Meta: U2FsdGVkX19Uj4AxCiiahphNicvr72T35A6MooAwQS7vhShRPaYjSEVLtyBg+5hu8mAx1DnXGFGEBJWgaszgV3wDRrbCRTZ5uZKDOa0eYB6JtTskJJVFRY0HElNiE8uCx7DM1uiRcES7C7V5y91S2es1UrTTawK3h9io0XVfLYrMezm4NA6DB3+0PvijY4T2u0FgrkM3Wn0lKaZZwDXlMmtqj5+cUw7eIApXu8+eCGCWo++s+xth+o340rcWwghg7Zj/kGK+Ui2EfRUfB9x72B0XHNpqmVCK7RzqxrPitm2ZfwebigfAFW27tYvcEjzcbwxBbzs/eVzE6hVnlPc/a9fxo+CesEDGxLVIlcJjJytwkKWjpwVotqq7752NiDRqJFNWRxxIPpi0Ia7F3dpdTEPlnvcMEQ44mR2sIKoT7P36yZOWxlSNS8TpUernSm8MJt+ThK/j5SghQP5oSSNtWbUM0ES3IciDFCBzM8/hl5GVlW8RyEeD9qvf+JM9HkJTAKzP4DKU68oweOE2DSWtJrqe4ARieB1ECq0afnoG2ITAO2oE+gk37UOeXIjNIwwqx6nmVLv08yQLp4gaRbAUZQdGMwYHGZzZEGOxUkrMDStUYaWKVIPodlCGrz1SITK3445I+gde/poicLTpiO0/OZD/vsExXe4Bqh0CPuyDcS1Aa23QR/3EzrnEnVy12LW9fOS8NYM+zSuJ7P8MqFFi3oJhVso9MKw8nThohVsex9ZXoR3s/i/C1qUJSAkZT1/OHAn6BrcuIfyAcq9OXZHQYLe515JM2fNWD25K/LGuxEh1ceMYJV8rPFy00n1q3AKMcU9lqaEyxxniAx4YpUVZ+oRvktlIlQACQsRgR047O3eQiunk4uIDTkB7Ih6cYKnU+lQ0EgD4iK2S69dorUSrIEllOH9bN9GBhFZErWyL67s746LHGDE0nvrXqRqKpbnifX8X6Q+cilTSGBWGb61 JpPLK8yJ 5WfH/IZPqAQqHE/bnauYD3z8OD6HHrR4tvuMbo99l6HYU/RSyf0XnHprLcJYPQwUL6FT4EFoG1Yngod7Db760HGoKAYafF7qQVRUAC7sAZxTELUSqp3OcLmoP0eCejSAWUJgVuXiL+soPi5fNX+5Vze3E4+8/mW/Sisve86nBUz3AZPJyLCoH08WwXJ8isHrYzO+ar+CStCnwIG1rIxjCt5qNERcZQiYq4/VXRq7SdsBbgQ0Cjq37yD89j9/drf6cSFzNQBh2dB4h3RLlSnQFIr4IAytctcyS5Jqc4vSD+SiEwHhkN0zzxvZXEGuTcYmvjJMiphlDH2MJiqUD69McrzPCHYSraNWCSHOjH6MO2aCIGHMdmrp/HmiVw1hNl3BOkubnMgH5CCVzko1/nxKM44Vu+EEz5aJ+TbgJpJuuKQpNQ1dXlGYJhAv++9kyw1vq+dZg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/15 5:55, Yang Shi wrote: > On Tue, May 14, 2024 at 3:42 PM Andrew Morton wrote: >> >> On Tue, 14 May 2024 15:28:12 -0600 Yang Shi wrote: >> >>> On Tue, May 14, 2024 at 3:14 PM Andrew Morton wrote: >>>> >>>> On Sat, 11 May 2024 11:54:35 +0800 Miaohe Lin wrote: >>>> >>>>> When I did memory failure tests recently, below panic occurs: >>>>> >>>>> kernel BUG at include/linux/mm.h:1135! >>>>> invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >>>>> CPU: 9 PID: 137 Comm: kswapd1 Not tainted 6.9.0-rc4-00491-gd5ce28f156fe-dirty #14 >>>>> >>>>> ... >>>>> >>>>> --- a/mm/huge_memory.c >>>>> +++ b/mm/huge_memory.c >>>>> @@ -208,6 +208,7 @@ static bool get_huge_zero_page(void) >>>>> __free_pages(zero_page, compound_order(zero_page)); >>>>> goto retry; >>>>> } >>>>> + __SetPageReserved(zero_page); >>>>> WRITE_ONCE(huge_zero_pfn, page_to_pfn(zero_page)); >>>>> >>>>> /* We take additional reference here. It will be put back by shrinker */ >>>>> @@ -260,6 +261,7 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, >>>>> struct page *zero_page = xchg(&huge_zero_page, NULL); >>>>> BUG_ON(zero_page == NULL); >>>>> WRITE_ONCE(huge_zero_pfn, ~0UL); >>>>> + __ClearPageReserved(zero_page); >>>>> __free_pages(zero_page, compound_order(zero_page)); >>>>> return HPAGE_PMD_NR; >>>>> } >>>> >>>> This causes a bit of a mess when staged ahead of mm-stable. So to >>>> avoid disruption I staged it behind mm-stable. This means that when >>>> the -stable maintainers try to merge it, they will ask for a fixed up >>>> version for older kernels so you can please just send them this >>>> version. >>> >>> Can you please drop this from mm-unstable since both I and David >>> nack'ed a similar patch in another thread. >>> https://lore.kernel.org/linux-mm/20240511032801.1295023-1-linmiaohe@huawei.com/ >> >> That appears to link to the incorrect email thread? > > I meant that patch is actually same with this one. Just used folio > interface instead of page. I'm not sure why Miaohe posted two. Maybe > target to different version. Sorry for causing confusion. These two patches really target to different branch. This patch is for mainline and another one for mm-unstable. Thanks both. .