From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A55DE7717D for ; Mon, 9 Dec 2024 17:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 147338D0095; Mon, 9 Dec 2024 12:47:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F8408D0058; Mon, 9 Dec 2024 12:47:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB4588D0095; Mon, 9 Dec 2024 12:47:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CD5F48D0058 for ; Mon, 9 Dec 2024 12:47:16 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53DCCACB50 for ; Mon, 9 Dec 2024 17:47:16 +0000 (UTC) X-FDA: 82876151610.18.5CE2B14 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 37B3680009 for ; Mon, 9 Dec 2024 17:46:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="rlybrBT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0JwVeeCC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="rlybrBT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0JwVeeCC; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733766424; a=rsa-sha256; cv=none; b=qE2tsv24uN6SLS6bb4vZvu4Xd8dsxnyGNK8AsTJftEkbPoISCXrmPqpOy9Z3FLM9eWC7BY bFYAjoMOWYmMgiVCqXU1GYdyBKehzd1vN7NxY5XCIWtCiO9sj08ldvpTkW5EhuZWVmwOqy 2O4XTLk8m5DBNBLUjEcL+ec2RmGLUyw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="rlybrBT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0JwVeeCC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="rlybrBT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0JwVeeCC; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733766424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xRlHEwDMGhFdyadGqgWa8NxftBI9cXikC0b4BLqAh0I=; b=4gDXlxXkWbYsWdRlajyvYd1bnBZtA1oLnhlwMXp9KCU/FQLFTlwqxgX/9Y312hIy3mwGF1 Yr2A6OTh35K7S6ZFY+yZ+dLkBxdoB9k3dRwCla01eJRLsFEpIN5BM5g43MhEhHr2ype+sV qCKwsz3gCy5IoXvrsdBvcjexlUHjZF8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B08F1F460; Mon, 9 Dec 2024 17:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733766432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xRlHEwDMGhFdyadGqgWa8NxftBI9cXikC0b4BLqAh0I=; b=rlybrBT/wWSqdYkA70QdLM2UmHDY9HOWu8ggd+nngPZSAmztgcGZKVt6CCvlIgMkjmcTK1 r2SfHS5Vaw1pWtYfd98X+GPvmXpRskKczf7bICDaIDgnAGu0jrMzdBsE7dc2RjkIZkcG+l WagaWDKXsCkE8VSMhvhcjt0NgUeSd30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733766432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xRlHEwDMGhFdyadGqgWa8NxftBI9cXikC0b4BLqAh0I=; b=0JwVeeCC0seGRfEcDzYyD9sK9IPorwfvkW81lvMGerBa+LZ4v/nD+WBieRAIAl3jzeOArI YAkG95Ygcgt27EBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733766432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xRlHEwDMGhFdyadGqgWa8NxftBI9cXikC0b4BLqAh0I=; b=rlybrBT/wWSqdYkA70QdLM2UmHDY9HOWu8ggd+nngPZSAmztgcGZKVt6CCvlIgMkjmcTK1 r2SfHS5Vaw1pWtYfd98X+GPvmXpRskKczf7bICDaIDgnAGu0jrMzdBsE7dc2RjkIZkcG+l WagaWDKXsCkE8VSMhvhcjt0NgUeSd30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733766432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xRlHEwDMGhFdyadGqgWa8NxftBI9cXikC0b4BLqAh0I=; b=0JwVeeCC0seGRfEcDzYyD9sK9IPorwfvkW81lvMGerBa+LZ4v/nD+WBieRAIAl3jzeOArI YAkG95Ygcgt27EBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2A5FE138D2; Mon, 9 Dec 2024 17:47:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 79sOCiAtV2fePwAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 17:47:12 +0000 Message-ID: <9e426477-ed45-4e32-a61b-917413b2ad76@suse.cz> Date: Mon, 9 Dec 2024 18:47:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v1 2/2] mm/memory_hotplug: don't use __GFP_HARDWALL when migrating pages via memory offlining Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Zi Yan References: <20241205090508.2095225-1-david@redhat.com> <20241205090508.2095225-3-david@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241205090508.2095225-3-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 37B3680009 X-Stat-Signature: 4h1o3tnjfrxt8trcuysod3n6e8xjh99f X-HE-Tag: 1733766393-602630 X-HE-Meta: U2FsdGVkX18m4VUG8Y7BKmllMJMaAoPv2Xt/Tj+ZzbbZ+dF6afkJynV9VqaXgTBWgfenBVHFlKAzOGWA9SR1HAcNUE1SLA66UCwHVp5/2oxe2S8Y8TRmyFs+xG+e/7sSHQ0n/oWWp1e/jcpcV/MdTSq+3jdUnZpKnEx70/Q+PigtJhEJf3RXlccmLuWf/avIEQDpHYG8CcUuK/Fvfzn3DZ0A9NyMHbxoY1ynrJ0aoVoaw0cnOR/4kMvk52iSM9Ssm3k/zWahmuCgThzHShFNUoXBgjBckGcon7bG0CD4Laqa59gWwWpQOUz3Y/Zyg06NEtzJRjcTjDk4HwMMOpBJFd7I/M3FTOnAM0RZMlDjbtELCI2uT9zK1SosP47jB0Ln0RA8HTiRXSja+IqdSPx91C1KA5oOlq/iYHcT/6/S2RVMB/rw2Lmp/026mtfcjU3L30RhdgMJs0J5i8Qj6tsYQ9HYazU44U+sPMiaP36BhroHNB0BOGQhiLX4vsF/twBQTG8DfbGIpQYZZAU/1oMrg9qqTWnEvY2a9zkIfKEhR6iUkMYC7z/B65C7dXFhQCDSwItqFvl+K6vIRh9HInpl/yTxfbREF++gQK6pFrWStYb4h63lDAMX/emlGH8dCoRepK2aDfghvHt+1TK14PO6msBIk4Oj0ji9fNdXC+vo2soQVhyO8kNzbgJbJYiap7XeHhVgaGXu7PjTv1L+bNj5WRhnkLZaIC2lVrT2BNSeaUASGNjMnmnxJG2rlDNXeK0/v9j1UY6jm2vq8MgnmJ1tLh+2iGZ3Kt2H8/jBWtWbnDpeyU+8q7lSGxKqTgnrE/hUwk0uBvTF8CZ59YBt9yQYE75d9+qPADQ4lUdBwWLik8FQHHcJltohko72tTvzTcCYeJ+5caNjuiErzg0SEY/rkt5js1Y59tofFAaa++rtzniNtuCxj3fd+hMgJYhPz2upDufHU3Fk/bqcVrj27Qq /7uVwwU0 zCSWF8xpU0YVOpUdns2Pdf8udkVV5lehnsr5BpCZkMSs5oWR94unbkbjxr67HANApLOnIJjJQGuYhs/3zUilSuJcmazdSN7dDIbqlz2ol/deEb1WC+gp3K+11BrhZu/p2Qt5UOsVslA9RM57g1UYrNWdM8WCnzUtWoCg0N0mu8jZ4DTt0q22EuChZdzXSUzDxlMhOFSphCnreqB87HxsNR9T59/4VW08/y6VZ7tK9lzvK4NLJDMx8UDbNzHlQiOwUtXj5/8rOR4C1fbOLMoUqaY1N0DP5zWtIwPlICuw5HC+Iy+MLlBPa0rBEJ+YUlVHWxc6LoZqADl58NjDlnv16np2kvTE2hDgXwPND X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/5/24 10:05, David Hildenbrand wrote: > We'll migrate pages allocated by other context; respecting the cpuset of > the memory offlining context when allocating a migration target does not > make sense. > > Drop the __GFP_HARDWALL by using GFP_KERNEL. > > Note that in an ideal world, migration code could figure out the cpuset > of the original context and take that into consideration. > > Suggested-by: Vlastimil Babka > Signed-off-by: David Hildenbrand Reviewed-by: Vlastimil Babka Thanks! > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5f497ccf473d..3b6f93962481 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1838,7 +1838,7 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > nodemask_t nmask = node_states[N_MEMORY]; > struct migration_target_control mtc = { > .nmask = &nmask, > - .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, > + .gfp_mask = GFP_KERNEL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, > .reason = MR_MEMORY_HOTPLUG, > }; > int ret;