From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA96AC369DC for ; Sun, 4 May 2025 06:47:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9136B0085; Sun, 4 May 2025 02:47:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A726B0088; Sun, 4 May 2025 02:47:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613C56B0089; Sun, 4 May 2025 02:47:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3FD036B0085 for ; Sun, 4 May 2025 02:47:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 60EB15FEFF for ; Sun, 4 May 2025 06:47:53 +0000 (UTC) X-FDA: 83404295226.04.1022B34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id C69CE40005 for ; Sun, 4 May 2025 06:47:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KIxDnhmU; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746341271; a=rsa-sha256; cv=none; b=aHn52D9m+Ua/4CJ+HMGMpFy8eUHsDfIixPsTWD41wV9pwEQa8yNGbgF9lyJhXZe489HmNd pc7ls7r8TLzYNVk/sXgxy3hCE6qRYbnu6sL5XRsSKrUTFOqn3DsCvwYhBTNvXKGqgZTWgk Y8+toPLzRNhrER1GakWdN/slDU7VOoI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KIxDnhmU; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746341271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VciL2Vnq4XFO2l1GLh+8tGcQoZiSbi51G5aHAKQPPMU=; b=aXsSSqvTHTXV2szMVBRTz3E+xt8LQj2auLdBssshS/1YXLRcUe+3zb/rqnWOM4oPH8oTUL zf4uWnlrSSi8HcFpWlgHBOA+hAyCQ9+YSMbfes5mJ/IRVyyURyqSh61sUoATlEwN8mG/IA 4UYWCNyzg3ipwcvvjxkrfer+dqcL754= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746341270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VciL2Vnq4XFO2l1GLh+8tGcQoZiSbi51G5aHAKQPPMU=; b=KIxDnhmUGJcDkB5LqvJ77cKUbArdysuAdogLAvAnCzgvuYGjWPjg6uQ0/1PY/wI927auLT xsbm0bjq3GS5CVFJEwrSPObbDhWuf12DaeXymDhyXhrfMoqQIHrnILlwDyyO0n1UqEc5kj HcpnKlKX/qESBtAzGknhPF3KSDUTPj8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-7D77DoXwP4yXMzPlj6U03Q-1; Sun, 04 May 2025 02:47:49 -0400 X-MC-Unique: 7D77DoXwP4yXMzPlj6U03Q-1 X-Mimecast-MFC-AGG-ID: 7D77DoXwP4yXMzPlj6U03Q_1746341268 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43efa869b0aso21807695e9.3 for ; Sat, 03 May 2025 23:47:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746341268; x=1746946068; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VciL2Vnq4XFO2l1GLh+8tGcQoZiSbi51G5aHAKQPPMU=; b=Alj0m7jyXQX+/dis2lZxEbR1YajxjYJcv+FZRvodoA3SMtVOaeZaZAR4hszgW9oxI5 ZL2e5WreB4P/pBGS3Al1LibOi3VwQPym82UrpG6uF8nieGHUa2uJolANhjlzXy74VMR1 RGYKfUW6ZJK+THApk6TUwiY8qI9Ynwt/eFPaH4sJKJ1IywQbLmaBbPNSz2PFUYlhvv6A hC5U1V/0JVl7NPzXPGZbRkZAMDe8rcITrcXsEDhy+PnVnB8b80cLA0Xvj7o4hyzKpH4F 6X+90z9ThguWrGSgadUGGxDZc7g+2RsY7v14x21IWL6mndRbghrVc/tJc31AfIzE3VcO vqPg== X-Gm-Message-State: AOJu0Yz7tsv7jOhkwVYdk69/xTSRvu55M93/57fzOn5PwFMuA9saFYt0 FFr1KDXL0dDVdflVgZu6fQd5PW4zjlyGndXna6GHYXxG3Ey1eO1E/JvDnKX83uaLEP8pHaOa6/V M6WEX7Qsffd2ATE0R87xZikcYghHMc8sOk6LQsFzzp8lY3L7d X-Gm-Gg: ASbGncudiWeZVXpArW9rlRz8xxLsh1eOaWOgCajdNLgmxVBXQezN4v01BeEXvqlJJ+e a/n79EGLe+f6RIVCqg+ic35MsrwzLvn2gn5H8dA83FZ0DkcvUpZndN2NVrRVZotuYRemtO+OCE2 ew2mBPrsqhguueydK7VfvYjELNsNbJItexYPJj11ByDnAHHjPk+gapq0UeWS2BCsDZ5JPFSUtOa GsyAX2WLxMvKx0gogAEsgbwLU7+HJpcJelIkpkJ/7HvDYAcFjivLi+Z5ugrxyzLvndrK7lnanMK sADqMlxNjXmofsypOSqm5iDt34pfiHXXehUvwZHSobBohIHhbIfMjxMb9Nom05lq2xjPu/XSZZD uQ+TgEJNgm2GQoMKspqQzcrTKHc7+d7+bvJ6BtVo= X-Received: by 2002:a05:600c:5290:b0:43d:fa59:bcee with SMTP id 5b1f17b1804b1-441c49340e5mr20735055e9.33.1746341267772; Sat, 03 May 2025 23:47:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXFB3FR+eN6PCitQ4q59SAduxE/fk7xHIzBkM+MEWxbylSCKCwT4qO0+BHzou0JizYj1Y0jw== X-Received: by 2002:a05:600c:5290:b0:43d:fa59:bcee with SMTP id 5b1f17b1804b1-441c49340e5mr20734905e9.33.1746341267422; Sat, 03 May 2025 23:47:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c732:7200:c4da:f12e:1fa8:eaef? (p200300cbc7327200c4daf12e1fa8eaef.dip0.t-ipconnect.de. [2003:cb:c732:7200:c4da:f12e:1fa8:eaef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2b20a65sm138626545e9.32.2025.05.03.23.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 May 2025 23:47:46 -0700 (PDT) Message-ID: <9e3fb101-9a5d-43bb-924a-0df3c38333f8@redhat.com> Date: Sun, 4 May 2025 08:47:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm: fix folio_pte_batch() on XEN PV To: Andrew Morton , =?UTF-8?Q?Petr_Van=C4=9Bk?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ryan Roberts , xen-devel@lists.xenproject.org, x86@kernel.org, stable@vger.kernel.org References: <20250502215019.822-1-arkamar@atlas.cz> <20250502215019.822-2-arkamar@atlas.cz> <20250503182858.5a02729fcffd6d4723afcfc2@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250503182858.5a02729fcffd6d4723afcfc2@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -P4ar1Ch_U3Ylfo75MrEi3BkhoicQf6i7Oe57d9_e-4_1746341268 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C69CE40005 X-Stat-Signature: w6ftgyfxbdikn8j8gx6mq4i1grbyrfso X-HE-Tag: 1746341270-596417 X-HE-Meta: U2FsdGVkX18q/1x3e214yzgiknOGmY/DHSxlSCvEKgkKh1NOa1TzoqQzdM4pQK+YSYXgqQyYr8L9J3XKzXfoYipJk4OfFtNCr56OxhVzFlJzFqeDL8tT1qBeDK8j3szClORXJgFofp1t9FdK3w7dix/rDCtnL8gzD0oscA1sIii2XaJj7qI4k9wqvpNfc3+cJ6xBigCpGAily5RWuBSBqsJZCa5sB1fLEeDO5XLFnjbU1z+bWOMbwW0D3dH3Dk6gnuWL8xOA6gxgDZ3mQJAn2CTBNNeUiGWkWnXvFxFyatoe3BgeCHzKrnZNjg5wzwVPM0sdW2n4gGJ8dpl6HQG+0O47xGlewX1LaDjzAVEfmbIKPCExMT9dqaXsT9ex0+RCbBLTKcqnm/Jtq3M2kY1MAcwutaMwxp5RHhkVQTqYnER8jaLRAuHnH8DaJHP+ZWt8cfvsjWiOA4hTA19vUBvVBhOfC+TinOy6oPaCh2Ltw8HPvrf+yWctloMwbWp/sX9wXkww9JsJ0Wl9kBNYrVubdpv21yN0tuq2KRTSNuFYBWlsLMRHE9i5GVqIOn88ysKxS4O1AbP9D9OutzdQORg7reX5tSY4vBqsrNq/YpN4JVvxHtcOOPJnmW/I1BueeUxidnJ+EP+j9pGpUPQW/bRrDwzM3gy/83bQx+3vDgN2zNti7V8VroVuyOcq0/j3boF8re5uefeHN/TmFJw6TOHS+5w6B6ivE9scVZ7CmuGUuzsQtmmCvr26Zol/g0gpNzWWjrrI+Bvf6OJZbJuVvo9cFRCEiZHuoGtwYDtt0SBGtE0dcBSh5jisUG6d+uoe95Dt4ILbiJOzD9x6y2GoyZo6t26vwA5a5daRMvbtOYA30OWbZYRwO1kRHgKGHrQLxW1NgKV4dFfdBZAYoJeywv0Z4+oyF+seYr3M5im3rvX9ZKACuNxdrv28PwzqXEyUzMOmlO5lbtWQ72gEmXCakf7 StL/C1CJ WnDt0WABAE79ljX/3J88aatF+L2xJ+1IjOWIIqjzyJOsQAvfy8WVW+23XPGu9F2dy8lby+KQOh/EVTD53NG+FRRhzH9UPRmuZN6fCsb/nKdwTOeanHSa7+bZ9Z6XjdxMbM6SpxaS4RsAheiv7v3REWTVTNzXU+VJcBtRzBdCTE/HYxx+USk2HrYdLFF44CpzEOMawIrCUesqVJt/xdYCO2ouoLVbI6d4/vbN8Ub5bFvCcEekIv1br/t6owDZckrqXAz+RL4s7JWDdhIuST23jzPv0Jflc6XQrCkwqXmMwaMMI1ANrFcU0RmZXz8bjPuVJi5ZpZBDgV2c4ZNvWpJvMtq2fn5NmbvukkbmQ+caVgZv8/GHaveRz9eZYZrdMs4Jhi0BpG8orbhgcKg5T7PKllxJKJZ9sUpslUwrzPvQTD7DDuRQPR4Pq/DHOdWxSIfjLRsYmz6YruBX3t/31OXtzguIMKLeNUBaxEWCNaMH13yXzQ+TrXB+auvS0/exAN/AAEU1nZv50mAq04Gk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.05.25 03:28, Andrew Morton wrote: > On Fri, 2 May 2025 23:50:19 +0200 Petr Vaněk wrote: > >> On XEN PV, folio_pte_batch() can incorrectly batch beyond the end of a >> folio due to a corner case in pte_advance_pfn(). Specifically, when the >> PFN following the folio maps to an invalidated MFN, >> >> expected_pte = pte_advance_pfn(expected_pte, nr); >> >> produces a pte_none(). If the actual next PTE in memory is also >> pte_none(), the pte_same() succeeds, >> >> if (!pte_same(pte, expected_pte)) >> break; >> >> the loop is not broken, and batching continues into unrelated memory. >> >> ... > > Looks OK for now I guess but it looks like we should pay some attention > to what types we're using. > >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -248,11 +248,9 @@ static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >> pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >> bool *any_writable, bool *any_young, bool *any_dirty) >> { >> - unsigned long folio_end_pfn = folio_pfn(folio) + folio_nr_pages(folio); >> - const pte_t *end_ptep = start_ptep + max_nr; >> pte_t expected_pte, *ptep; >> bool writable, young, dirty; >> - int nr; >> + int nr, cur_nr; >> >> if (any_writable) >> *any_writable = false; >> @@ -265,11 +263,15 @@ static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >> VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); >> VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, folio); >> >> + /* Limit max_nr to the actual remaining PFNs in the folio we could batch. */ >> + max_nr = min_t(unsigned long, max_nr, >> + folio_pfn(folio) + folio_nr_pages(folio) - pte_pfn(pte)); >> + > > Methinks max_nr really wants to be unsigned long. We only batch within a single PTE table, so an integer was sufficient. The unsigned value is the result of a discussion with Ryan regarding similar/related (rmap) functions: " Personally I'd go with signed int (since that's what all the counters in struct folio that we are manipulating are, underneath the atomic_t) then check that nr_pages > 0 in __folio_rmap_sanity_checks(). " https://lore.kernel.org/linux-mm/20231204142146.91437-14-david@redhat.com/T/#ma0bfff0102f0f2391dfa94aa22a8b7219b92c957 As soon as we let "max_nr" be an "unsigned long", also the return value should be an "unsigned long", and everybody calling that function. In this case here, we should likely just use whatever type "max_nr" is. Not sure myself if we should change that here to unsigned long or long. Some callers also operate with the negative values IIRC (e.g., adjust the RSS by doing -= nr). > That will permit the > cleanup of quite a bit of truncation, extension, signedness conversion > and general type chaos in folio_pte_batch()'s various callers. > > And... > > Why does folio_nr_pages() return a signed quantity? It's a count. A partial answer is in 1ea5212aed068 ("mm: factor out large folio handling from folio_nr_pages() into folio_large_nr_pages()"), where I stumbled over the reason for a signed value myself and at least made the other functions be consistent with folio_nr_pages(): " While at it, let's consistently return a "long" value from all these similar functions. Note that we cannot use "unsigned int" (even though _folio_nr_pages is of that type), because it would break some callers that do stuff like "-folio_nr_pages()". Both "int" or "unsigned long" would work as well. " Note that folio_nr_pages() returned a "long" since the very beginning. Probably using a signed value for consistency because also mapcounts / refcounts are all signed. > > And why the heck is folio_pte_batch() inlined? It's larger then my > first hard disk and it has five callsites! :) In case of fork/zap we really want it inlined because (1) We want to optimize out all of the unnecessary checks we added for other users (2) Zap/fork code is very sensitive to function call overhead Probably, as that function sees more widespread use, we might want a non-inlined variant that can be used in places where performance doesn't matter all that much (although I am not sure there will be that many). -- Cheers, David / dhildenb