From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7791C48BF6 for ; Sat, 24 Feb 2024 21:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41A116B00C9; Sat, 24 Feb 2024 16:02:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CADD6B00CA; Sat, 24 Feb 2024 16:02:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B506B00CB; Sat, 24 Feb 2024 16:02:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 154D46B00C9 for ; Sat, 24 Feb 2024 16:02:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AAF781C05A2 for ; Sat, 24 Feb 2024 21:02:14 +0000 (UTC) X-FDA: 81827920188.04.45E93B8 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf10.hostedemail.com (Postfix) with ESMTP id BD80FC0015 for ; Sat, 24 Feb 2024 21:02:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ee4uYkIA; spf=pass (imf10.hostedemail.com: domain of rientjes@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708808532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ePcRftl5sVDiYzrpHJ3u0w2CefDD/b0RFj0UwX8i7Ys=; b=QjXQLDC7W513qDWyDz+rTtc4pqTIHppGPTaAbNfx+2UqXlf4i8hVl8PRCAo+dC8a4duEsp XE1FbTo+JciVCQJXl732SiqpxBQX6hXLUjo69Y6ChhkWHVmlBsvpywxACbg8leFYgkJ0eg vkZrnwnpkdeKI9iTefcMFOtE8s9EPr4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708808532; a=rsa-sha256; cv=none; b=t+g9Di/Fvq/CNNq0beIWHZZ2qoPne+Vj4Spaoz+8ScHfVWVRja5D0XuM6ld6EPEpRrzahO 4Db97wM17ax2HY40Qj8saiNj3WZg/u1B1CxNtpxBAzw4EnMcFlxYAbvyIuoPmDleVx51IY l86lBrwhSI9DACYogF/vyvpZkEtQD1E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ee4uYkIA; spf=pass (imf10.hostedemail.com: domain of rientjes@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dbe7e51f91so84225ad.1 for ; Sat, 24 Feb 2024 13:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708808532; x=1709413332; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=ePcRftl5sVDiYzrpHJ3u0w2CefDD/b0RFj0UwX8i7Ys=; b=ee4uYkIAERWnDpSTOdV/mshQk22eYH0CmkWf6xB0y5RIAMDqo0m2x8Sej2FSmU9dnB VlSz1vFHJYGspEHjJ7+7Vuxe51TChr9pd1kJ8P2/DKtLosxWDmgwlLcYIspg6Kp3M2gw O1PzjczOQdSriu5FCrnrTwI20P99wjLER6vTppCkXKTtbD6QRCQ5h6PGpwK0wiW1g1/F IliC51gfyyv0OLaKB28Npjip2carun49hjnL2lp6xo0MImkZelbHYR25c7hbtu1dllVG gj7SoEnYVjvyy1OwqE9EhvPt2TT/wVT/WjkS81kicMZ+SpiQ3e3PajGBv67jSz3iuMiR elvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708808532; x=1709413332; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePcRftl5sVDiYzrpHJ3u0w2CefDD/b0RFj0UwX8i7Ys=; b=GBq1HztocUONHLYvOrVjC2902NAxhcMxMpdsiJcm8Hm0nhk/GSHUVQfkenfanvx7Or BnnFHCnc8V74NmvheGQRLejDL5zigBqR91KXMV1GhQrJUrS5SO+E8wUmUdyva8vlB1Ek 9pArgO05A2KZJKri0hLyEmzCsT+pcRJEO7WnknH+XuTBLzq6y6Z2ABsAsfHfhGj5lHss RFG0SAkj2r8pF6jZYDQtnLAnIoYwvaDg/HdCJ10sNB3jA5HmL3dzMOzuIIpjLbxiL7E4 NzOK3pz0Byfr6Mk3qIhz9nKJBAcDBwWOWBKX+apybcIUcH699ijroRUGG9sH3Brh7SPr TJ/Q== X-Forwarded-Encrypted: i=1; AJvYcCXB9rero8INURpr1ys9aPJ6Oda5lBfGW+yZnyq8mJWGHV0OvhaCS29YH6kX9odNAfnN8ShM4ZWVfc6/EL7ubBCw3A0= X-Gm-Message-State: AOJu0Yzp0uQAXP028lFKN18u2SECq85y2QLjXEzCdT+Hsasl2gL9eZmG 4BVKZkVJ814hPZS6+1el6AO9aEMl+xzCvpnCX8VTsacoKf3Tyfgyxbifs1msbA== X-Google-Smtp-Source: AGHT+IENt6y3xMZdPidcytahM/DYB9CW9Wn2djHjVN8SOPgNVka0WghH09kEdgaru+hlSeLMJP3RPg== X-Received: by 2002:a17:902:d203:b0:1d9:907f:635a with SMTP id t3-20020a170902d20300b001d9907f635amr183529ply.13.1708808531154; Sat, 24 Feb 2024 13:02:11 -0800 (PST) Received: from [2620:0:1008:15:ce41:1384:fbb2:c9bc] ([2620:0:1008:15:ce41:1384:fbb2:c9bc]) by smtp.gmail.com with ESMTPSA id r32-20020a632060000000b005d30550f954sm1474292pgm.31.2024.02.24.13.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 13:02:10 -0800 (PST) Date: Sat, 24 Feb 2024 13:02:09 -0800 (PST) From: David Rientjes To: Vlastimil Babka cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v2 2/3] mm, slab: use an enum to define SLAB_ cache creation flags In-Reply-To: <20240223-slab-cleanup-flags-v2-2-02f1753e8303@suse.cz> Message-ID: <9e2e6912-5778-2e34-5f63-3ccaebdbe576@google.com> References: <20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz> <20240223-slab-cleanup-flags-v2-2-02f1753e8303@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: w9bumdc5bzp1zu4ig6msro4d5drcx1bj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BD80FC0015 X-Rspam-User: X-HE-Tag: 1708808532-889740 X-HE-Meta: U2FsdGVkX18Mn6tTqowZl6VQ7KApM1cCcpZLxiCEeTLjPe+qOvjGqAN7VaaOj2c/RhdfpV6mcLlZYL4ySEddIBeRpvIQXaPevefmFjhJJMB4BcSw3iuQ/H+YMkPQV/RfDXepXUqApwESkcytladurRdHHBxgUnRLmT8uN7SnJBAvcEiG4mbp9lQvgAYTeBga3RjRQ8kjiM6C104Cjz2jctR30BuxZxCZl1dpRo5MPLMZ/CvwrD6SthoCdliWCZmoUEhRPHAGEbJUo9RaLA5FgAIDjMPh99rkhU0rYEVL3OLfZtSm/wPMt3rG4U/OyDF5Ki9pgqsx2rKDkGuT4f9vY7rVs7TCl7wYmK/5XtO6JWwcgAWqFrPNQ/Fk+rWzSVqCw+OFwJCtmEw2fSovRm6XhTsP29/5a7Ox4S5wK+7hNnUf27oAZh5jgq9DaOjD5WtefQHPfbr22wJ9ycAixVNE1F55Q+Io6T/rTMBDr9TF00Jdltd68KLO7Gv/OtpecDQjxvuIHOmCcEifMChFVvQvJvgEkpqiseNlTdNvLr80pT/BbOt3xBVKxaHCWn8+2uhEbddEByiqdI60h+gmcW7fEeINp7M3toAMjkI9zehgQa0BJZsS/3wupA3n1CPWS4nhnwBT7Ay3fD3/R+K6hnJ4JUf8N6DmE1gyE6adBG7xmuqFngejJe3CHqMGaJUEmkeN2AhueMwPsFRK3beJxtcjM2efIRq+TDDk5U5hKk1rTEJ8ityqxpM7+ootRqgkO3eYqgCqI3RhWI7X7CSYH202J6DFqJWGUOx1lKCA335Jdzg5PyVKlGJthx24oMoCzi95TQ7RQRocKw4GmVR3sALoo7gQldjeDTBx/YHRbUEG3776NwZWXIxyUHtS4KaJT5yqUA1C2SlGrcXR8Z166vQcvpKea+FS1itVrciSX6zlFopOiO+dlJnopbI1gK4VxvaTzWZnEldxs6dLrAJB4fN 4wwVFutb RTlJONfCznAxK2/8iOIsgWnPChuFtfgaSC8gVcLLmzYFL9OdklGzQJsvGdZtG80YXH4LgdMPQHVK6DRdencVA9hA2D9XRap4bwAah00TfdENPej7UyvR+z0MKoOIkf1MWQErK9/xLz+qMWXR39+tLmdYr7+aGeDGSOF9OysnxdCZ2yyLgz0qtVdbH6uZzzJOL8+CEmOQoZUC3z2cwm5cU5Tv+uGOcW7tJ8qs1dsI6Fyj2dRTM6PZ57ylpH0BpIupu6uvukjvjnM6zQ4b2Ai4Ha7EhWbb7HjQJYOTe22ZHhvNzy+qVSNbxQjhkrmyTPCNn1SQHUOHzBAS3RO3gKsVMb5p9bwT6BoqF00+amUaV8D4g1Vdtd47a2JD5CQX3rBH511+pT3xs33NwG510pPJ95JVrob5Yl5nBj2VsVGBr3xauaycIaksCvT06TKQXP/QPwOBUuH3yeQ97/EjNemjAq2fs7G2g95KW88P1QBoerLNX0GHiuXDfBuXweIIaNDtXonh0CGmBOsB1zhxFnEcO87WECRyf33+1o+0MyawbkhMew7a6/dXOxOQtvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 23 Feb 2024, Vlastimil Babka wrote: > The values of SLAB_ cache creation flags are defined by hand, which is > tedious and error-prone. Use an enum to assign the bit number and a > __SLAB_FLAG_BIT() macro to #define the final flags. > > This renumbers the flag values, which is OK as they are only used > internally. > > Also define a __SLAB_FLAG_UNUSED macro to assign value to flags disabled > by their respective config options in a unified and sparse-friendly way. > > Reviewed-and-tested-by: Xiongwei Song > Reviewed-by: Chengming Zhou > Reviewed-by: Roman Gushchin > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes