From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3DEC3DA79 for ; Mon, 26 Dec 2022 15:07:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E98ED900003; Mon, 26 Dec 2022 10:07:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E48E2900002; Mon, 26 Dec 2022 10:07:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D10BF900003; Mon, 26 Dec 2022 10:07:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE7BC900002 for ; Mon, 26 Dec 2022 10:07:56 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E75B1A0938 for ; Mon, 26 Dec 2022 15:07:56 +0000 (UTC) X-FDA: 80284787352.16.5ED82DC Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) by imf13.hostedemail.com (Postfix) with ESMTP id A318020012 for ; Mon, 26 Dec 2022 15:07:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=paragon-software.com header.s=mail header.b=bmGO0e+P; dmarc=pass (policy=quarantine) header.from=paragon-software.com; spf=pass (imf13.hostedemail.com: domain of almaz.alexandrovich@paragon-software.com designates 35.157.23.187 as permitted sender) smtp.mailfrom=almaz.alexandrovich@paragon-software.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672067274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b1y7zXkinhxvot9jeetf8cDO0mX7qUONskkFtfjYn9M=; b=tCvUqQQPD23ZXAxNJrblOR4DZYH/Z8TYiwQVD181sI4bK8H8BuTrjSEYp25bYcxM/0j9Cg IqwBXiRIsTxWXTEAcn3pa/sexyDbEebRijJMJMmv2yIP4zCzzE5EM6o0olVWIhyN5vANCW RDk0bo2MRhKlU6ZbqIHvWIYzbZ9E65c= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=paragon-software.com header.s=mail header.b=bmGO0e+P; dmarc=pass (policy=quarantine) header.from=paragon-software.com; spf=pass (imf13.hostedemail.com: domain of almaz.alexandrovich@paragon-software.com designates 35.157.23.187 as permitted sender) smtp.mailfrom=almaz.alexandrovich@paragon-software.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672067274; a=rsa-sha256; cv=none; b=MFa0x4bIlr6crMjT410DOo0G9FeJSojo1TZr3xlkqM+4vYHqDZTTOcbcLx6zddQRX/kO6A 1ZTw0NHe93V0S6JMjW3oJuA3xJaML2+LMQj9Wqeqm3Li7fFM1oSNaHaja/VrVDE/BgY9G/ 1JqAZKPDKMTDzQyD6C3pGpyzds/nSLg= Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 6A75B1B7; Mon, 26 Dec 2022 15:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1672067062; bh=b1y7zXkinhxvot9jeetf8cDO0mX7qUONskkFtfjYn9M=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=bmGO0e+PcHHy/MZcIUThzTX+m8GtUlc4/5m6aSlVDWGSgWPweaVF1Nf2kxvc9HdGn 8L8gJ7zy5uTPEoBUSOIbtKjlnVoQNCRY853bV8eXAr514L5uy2tI0i0DW1fs8OhrH9 lhHPrvbT7E1CCUPVCB7VBIddsjqLg12jTDfoPFUc= Received: from [192.168.211.153] (192.168.211.153) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 26 Dec 2022 18:07:51 +0300 Message-ID: <9e11da02-80f1-55f3-8bb5-28c3508e5396@paragon-software.com> Date: Mon, 26 Dec 2022 19:07:50 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] fs/ntfs3: fix wrong cast in xattr.c Content-Language: en-US To: Daniel Pinto , kernel test robot CC: , , Linux Kernel Mailing List , , Linux Memory Management List References: From: Konstantin Komarov In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.211.153] X-ClientProxiedBy: vobn-exch-01.paragon-software.com (172.30.72.13) To vdlg-exch-02.paragon-software.com (172.30.1.105) X-Rspamd-Queue-Id: A318020012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yzqr7qzw8qoi9yahdcgu76pabmo4souh X-HE-Tag: 1672067274-664130 X-HE-Meta: U2FsdGVkX19zRs5lVcHXfYFWfmduO1kcuXgcarkqClvCqFEUzjs+evDXcv+SGeJCbhsDZkUvZXLLabdIs/koUc3xaWoWlL8Iezvm+EcHD1Ha846AQR3ZkY5bisan5FndDCdodARqiDD7K3VxHvMTi0fF/VqDNYJaafEz9BC2bxA35DAJWwSeKXy1Bug0m3EDQUx8Ga0ekv8L/Q7285CU52nIf0FSrKHFJZRkwD+Jr6vT9PwGk6XM0uI4MZE/O5kbQrwKkYfndLuoJ/HTuHNh7XQP578PgMCN7U5d3kmh0Tf0iXMkU8G2fHpWQM3zOJEW0Gqu803lHt2tatd0QoLlLD0ikshZs9MRwhX4zY3QoVIMDVHSv6H3NCPLXHLJra4rAn1xrfZwnIKdf2jzResVrzz5g/AUquWzjtZLs0xbjaYZVqfIKAMgAAJdlCJPn/Vc9SsR7A3BybPDY02HaSMHtfLWMETeD40gt+pwG9dfGKFEKIGn4mVeg2icQAkPcOpeak2eH0KpMjP4sNbjmVbUhDARX3ayFseMFlppo/Xpt6Mnpczqek7z3M+QnGUt0IL3R8/QAeLPNJPGns+iMuPwi6oRBlWKBwBD+0T16gZ8HN0l+/sBt6uQtRp+21gwtsq0nTCrAYOsGXleo9PGkvinomhPcB3Ra8pUUFzXfnVg4na+OAGZvczYoJYHcuylI0+4TfBojaZNKGY7t1BajeHBc+IGndvS9R4TpZuwfMj79jV5HzE1Lwka7gEHTvpO9fH3KPSLFgnRjIpMmq7bJQACNlPQPiBfyu7KgnkQvMFuWPel1CPsa2ff5QU6nB07WWmmCD27c22v44jeGIlylltX7WzIeSzVuN9puarbYribkFwXkgO5OJPOmG6uPNpVWRoUEpMeOl91zuqTIUEixCfyE0tEvEu66HiHJ9UrgG6x6MWeL7KRUqHbPbVWSvAxUTo56GhJpO9DE873lAH2ai8 0kcNaLGn cNyy0JMhNj0AQsAsEHFJRyEXqtn4vlW0ACdGxQdMrgZLsle5H7fCpJsLHoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.11.2022 12:17, Daniel Pinto wrote: > cpu_to_be32 and be32_to_cpu respectively return and receive > __be32, change the cast to the correct types. > > Fixes the following sparse warnings: > fs/ntfs3/xattr.c:811:48: sparse: sparse: incorrect type in > assignment (different base types) > fs/ntfs3/xattr.c:901:34: sparse: sparse: cast to restricted __be32 > > Reported-by: kernel test robot > Signed-off-by: Daniel Pinto > --- > fs/ntfs3/xattr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index 8620a7b4b3e6..6056ecbe8e4f 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -808,7 +808,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de, > err = sizeof(u32); > *(u32 *)buffer = le32_to_cpu(ni->std_fa); > if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) > - *(u32 *)buffer = cpu_to_be32(*(u32 *)buffer); > + *(__be32 *)buffer = cpu_to_be32(*(u32 *)buffer); > } > goto out; > } > @@ -898,7 +898,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, > if (size != sizeof(u32)) > goto out; > if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE)) > - new_fa = cpu_to_le32(be32_to_cpu(*(u32 *)value)); > + new_fa = cpu_to_le32(be32_to_cpu(*(__be32 *)value)); > else > new_fa = cpu_to_le32(*(u32 *)value); Thank you for your work, applied!