From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF93CD129A for ; Tue, 9 Apr 2024 13:26:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DF556B0088; Tue, 9 Apr 2024 09:26:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FB16B0089; Tue, 9 Apr 2024 09:26:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22FE06B008A; Tue, 9 Apr 2024 09:26:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05C636B0088 for ; Tue, 9 Apr 2024 09:26:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C1A591C05E1 for ; Tue, 9 Apr 2024 13:26:27 +0000 (UTC) X-FDA: 81990067614.28.9FFA1A6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 80C28140014 for ; Tue, 9 Apr 2024 13:26:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1/fUEmSe"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wUM4KL06; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1/fUEmSe"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wUM4KL06; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712669185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvS1rJ5mx8pYO7vENhq0cJL3Mk1dX9RkykjtDYlgdds=; b=Y+WT72+CP8O31nIfWFRCnP6HJXGm7/E+j02/Ic+XKyVQGz2z1yWy7eF7WQhOLUV/dsNya5 zwjE2Wj4V9mfD1SlznwEElgVL+pDmLXvSG6EHoGObsnRT0R/OGPQTGQpBKZ/A6U+ZEOyxB kIorWAG4T8YvtNnJAlHUywcW6xXkVlM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1/fUEmSe"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wUM4KL06; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="1/fUEmSe"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wUM4KL06; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712669185; a=rsa-sha256; cv=none; b=tX73YPlIVmJouu1kubuv18kg3Sn/82YD60Q+S58bnCDw088lKb7Gb3cOhCm5kHV62N9ldk bXY4e5tmt+ehcFwrLBWStJEAtbe3Dj4CMilR3q7o63YCBmwDL+cXfVdNPzH6vScdGi+inM gxRQ42u4eB0r1ZLF/Pa2PfvuQqDjk5w= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96750339F6; Tue, 9 Apr 2024 13:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712669183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvS1rJ5mx8pYO7vENhq0cJL3Mk1dX9RkykjtDYlgdds=; b=1/fUEmSe/yWXn4yOhZef9JXXB06grucSLWkEzhty23m0DtaWlU/0c/Z76rcXArnEK1I++0 gnW94TpBssECU05F5uTDAd0EDWIL/eaxPiLL+jYbdrx8B37pHcRx14hOKbhaMv4Xl+zSvc b9ElegCpZT6ZER0XexUdK2uM6+X+S70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712669183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvS1rJ5mx8pYO7vENhq0cJL3Mk1dX9RkykjtDYlgdds=; b=wUM4KL06rtPnKuUWzBGdjnTEGzeZToveQOZg4Ug8V10Zca+0Nn3dnppKU4X2KHbw7e6GGP 90pOtWBOVrfniFBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712669183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvS1rJ5mx8pYO7vENhq0cJL3Mk1dX9RkykjtDYlgdds=; b=1/fUEmSe/yWXn4yOhZef9JXXB06grucSLWkEzhty23m0DtaWlU/0c/Z76rcXArnEK1I++0 gnW94TpBssECU05F5uTDAd0EDWIL/eaxPiLL+jYbdrx8B37pHcRx14hOKbhaMv4Xl+zSvc b9ElegCpZT6ZER0XexUdK2uM6+X+S70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712669183; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MvS1rJ5mx8pYO7vENhq0cJL3Mk1dX9RkykjtDYlgdds=; b=wUM4KL06rtPnKuUWzBGdjnTEGzeZToveQOZg4Ug8V10Zca+0Nn3dnppKU4X2KHbw7e6GGP 90pOtWBOVrfniFBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 89D35136D9; Tue, 9 Apr 2024 13:26:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id K4JSIf9BFWa0HQAAD6G6ig (envelope-from ); Tue, 09 Apr 2024 13:26:23 +0000 Message-ID: <9e0de158-f7b3-4602-8552-f568a96c3c65@suse.cz> Date: Tue, 9 Apr 2024 15:26:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm,page_owner: Defer enablement of static branch Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kefeng Wang References: <20240409131715.13632-1-osalvador@suse.de> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240409131715.13632-1-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 80C28140014 X-Rspam-User: X-Stat-Signature: q54494cy1e6j5ma6sprfad8argtdx3bf X-Rspamd-Server: rspam01 X-HE-Tag: 1712669185-242046 X-HE-Meta: U2FsdGVkX1/2RNGVpdJX/UaqIlTQVtmSpknMmocToK7RU8H4aHoka6iXJP9BwfGPQeqdW5lxIJm6nO70bia+r2IPDaLtgb7JyULQKIIOvPQyEr6/Edi+gD+HHXaow32xPyQRRygJFU503Y6c6m9FGyhJ+rpOONaOgUrYmHNqz/TQuYUN21w70ZS+FKqDQON8FIrFEXjIin5OnVUccl3k2gfOUCtI/vg7nlSe5DXMZYvoA3smIkgvGkKEpfievxrE9OGzWwKNn2CnwwLm/qaDE7ST55QSN0KA6AnznYZMUEzWT10wjGk1ocAihqVmncQLxgpBhShcIJcnlhEWtiWGDZx/yjjMVh60gR44XVsjzGXI6mgQx8sWbu/Ojsr4+yDYcbMIjlcBwcNhCSF9WGR5C4FDmJHmqIFvVRIYCzO/9yRhH0D1hzYJi7KlFiUq88gNoEwIGpG4jvm1gQb3n5K+bmqQa6qRPXzQXcQuW9c8Plg9n9j1NwpmPsTaxfUuW1CylxDd3a/4J8tSlWxVksMQ6fXjAcupt8zi95gbED5x1IVOFrGw9LeFtUwlEVIj3BpU6f9jDH4WRWEzgWRqNxJlpKyHumPSPtD4O8J2zuq0/czKzlZBu2z8m9v8s2C0HL1fjtuNxioWVgvYb1fGbpFSVigXUdwgrTvHsnl1AOCeFiHDg3bC4Q5OX5DipdWEvb3bcfmb8zao0BaxR5fbew3hjQL/urVXe+TMcKIf1HzZ7BeG/Q82DEkMurBXjp9jv5xRltxVlZ3U9KTUE2a+3IRzbNnHi8FqODCq9A+qwKv1HVOv+Nm9zwhGk3G0fVFIntj8q16KhuBibBskki33lC/i6xNDpc4jEHcHpLpSPO6emHBgGO8kz8v5c0ggWihFRdfZUNG24rZ91ttxSoyGjsG4Nn0AINo+7SpZvLbRR/tlk530LXcg0gqQJ9po2lxyZ1Ybn409pCbNPJa+H8la3Gn +CN/rR3w ANiAN0IM3Z9FD7Uc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/9/24 3:17 PM, Oscar Salvador wrote: > Kefeng Wang reported that he was seeing some memory leaks with kmemleak > with page_owner enabled. > The reason behind is that we enable the page_owner_inited static branch > and then proceed with the linking of stack_list struct to dummy_stack, > which means that exists a race window between these two steps where we > can have pages already being allocated calling add_stack_record_to_list(), > allocating objects and linking them to stack_list, but then we set > stack_list pointing to dummy_stack in init_page_owner. > Which means that the objects that have been allocated during that time > window are unreferenced and lost. > > Fix this by deferring the enablement of the branch until we have properly > set up the list. > > Reported-by: Kefeng Wang > Closes: https://lore.kernel.org/linux-mm/74b147b0-718d-4d50-be75-d6afc801cd24@huawei.com/ > Tested-by: Kefeng Wang > Fixes: 4bedfb314bdd ("mm,page_owner: maintain own list of stack_records structs") That's in rc1 so ideally mm-hotfixes. > Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka > --- > Special thanks and kudos go to Kefeng Wang for helping me out chasing > down this bug, as I could not reproduce it with any of my machines, and > to Vlastimil to bring another pair of eyes, which was very helpful. > > mm/page_owner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 9bef0b442863..742f432e5bf0 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -118,7 +118,6 @@ static __init void init_page_owner(void) > register_dummy_stack(); > register_failure_stack(); > register_early_stack(); > - static_branch_enable(&page_owner_inited); > init_early_allocated_pages(); > /* Initialize dummy and failure stacks and link them to stack_list */ > dummy_stack.stack_record = __stack_depot_get_stack_record(dummy_handle); > @@ -129,6 +128,7 @@ static __init void init_page_owner(void) > refcount_set(&failure_stack.stack_record->count, 1); > dummy_stack.next = &failure_stack; > stack_list = &dummy_stack; > + static_branch_enable(&page_owner_inited); > } > > struct page_ext_operations page_owner_ops = {