From: Dave Hansen <dave.hansen@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, nvdimm@lists.linux.dev
Cc: Ira Weiny <ira.weiny@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] dax: Kill DEV_DAX_PMEM_COMPAT
Date: Thu, 28 Oct 2021 08:57:44 -0700 [thread overview]
Message-ID: <9e0685fd-0383-5dba-285f-65ec32895e4b@intel.com> (raw)
In-Reply-To: <163543595723.2281838.11942022992765100714.stgit@dwillia2-desk3.amr.corp.intel.com>
On 10/28/21 8:45 AM, Dan Williams wrote:
> The /sys/class/dax compatibility option has shipped in the kernel for 4
> years now which should be sufficient time for tools to abandon the old
> ABI in favor of the /sys/bus/dax device-model. Delete it now and see if
> anyone screams.
>
> Since this compatibility option shipped there has been more reports of
> users being surprised by the compat ABI than surprised by the "new", so
> the compat infrastructure has outlived its usefulness. Recall that
> /sys/bus/dax device-model is required for the dax kmem driver which
> allows PMEM to be used as "System RAM".
>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
The compat module has bitten me more than once, and confused more than
one end user who tried to use the kmem facility. It's definitely a
liability:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2021-10-28 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 15:45 Dan Williams
2021-10-28 15:57 ` Dave Hansen [this message]
2021-10-30 0:19 ` Jane Chu
2021-10-30 1:44 ` Dan Williams
2021-10-30 3:54 ` Jane Chu
2021-11-15 21:20 ` [PATCH v2] " Dan Williams
2021-11-23 19:11 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0685fd-0383-5dba-285f-65ec32895e4b@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox