From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19869C00528 for ; Fri, 28 Jul 2023 09:08:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CE736B0074; Fri, 28 Jul 2023 05:08:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87E5C6B0075; Fri, 28 Jul 2023 05:08:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71E258D0002; Fri, 28 Jul 2023 05:08:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62B286B0074 for ; Fri, 28 Jul 2023 05:08:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12DFFA0984 for ; Fri, 28 Jul 2023 09:08:34 +0000 (UTC) X-FDA: 81060444948.29.713513F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id C581A180019 for ; Fri, 28 Jul 2023 09:08:31 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F6qWBzs1; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690535311; a=rsa-sha256; cv=none; b=o+skx2S0+xFcwHCynGejf7viVGNcWQprBiWOhAzjjvDA+kDtBT5G+oYjeqS9elsVa2brx+ Z5PaFT2mOxUJ9h3QLU+I16ZyC6cj/4M8Q4Pg/Y77rkFXkyS3qjgi/dCQvn0qAvQwr15zua GOMDHecklwadaTYUdGHUKROa1o3x7Z4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F6qWBzs1; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690535311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vICWQosjgzvmsNNhYWSQCG3V0LU9ep5z1NVKRcrU2Uo=; b=ps472E5+jX2msOtCUYELHNbeOUdoNNT6Wu2oVQqx1nuP2DskRWl/ZC86qlEM8VySFy4ZSQ tsFRHQgw1dtueii6MHXIOalB3gDcM97tGcHnoJpu6BbvUXk3dklwh/uuuFvwyD14zbMYBf k3tcTvkeHB47HEGxXPDsXdMBix6ntD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690535310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vICWQosjgzvmsNNhYWSQCG3V0LU9ep5z1NVKRcrU2Uo=; b=F6qWBzs1mIVP7KZk7qIgPKkf0k3T69O7ps4MQkHn6DS/hAv71YzfkhyrUG/xnR/xnCBeW9 W6garaOe1lGkyYZEgHo1/rgS/rig9hdIHXDZotVYDhrjXNyt77fxGeubmdfKQiUdIctvkZ VitTDeLAQbtV/F+Yh3iZt/PQ6zGP34U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-0FuEkezVNTiJhMT8FvMevg-1; Fri, 28 Jul 2023 05:08:29 -0400 X-MC-Unique: 0FuEkezVNTiJhMT8FvMevg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31775a8546fso1237121f8f.3 for ; Fri, 28 Jul 2023 02:08:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690535308; x=1691140108; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vICWQosjgzvmsNNhYWSQCG3V0LU9ep5z1NVKRcrU2Uo=; b=Wcq2yPNOm+iBW4cuvFABK02+ucTrotr6fUR5xN8ZfUBcgOvs0RkcsZNgoMSzdrVX2t zV/FHqxsP4rc9r8PfFsLP/2GcCVxbidJmXKu5MMNKUpv/KRGlMmtRBvSxc4CWlvqbcxa HrI71L9pjNVoXqBd9Z6eSqFa1nHRXVtIR2N8KiQXzx4U/I8moEX29fvh48e7bk5ZVvI9 V1MeHRxFfd51oI+9552ZYbN19GJlOFEAL+2mmfnQu+LwbppyJosUFuiaJLP7hGyL6m7L rBRUHo95DtU/vZMEYBTgdGR/ekNphAWjr4Z2RgrdbIXJ05OjvRjZNkL7fV32l4Hh6ylh cXzg== X-Gm-Message-State: ABy/qLaYQysoYSkLP1zw3/x3JaTZhVoBFDlKRlnqSn5bGUCoX2AFzbcl Poyec1/Nag1AM8CCP0vyhaQVHOmjTs1Qse0rckJ/ubH9fq1xH7njscg8fGWuJhTs6z+tNpv+U+g lLe8wDgqCkx8= X-Received: by 2002:a5d:67c5:0:b0:315:ad00:e628 with SMTP id n5-20020a5d67c5000000b00315ad00e628mr1568680wrw.47.1690535308172; Fri, 28 Jul 2023 02:08:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlET/x722nNr1YsUgbVHFCqqtp0/WG14rtyI/qnYZsfx1F2ctU05mFLkl1GS6ELaMkI9jDmxrA== X-Received: by 2002:a5d:67c5:0:b0:315:ad00:e628 with SMTP id n5-20020a5d67c5000000b00315ad00e628mr1568654wrw.47.1690535307666; Fri, 28 Jul 2023 02:08:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4806000000b003143ac73fd0sm4343354wrq.1.2023.07.28.02.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 02:08:27 -0700 (PDT) Message-ID: <9de80e22-e89f-2760-34f4-61be5f8fd39c@redhat.com> Date: Fri, 28 Jul 2023 11:08:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: John Hubbard , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , stable@vger.kernel.org References: <20230727212845.135673-1-david@redhat.com> <20230727212845.135673-3-david@redhat.com> <55c92738-e402-4657-3d46-162ad2c09d68@nvidia.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 2/4] mm/gup: Make follow_page() succeed again on PROT_NONE PTEs/PMDs In-Reply-To: <55c92738-e402-4657-3d46-162ad2c09d68@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C581A180019 X-Stat-Signature: 188nc1rbazeg7n3zaf3fi579ddunxhqy X-Rspam-User: X-HE-Tag: 1690535311-726226 X-HE-Meta: U2FsdGVkX1+UwbzorDp/SQjJlXKwdrLcqf2elXG3gQBFHK4akoESF1dkyc0pTltYrUiLPFNkihcydvVaF7NEvM0FMxWW6RQHCuOmswV1qBY4zdmcDQCKoJan75dinP7NZTrsSmbyd8lCDiEI1dc30W8Juk/3Q+KsSJRHaAugDtRDpWf2EMhQZjFNQPe/ZCryLFw1u3cS0fQo6nD5riQjju9rdih5rwoRpeD+xNgbZWFXBTnTQjo02s5Ji61PjzYDD8Q9eHb2QN3h+7APXy0X6/7GPUbmSFhUPbykNxzOPPBOx0RBrOfqdbUSqNqoDeQdUDYLF14jMpAi5YZDG4N4FDqY3nUhAZ16nmrM1CLOUndb4DF4garP107T8ZGeJkPIQ68dDNaBeA22E5vww1IyvWisegDeIUDwBBphKEB7ZoAc4L4gktutERiHqwPvrB++jhEQDX37SGvJI5DxuguKWsC4+AojbdTvTBdH/cS3j9WGRFTtZ2IpHRepfPJAoNfkrv5kJ9ppnFpYOdfiv8oP2InihmsKx4ttiEqS2zGsVu4gZwST/FFDqvjCgLgn9b1j/YLq2dHAAoEwWQZyrc/svgE6Mpil7qJ2BqRG5/xOG4pnHaQFokQukDXJ2XsP490MNuYdf72fVgEyjKcUStT8MWGP6Kivx19hhcelq3MbG/4OTcrl1MkNxaYs7EdnRrbnbrmWB7OussHZh/qqtwlmATF3Vt2b2Q5iICjs67O1uORUay9Rm1wAe7Fyb6y4Y2qq7jGgwOsbqPl9llsQ0xKV+a3dPnjKEsG8R+zQbqOXATLaT8YdvyKW3IIwnfqABV2BJ8I92s5yh2W5sbaj4890FYCVDCmQ9KUQqnB7D8lE3p7/4qJutOFgRBlEnLv8POF/vAID2a9j09L12ChD/MrRpNlSUEI2KZT+iAp7PPG0+0f6m+KFYeU/IT3R4OS1hmxKEqsJxzEU37EywQncjnn h5DLzqQW la/DBEgfG9Xb35f16qLQDOTwUEfmuP8KguxVHP7gQ9HyOMkn0XtgylMPCpVnTi4O2KOplpLHLjnf1u3FTWr5NInqQPeWxB+xpd1f0eVZgB5v9/i1RGATQIVo8MUg3huhW81r8X3EMVcyxpA0clLkN1SeCu0QnKhoj3PHtvb+/EqgFd2wQZ8YFVi4pMCTZQSFKSmJOF2MxV6jeqSz+5xwUh1mRGJmmIEKLFi1jsnS+iF1e2q82OwWhGphx09oCwg8TasBQKfcEzQfa4I17ni1jOu4ywtLzs117u2tSfnfd/F66kLeqOw2Vjuta90mB2Iad9gbSQgE/7QiVnhthwTHR3ilviZjQsh9olWdWp/T4+cdMsFbhJwG9wgFSWtwEQ/Yxq8v1U/n4igaM0BdBD6/vDkf4YiEgPLvZ0i8bFaKcHUAB82F7+RItZ+kJExfLZOZ22WjmLCrrrsnv9S9CatEEtq1SS56As5gustX0GKt6ludMdIgSPeGgt5YpKVRWvBQW4irdRIj0EneXGd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 04:30, John Hubbard wrote: > On 7/27/23 14:28, David Hildenbrand wrote: >> We accidentally enforced PROT_NONE PTE/PMD permission checks for >> follow_page() like we do for get_user_pages() and friends. That was >> undesired, because follow_page() is usually only used to lookup a currently >> mapped page, not to actually access it. Further, follow_page() does not >> actually trigger fault handling, but instead simply fails. > > I see that follow_page() is also completely undocumented. And that > reduces us to deducing how it should be used...these things that > change follow_page()'s behavior maybe should have a go at documenting > it too, perhaps. I can certainly be motivated to do that. :) > >> >> Let's restore that behavior by conditionally setting FOLL_FORCE if >> FOLL_WRITE is not set. This way, for example KSM and migration code will >> no longer fail on PROT_NONE mapped PTEs/PMDS. >> >> Handling this internally doesn't require us to add any new FOLL_FORCE >> usage outside of GUP code. >> >> While at it, refuse to accept FOLL_FORCE: we don't even perform VMA >> permission checks like in check_vma_flags(), so especially >> FOLL_FORCE|FOLL_WRITE would be dodgy. >> >> This issue was identified by code inspection. We'll add some >> documentation regarding FOLL_FORCE next. >> >> Reported-by: Peter Xu >> Fixes: 474098edac26 ("mm/gup: replace FOLL_NUMA by gup_can_follow_protnone()") >> Cc: >> Signed-off-by: David Hildenbrand >> --- >> mm/gup.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index 2493ffa10f4b..da9a5cc096ac 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -841,9 +841,17 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address, >> if (vma_is_secretmem(vma)) >> return NULL; >> >> - if (WARN_ON_ONCE(foll_flags & FOLL_PIN)) >> + if (WARN_ON_ONCE(foll_flags & (FOLL_PIN | FOLL_FORCE))) >> return NULL; > > This is not a super happy situation: follow_page() is now prohibited > (see above: we should document that interface) from passing in > FOLL_FORCE... I guess you saw my patch #4. If you take a look at the existing callers (that are fortunately very limited), you'll see that nobody cares. Most of the FOLL flags don't make any sense for follow_page(), and limiting further (ab)use is at least to me very appealing. > >> >> + /* >> + * Traditionally, follow_page() succeeded on PROT_NONE-mapped pages >> + * but failed follow_page(FOLL_WRITE) on R/O-mapped pages. Let's >> + * keep these semantics by setting FOLL_FORCE if FOLL_WRITE is not set. >> + */ >> + if (!(foll_flags & FOLL_WRITE)) >> + foll_flags |= FOLL_FORCE; >> + > > ...but then we set it anyway, for special cases. It's awkward because > FOLL_FORCE is not an "internal to gup" flag (yet?). > > I don't yet have suggestions, other than: > > 1) Yes, the FOLL_NUMA made things bad. > > 2) And they are still very confusing, especially the new use of > FOLL_FORCE. > > ...I'll try to let this soak in and maybe recommend something > in a more productive way. :) What I can offer that might be very appealing is the following: Get rid of the flags parameter for follow_page() *completely*. Yes, then we can even rename FOLL_ to something reasonable in the context where it is nowadays used ;) Internally, we'll then set FOLL_GET | FOLL_DUMP | FOLL_FORCE and document exactly what this functions does. Any user that needs something different should just look into using get_user_pages() instead. I can prototype that on top of this work easily. -- Cheers, David / dhildenb