From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02938E7716B for ; Wed, 4 Dec 2024 11:10:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87AF56B007B; Wed, 4 Dec 2024 06:10:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82B166B0082; Wed, 4 Dec 2024 06:10:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CB206B0083; Wed, 4 Dec 2024 06:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DEDC6B007B for ; Wed, 4 Dec 2024 06:10:17 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EF0F0120F08 for ; Wed, 4 Dec 2024 11:10:16 +0000 (UTC) X-FDA: 82857007002.01.02018CE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 6160740013 for ; Wed, 4 Dec 2024 11:10:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0AS2fUmE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cIjwvu+M; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=x7g+wthQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vjNA9sUQ; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733310601; a=rsa-sha256; cv=none; b=fAXhG20lDB3XgBF0S6nOHopVZyAayfnXKe78tUAx7pjY59gjKo4Tt2i+R2U6JWtGw0QqhI xWCaWRzReynW4LFjTqnCDje5fludWSk8memxD7D1K5CwQTekELoiTeabrf+R08jsk1DHOW JYHWYkJbUhdLxwMy90qq+mTTNf+Kj+4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0AS2fUmE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cIjwvu+M; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=x7g+wthQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vjNA9sUQ; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733310601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdFINnsfAekbpidX4+iwZuNtvk8m+D7SKR/vCs1MuOw=; b=77pPJ8tnd8syMFW372WzgaPfRAhhTkhVq2n1EGzXcHfzKXmTT4ifQovLMZdgoV/EuokkyK TDqHbmxW4Ch0IM2YEdQi8ZFzCw3iPbOtYcZztObFSHZkRV7j1c9VbuM292oAnhzFJEplkZ EHpZ0p8uwel7QVo5+Ruzr/vAqFsXMQI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CECC91F38E; Wed, 4 Dec 2024 11:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733310613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdFINnsfAekbpidX4+iwZuNtvk8m+D7SKR/vCs1MuOw=; b=0AS2fUmE0wBZhXlJyzUV5/Ib1s4DGFmhIpNDQRMig3Iqrd3iQ4iqyPKs9r8j7Y0yWY6pBE Ye/OXz9t8JcGkDYa4E9LS5heRZwYusasAY/1ZN4iHo9K4xZCnw6jHJgIhjDTsBX8MowI3V YctQbqoVYG5jd/e3P7hgb+XyiMZ9MFQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733310613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdFINnsfAekbpidX4+iwZuNtvk8m+D7SKR/vCs1MuOw=; b=cIjwvu+Mr3PTCqGi3O1ZIlq/gt6tsiSRqEj7rUY5lSippAhb7P/TAjt8HKieiqEfUb3drj z37dd4W+L6SCYoCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733310612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdFINnsfAekbpidX4+iwZuNtvk8m+D7SKR/vCs1MuOw=; b=x7g+wthQL7fJ7q5zs7ePfxHv6CWUSmte5jGX8G8AVCM6EywbyKzuFxMgxENfOSuWhp4pdl UxArWr15S6sJkxWXFV+r0ZwdRW6G0HfklvGBfOx4CThQsz0wq85qARsOROKt3DJxLQZWYy wgJH9PsdjVxKjc9P5qQL/kd0nseq468= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733310612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdFINnsfAekbpidX4+iwZuNtvk8m+D7SKR/vCs1MuOw=; b=vjNA9sUQ356kKe67Y2/msmrTSFEZ0Yo+ihQfKPFsKhxwY/2fWAvlKZcHf48ahexnkx2HSI 1Zu5atQML3x+FOAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C025A1396E; Wed, 4 Dec 2024 11:10:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8leKLpQ4UGfxDQAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 11:10:12 +0000 Message-ID: <9de07435-73eb-4772-81c0-d95cfe3964c7@suse.cz> Date: Wed, 4 Dec 2024 12:10:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/15] mm/page_alloc: Add __alloc_frozen_pages() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-14-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-14-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6160740013 X-Stat-Signature: wrahmukez561yi37i7d8uamqrjf1965o X-Rspam-User: X-HE-Tag: 1733310608-627752 X-HE-Meta: U2FsdGVkX19OKV6a0YcxmPh2f4bYsPX8xLiabSwJp266G1fUmfg8d3MWCup0ljhCtjrYS0lYBANuDXpsnV/kG22wfE1Oo//wFZR9h+dlVwM1Y/zlsIN43uaP1EBQxECXxcODHC25yaPRfJVDJTRVwH582g0WfHg/rHWYw+2IC1pnqdMOesPv8GwdTQYvjiE/FGLT7iqzaWOvab4pWs41lKlkMkTBwOsMEd0CmN5tF5befNBYxKC36+y5cl3pnWAvF8Kqc9Q5vuEMgek8IQ6fqoTU5mOfMyTPoXMyXYXY2ANunWZoX9QpQdG+EAKu+pAVfUbKf4bJgUoYSS+wAhtFuI+ch7L6OxUtPnvApJz7bep36QcN5cIdh38xR5BjmPBIG4Haa43UJtDVdc7nOAp4e+8VurQWQThZg6LQmG2akKMBgq0fu7/b3+a54OXSZGhcsZ0ASEK4fNZx7rPsTOWHvNUQj4D7Ei79NnHUJ2QRjWQu0s/Wz4FMiP63pAuuS7y2NgwT6C3ymfmtWlBlLaX94/gQVZ2TzN0fSugJreBO1kwwtB8YkXkhaocGwQDYdh2ZeD+YXYzQlZSMZL1YGnIp0q9rNaiYGSkBQ3RwZXYar+G3zWZIwA7gMGgwBA1F5Sdc+fZEhgjE/BRPkNVn2WLnQIKKuUES3a0wMqBR9XgzJB4RzILJq0QZVo2imZNXNl+VG2re9PkC7W7D4k+EfFnY1ZvYIPhnEYOsBk9aMS9RT97cnQcqW2c9radM8q0c7vIJQJj1+zxBffvXgGZbFG1F/9gqp61Vr4LvhX8yx/0pVSKNkLv0SlK7hfFK+uW19m2NUNOjnUoIe+mVocFJZXXIQb4P1DAH02EI8RAdQJ5DvifPZUiRkI4SNVyCk25LFV90lXTu8PDZhAD6ZVGXF/XAnizz14eVMRk0OZOPmkAtKZMAZCC3v7caw7/KaiuGbV24jsgn7qosxQjf3nY/zBf DThi6kZ4 EoVQrkcLTXCgILA2L4m+1cb8sdloCWDs0EPq3QRYKhOeQjclUNAXClEcFArEjsIguESEaZeCmyDahnjMe/ILUyvJ9KDVkVRNdDpanyT2HaYDVSpdGTiNFj8/yL/Ven/cPhtNXIxnUx6ddK2GYX4RzeJsyVV4xkeZZGfW1QxIU4zOkUjxMLnID4GasFGgB3JuXsOI3fxuYZGVS+ou5WcRJaywuVO0qCAQCQWASkDGIsrdIGK10V56ZR+PKwVojj1/rbiNyiPw4vB/NIHLZd9J75PqY5M5NpWCQInqJoqTJdNEqFv757qzkurH+86E7S0043OmqeTYNg14Izvr6qQjWBpxQ48Za3d6x4b9DpV36EN2PczFhWzNFEq5zVLkGTd4cSypeOhRWVcn05XI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > Defer the initialisation of the page refcount to the new __alloc_pages() > wrapper and turn the old __alloc_pages() into __alloc_frozen_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka But: > @@ -4804,14 +4804,24 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > free_frozen_pages(page, order); > page = NULL; > } > - if (page) > - set_page_refcounted(page); > > trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype); > kmsan_alloc_page(page, order, alloc_gfp); > > return page; > } > +EXPORT_SYMBOL(__alloc_frozen_pages_noprof); Since there's no user, we should't export. If a user appears (I can imagine e.g. KVM), it should be EXPORT_SYMBOL_GPL(). As should have been the rest of symbols here, but oh well. > + > +struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > + int preferred_nid, nodemask_t *nodemask) > +{ > + struct page *page; > + > + page = __alloc_frozen_pages_noprof(gfp, order, preferred_nid, nodemask); > + if (page) > + set_page_refcounted(page); > + return page; > +} > EXPORT_SYMBOL(__alloc_pages_noprof); > > struct folio *__folio_alloc_noprof(gfp_t gfp, unsigned int order, int preferred_nid,