From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EA0C61DA4 for ; Tue, 14 Feb 2023 15:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F66E6B0075; Tue, 14 Feb 2023 10:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A65B6B0078; Tue, 14 Feb 2023 10:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 295BA6B007B; Tue, 14 Feb 2023 10:36:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1AAA26B0075 for ; Tue, 14 Feb 2023 10:36:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B27E7120EA0 for ; Tue, 14 Feb 2023 15:36:34 +0000 (UTC) X-FDA: 80466299508.10.4A0E228 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf19.hostedemail.com (Postfix) with ESMTP id 932151A0023 for ; Tue, 14 Feb 2023 15:36:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=3CwmEVnF; spf=pass (imf19.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.45 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676388992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y0T2UJE2bMCBLwJStDfFX+eI9IUgxEljeFPQRg6MREQ=; b=HZf50/KSzMkjKHcDM0hxw7341N/YP2b8C9bxVXzCqZnMQw6gkNFFrSnTQYwBiOiPFE84gj odrHwAu4dtyS9pGmMfUxkdKhKQNYP3WNBaI9u/WVotpXh9wP/jjlPHPS2LpCH/CNFjoRKP LPgy6isBV3TbS7Z0un1/aFkN7CqsjGI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=3CwmEVnF; spf=pass (imf19.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.45 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676388992; a=rsa-sha256; cv=none; b=xwK3HeDWQNGOLqXwnzy/s7PTe23kIsnjDg1TsdboxOgiIbz+ZtrN1vpn+sK0HRBIU8pYJM GKeTJIYSAiIB+8OzPp4V/YJHap0HsivmJmDtg4EiyMAEkBfmwfGoMe6l4J+bj/qerxsMSO aQVdoBJ/py5ktjisRYePIJIF5Mfuyxw= Received: by mail-io1-f45.google.com with SMTP id 65so5985405iou.3 for ; Tue, 14 Feb 2023 07:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1676388991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y0T2UJE2bMCBLwJStDfFX+eI9IUgxEljeFPQRg6MREQ=; b=3CwmEVnFjLIj2M7AESv5Ufvhjj5LMYX0FPahCxQHOYCUcX921x3nAR9l6A+ke3073r nG3fPdc1R8o3Uzw4l1+NFLMJqtExZc+iH1FlLz7xemEFHu7HWQTwCuQs2HPN/1z7IpU6 1n6sjsIVDnb/L66aSmmOWhu3Z19HhWzhE/5DGgDdcJU+I6EbqxE4YZaAhqIibCpUW1Tl PrrrQrpJhKuO29MrCUVjLaw6taogwwofsySJfqFxUzeSc5uvn8FQY8O8waMf3pPGdejB 8vqb8X+ZX5YJd7rOhi2ZDMZVUClmIZ36jvehoVgGCM1U5Xh8KLi/W1yhsy16HSty/iJF 0FJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676388991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y0T2UJE2bMCBLwJStDfFX+eI9IUgxEljeFPQRg6MREQ=; b=SjYKNihmzcVg660SfEnhHXf9FIo2MeqhyRup2FifXfR/iNlLy644jeqj0ICIFkpA/p VwDg3MgPvRGv6IPJl4/60MvvSJabnK3vnqjAQ7fSFPnnkZS7p/6sjrjHdHPB1q6hhwPP IgrYjlFjnK+Wtk4fFNO6uUHIYwosjyyDx3Lervnp4PesuItPs1IGeNyXBKYgq2CWYH6u 2ylwP8WrzIrrITI+APy1AHKdRTfVWVG9BS45EeHQ4qgYtBGZVHb3v54eaStzoctVfJ6V IbjpLmVe9fZNfWG1EMsLyuu+cHzhfLnMBMxhzdera1J8lPTODlTg7JQily5KUnqGju79 R3nw== X-Gm-Message-State: AO0yUKW1q915rNI++a0FkuBaU95Y5XPzAJwDvti3VrFi6Sh0bRORfa6V cLQyWBJHJBwSpnvLjMKI8RpAcg== X-Google-Smtp-Source: AK7set+bvRjsHoUhyxFQhAxs5vunmvxeTg9ZtRFdfIR8WeD4EnyOp3kOo3s2n6ZojHpUHdTM2CUNOA== X-Received: by 2002:a5d:8183:0:b0:719:6a2:99d8 with SMTP id u3-20020a5d8183000000b0071906a299d8mr1741407ion.0.1676388991145; Tue, 14 Feb 2023 07:36:31 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id y74-20020a6bc84d000000b0073fd8ca79c6sm1515790iof.9.2023.02.14.07.36.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 07:36:30 -0800 (PST) Message-ID: <9dd98aed-0d9a-eb3e-790c-0dd744be8ccb@kernel.dk> Date: Tue, 14 Feb 2023 08:36:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 0/5] iov_iter: Adjust styling/location of new splice functions Content-Language: en-US To: David Hildenbrand , David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230214083710.2547248-1-dhowells@redhat.com> <75d74adc-7f18-d0df-e092-10bca4f05f2a@redhat.com> From: Jens Axboe In-Reply-To: <75d74adc-7f18-d0df-e092-10bca4f05f2a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 932151A0023 X-Stat-Signature: 13yhinpxehf5g9jzbyd5hzoh95ommfg9 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676388992-193469 X-HE-Meta: U2FsdGVkX19ohfRPSM8Z0wGBsk5d4lJ3J5Kvch8TQ8oTBxCFGF3HglchLrLHOakHMJuYbPfymU9uyPHC8dH+v/3ZRcFzzCYP/D2Ui2iprFyq/eIzjHN9mtlzTe8HKwHtDCkFKWF4RZhzvimXC3S+yIw6tMXE4ajLAXsESEVaKDdJZRFnpe145WW7lmwa1eHzHH6NZKiwUuBuRv+k/fpwicyoGtinBeDaMHhOX0PGIvvw6I2iEefxIlCt9syEJ0e/k3JZWqADQkzHQoymuv669/dlxY0KZPyS1qmJXElJt0Mg1HZ+hpbYRMc46ChsZt3tVcw0zvQD+leTKq7mryhg/vTuCllmcd856+Z9Ge+C90NKQgmdXeFAc0LDK2mo//zxCHtqVK7ljY25/zCrQ+FzDTMPl4Rc8NsRJOObK7iXVE5/YsDY7mng+KGBtVhxIqAm9QaEy3vPSF7XEVhycZmi0kI/Bvf1C8ce0Z8I9VcJSuqwSFKFKvO07OyonpQAVmPT0u0WJ0UDTyWNbh3TD+uPR7m5ZaiCvnJ2R81mDIbOFAhKX/x9pr4imixbNLh2pW3mZL5C9OHT0MAE7vx00SeQ+lbrCm5QM34DAMYI35+3Y9DUFP9+pizjQwa+adsM9Gj0AQ2W6tSJgSpLQfHg73AZbs52frc2wtzsEvJA/8euKGLq2EPxxU2EuUdbtZPHu4b2l6/33jT3GIkXU5XDMX1nwJmbMVbRq6Wd8xgLCarv/eN9dX8Vp/l2nM5JGMGXsy3fMi4mor0zTszbqpku1zKRzIPN+Zc3QLhwg838wZL0OQZDZIx54qhf2wyAqKVhlJ9Be5zQFRSg9l9lG31s+bK/yYOidQTAhE4u5QWi/tKyE0TPaUct1cP3OwBBSBSOljdzDkrPaoWFXZ28RHYbNJ3S1MhjDq3n+VHliFvH/+UkRvPwXD8s99Rq3ZNgHObIJ1CgWrfsRcG5jEwwRRMZxyR 8RYIOzV5 BtLCT9UAjBzo++KgL9wIl3OEBN1PnpMnDHOPd7O/lfSoY//X6ogmijYCjZKDVLwXhudcLhVK1Aq+FzFqSn9brouyOVBtEQpDLj4WSMYuVcImj8qncFle0v8k/4J57pVlhc/i02krmMbHcEkhtSsrw3NbKpC14Bjl5fwhi0Mp7U/V8PfnPnC5jYnvaj5bRQP1egVhgKg95Z1/TP51k62LFmEaziW4vSgoMuCUq7GrpEdWnNZxIaXSBdeUEfAzFaCGKE4t9QUxWmJ1UKwCpUcbQGYrjOJg29mPU10t/5RtypeQsUKoBf5BPC5YMPXf3dQBlauY38Bir8VDTS93OfO8eEqFor661ZO1XFsUEiVlJcFbjFX7j3YkYMrcN4OrA3czkkVI0MBYWlEvxVcCT1KKJow2Hw37zSgo7awWmHNhMCDHtEfTnJKmu5nO4Vb4SWoTi/f/9dEaPfuiNUJCO9jY4PWlbhwlUZoSVVo/ZO0aINZ13TJ8vLHN4U4B5ogScN3TAHq6vGdCgNLm6XmtmR0zvZNcNTWsJh6bFi5awAoBnW1iPXVzWAXOJ5qWKrJ6BVYiKxS+F4ttupYxSIVO03oYmy7sPvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/14/23 2:07?AM, David Hildenbrand wrote: > On 14.02.23 09:37, David Howells wrote: >> Hi Jens, Al, Christoph, >> >> Here are patches to make some changes that Christoph requested[1] to the >> new generic file splice functions that I implemented[2]. Apart from one >> functional change, they just altering the styling and move one of the >> functions to a different file: >> >> (1) Rename the main functions: >> >> generic_file_buffered_splice_read() -> filemap_splice_read() >> generic_file_direct_splice_read() -> direct_splice_read() >> >> (2) Abstract out the calculation of the location of the head pipe buffer >> into a helper function in linux/pipe_fs_i.h. >> >> (3) Use init_sync_kiocb() in filemap_splice_read(). >> >> This is where the functional change is. Some kiocb fields are then >> filled in where they were set to 0 before, including setting ki_flags >> from f_iocb_flags. >> >> (4) Move filemap_splice_read() to mm/filemap.c. filemap_get_pages() can >> then be made static again. >> >> (5) Fix splice-read for a number of filesystems that don't provide a >> ->read_folio() op and for which filemap_get_pages() cannot be used. >> >> I've pushed the patches here also: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract-3 >> >> I've also updated worked the changes into the commits on my iov-extract >> branch if that would be preferable, though that means Jens would need to >> update his for-6.3/iov-extract again. >> >> David >> >> Link: https://lore.kernel.org/r/Y+n0n2UE8BQa/OwW@infradead.org/ [1] >> Link: https://lore.kernel.org/r/20230207171305.3716974-1-dhowells@redhat.com/ [2] >> >> Changes >> ======= >> ver #3) >> - Fix filesystems/drivers that don't have ->read_folio(). >> >> ver #2) >> - Don't attempt to filter IOCB_* flags in filemap_splice_read(). >> >> Link: https://lore.kernel.org/r/20230213134619.2198965-1-dhowells@redhat.com/ # v1 >> > > You ignored my RB's :( > > .. but unrelated, what's the plan with this now? As Jens mentioned, it > might be better to wait for 6.4 for the full series, in which case > folding this series into the other series would be better. That is indeed the question, and unanswered so far... Let's turn it into one clean series, and get it stuffed into for-next and most likely target 6.4 for inclusion at this point. -- Jens Axboe