From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEF1ECAAA1 for ; Fri, 9 Sep 2022 11:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A425A8D0005; Fri, 9 Sep 2022 07:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F2178D0002; Fri, 9 Sep 2022 07:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA608D0005; Fri, 9 Sep 2022 07:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7F8368D0002 for ; Fri, 9 Sep 2022 07:25:33 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 38DB5412D2 for ; Fri, 9 Sep 2022 11:25:33 +0000 (UTC) X-FDA: 79892316546.06.64B1752 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 3A79C20095 for ; Fri, 9 Sep 2022 11:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662722731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lett+OMh9RV2ImeP8GLziHw5ig15HxWDOKscDnHXwoc=; b=X6/TS731TRSFazh1i0dG6waaiKMP+VvGnvT11FgnWR1gBffNuj/5JMT/eojLhk7DAJO/dA 2jOSFVw72ZHCQUaJgw/as2cQzX+B5By5yxvVg7/NjDUmz75/Ga6DgODKYJb3TF+CAXJaY6 idHJkON6go2GZgC5eDLayH2CwZQBADI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-652-VFLvk7GANT6uZ3CQnBRB8w-1; Fri, 09 Sep 2022 07:25:28 -0400 X-MC-Unique: VFLvk7GANT6uZ3CQnBRB8w-1 Received: by mail-wm1-f71.google.com with SMTP id r186-20020a1c44c3000000b003b3309435a9so1915040wma.6 for ; Fri, 09 Sep 2022 04:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=lett+OMh9RV2ImeP8GLziHw5ig15HxWDOKscDnHXwoc=; b=JUPr9zZGGHq7a6FEw0/RMLXzl3jrj4tjXAs/ZZuriVzEzuqb4SUVFzkvWcM7m+SWIw vA0qmrIS5SAYsPbQVDPNR9HrpKEG5gyFd6q93bu05StwDCwV+dGyv1zyFEr5aZhTv9u0 4lI2227do5wcKl45RGVGHALbMRyTZzjH7OT+2Y+ba78wsD8rKmsvh6hQEdwZVCwshOSM t5pR11nmKeRrA/RjVT3QryA99VOFx8r8vOyE7Z5+fD7kE/hvEISJKl0K83ToUlH6B3fZ bqKUiXm5W4iDSYDCqX+a8m8I5SripX2D902ZSmTEvXov/zXHizGgw5vYTZygyQtLA74C WPSw== X-Gm-Message-State: ACgBeo2+qi31yfq+BSpLC43bpEQcCExp6u2nLViyXP3ha/GcVZtLQeus j8MY6iFt7aoYzdYGQ+R/le00hecYcgu6Yb/DD2RKwWf8B7pf51WoKz3illjcbsLe1pOSss/K8Tq qn7szA76XlE0= X-Received: by 2002:a05:600c:444b:b0:3a6:6b99:2394 with SMTP id v11-20020a05600c444b00b003a66b992394mr5166891wmn.43.1662722727159; Fri, 09 Sep 2022 04:25:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR66u6H/yD0rqeGiYuHOB58QLfDGBxLi234XgcQ0LqmW2zAEVWwvc8Gqn72NSpnBcMkSL9VSYQ== X-Received: by 2002:a05:600c:444b:b0:3a6:6b99:2394 with SMTP id v11-20020a05600c444b00b003a66b992394mr5166877wmn.43.1662722726919; Fri, 09 Sep 2022 04:25:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id m6-20020a5d6a06000000b0021badf3cb26sm342953wru.63.2022.09.09.04.25.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:25:26 -0700 (PDT) Message-ID: <9dd94b86-4fc6-a636-9a4e-bddc77225644@redhat.com> Date: Fri, 9 Sep 2022 13:25:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 16/16] mm/page_alloc: fix obsolete comment in deferred_pfn_valid() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-17-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-17-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662722732; a=rsa-sha256; cv=none; b=4gvPZVB4sFA6KKMqgumSivDWcUEHqGbKtKWPZVAqmkbUdHpTNUyXmgxYGwZ2a5PmvoFuqr KV8pBl5/QkD3MC2gRUH7ikhZK88dPOH9Y2EVP3+1K7KAq2jggRC2Rskh9nqDWujvikTAQl 9t+d09hGzzDzH8VyxHNgHwbd1mVtw+g= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="X6/TS731"; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662722732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lett+OMh9RV2ImeP8GLziHw5ig15HxWDOKscDnHXwoc=; b=CWgZgjLg3gTtQQKO0fK+GZwHA46lvtCpqZIivnZf64v8bzmfwgP3aHZ9n4MpbJ+NnXwtAn +gA5gZPWv163PcCWbPrgvj6WydIsG6vH8t+7cAeV80Jub324apRK6PCU4XjYNeNCE5ZQJv gvxB0ShHiSln17/zxmIVvlbOsTaB0P4= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="X6/TS731"; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 1mw5kxiggwhbs4c5xmyzczhajkakqn1w X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3A79C20095 X-HE-Tag: 1662722732-581352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > There are no architectures that can have holes in the memory map within > a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() > and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 262e8972e019..4cc0232020d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) > /* > * Returns true if page needs to be initialized or freed to buddy allocator. > * > - * First we check if pfn is valid on architectures where it is possible to have > - * holes within pageblock_nr_pages. On systems where it is not possible, this > - * function is optimized out. > - * > - * Then, we check if a current large page is valid by only checking the validity > + * We check if a current large page is valid by only checking the validity > * of the head pfn. > */ > static inline bool __init deferred_pfn_valid(unsigned long pfn) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb