From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD6ECF8853 for ; Fri, 4 Oct 2024 17:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0E36B040C; Fri, 4 Oct 2024 13:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7636C6B040D; Fri, 4 Oct 2024 13:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58AFF6B040F; Fri, 4 Oct 2024 13:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3663F6B040C for ; Fri, 4 Oct 2024 13:20:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C1D53120A32 for ; Fri, 4 Oct 2024 17:20:17 +0000 (UTC) X-FDA: 82636583274.18.A568814 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 50C752000B for ; Fri, 4 Oct 2024 17:20:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=F+8SeIKo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gcnH3Qed; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1728062308; a=rsa-sha256; cv=pass; b=lIdCf1EUvvFkvxM90LWtxHkAXIWXPVaTUqUZMw2iIthHM8lQ0qqxFLGWk1Q94Zsc4MSnQh qn/wDQGBYt0spLr0gIK6eXVVgRliST2K8gscjW0Z4OPxbsn7UuFPdByxI6R6D9TgQ30DK5 i3DT2pOS3QcPbdtqOFSSJRMLcKJsioQ= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=F+8SeIKo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gcnH3Qed; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728062308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tUD8/mlXkmORSfZYl5pYs09ctmXW2ddGgcq9+nvtro=; b=yFtg+Ask1dDfzSPmtwGuIJO5aFOpS/4z1lr1/xVSqxh1bvmC+ormCU78D7uJNKXdP+gXc8 kdcZOAQPwj6szz9GdOGBZvWVRPpwdAUH9M+5w/r4TrGG305zNizOjubrIJ8hDZGGF5/luP tR5b4/BX3KOAibBMK/MwpAQuSRj6Uy0= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 494GfaUt012656; Fri, 4 Oct 2024 17:20:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=9tUD8/mlXkmORSfZYl5pYs09ctmXW2ddGgcq9+nvtro=; b= F+8SeIKoi5MS9qkIOvTN6mnip3z4baEy/0h/9pf2JmkXAEnRqm97+1nPS6m9y70H 25DV4SjFSTHWVY+Ki/UETizmFqw0Se8cqO9SZ0J0KDfd13U5U91KqM9CGu7V7MjU w+mVV9+ZZjNVrUAQ9LEtZpM9hDprXwkDswE0J4q64nWfUQ+FtyhsGyruR/glJlb+ O4ZTbE4rduT3JNqqpbzPxG+0lAapzaPREmw/GNlS8Gms5FmSJup/JBKXjNrGK//V rhnv2YZ+AT3LAQSzdAYYJc7eL+YA0OInLz5cDnyrmsigD/U+8M1YnLDSqoCfiqpJ jVtHi0nb2mIFySTncwcnmw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42206m22bb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Oct 2024 17:20:07 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 494H7IgO005957; Fri, 4 Oct 2024 17:20:07 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 422056tyfc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Oct 2024 17:20:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pbDCAs7KC5n+LzK8x+pxYiUG50ZptG156rLiprHn5EN5TldHRh/Iw7dbPOG54F+3lrewp9dKFyHB0kxSvzENTeYyxpcaxM+PsLy0exTLr7dq/MGb2JcsZAt5sMGEaLJu5iS3WqUflv9h4RoxH9ouDBZ6ZBD7RnaQkovJdG01IEWA4liR9dPLtYUWbt+zirI6YFs3IxUYxUZMkwX3FAn7NWnn9/+/lrXxGHyJ/QjM33CsLtJqrjTF85SOyEFNH1t6diJQBDdzAEg9oT2OS/P+V9bkIfOS4cMzN8lGMM59iuYTf3RqjP4d8UxCwTwggmQK6bDxSeHbuYO2NpcY6YGZJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9tUD8/mlXkmORSfZYl5pYs09ctmXW2ddGgcq9+nvtro=; b=UlGHee94ivdi5lB/JVomDkIpQE5hHeAhlxwKTMPHEVAF6TkDN+Q2SrmsuF1vNUKgDyaN82o2i8M+6Q83EsBPtMDHSmdpsdpgs8fg5ElHLv63gA5EWtTpyG4LytCf2w1WPKlvTRk5ZRduCh1tpw2BDgk5rNvr0AtHQlsW/8m/MvlIZGGgLdhcf8abM8kvznbNqStXONzdzntha59d0eyvD/aWknq98ybkUXizL+9P/rSlB6hPgCuo0G3AjY8ilCtiUwDH8xGlDkunKAOMfgQa5C3lqgzRz2LzJ3Fd8wlrsu8Y+aS285IXc/O4mjr4jaBgZ6rULt67Zf/ytrOfY29BLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9tUD8/mlXkmORSfZYl5pYs09ctmXW2ddGgcq9+nvtro=; b=gcnH3QedbDHpGpA/nfLTA3+kVsdvt/crdOIo/39Cj+WDNe4WUyRgV10T0YZ6VwiUHPofXTfYCG97i0nyz7PtY1jRSTHYdoh/Wc4Zo56PMrX2ch1msWk60AoztVrGoa2rQgXlmSj+Dz9Cgt5Rb2W2srP6bmMuz5iHvNiPd7HFVic= Received: from IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) by PH0PR10MB5707.namprd10.prod.outlook.com (2603:10b6:510:149::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Fri, 4 Oct 2024 17:20:04 +0000 Received: from IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572]) by IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572%7]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 17:20:04 +0000 Message-ID: <9dc54dbf-18b3-43f9-af4f-39ce44406ebe@oracle.com> Date: Fri, 4 Oct 2024 13:20:00 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/gup: folio_split_user_page_pin To: David Hildenbrand , Jason Gunthorpe Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox References: <1727190332-385657-1-git-send-email-steven.sistare@oracle.com> <982f3e26-c998-4e72-b374-3f31bf0ca9f5@redhat.com> <20240927155848.GD4568@nvidia.com> <210cb725-fdc5-4878-9e6b-4357d34afb9f@redhat.com> Content-Language: en-US From: Steven Sistare Organization: Oracle Corporation In-Reply-To: <210cb725-fdc5-4878-9e6b-4357d34afb9f@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN9PR03CA0505.namprd03.prod.outlook.com (2603:10b6:408:130::30) To IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR10MB7447:EE_|PH0PR10MB5707:EE_ X-MS-Office365-Filtering-Correlation-Id: 9691cbe2-1b7a-4b24-803e-08dce498c910 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NCt2elRNSllEQUVsd3ptNFFnZlFNM1ZBTzJPTllnUmhTVlRadHhTdmx4cnpv?= =?utf-8?B?TFFrdXBCUXpyN0Q0YXV2Snp0QU1XZjgwV3A2dS84QnpKaXdKNi9rZTYyTHY1?= =?utf-8?B?VXkvbzNaTVdXSm95bU05K2IxeTZIRGhac3YvVGlzNXliU2lhS1JhVXBhQ01r?= =?utf-8?B?aThpS0NEOElRQ1Q4Rlk4ZlJ6dUpZV2FnUStLU3dZY2Z0emNlVGFrb0pBNW1S?= =?utf-8?B?UXZ4VVNoMktaYjhCMHdVeHluVkpsdUJCR3lZazAwa2NkT0puTUV1aWliNW0y?= =?utf-8?B?YU9FMHA0ejZKNkFXMm1jQWtxUTZtbWgyZzFVZjMvbEdWSFdKL2M3T200bUQv?= =?utf-8?B?MTAySXB2UFp6ektPRXBRb05rZE90S09KdmRDb2h1RzNMWFZoTmdHdm83QVNo?= =?utf-8?B?WHY4UWVrUU56T3pzQ3lLRHFtNUJoUTkzcmlGNzNleWRVVTBmdjVjczhEUFZm?= =?utf-8?B?VXpWLzZrbXg0T3VxS1NsbW9PbUtsZnZtaXpwUDBIU3BPR256UUh0SlN4MXdU?= =?utf-8?B?WkRlSDBKUDRVcTNrdmNsMEFkK0x2RVBsVXVQSjNVKzJvKzFVOGFYeGFDRjJr?= =?utf-8?B?T3dxSkVJSkJLcXNpeFFOTldGa1NpUDNLM0RkNGx2QWlMQUtkQWtxUjVNckU5?= =?utf-8?B?TFZsSXlMY1lVa3FZRDNhaEhIZHNMaDd3QVRvZWxidjJtdDlOQ05NSzNpZUlv?= =?utf-8?B?cWxodGppcFkxbG5vcGhXZC9nTDRuTVdIY0xHN3dRVkdjV1ZiYWhVcTRtT0FF?= =?utf-8?B?dTRPOWQ3WXhDMy9TdTg4WHZqRkZxVDdTOEk3YVp1djkxMzlpT1pmVnBuTnFE?= =?utf-8?B?VFEvRy9ESGVIOExjTUIyam1VSEg5VVFCb2toTVJXUVFPNU0vTitGeGVIbFpR?= =?utf-8?B?a3FuMmtadzQ2WDdUdjBZRWJPVm1hTjBmZlY1Vlo4NkY3UHg1OWhENU5rSDhH?= =?utf-8?B?eWhrUmFUS0lnSlJtWklDaEdGd2VHQnBBblRwWXFjeW5LMkZXWDY4RDcyOFBo?= =?utf-8?B?SU9hdjV4Y1hOOXNoZ2Fvai9Zc1NZaGJhZHhQcEU5NXcxUEFDdlZ0U2k2TC9N?= =?utf-8?B?QjdhMFVhMkptbHpneVd6SldtS1UzY1d3cXgvemRYNTdkdjNzb051RjVDcEFL?= =?utf-8?B?ZmtLd2JGY2J3QjV4YVNWaG1BdVNWNTRWdFVreUtlcm1UZnl2UkdqUkFkajNP?= =?utf-8?B?cUxNS004dVRldDIvaS9jWFNYcW9aRlNBcUlHZXJxWThuWWI3dnE0Vi9GSkt0?= =?utf-8?B?TkRJaG1ncGxvUlZybUxCYThXcG1SaGtqUThOUmliM0tKbDZNa2FjNGROS2di?= =?utf-8?B?TW16bCtVamRCbDFHS3phMm00NzloZ2VocU1rYXorLzZWVlYyL1FuZGVqSlh6?= =?utf-8?B?RW5QMlNUem5QUnZKdERpK2JHK1FVODJKTDJuZXVzdURoNFlaTi9uT2dUaVpG?= =?utf-8?B?ZFFPVUxCQjJzTy9zNEI0VHpDbmMyTHlKWUtIN05DemtZUVFIOGRhd2I1R2NF?= =?utf-8?B?QmR6WnZpTUJwbHd1ZG9sdU5PeWhKOXM4NHd4bk5kclRpalJUV2p4UGlpaDdY?= =?utf-8?B?N3BjVlpDNnZvb3lLSkh4Ynd4ejd5VkZQNGV0b2hSSTRKRExQa2RoWFIwMmd1?= =?utf-8?B?eG9aTzg2NU9aTUdNdmZPbi9EeFZNQUt1THBNUzZpTjZQUEw1cUJEUWFabmVI?= =?utf-8?B?ekM4NjNMQ1ZXQ0FWQmV4cG1XOVZEWThLdVpkWUljcXpweHhPTWwwaG13PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR10MB7447.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm5EYXpET3FvY3RvMHgrUElVbFdsaVZIRzZJalVRY0JWVXIrc0ZHREtFcU5x?= =?utf-8?B?RmdNd3pQRi9VVWY4S01yUWJsN0p1aEp0TTBmc2o2MTVVSGpKWkJ4OFdHa2Fk?= =?utf-8?B?ZmloRklwYWxqaEdqTVlNcnljaWdCa1d1UUlCcFdVWFRqeUkrYmVpOWM2NVBp?= =?utf-8?B?Q1hDYUo0MFRac0F0RnVDdDF3TXRsMzFpWmtndG5TL090UEdYTlBLNW5jcmhz?= =?utf-8?B?cHJtSjJneitvZHU5U2Fpa2pPTU1pSWRVbTlpNmxhWit5OWxCeW55M1FCeDBJ?= =?utf-8?B?ejFtNlEyci96aTBRR040SkJaNnN6SUpRMkIxK25jMzZ1NU5vUWVRMEJ5VGVh?= =?utf-8?B?S2ZqcHRobW9yMWJab21FSEFmSk1OQTNXVmh0bjdWWld4L01KTUdYYTB6Tm5h?= =?utf-8?B?UHlkc1RiK2tFc2svaWdxVlU2Y085SjRCSEtEenpFdjg2b1pxdWo4aFZyTTdL?= =?utf-8?B?VGZJU1ZKRFZNT25tYThnSXU5RmozWHN5SC9IVzlDNkxWYUlUWlhuTXMxdTFx?= =?utf-8?B?NVNYbUQrM21ld2JvRXBOMTAzOXVHWHRHWDNjUmhjQ0hDdUJQMkJVS0dKL0hU?= =?utf-8?B?dk1KNjJ3ZVNCaGIzWERuU3BZMHhiY3kwWVE3SEFVTThHNExoV1pNdVFqdk5D?= =?utf-8?B?M3pqUi9OZms0ckJYcUQrTW9SWXE4Q1gvY3F5ZjY3UEJubU1POW1qUFpUR0tr?= =?utf-8?B?R1l6NVdEVUEyclRITFpHRHJodWZ6c2IxSVMrNmxnQzE4S0E1OUNsS1ptUURi?= =?utf-8?B?cEc4U3l2VGExY3NOVnlDS0lMUnYwTkwxajlSQ3NwQ3VjQzB6SzFlQVhnV255?= =?utf-8?B?TjF5NjZDYVRSUXhIUklOM0hWeWxXY2tnZmhTN3ovdjJDRWthbXFNaERYNmVi?= =?utf-8?B?SWIrd205a2Q3b3IzenViaHZKY3VubkJZQ09aREEwWUsrdktieWFEZmZYU01x?= =?utf-8?B?TG5OOUhSbzRyUnJ5anBTaFNMYjdJZzBnM1ZUZ1BqWXREU2JlRDRHMDRIaU9R?= =?utf-8?B?WUE1RDgwZlU1RWpMVnB1cTJyRUJHOGNWREFId3Z5VlUvb0Z4TzlXN0RFMGZw?= =?utf-8?B?S0tlYXFLenFhbHhVMjM1Q3dFQjlqbEI0Y1F4cGxzcmhhUnd0ZC80OEVMcnIz?= =?utf-8?B?NFprKzNyRU1VaGtnR1JyWnM5blo4cVVkNVFMTWhSTlc1aDZIYmt6TVR0d2h4?= =?utf-8?B?THdIWkg1cDNMWXlOZGloeGtnRWw5ZTFiQUFNOUVjUFBOUGM4RXdFNDZFekcz?= =?utf-8?B?RTlXSStSb3kwSkhRaFZqcFExSUNsNUpEUERNYzVKUGh5a3JCdDJaSTQ2WGhn?= =?utf-8?B?WGM2UWEwR0dyQ3VmY2x5c3VxRUhCVUFoUE1vWTB6VlhmN3dhdFhsSG9LUkEy?= =?utf-8?B?bTBMSXFzeHkvNTRzenJHaEVCbWxObUxEL1V5WmptdjlRTzdPOEE3bDVvL2VX?= =?utf-8?B?SFlMdURUenJwRTc4T2EySThLOVM3bDRCSVRVeHFKWG5CZGd1QlE3Yit0eitJ?= =?utf-8?B?Y0tsZmNER3pSU1o0QkYrdWZhcENsMEFzWU9VWVNBTk9VdzB4MkFjd2NpcEh3?= =?utf-8?B?NDVybStDdm54bzRQUjdWOXlEdTQxUytweDUyekdDZ1VHOHdYc1hoT0JDMkV3?= =?utf-8?B?RVpWbnhGWmszTjBGOUdiNmNRa3E1d0ZvRytZVEI1VVMwKzFCaUhYc2JyNmE1?= =?utf-8?B?ZmhwV1BSL2lNalpJbkNES0U4Nk1SWnp3a0Y5azAzTVJlWml4czNYckFQQmZp?= =?utf-8?B?VVEwK0ExazgxOUdCTmRwYTQ5K0VpbURHSUZmVWFLUVo0T3IzcHY5N2R2cXJH?= =?utf-8?B?RTZVUVB0VjdJUElzYnBwMExaU255Q3JjdzBQM0pyUEszekdwdURmVjZBOVpU?= =?utf-8?B?L2RNaFBNN0NuVVh1UHp6YW1YaEhUNldBb3hQNUViL25PS1daTThmRjN1NXkx?= =?utf-8?B?WUJ2M0NyMDZJZEFRQjg1SndPaGpNUjVuaitzRXhoKzNKM08wc3NCZndXYWJK?= =?utf-8?B?dWg1NE5XMmpkSEEveGNxYWRqVFhvOVNCTi80K2Qyc2hMaHM3blFIY21RR0pq?= =?utf-8?B?dW1udUsyL2pHVlRBcXA3Z285T094N0xyVk1wYnZkNXc5VUgvM01NSllOWFVD?= =?utf-8?B?blNpSm5kMmFVaUhmVnB1RnplRk1YVlBGcDNycWxURUdOWnZyclZ2SElnZk5i?= =?utf-8?B?cVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /iNj15oNrFKKqFZj019J2Y9KL09hJ6RH0fX8cg0bc3kEe+JJ5MybRy/Mho6+Zh0u0zAJxrtYN9GB74S83TiigrWLoCQE4o8HGUioVx544VBYIMQMXf9plASk4e21qZPU+cpS1y/K2UP37haAZrPevgtq5v4PlV9bL90C1ziDQaI07Hhz8ssmxDneGzh4NyP+OstfJYQqIUSrkgFa5k1w3zujE8KFRCLxTdSTFTNw3X9ZDyp6JlcHjmesSpuCrtqgjwdDrf0GY9HR7eHvp8EbgG5S8kXYypWQEILdURdzJfs5AzIowBc2yGfuUFu/Df46YGlQK0j9QIJpSsxkowTpD81LKj8QJqx4Gsm4D8gxmBCPvDW6OGAy5X558GmDBgXdJW+9wzG/6LOmK0pbOmdwN2FlmxPAGKHhTka9NchP/Kwww5bqsHTjGB3chYUfYrKnbF2jLfJ1N2gmmGJ+gQUlllc8gx6ncYfFbC8tS7a9IPt8oqX9SF+0myFO2WngxmEV/7mVrZxexo66EZGjhoN2omfWlm2tMxMo6eGIjv0SWzDmLuPmqZgeR7Hl/BSq45b3qTB2pgqFgA1rEdThsLzNrnB1IU92tVU7bEyVx67PB8U= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9691cbe2-1b7a-4b24-803e-08dce498c910 X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7447.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 17:20:04.0934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZXO0y+9/gu/cpMnyQSQcagxZ3FkVz2ZWVm3wIIcnj15Z5tLiEDty+I30Dtxfzc5alz22DI1fLnQ0rDBXosl4X6VVP/ak5mYtKocC5pZmE1Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5707 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-04_14,2024-10-04_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410040118 X-Proofpoint-GUID: okSc0Gr0uQVK6hi8uzSGNGrPFF1ryX6i X-Proofpoint-ORIG-GUID: okSc0Gr0uQVK6hi8uzSGNGrPFF1ryX6i X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 50C752000B X-Stat-Signature: ge5x9jwiunkh7p38xc14goszqzfmbs1o X-Rspam-User: X-HE-Tag: 1728062414-215778 X-HE-Meta: U2FsdGVkX18gQ/U68FKtr5yX4KIxrgffaYix9WFIjWgTkLEb81b11unZcgbV4FD3JwKnCwL+Bb6h/zvWVbUsnBSwVt1o//aFuEzCJbJRXMGBdNq4mPv3WIjsN+UoFvgsxJ0Gdo+iQhr8VycYBUguOazLKhqDZ7dRVCu5W4K7P4i/8MUnEJJvRyJ4FZuaNUQOo6XBR9Kc+ngiVW2WZEr0JAuYc/T1UYW/cjobBB3203Mkgd5kznGv82wPU98NgyHrMKndlcQFcNZo/uO8wmacRiTdSjJIF+yHsdtOzEyLpqig4wLYE7UgYv8N5oInMqayBZbPjyA0QdcWGmduc4b3olwv17Gp6SLOdNV9WUR4iB/z3kKQ5B0HFBmaUBe1TI4zU4AiOeEyuBLrZW5I7jLT61oYRdIVxqMnxMb0QYng+UGm90MXOAIdrynM0wNNuAqpnJcWiJHdgbhIZXFyZOq4gg00phW5wNryI0CNAMKw7Mp0RybPwX9lSyzBOPY+2DRqCHQFdDHYNL26aot7Q0R1WHzHiE1pIOVzrc/mIfjwxmw8+CtGLmsXnuNuYKol2YXWNJ/rnl3QLeazJz8ugZSqmVk3fXCns4t1dowa4kJa3kWDzpqRmIH8Mt9B7M6ctq0Uy/aSxtCIg7zRyZzl4Mc9t+AN2VUT/b6PchUg6w1Zu+5gBoIyFYuDSb1WZDg0Ov7/I4alJ8raRRyTIGoSwo9QncpTPA8ayiu0jkHurSpYS00uDJo3KbCsEEcXP11KWHq/aNvDgwZeUf0GLJOqXF+gN4A8MVsqkEvveMOSE+nQhXxwcmJWklcFVJYwe4M1IDd1v6dHwsc9QexYGzuVJRH0CAhPIBfEhfmWHc05TsulAiDzM/F0+DwEi1lbbBaGuUZFvi2DRoZWqslKyCZngfCEydJcmaoIDLsx1BYh7s6slWgzwcY6CQqgi/AeFV6cXOikgpyoHWMKP27FLxvfOTV MaccA2+r JjqiGqDl06Sf+CL9TsqWSwwRD8JCxWS8uRsjgafaGaaxcCe0JqfqBJNNBAiyiHC5pVxD/NV5ompJY6laK+83p5mH0Jf4B2lx0SN/7ZrvM+kwHzECplqgNa2O3sffJIMyL9egOuAxPgYQoBtInwXkgxtIGlXPpCWc8Y0IzfHkwn7F4c8Bpg1d02W0VhLk5w0o5Qqrjc0y9L5fPVQvMsj0xM7SgqNdjC220CpvL5Xs8kFCcGLsbDFPhQ5l31O68fo/luAEalesRl/ICm1drBysxIBv5818BpZ+19HszDVaWLFJgNnY9aqm/ZLVAQE75HXC+WUAMShhyFqWfUpdrblIRk6wp75cQclk9DTbPLMUNJM/fxPHlkR87TOEL3VxGqMG5g5lhsBDq0c5PK66FYInL7p9f56wuh+y+LQj5Lgr909sv+eOt8Uco5Rb9uCPwJwD2t0Nn4ZLK6Juk1TbtgfGN2tUTbUs+vyizTmCu0BShEI5HUo56sh9lfmziVgi9KU3pO3ppehjvdI1QjRlaJqH2zrNkCGRPrCcbqPujUZeqa31pHdBSyx3o01Ia5hVHtRfg63DAXMVVUgfOvgjYHtxGyrwYQAAPfPXpndfLCSsNQhyzU4tJax1mWG3RNs/SOW8YCvduFjZ4Wnbeskw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/4/2024 6:04 AM, David Hildenbrand wrote: > On 01.10.24 19:17, Steven Sistare wrote: >> On 9/27/2024 11:58 AM, Jason Gunthorpe wrote: >>> On Fri, Sep 27, 2024 at 05:44:52PM +0200, David Hildenbrand wrote: >>>> /** >>>>    * folio_try_add_pins() - add pins to an already-pinned folio >>>>    * @folio: the folio to add more pins to >>>>    * >>>>    * Try to add more pins to an already-pinned folio. The semantics >>>>    * of the pin (e.g., FOLL_WRITE) follow any existing pin and cannot >>>>    * be changed. >>>>    * >>>>    * This function is helpful when having obtained a pin on a large folio >>>>    * using memfd_pin_folios(), but wanting to logically unpin parts >>>>    * (e.g., individual pages) of the folio later, for example, using >>>>    * unpin_user_page_range_dirty_lock(). >>>>    * >>>>    * This is not the right interface to initially pin a folio. >>>>    */ >>>> int folio_try_add_pins(struct folio *folio, unsigned int pins) >>>> { >>>>     VM_WARN_ON_ONCE(!folio_maybe_dma_pinned(folio)); >>>> >>>>     return try_grab_folio(folio, pins, FOLL_PIN); >>>> } >>> >>> That looks pretty good to me too >> >> Looks good and passes my tests, I will add this version in V3 of the patch series. >> >> Are you sure you want "try" in the name folio_try_add_pins?  Usually try means >> that any failure is transient and a future call may succeed > > And now I took another look at the codebase and we already do have folio_add_pin() that adds a single pin, but continues on overflows (not sure I like that, but at least it can be caught and debugged). > > So yes, we could simply turn folio_add_pin() into a wrapper around a folio_add_pins() that adds multiple pins. > Looking at folio_add_pin() vs. try_grab_folio() I am not sure if the open-coding the logic in folio_add_pin() got the NR_FOLL_PIN_ACQUIRED accounting correct. To be clear, I am only suggesting that I use your folio_try_add_pins implementation, but rename it to folio_add_pins. And not touch the existing folio_add_pin. I am ready to send V3 of the iommu_ioas_map_file series, and I would like to add this patch back to the series as Jason requested. - Steve