From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165CCD17130 for ; Mon, 21 Oct 2024 20:31:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8226B0096; Mon, 21 Oct 2024 16:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9967C6B0098; Mon, 21 Oct 2024 16:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E9646B0099; Mon, 21 Oct 2024 16:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 59C956B0096 for ; Mon, 21 Oct 2024 16:31:19 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E5B89121AAD for ; Mon, 21 Oct 2024 20:31:04 +0000 (UTC) X-FDA: 82698753774.21.51FEE42 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf08.hostedemail.com (Postfix) with ESMTP id 5696E160017 for ; Mon, 21 Oct 2024 20:31:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=XIR8A0+T; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=y0fwFrUm; spf=pass (imf08.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729542625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cLiM/WEPt1Iivz8csBG2vArirZi39e06Mzwqd95+edk=; b=Zk+O5FmI5YgI0jAzrGuPVh9ExeygCX26Wh3038xNtRLwkbsVSjrbyTNbVyStsjwb7K6NDP hFERpCLevSOl8crvNIlJvVqT4dUIkgjKhCFcvSv9AuO1HPPKxKck2+5xiiI+aWIpv+1NDY 9L/mQyTyGJUyq69FdOr+Jdi4QrltXUc= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=XIR8A0+T; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=y0fwFrUm; spf=pass (imf08.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729542625; a=rsa-sha256; cv=pass; b=Bhoms2SUcafegjkFGhPn8zPkOUgV0Way+WbXG9HpZpruh8jlia+i7OclAqeYhISGwSdJFj XBUto0lUvNzKm6c2tGgWi4az397rveNrnBYrbC2WncdjpLsF6XPVh5wtNaV41y7D54H2AN vyX3mpsx3MGDftf2R3EX3Ne7p5A3KAo= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49LKBgrG023399; Mon, 21 Oct 2024 20:30:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=cLiM/WEPt1Iivz8csB G2vArirZi39e06Mzwqd95+edk=; b=XIR8A0+Tr2cZzX0NlWTxXUpZpX1aMoGilt bIi924iWlNXC1cxIx/ibTXfsfgN29gocGZrfJGSPBHwhWMJZn6rMRV56yPg4XsXD d+rnNTwzJpaVFFMYasCT0BhVMcUmw3MYst+HM8/ElVuBPoNrI3HKZStgjoLwmLqt UO5tuRhothyoBMTu3YBHd8FM+JrrZ8UtdLAWClknrGPwpv4zZZQRtGw5EnPF+3lg Etld9QruFzgW1pJjFVYapy2x/ouOVH5P2L3NEWdb8U5GjRnwlSHa/Su4zH1Fc3Tz 01Ff2lTXgOvk3aHieKDhsorSuPQJ+uDTfubDapEB7PPJdXpZE+Ow== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c55ec2c3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Oct 2024 20:30:54 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49LJVMJq012005; Mon, 21 Oct 2024 20:30:52 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42c376kpgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Oct 2024 20:30:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ruy0wMXJzcL0XODsEqNnkuqg18Y1JDrf2BitgA3RS44F2/Rs2e1+0UAVyOGT680tzIPjNI7SS7hzUD2Lqw45gRzb69mlkICxnVE1z+z/lPITCSlUC4IQXbQ/SNqjZToSg0UFSCV7C1E9gwBDk+ibaw76IafWn8a7K076iZpl6kNhDWV0Rn4ZSjn0tpfqY/nJVl7eR5hts9cSDTL5CcNjB0hWZaQJviTa4LlTPMUofeyB6qBV1er9gxQg/DWyma61gD79o65iiiAqHEENehSdUoc52+o5nNL3P9O4zQ313D9LK/lUH6RSJDG4NAWzRi14qImCg5dwwfWyLWRYGZPOHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cLiM/WEPt1Iivz8csBG2vArirZi39e06Mzwqd95+edk=; b=TGNfV5Zdx0kup9F4kuIA33n3r7ghvRkjKWT+SBCLLv7PNRXHQQR+tT5Q8dLvTHrUklWw4hanfQo07FhNVF3nxw6oBEXuVMnJxzXyGg47PoDfASUXzvFDOfuWlajrygZ0Wl3Q+JoSCG7tEsnSONgjpof3yOVKKSLjV6igVxC/FkvRi/j6WysoVOZy9sNVs7PqohRMdpv12pt0Y+XpSfEEHMQtBbVKVQ67Q5IkNxr9IVK4G44cIXJivrVCYjp7plqdLFzdjtbwciubfO8dsv9zkgQFOIfTou49Rf7OuAy/jlP/baH4upyiVlv0TlkaHJfFthh7Mf+Z1PnchWPdskRNVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLiM/WEPt1Iivz8csBG2vArirZi39e06Mzwqd95+edk=; b=y0fwFrUmDJLB4OvULhCzYuXYTBjyeDz0jfUa4SrqbRDuk5bReEEhr2uZ7ed9Zw3AUUX35QaFP4SkHKjgQ7lMqnIqBMFp5NxwSjAshVogh71j2l+tpzbjgR1atLeepTC40y5mnFRgx+ubra6dutxJWpV6cAydaqEkZdnkgqmjAcY= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DM4PR10MB5918.namprd10.prod.outlook.com (2603:10b6:8:ab::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Mon, 21 Oct 2024 20:30:49 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8069.024; Mon, 21 Oct 2024 20:30:49 +0000 Date: Mon, 21 Oct 2024 21:30:47 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: David Hildenbrand , Andrew Morton , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , "Paul E . McKenney" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Chris Zankel , Max Filippov , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, Shuah Khan , Christian Brauner , linux-kselftest@vger.kernel.org, Sidhartha Kumar , Jeff Xu , Christoph Hellwig , linux-api@vger.kernel.org, John Hubbard Subject: Re: [PATCH v2 3/5] mm: madvise: implement lightweight guard page mechanism Message-ID: <9dbf378f-5f5c-429c-bdb1-813ef3091881@lucifer.local> References: <6c282299-506f-45c9-9ddc-9ef4de582394@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0281.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::29) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DM4PR10MB5918:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aa4e5da-92b8-483e-9d5e-08dcf20f4016 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hAmz0dIwwRRHKRrmIEuDirQEuPnPYxjs9vlpOl/ab1BWQ5nEvvNaELiRAf0P?= =?us-ascii?Q?k6hdkaCJQXYzSPAOSV5mJTpEww7wu9EO58AiW/aLaVP/0G9/hrPfCATRKjwC?= =?us-ascii?Q?yrO6TUwZp0FDVhfwrU76FZNkuVVN9YkQX11bFbdEnG6jVIp9qXRqNsZ3N9Nn?= =?us-ascii?Q?hw9Pqi7C33XyO0u6RKyUd1Lev2NhH8Yn0HiVxIxBj3d73L3vKZdQmkjrBsUn?= =?us-ascii?Q?iwFxKHRX1+b5UMw5NXr7TPXhEIwqHlFFo49/jpZVMbeQPAnvr8ZZ4bTD2ffl?= =?us-ascii?Q?JrUUr9m751g7OPs0RPxk29IN5KMKEHM74xPDIPH+8RchUfdpqL0lYrOfXp1u?= =?us-ascii?Q?bKZNzR8llNPPmpQzFInn7C0piXUaV7mPLRfJiE5WMZhqXrsVnfFByPgWPlvt?= =?us-ascii?Q?w6CiEJpnVKQ3QDzJrvQ4KV8+KV+CJ1AVuE4+sOEXZnC0tN4SubMXWYxdCm/6?= =?us-ascii?Q?rB7rflDIokWb95sJTlExfJT7W8L7R7ClqysMV7XFtsRMUHNX9Ag/qX3ddnad?= =?us-ascii?Q?FbGzKh8IRI4fK+uOfdo5EDUHEcsW/Ko5+2WF7aVndC4zhfIQ4ujJMJ79SDv6?= =?us-ascii?Q?W+0JJMeam80DJnIG3ptEcQgUFBC4bg4D6Su/FGHwKObJgGHItaZKJj3RE7fT?= =?us-ascii?Q?SU7LXCt9Dxr+uyIn1wcyLsB8+6QP4JYq2a8ixbf/VBJ4aQ7t8aJCIulhmZwT?= =?us-ascii?Q?6hYxPwF8dEWDUQP5MsAU9s4TQeJSzfmGszpVvGFdh+V8jxx+kBlVQ5t7BL3i?= =?us-ascii?Q?XuYmKBC30c8RgjHLeOoJ5dnyJQJI+q1ZHiBy7e0mPgfuR+92NNC5O6YczJ9N?= =?us-ascii?Q?Ju3mFUgDq8bT1fxecuaN+tn3cLcMH0WfvAWgK+OwTeu5xvUGp9CMEguxYrLV?= =?us-ascii?Q?pfbOVsBIUHAPUYpTXKGa2ltsa0CC+CDaOJq5n8MUNJaQUwa1nJTWu4fs1TAY?= =?us-ascii?Q?R9UYVC+WeBrNIouTZZryltdPhXCI7s+cvUic1g4dP9nqYEv9f0wjrua1DHgJ?= =?us-ascii?Q?FZ/q5aXc/OgHlYQFzGnmYxoQB7cyXt5FrhntAJwmhrBxf3m6XcKUUqERJ1bz?= =?us-ascii?Q?ofGdu4jvWVF8Qj1BXe8kCdhNnh2V0Oz/id5BWnW1oA1oItUsDcKVoEN7LaEf?= =?us-ascii?Q?huCXdhajyV3s2u84ciD2R/1RuUlrwLr5tF6Ds5X9LtQJqUmR/bM48+m4aq3d?= =?us-ascii?Q?SBVeMnGzNXccrH/DJPOcjKNcudgSnNbK8ysNE8s4DQmejlI3zb/U3v1PswMn?= =?us-ascii?Q?4YbmWGkY7UpGM7adTQ5N1s2/qsefSfp+OuCF1eBJ9E0RFNpxtae7riuyn9Qo?= =?us-ascii?Q?Id4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vQMn1i9l+IoAmIQ0vnPOOU2f/pGVl6QT0o5saCMg/5s57Jj1XXxgKrZI01cy?= =?us-ascii?Q?ih5OgAg1AiYbzCfZJTgPBRtOJ4ztozK5VG/XQxGtwYJXVLp5pAg2v9ukY4UC?= =?us-ascii?Q?ZoKFm7SvjfLI0SIuitjmFj8yxZYUrjo6Nbl/YcEJ+vWJcLJrJExPXeekMm4m?= =?us-ascii?Q?ahsBVUAo/TW0vAG5oe9cniegk9z8BfgGgEq0V+bWg1xW40b2AXYaME3oMHyY?= =?us-ascii?Q?ZO0XzGu6V3DhEyGAN+RwbqD2KDGxnO8ECdePODRK1iBGWFh4/GuCSYCgAjTl?= =?us-ascii?Q?Pw//m2KLabFQ810M0ilZ8XEq23UASiAIFuf41M5N+LjrqRfuylr5Ud6G8bX0?= =?us-ascii?Q?+5NfA8xuIdsYVRvXc0j37HBCRnDnVPah9ejcaLR7R0YhEt+qqhXVrxjIZjAs?= =?us-ascii?Q?aOSH05nA+wFNxlwH5nIPUN7Jn4ETf1H89XvAD8N3dyKeUK0nOkwjRtWaGoDZ?= =?us-ascii?Q?h32sklaRFQanYd2C6fr+vcK6i30qE3CxUzDpDZ3Afq3EOR3EjxqHDGtCrC1+?= =?us-ascii?Q?ByfTi94ozXl3W7WlGeoPNQ4Ljt8ZC/XuFh8dWGIAN8Qqx64s0VqKSlMSj4DE?= =?us-ascii?Q?SxZCA/VJ7lvgkUAkuFvkgOUYjk5Y74vL4qF2y7KUwikIcHD3AAG/mXl51qA3?= =?us-ascii?Q?SrUkYiBLzPPGTBoofHamiJlohEio+DRItZXiJNVRuRsIWR6NkaOR2CC8g+Ev?= =?us-ascii?Q?YH1pfGVBQJF0qJdnvSnRUlcvSA+3BPXfOT9rv10ojMGTJ9qQt9QkBWz8bbzw?= =?us-ascii?Q?hFYUmeiFlyCtwcFrHeuAdpjkIw6Rjhs/UxY8nUGp4RIJ0dpLrl3BZ/y/Uehk?= =?us-ascii?Q?uvS7wa+lcQqoahAGqXMYOJeKvTU6+kvSut3JT1EAqPAaHMpNHKGbkB22av16?= =?us-ascii?Q?uH9M4NIQIAsaIJO5nmqbQ3l+Vst68AbnepW7wlijr/rV+pcbqaxjKdpiNSBt?= =?us-ascii?Q?j3n6l/9YcUIm6oDF9cAsyvbJqasDo3vnrqNbOQpRtmFS209bB6VcRJsJh8Zi?= =?us-ascii?Q?CGDM3w42ktZKJrXK0QRJB7zTBvQXvt1LUWtxsOR1VqXe5fCUo1zQU9joLl3x?= =?us-ascii?Q?ZwhFWclvEtb+IgTpUWG5szWMpKtgtMcRTJEGlT3O5DfisIstVaUfcZDOui55?= =?us-ascii?Q?IzgRUTwkjD+7cdPP3ynciv8DrSWlThdfpKTtimAS0o7gt/vRsEy11x+DDFOx?= =?us-ascii?Q?+7xHegrhTsh2O5K/WA8uIgQBFOEZ4LsWgT9QG2c8pqmVPR8ZPtoGb0yDbUwO?= =?us-ascii?Q?FUFGkWYrT48deIXSP7gddwzVPytKPjBemintGl6HoTq96H9BTizM2vb41aQv?= =?us-ascii?Q?xs1A10UmmU9PIdcR6N91IEg6ArRbVyRjSdeTzcxraJ5wiR1HXjqwlhA+GDjL?= =?us-ascii?Q?ans8vLaYyGT0lf/CRGCcYNeOJqRbSzgFwLqJqa3zM1tkGEogqkythzSVSVwz?= =?us-ascii?Q?t5bzt0Zf3j1sokMJPxa0uTPlKFsgRk2i/AYLV9Fqo3kthXL5TykFRwzvf4vt?= =?us-ascii?Q?V9JiWIaKecjiwmVc9tXEKV3cJRI+90mskvRReKRLj7Hs7xSOFKCBeXkRQD88?= =?us-ascii?Q?5wfEzgsfjn7r7dog3/v9MQdZT9i1FiUlv1YVcJUcVkBj2ZTeu5lGPTZv7lni?= =?us-ascii?Q?Ig=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XCmerjsgl4NaQh3FNDNlM7SqgKJLZwPnfYps72jqqvJ+OIAU6d6JcHYjgg6q9PujCNPNR/SrG55pkWpP+H0aqaG4OiixaW753VMmZY/2bqHOxwHkgChqPcdgkRcuGodnzTRcZqoHYw8n8AXp/txyd4vzNVinzPk9hI1BB10HHbSRpKJCYZlj2tbqvHo5aJUJR4TkGZQk/ECFtdWB94MnD1bK/9GYJU7u4PKw08g3/KfN8yTWUgB3EVNk6tirdlnYDlgNko1r2CRqb060s7xfqJP3bBBCbmYrhBSdtNRJJDzhnwFAWT40CxzsCRz33VTQsqpqvVdOhoddAOxdPPxzDnM6tB0CalkPW7+aJsjUg1L17DB2DY6tgqxWwSNioaye9+IhwNONleYUii5e1LEDJiXed9QtgFQFWbFMLAomarj8cPIo/2lx/w379zCdKajyRGlpa+895mvLu3p4/cahA4Q4CC42jZ7DzvzlWe4Crvt/8cdtqNkpkBS+DlaaQPwNZ/OYsJDvzpjBioljVoTg0I7R5a071qPWghQ7IySu+WaJkRET9cbQpa0bSeWrzC6q9Nef5dEEs4wd62WHm4yr09zJ0ytFTpCZkwX5zqtFwqk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa4e5da-92b8-483e-9d5e-08dcf20f4016 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2024 20:30:49.6298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Lay9C0GaD/FcxtlIxeEo+nv6r6S1GvJLAcR5ac2S8piWVkrD8JMQt1/Y6Ar9FA+q7eG5D3RwkzhWDhWhjUdcR4qSyT2civ8q3GeMY43g90= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5918 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-21_19,2024-10-21_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=985 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410210147 X-Proofpoint-ORIG-GUID: WGixXZE48RIA2hwgOOSGIQpBosKQV99T X-Proofpoint-GUID: WGixXZE48RIA2hwgOOSGIQpBosKQV99T X-Rspam-User: X-Stat-Signature: kdc8ijw5seckrjuft5hf6zknk8fhky9x X-Rspamd-Queue-Id: 5696E160017 X-Rspamd-Server: rspam11 X-HE-Tag: 1729542665-457763 X-HE-Meta: U2FsdGVkX196BfjGI/QNS6d9emQs1O+sYEAwS7M1SNYFC3+3ys82oHfqCIjhrgNPt9XY1AG3XZXUkKT+tmUyiBAHXnsGn2SEwpWf6CxORDK1smQuHYTBfMGX+9l0Fws0cPK4PP6G1r4CmtZDE7cxOaywFp3FTBvGsYTVDjr0XWQNjrg3A+7BUw1h7/WHMi/vBueiBqBGeNyjhNwSEVXSu35Ecs3cjZt1ywuuESwDVc6AJ8gzcOROh55NoRJyhfEPntf5CXuzgWYCxWsnIxGeCXG+RgGeS22rwUp8JoJD2WkvQoQw8fa0Ia6ZjM2GZfUDiRRnY4fRq9yDiqu7y0DsTeX+nYg+JLte7uQLi6Wauvt2wFq+4zUCf2V23Z3sli3gaUVikcJmNvQciEP0JR2CCWyJvJklBI8Xep2PypUYu65tx78JQc8VYra3UvvHBZFPGjegijkJp1SQ2ojqv9bDgEWJSJMuxck0c5nrjaUr8lkYjXVPpltWa1jQQqnWy50ZacnzT2hRKowncgpZoi8r118Ff9tAXZZ74XVPqBAMgbQuNyOO3IaSVCnTudHbvaOSadkEeO6ad+obmFllnwdulnYYhdUjWONHcutLaBCAbthLJjicUMBw21y4WY7Bz8MftI81871KjR4pNzcVxex5PM84jeV7YocFRsWxIJc1DK3RfZ6pDbGMPKa5WRLPhQxHL+u7gMm7v5qls2hiygQUv1fXFigxSgk9f0ZFjuOj84F+zpOmv7iWymYMgvki3TdwuYIt404oXrsoRIxsWBZeYyRWjjpYpCC0XJsribCozl4UZAnS9IQnwhG6zC6DCqOZWIH9FG/vQS2frYrKORmfzOTFxXQ2I8MbVlKQlSmU82zGM93m0dGj0YHufiZF4kI83skvM7GMslJTyg6+gHu5mmQ5Zs7I3BEqxxnQ/nokZ7yZDUTFMJEvVvCGPjDG8NUfEZhFlAXHJ1yb8hAMv27 T6Cb/3yr WFvzSx92taczHuzKi5KJExuVMVrQEZ9zmkoVJyn5iVJ1Y4ZtFlYAZa1TUM9j0SP1hieSuguRJuShy+tJ4USNQO7Yx2vo5uEYqhEjaMAfV5m7eSsYFykJIh5t/LHpKO9wS3ehK0sUeTtuAvH4pKI8ysxn/6vkYtaPuSSKpGJR2OM3Mor5GomDm2iLOPkQD1nnYecoH4WGKW49jYGV+/ZSPniOKE19xxxZd6KKAzRcCTe47bvG0Yaf5P9qLRz7jsIN2b22q7kisp6wnKHp5rrG4cs9RZrCLFK/omdeiApKlksHn43P01LN6JvYlUVr75ZoYRN8bKbCgZQYbGBksTLpN4j7Xq03qpaYnSyUM1O2BYUQC4zCYoVal5H439ji78SYFpnErh/GZpc1IFaysNk7hJHyULVYOvZuVOJnV90D1cs01v/XJ4vzwhf27pStpEJPreT+bIC8w3yva9IHyk5KlUGpbvD0chCzK72idrW/5oze+NrpVscb8G/uYnXGtjWvqMQ0v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 10:25:06PM +0200, Vlastimil Babka wrote: > On 10/21/24 22:17, David Hildenbrand wrote: > > On 21.10.24 22:11, Vlastimil Babka wrote: > >> On 10/20/24 18:20, Lorenzo Stoakes wrote: > >> > >> > >> > >>> +static long madvise_guard_poison(struct vm_area_struct *vma, > >>> + struct vm_area_struct **prev, > >>> + unsigned long start, unsigned long end) > >>> +{ > >>> + long err; > >>> + > >>> + *prev = vma; > >>> + if (!is_valid_guard_vma(vma, /* allow_locked = */false)) > >>> + return -EINVAL; > >>> + > >>> + /* > >>> + * If we install poison markers, then the range is no longer > >>> + * empty from a page table perspective and therefore it's > >>> + * appropriate to have an anon_vma. > >>> + * > >>> + * This ensures that on fork, we copy page tables correctly. > >>> + */ > >>> + err = anon_vma_prepare(vma); > >>> + if (err) > >>> + return err; > >>> + > >>> + /* > >>> + * Optimistically try to install the guard poison pages first. If any > >>> + * non-guard pages are encountered, give up and zap the range before > >>> + * trying again. > >>> + */ > >> > >> Should the page walker become powerful enough to handle this in one go? :) > >> But sure, if it's too big a task to teach it to zap ptes with all the tlb > >> flushing etc (I assume it's something page walkers don't do today), it makes > >> sense to do it this way. > >> Or we could require userspace to zap first (MADV_DONTNEED), but that would > >> unnecessarily mean extra syscalls for the use case of an allocator debug > >> mode that wants to turn freed memory to guards to catch use after free. > >> So this seems like a good compromise... > > > > Yes please, KIS. > > You mean "require userspace to zap first (MADV_DONTNEED)" ? What on earth are you talking about? This is crazy, we can detect if we need to zap with the page walker then just zap? Why would we do this? The solution as is is perfectly simple... What is the justification for this on any level? Again, if you think there's a _genuine_ security/DoS issue here you're going to really need to demonstrate it rather than hand wave? > > I'd normally agree with the KIS principle, but.. > > > We can always implement support for that later if > > it would either mean later we change behavior (installing guards on > non-zapped PTEs would have to be an error now but maybe start working later, > which is user observable change thus can break somebody) > > > really required (leave behavior open when documenting). > > and leaving it open when documenting doesn't really mean anything for the > "we don't break userspace" promise vs what the implementation actually does. > > Or the changed behavior would need to come with a new MADVISE mode. Not > appealing as it's a mess already. > > So since its uapi we should aim for the best from the start. > > Best is 'call the madvise(), guard pages installed' which is what it is now.