From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
0x7f454c46@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
x86@kernel.org, linux-mm@kvack.org,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCHv5 1/5] x86/mm: introduce arch_rnd() to compute 32/64 mmap rnd
Date: Wed, 15 Feb 2017 12:34:19 +0300 [thread overview]
Message-ID: <9dbe048c-b332-199d-3d80-dad0562e3153@virtuozzo.com> (raw)
In-Reply-To: <201702150640.DEwJ0Wro%fengguang.wu@intel.com>
On 02/15/2017 01:22 AM, kbuild test robot wrote:
> Hi Dmitry,
...
> vim +/mmap_rnd_compat_bits +58 arch/x86/mm/mmap.c
>
> 52 * Leave an at least ~128 MB hole with possible stack randomization.
> 53 */
> 54 #define MIN_GAP (128*1024*1024UL + stack_maxrandom_size())
> 55 #define MAX_GAP (TASK_SIZE/6*5)
> 56
> 57 #ifdef CONFIG_64BIT
> > 58 # define mmap32_rnd_bits mmap_rnd_compat_bits
> 59 # define mmap64_rnd_bits mmap_rnd_bits
> 60 #else
> 61 # define mmap32_rnd_bits mmap_rnd_bits
> 62 # define mmap64_rnd_bits mmap_rnd_bits
> 63 #endif
Yep, thanks - it's better be ifdef CONFIG_COMPAT.
Will resend today with this trivial fixup.
--
Dmitry
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-15 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 18:36 [PATCHv5 0/5] Fix compatible mmap() return pointer over 4Gb Dmitry Safonov
2017-02-14 18:36 ` [PATCHv5 1/5] x86/mm: introduce arch_rnd() to compute 32/64 mmap rnd Dmitry Safonov
2017-02-14 22:22 ` kbuild test robot
2017-02-15 9:34 ` Dmitry Safonov [this message]
2017-02-14 18:36 ` [PATCHv5 2/5] x86/mm: add task_size parameter to mmap_base() Dmitry Safonov
2017-02-14 18:36 ` [PATCHv5 3/5] x86/mm: introduce mmap_compat_base for 32-bit mmap() Dmitry Safonov
2017-02-14 18:36 ` [PATCHv5 4/5] x86/mm: check in_compat_syscall() instead TIF_ADDR32 for mmap(MAP_32BIT) Dmitry Safonov
2017-02-14 18:36 ` [PATCHv5 5/5] selftests/x86: add test for 32-bit mmap() return addr Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbe048c-b332-199d-3d80-dad0562e3153@virtuozzo.com \
--to=dsafonov@virtuozzo.com \
--cc=0x7f454c46@gmail.com \
--cc=bp@suse.de \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox