From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E147C25B74 for ; Thu, 30 May 2024 16:21:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2651E6B0096; Thu, 30 May 2024 12:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215526B009E; Thu, 30 May 2024 12:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B5EA6B009F; Thu, 30 May 2024 12:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E2E246B0096 for ; Thu, 30 May 2024 12:21:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 82EA740375 for ; Thu, 30 May 2024 16:21:25 +0000 (UTC) X-FDA: 82175577330.19.364394A Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf15.hostedemail.com (Postfix) with ESMTP id 56D9FA0009 for ; Thu, 30 May 2024 16:21:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=GjGj4v4x; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.44 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717086083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OieraxBcsvRTdK3OcSRojD9cGTahPveJy8SszB1ZOBE=; b=Z1YJu+E8NbqYN4ZROHGGFoKVHi9MU9Fzksvdh8cBT8H5UTOGOdia/U6MzSGaB93ldWVrzH 9l7eNEd0obWTl/VvdDWSIZCAIGbvurN0Lvemtm8+NR05JTItYqIQgz35ZV0tNx8pAtcHsk 8imLrcdQy2FXXlLRR1sV82/BmxmHgtk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717086083; a=rsa-sha256; cv=none; b=e9yRfryABfEzZJBij7MvR/0ZDXeL3gUH7YfbTpwJLdewzK5o+dAGRcw4CbWwQa7tolBRR3 3/lOvuPXcoxxYaZPjyrmEml2gH0cNC0R9cc/fksQ4W1Xo/1mGcwZVadGt9SWD2VMHD5x+f zOl2LrZgtOFiwN/WxJduDUDnidZJEck= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=GjGj4v4x; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.44 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6f90543da1aso26530a34.3 for ; Thu, 30 May 2024 09:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1717086082; x=1717690882; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OieraxBcsvRTdK3OcSRojD9cGTahPveJy8SszB1ZOBE=; b=GjGj4v4x9tAmLv8fPV/WwgxmASC+ispMWOdnadai81QwVHVMJ8IG6r9nDlqILnF6/s 8E9iKGVimIbddZdSpz5+PvTOadu9bb8wde1C4WDeIm6JYX4Y5r5LsjP2puMammNEQlzF wxWd35HP2v+2M5SbA/7Y4ZHbOqcjXt+bGqpNkPMStGedW7EPOGRflgVuFfrasGxK0TQE wNJd/xp3sPCybkVgfyaqa+rycGQlg2zGY5uAwZQjN2tsbuHqbCB0yeNuB6dMrcdFHYGF EMvvaVZ3LBHPmTC13iuOXmBPsHTXbR/Bghu7TWGo48YBqwjsKygOFjzJg8TotehUc3kx dWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717086082; x=1717690882; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OieraxBcsvRTdK3OcSRojD9cGTahPveJy8SszB1ZOBE=; b=SNpB+W2y3ea6Xn7uao9obIj6P7cvIw36nknW8HlLiXSmXnH1dBFXuIitY6syowhR0f Bktf5CNftKl21iH9d7Wl6XttsQVVkPGSA4/EHmWC1xSWYtz2YF3pt6S0enx0+0F3rGKd CRf8e/Jn2BQMX+Y1C+FCIPODY3Jr4RgnyUzXj4upmET+IyFmAFq4Bfh0I5dM0HoQf59o 3Z+yTibQbrhbJGZCigrMSMrSvdsKLPZqt+wz1qrcBhZPIb8JqcE4YMNCftaSK7NaKKL+ 3lN5rGsO2ogK0nXKV+uqKrgImE8Sf+dY+3sXI436Uq8H2NxQxXc2iUuIcsD7Zb0FSRbq AyMg== X-Forwarded-Encrypted: i=1; AJvYcCX1jd2JYQglsqAZN8X+DpnBuOVQmBStChNwTCxNVjmy8gRFVtWBGjp0MUYlPUEvNbKeUql2Lx7OhsFYcwCkyCwPHaA= X-Gm-Message-State: AOJu0Yyth7GXS5bc2kkfIfHJ8fbo7DnjFvMfWWKUKLQyO+KudAW6IZmD szMhbuGfgs6SwyJr8X5dmQLE+mtAhim37m4EUaQFsskEGb/EUJ4Bnck7E0yhuJE= X-Google-Smtp-Source: AGHT+IGaxrcFOIbphwZTYIv0ek+RxPvRrF6ZGN6TagnzapF/2qunE37ScKDQuQWCgn/L7gsn4PPBgw== X-Received: by 2002:a05:6830:7203:b0:6f0:6420:35d6 with SMTP id 46e09a7af769-6f90af7702cmr2780805a34.3.1717086081998; Thu, 30 May 2024 09:21:21 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f91059cc0bsm12129a34.57.2024.05.30.09.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 09:21:20 -0700 (PDT) Message-ID: <9db5fc0c-cce5-4d01-af60-f28f55c3aa99@kernel.dk> Date: Thu, 30 May 2024 10:21:19 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring To: Bernd Schubert , Kent Overstreet , Bernd Schubert Cc: Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org, Ming Lei , Pavel Begunkov , Josef Bacik References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <5mimjjxul2sc2g7x6pttnit46pbw3astwj2giqfr4xayp63el2@fb5bgtiavwgv> <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> Content-Language: en-US From: Jens Axboe In-Reply-To: <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: exsfjjoet69cjmu1bbts5g5x3j5g6f6c X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 56D9FA0009 X-HE-Tag: 1717086083-986591 X-HE-Meta: U2FsdGVkX1+j2OVgUGjxouIepkdB6X1pHR3sR88bunWzqfZhW3fX8PqWooTAavMVllbmYMz4F3UpWCSQdKBOMjROaf4efUZGR32aaBJ3BfrtVlHiE6O59Z7uJmq570sTaelFaWgKLYbvlvgGcem5ToqBQljAn9Cz6nnZKJUOCsXHKLe/Aot0iuajYJby4BY7rmcKcRV5RCEow+Sq64hhMLEkUOM4mFio6BUDfTFmWF75kVWfVktSCnqJOx6kPMBFDblSt4VCo5DAYl/PS4/3n+2hTQPa9DdPBftB0ljounjBOjkYaCmroD5pxv6dIVn85c07d4MJSwEJFCnEIdoPBogolaVSeJqCDL71EngL7ye+yY7PtZZpe8gVr+/LmBGu2ClfMzCmxZ3Z8dvJPex4C/rrFZUWFBPMUWnODH+m9i9x1hFcHwifrLpow+fCFfWPgMTP9CPhFO7w6qtnna90QIr7oX/JeqL+YGSNk7LBkik54R6sw7hvn1FCHQ9gpWGTbFV8DpvNC0jxgrTyrNo4BOeTNj/IOvYKFvgictCrLgg79PDwQ7V3MG0jZePcsTqDAhLTkBLXNtVZWcI/i/cWQDRK7aTF054fxghZZ8fANdd6OphvZDp7ZQQnCr5H8b34JfZ+PnDVU1rRfkIS7hc8HlzqKbnC8cVbYbhnZpnpi3Yu0ruj7a8orO5DqcYe6VX0dNfdb8hPm2FQWB6uE0xXNBKwg7WOAgJ8BFNKy2GpZh4EWAF61Ehk0iQSobZwl/8WJczNhBKyxOMLnUc9s+vtwfSvZAkEtNajxZuQt98dRMR7DL6pD6+6xGUR4Au0MsA8UrMxvM0evg/rD2+5mpT56r38YLnYYHCd86UDvZMbUH+dRhvNN/RpTglie9pkHCe6R0kSCanZwMubZ1faG6YbQovPrqXyFJ5JOURh603wH4iEhpSwq25yj5uMWux/vaaaiLBkAJgrfBKf6KSWg2P 7luI9y7q Xwbojsjgpc6LygmAelaznq7KINnmaWQ1Jj9KLMQJ1+SbD6dwQ9jPv2Xfq3yOC5CU3F1AvkaVwalsLs/fXdfbQjqYaF8Cxk8a1dBuqCJlvLwfLGTDzZbz428NU21EF4sTYpB9O6qSpwdxhqEXRIf9T4mVk5K/T8FTSmdk10URRl4MpzXs9Z5DWY5s1X4mEshSPnxoYvkOLvROuzwWrwtLBvTeu9TTJaCYzLiPKwPKXfFDUf707+7GzQahqPkHMg9edsQx2VgLJ192wEuhgYik1Uhf5DgajXkgD+U+5cxxgPw6t2gOX5sJ/yeSmiJRgzxfolSYy+vEbWczEKeMaP0HbJngNUcRnG03StXqI0lSeRg93V/bWfhRDq07F16J2mrjt8xmU0YFGMX2NdoASmXgcLlt6HtYKHcTQs622sFOeEjWhbyL/57u+ZX34fPNZ7FECmFqzb8ns5RvCpwgvvIy9+66dpeLNU/syOH3TPUC+/N5ReyR6gaJIWDmID2F8BbBUzd28LOY0BUA2nM0nHH2Fce+DqT88+aMqFOkBihKcw5jQaM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/24 10:02 AM, Bernd Schubert wrote: > > > On 5/30/24 17:36, Kent Overstreet wrote: >> On Wed, May 29, 2024 at 08:00:35PM +0200, Bernd Schubert wrote: >>> From: Bernd Schubert >>> >>> This adds support for uring communication between kernel and >>> userspace daemon using opcode the IORING_OP_URING_CMD. The basic >>> appraoch was taken from ublk. The patches are in RFC state, >>> some major changes are still to be expected. >>> >>> Motivation for these patches is all to increase fuse performance. >>> In fuse-over-io-uring requests avoid core switching (application >>> on core X, processing of fuse server on random core Y) and use >>> shared memory between kernel and userspace to transfer data. >>> Similar approaches have been taken by ZUFS and FUSE2, though >>> not over io-uring, but through ioctl IOs >> >> What specifically is it about io-uring that's helpful here? Besides the >> ringbuffer? >> >> So the original mess was that because we didn't have a generic >> ringbuffer, we had aio, tracing, and god knows what else all >> implementing their own special purpose ringbuffers (all with weird >> quirks of debatable or no usefulness). >> >> It seems to me that what fuse (and a lot of other things want) is just a >> clean simple easy to use generic ringbuffer for sending what-have-you >> back and forth between the kernel and userspace - in this case RPCs from >> the kernel to userspace. >> >> But instead, the solution seems to be just toss everything into a new >> giant subsystem? > > > Hmm, initially I had thought about writing my own ring buffer, but then > io-uring got IORING_OP_URING_CMD, which seems to have exactly what we > need? From interface point of view, io-uring seems easy to use here, > has everything we need and kind of the same thing is used for ublk - > what speaks against io-uring? And what other suggestion do you have? > > I guess the same concern would also apply to ublk_drv. > > Well, decoupling from io-uring might help to get for zero-copy, as there > doesn't seem to be an agreement with Mings approaches (sorry I'm only > silently following for now). If you have an interest in the zero copy, do chime in, it would certainly help get some closure on that feature. I don't think anyone disagrees it's a useful and needed feature, but there are different view points on how it's best solved. > From our side, a customer has pointed out security concerns for io-uring. That's just bs and fud these days. -- Jens Axboe