From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C2BC433FE for ; Tue, 12 Oct 2021 21:32:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EA5960F3A for ; Tue, 12 Oct 2021 21:32:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1EA5960F3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 512C16B006C; Tue, 12 Oct 2021 17:32:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C308900002; Tue, 12 Oct 2021 17:32:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38A426B0072; Tue, 12 Oct 2021 17:32:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 2A9BD6B006C for ; Tue, 12 Oct 2021 17:32:29 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D591431E4F for ; Tue, 12 Oct 2021 21:32:28 +0000 (UTC) X-FDA: 78689084376.35.B1413A2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 53B913000098 for ; Tue, 12 Oct 2021 21:32:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE2CC1FF6B; Tue, 12 Oct 2021 21:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634074346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7HK2Kf8c4mJukZ0Mo4rZUFzKfAvYTuMEdKV03E7+Ik=; b=FpSMq6bMGmBtf+GXUgoy6QUKoqjS1iGl/eQaDcISbQN+vLEzbaRikq+rrgGfXAgkENuWNX Dcvkx6oUYx9HNZqBEH7kuaqzeciKuFaOm+4Zsu3R2zfthgtWdfdUs1tvqTUyxUByoGZvsG kngIxSaiHdr0h5zCvzrVVfnmhoaEf8M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634074346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7HK2Kf8c4mJukZ0Mo4rZUFzKfAvYTuMEdKV03E7+Ik=; b=Ge3Os5wqd0rcf6HlPW9CMrCK6lYZBkjzDchFjPg2nqQ83OzMXRU5UZJJ+t2Ug47uFb3LXV Sr/bd6t3aQGi6uCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 81E3913C8A; Tue, 12 Oct 2021 21:32:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3n1HHur+ZWFqNQAAMHmgww (envelope-from ); Tue, 12 Oct 2021 21:32:26 +0000 Message-ID: <9db5d16a-2999-07a4-c49d-7417601f834f@suse.cz> Date: Tue, 12 Oct 2021 23:32:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] xfs: use kmem_cache_free() for kmem_cache objects Content-Language: en-US To: "Darrick J. Wong" , David Rientjes Cc: Rustam Kovhaev , Dave Chinner , linux-xfs@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, Al Viro , dvyukov@google.com References: <20210929212347.1139666-1-rkovhaev@gmail.com> <20210930044202.GP2361455@dread.disaster.area> <17f537b3-e2eb-5d0a-1465-20f3d3c960e2@suse.cz> <1e0df91-556e-cee5-76f7-285d28fe31@google.com> <20211012204320.GP24307@magnolia> <20211012204345.GQ24307@magnolia> From: Vlastimil Babka In-Reply-To: <20211012204345.GQ24307@magnolia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53B913000098 X-Stat-Signature: y9nqaaajyfiwb7tbqa9oqx9b47zneyyh Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FpSMq6bM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ge3Os5wq; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1634074348-161886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 10:43 PM, Darrick J. Wong wrote: > On Tue, Oct 12, 2021 at 01:43:20PM -0700, Darrick J. Wong wrote: >> On Sun, Oct 03, 2021 at 06:07:20PM -0700, David Rientjes wrote: >>> On Thu, 30 Sep 2021, Rustam Kovhaev wrote: >>> >>>>>>> I think it's fair if something like XFS (not meant for tiny systems AFAIK?) >>>>>>> excludes SLOB (meant for tiny systems). Clearly nobody tried to use these >>>>>>> two together last 5 years anyway. >>>>>> >>>>>> +1 for adding Kconfig option, it seems like some things are not meant to >>>>>> be together. >>>>> >>>>> But if we patch SLOB, we won't need it. >>>> >>>> OK, so we consider XFS on SLOB a supported configuration that might be >>>> used and should be tested. >>>> I'll look into maybe adding a config with CONFIG_SLOB and CONFIG_XFS_FS >>>> to syzbot. >>>> >>>> It seems that we need to patch SLOB anyway, because any other code can >>>> hit the very same issue. >>>> >>> >>> It's probably best to introduce both (SLOB fix and Kconfig change for >>> XFS), at least in the interim because the combo of XFS and SLOB could be >>> broken in other ways. If syzbot doesn't complain with a patched kernel to >>> allow SLOB to be used with XFS, then we could potentially allow them to be >>> used together. >>> >>> (I'm not sure that this freeing issue is the *only* thing that is broken, >>> nor that we have sufficient information to make that determination right >>> now..) >> >> I audited the entire xfs (kernel) codebase and didn't find any other >> usage errors. Thanks for the patch; I'll apply it to for-next. Which patch, the one that started this thread and uses kmem_cache_free() instead of kfree()? I thought we said it's not the best way? > Also, the obligatory > > Reviewed-by: Darrick J. Wong > > --D > >> >> --D