From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0667AD339B2 for ; Mon, 28 Oct 2024 18:28:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 759BD6B0096; Mon, 28 Oct 2024 14:28:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0CD6B009D; Mon, 28 Oct 2024 14:28:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5343D6B009E; Mon, 28 Oct 2024 14:28:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2EAD76B0096 for ; Mon, 28 Oct 2024 14:28:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9BAB61A0D5C for ; Mon, 28 Oct 2024 18:28:15 +0000 (UTC) X-FDA: 82723845540.14.C61E6DE Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by imf12.hostedemail.com (Postfix) with ESMTP id A48C440025 for ; Mon, 28 Oct 2024 18:28:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=WMjqOgKe; spf=pass (imf12.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730139934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xfwaAlX8xBNBzzQd8cWtPopo9omhZXUl1zo673gmZPU=; b=ZTGW0g7L87/SqjMqYD1UVEJREps1pUmUHD/cgRNcjxN6QSXoY16uZ7b1XuNv6iizGxR5nx 9qqnr7zAk0muosImPo1gX5MqCGZw/J4uIa3hlOBSrV2qjAhhI2qQ4r8ytIgHfjLj8xUS9M 0F0ZKaDwKNvVtpVMg4uuxH52X0FuOX4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730139934; a=rsa-sha256; cv=none; b=zL7cUlUg/yS5nS8pTN8Fd+kR/6co0PaJmAEfGHmz3814W+ATSTwkR61RwKFQkaSSyYtLeN 00FgyEKPcz9MURUHuBWqCUUgwClx6j5LqsRbOWWZ9GtNGG2v/QoQhcNLFcUmXEgrFfPrtW M2l0v636Jo1XTb7mKcCbHW7Q0H3vYnU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=WMjqOgKe; spf=pass (imf12.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=xfwaAlX8xBNBzzQd8cWtPopo9omhZXUl1zo673gmZPU=; b=WMjqOgKeRu8KLmj0e+FfaKQ5nw SgLTeMPtlxn7YvNSwEXm9WRVO6V3OfUYWzBkFxex8g5DhluJnjtGZAOP88y+oEYbhTswl001wqbjC VAMp0KBM1cV3pxfWiT9t7GEpH6PP3iHvzxFOSltTDDGP1nFT4qfRwTkyuhh+Ij31rgOzU9qZSzueN FXFsu3EvxwXrCsD6Ddkf3+5bHEPJculCmwf5FKruYO+4w5MEugAU88AXgFQlK1emwFsWfp6VAnMOR XgGvOU7wsYcyzcO9LPQQNiLmuWtrD8A0tY2Ryo4R36g1lHw3F9kJrwi9exvBKqXcTantt6HmE9C2I NC3mHOlg==; Received: from d104-157-31-28.abhsia.telus.net ([104.157.31.28] helo=[192.168.1.250]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1t5UT4-002Zeg-0P; Mon, 28 Oct 2024 12:27:54 -0600 Message-ID: <9db04bd9-81e1-4e60-a590-0882cd86052f@deltatee.com> Date: Mon, 28 Oct 2024 12:27:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> Content-Language: en-CA From: Logan Gunthorpe In-Reply-To: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 104.157.31.28 X-SA-Exim-Rcpt-To: leon@kernel.org, axboe@kernel.dk, jgg@ziepe.ca, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, bhelgaas@google.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com, m.szyprowski@samsung.com, jglisse@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio X-SA-Exim-Version: 4.2.1 (built Wed, 06 Jul 2022 17:57:39 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-Stat-Signature: uojwpcbd969otupd3oahnuboscktcoiy X-Rspamd-Queue-Id: A48C440025 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730140082-634405 X-HE-Meta: U2FsdGVkX1/LVDyaOpIsfOR3ruq8500NpwAaKh6Tutmdot5QGD5ektri/0ySXn3SuyNKNlZLjAyzWzPhrmOMeCpvwzol1EcHtbcKYXpshzXq2gQVlabgcw98LOBz9Uyhgau+GLCzGitnZxCg+iJuHdnTldNk4y02QPin6wV0QVeIP0Ef0SKJIqPxAgjUVwTIPljr0aAR7RS9Cooe7Q3ZGnrzmdX0W5F2E/caMlT1w8k4Fknsn1V/7cyrdWi/1JCcvEZjEGPiKNrFlPDZR8Fo+BQcqvNBwTKy54sgTjQ27jgHm1m7VCA6drssTnWMFScVIQCu3Du4KsV6Fl0dIoAZl6A/lPV1lxs2UEa0qwMIsjLEtGFCh4nN/uMQdeHebo4umxsQGoytKxIyunP5rpoQdiPF+u51v8R99Re/rwNsSVgnqOH8/fpD+eBoxWeomwb/yk38Na7HMia9FmI5JIntXVOnNo3vi9t4AVckJPNvcw7AHYhvPe+3LXv6+XvI8WIR2UYT/rk3HP5wQmfB3Hk/z8z56jTOFP5gQmkXRDWgRahilmWsrrYFLmYkhxPdJ3EpD5n3VfaetQYqWSC/o8tntmPyyH0HgP7fR+KnFp0BpUVrqiby5JhiyRe5xGuYKlAaVDa+USQI3Y595QyacBZBXoU2V4TpM6UjOrJWStvDXMa1k1reabq+Ievb1rpq1/1sgZIb/yaZHmLMjRC2NbHqgBpnrKuVknZE8xxJBciHlv8vQgKAqjYDeCEOXmSDVNHN0yUk6mWasxrPDgVKsu2hiS7+IdQJ6SMytC1ZnleBFzbKKJ9U0Uimwg0sgtlKeUUYbdWeJ38iV5LNjiXkPJo7tG3jOhhOsulqX/Jo7YYac03oHyyDwnSBrYKPDvVx8WeUZ5SARqfkuujBiCIW1VIqOxaC3VL5aQdXjEhBolLC+WD9Orjr0GxK/AHOCeRilz1gr8JE9exSpCUTswGV6Qu IDN3UlNV eBWzqAiTAoaY4Kd7qOb51KixJFNiBjZeczuSPVY7g4cuSNgi6dO5Yq0pcU5qKW4woUP9Yg0ar8+5KX2v/C1ptgb4ofNXOv8JZGuxql+ernkgOnwzV54N1s3AkKSKlZmb/Lcb/MpFsyC/CIzHH1vHWI/N2KCJ7PqMl4uEoCtgrAXADg/+kIBbGpzFovUFX91SBq9XAKnhyYsstgE97RE7Sg0rcUSRsLxP2eQ1J8JB8m26jvikSQfq3788XtTxmXFCRE8KjdFZo+vJkTeDWvLC9JJC2BMWMHP4hDxN2m1F3dJpgx8p00m2H2ikwo3CUlB6MaEes1n8BVlWL0Zk2+PTdl6VSqKkuxXrSelJsIqMfSVPqSP2UgfUnqcgvVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-10-27 08:21, Leon Romanovsky wrote: > From: Christoph Hellwig > > To get out of the dma mapping helpers having to check every segment for > it's P2P status, ensure that bios either contain P2P transfers or non-P2P > transfers, and that a P2P bio only contains ranges from a single device. > > This means we do the page zone access in the bio add path where it should > be still page hot, and will only have do the fairly expensive P2P topology > lookup once per bio down in the dma mapping path, and only for already > marked bios. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Leon Romanovsky Looks good to me. Reviewed-by: Logan Gunthorpe