From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C70C369A1 for ; Wed, 9 Apr 2025 09:58:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 024F128005E; Wed, 9 Apr 2025 05:58:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F16DE28005D; Wed, 9 Apr 2025 05:58:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB52328005E; Wed, 9 Apr 2025 05:58:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BFDE428005D for ; Wed, 9 Apr 2025 05:58:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 28DA51C8495 for ; Wed, 9 Apr 2025 09:58:01 +0000 (UTC) X-FDA: 83314054362.17.0DF4CF2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id CC58D140003 for ; Wed, 9 Apr 2025 09:57:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Vj/QHY1C"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744192678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+L1Lnd+PcedYee10bRY6lZSgXHVSmYPHtTKJdqkx5c8=; b=gruSNAI+FCGAuME7OLlwIIN1qV7sucGuWvPxDCG+aWcYsRmkSZp+RT/lXnCSBwxlqe2AGf 5ATUkyz4NmKJc4K09zxxqBYsjrNGVql2j6bEJqg3Y77m0n3NO5sFINaocIAI3hXP9KHA7o uVz3EjmOXvkTQxcbMAaMi0jCt+YxfxE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Vj/QHY1C"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744192678; a=rsa-sha256; cv=none; b=B1uruCNpI9yFP5xHse542k5n12eveHGMlLkTgrE6h1z+qIHSPQztT7vN9p/BrZ8UVpsyh3 7IIFaG4aeX2Y8n8izCb7w/3Q2yQKcR0ddVBTfN0lksl+ZU1/AqXh6IXkY1RE2DWRwvtxzS rTmPgPdWzZl2+EXG7WwE9ca8v9Zdt6k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744192678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+L1Lnd+PcedYee10bRY6lZSgXHVSmYPHtTKJdqkx5c8=; b=Vj/QHY1CYNw79GEIhwq/mhh38jD66kfyRJ3cJdYoJfTA+hRhrY3y0WlBoZL/1JP8YuokH0 ZXPzknmslPj9I4Ba3tfI6fSfmOj7Gk1mWst2P2lxfqCOc3E1YQxMT/CQzVcqKcdhA6MRDG EdS58X9KgJ/FM0QARanAUThZzVcDPQ0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-6UxY7ABLNdKgXtgDuwczwA-1; Wed, 09 Apr 2025 05:57:54 -0400 X-MC-Unique: 6UxY7ABLNdKgXtgDuwczwA-1 X-Mimecast-MFC-AGG-ID: 6UxY7ABLNdKgXtgDuwczwA_1744192674 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf327e9a2so55263035e9.3 for ; Wed, 09 Apr 2025 02:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744192673; x=1744797473; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+L1Lnd+PcedYee10bRY6lZSgXHVSmYPHtTKJdqkx5c8=; b=jPEQTpWAVI9cgovzumThJfDf1v+HmwkWCLNXBxOd0wnwTyXw0nEiQAWC2qUmOcMQ3D WFrThRBZt3fXR0OOCCWab2CM8XVqGYITKf+cUG4xUJyUKPc42ImKKm/4LnGrnPVdx5KS W9MlYm94HGmwgVn/pr0UgGG2u/egGhgyhOmQjKVdMkO7FFfvfxM++Hdu/jX2A9eqxeWD GF3aRDtZGohZ1ADM9DaJ9S+AGlBTaTAyUXjJZrq9da0cE3aE9Lq/OlyOIk5gDuElaxBU uTRXoyt+SSmRu6QtzxocalhHIV6Qk5aaS8CXpFO0wLAIt7bdLZVA9ADyMeuASkKU/+LL FRUg== X-Forwarded-Encrypted: i=1; AJvYcCXDnou0TUYd8W4z2OUcVwrHO7pK8jXvBL9Hk4HRiAhG7RSpaKt5h8vD6jkH1ElDz1uW4quoi3HDWw==@kvack.org X-Gm-Message-State: AOJu0YyqbA5RNFbCuEX9tQ6MHlhIqqKPOY5bDqxyKxu7ZW4FxAb8lA7c pf+GbgTxePX4ZH6iYGi8IfeDdzKQibX4InTT8EMmR4enZpoHMduKVynLoFeMaGUsaWEP+2JPZDd R9yzTUGfKOgDR45nB74GVpJbm59+QQvNy5OXg2u7SoqdVnCc5 X-Gm-Gg: ASbGncvxBBMjdx61vKvAFemPJgARlnOapUzsB2GduVMi5ZThu1MiTkBDE+9NNDF/VLT /ZGO4Ng+27ePNBw78yQ3hSWnzf1Xkw7l727vHRrgqC/fZUl/q/tAHpymruHlhtcXTqdDiF9xIHY 85T1rITGLNRzUGTacgqaUDjguJLbJ2OSxI5urfgEHMrNdf/XNor47RJULGBQASM9N7cJ9xa5FFy QLrXVDFANaHbB3tvkc2q80mWrgQa882CFwaN6FAOCW+Z3enCyTADkMzaRgyS+u4rD9t1OOBx6GH iFIYvMX0nV6SN51YKXnPTFrfkieKK6PRN2bftO08/Ql/ZWq9TjfDAYc3wPnZTJS7G7DTC8i7zdO 48WzVLli+dqYIiVerS+N9xkFlJJUqvo9TqQ== X-Received: by 2002:a05:6000:2508:b0:39c:1404:3748 with SMTP id ffacd0b85a97d-39d87aa80edmr2163220f8f.16.1744192673599; Wed, 09 Apr 2025 02:57:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfJJjXQVACsDObppdCDBuWzUkg8k622JfKmLVPltfHoDeLfRD/0IZh3fvzW79lsgT4GXzBUA== X-Received: by 2002:a05:6000:2508:b0:39c:1404:3748 with SMTP id ffacd0b85a97d-39d87aa80edmr2163204f8f.16.1744192673298; Wed, 09 Apr 2025 02:57:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a4dasm1137183f8f.48.2025.04.09.02.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 02:57:52 -0700 (PDT) Message-ID: <9da46633-e9c1-42a7-b52b-16cf89836abc@redhat.com> Date: Wed, 9 Apr 2025 11:57:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250409095006.1422620-1-anshuman.khandual@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250409095006.1422620-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: O_TwM0LI6moe9ETMbcdkuq2veKDUq_9v5muJIuobpeM_1744192674 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CC58D140003 X-Stat-Signature: 96zp973zqb3ugn3cbsettowanip3ngqw X-HE-Tag: 1744192678-230782 X-HE-Meta: U2FsdGVkX1+VGFUnMbB2cAeO1ytwWCGZgZtAxPMjgvjORzRq/6QaZI/cn6zq2iTJfT1T0aTXCN+HY27nIjQAW0ax3wCuWiKu2WJPNeNalyrkY8fRxudNm375xIje8wAIqa+N/vY5IsARQ2Z/FFJT9X9QFSQv9zkRCkDMuD6n+22C8kUBTNWDK8Or8zbW5XKMFRQiCclghemj38T7xoIZWRMkL9x8hSHf3tBCMncRkQW08YJkop2wGnA00tHTKvfUgAW6caeagI+edK//I6fJW6AgY6Ev9WkzhrqWjyGL9YaY4XGzsGzQ82kkN2WmZXG3YiCOKLKjtrNmt+tTAZLPJm9i/QYD3qTrMsb7Au2Jja7dPP+nqZ4addlp4dlAOOCx6VCkaYkhIebHQve4/hdQXzEQ2XlQtu/t0L1AJN7QRw5VQMFhrVORuywqv5luBEVm7Cz1aT78YZZDOEFO9eX6PWFqnRWEtA13IPvtkFBlq0mHH3eonbkLEOaq34tEdMGZL+nvWvgYa99eAaqEX0sZGQM6PDhy9OiNsrRN7C+GWkP39T0HpYQ1DI/X7LErtdnOCHqi0vSoQpBXMVh4lkrN49DGsZV06hRqSoEYP1JtMeMqIO15hOw2WXqmlDxQWYQjghrwgIU51wMkfo2HuBn9ZkGbXoX1yUBA6/SLlb5P/bodTqIYMeBzG/WiOPjrdXxxQsnfJ4/jy+BzzT0vl+4SA9xJZ7B0oaqEN6Ppg0W9IxOF4sCL0vxMKKuq0NtXQBuiQhetMFzbytNQkdbdpsDzwx4HJP1I7BaD8T1PpN0+iNshTY5pUMq5P8Y7Y2IMOwuD1/x/lvdol3v3+AiS9VSfu9xY+NdgoCq2HqA/0X9HyI7hT6qUWF6pS4aoeIrMAJg6chFNusGfFciYCgVXW7aWcA3QT20WQmt0cAnbZSNSpwvOCMc4zKVzGVBK/1r8vxJMNqWEbKN1VD6ceyOUrVR b8Pu+k3g YObkqr6wJnMcPgb9B/bTe9nbVrukTDiHJJOILDhFciG/y73+QYy5hiWU460T/YyhOsfmboJGdCudY3lW5Y48Y8F/em3ac1wUsI7bAka7/IuP8CVxi7WmcVsT+S2ZyIF1YH7++bNfhl237gBp1LommzzwqSTOxMGoZkRgVe2NcoXCS0SHJ7b+hjzD1GdmbCxkwyLuNL98t2q6NQR4t9Hsn6AMX7o8YmhWs9SgzYhKcLCTmEqITGlTrXGam2Ow7QJPSslH40dqeeWglgiOWtP4XGXw1riNVeDr9MbdPLKeUegeDqMXR8bpTRXOyyBKRGHlqBzMX50nRPqRCCRYK+cjUxQYSBLgb9+lNQMyG18RijnZcQ3VdYTvnK48YPKB6aLWtaApR9b5ud/vLe1qUvovsXLkO2j/phbWKZ7FQE0KRFyrJM6VQy/UlAb7btIj6QtHkl3CRjVOTsTKBafsyY4QG7A4t5UlPGIwzr4vaZ1+AL/zoNk+vhFrCJyJC8yHlmk5HNT+3S/eMm0x5fGkmovokmLsL8qSIVkLJ2SZf2nZSWCncJj2K2XcPqvOgQPlWybOWUE3SYz5wMOdiPqm9EEuIwl1fGZI1LLK6mYorhXV/pHD6Ot6hfMT6z0I6Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.25 11:50, Anshuman Khandual wrote: > Following build warning comes up for cow test as 'transferred' variable has > not been initialized. Fix the warning via zero init for the variable. > > CC cow > cow.c: In function ‘do_test_vmsplice_in_parent’: > cow.c:365:61: warning: ‘transferred’ may be used uninitialized [-Wmaybe-uninitialized] > 365 | cur = read(fds[0], new + total, transferred - total); > | ~~~~~~~~~~~~^~~~~~~ > cow.c:296:29: note: ‘transferred’ was declared here > 296 | ssize_t cur, total, transferred; > | ^~~~~~~~~~~ > CC compaction_test > CC gup_longterm > > Cc: Andrew Morton > Cc: Shuah Khan > Cc: linux-mm@kvack.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > tools/testing/selftests/mm/cow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index f0cb14ea8608..b6cfe0a4b7df 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -293,7 +293,7 @@ static void do_test_vmsplice_in_parent(char *mem, size_t size, > .iov_base = mem, > .iov_len = size, > }; > - ssize_t cur, total, transferred; > + ssize_t cur, total, transferred = 0; > struct comm_pipes comm_pipes; > char *old, *new; > int ret, fds[2]; if (before_fork) { transferred = vmsplice(fds[1], &iov, 1, 0); ... if (!before_fork) { transferred = vmsplice(fds[1], &iov, 1, 0); ... for (total = 0; total < transferred; total += cur) { ... And I don't see any jump label that could jump to code that would ve using transferred. What am I missing? -- Cheers, David / dhildenb