From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BB3C433FE for ; Fri, 11 Mar 2022 10:13:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38C988D0002; Fri, 11 Mar 2022 05:13:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B438D0001; Fri, 11 Mar 2022 05:13:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22A6D8D0002; Fri, 11 Mar 2022 05:13:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 0E8B58D0001 for ; Fri, 11 Mar 2022 05:13:00 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CDA0E21B96 for ; Fri, 11 Mar 2022 10:12:59 +0000 (UTC) X-FDA: 79231692078.11.CD9276A Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf12.hostedemail.com (Postfix) with ESMTP id 39B3740019 for ; Fri, 11 Mar 2022 10:12:56 +0000 (UTC) Received: from [10.20.42.25] (unknown [10.20.42.25]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxusylICtiOUoHAA--.3045S3; Fri, 11 Mar 2022 18:12:53 +0800 (CST) Subject: Re: [PATCH] mm/khugepaged: sched to numa node when collapse huge page To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220311090119.2412738-1-maobibo@loongson.cn> <52412f08-829a-6c29-60c6-a24c866e6253@redhat.com> From: maobibo Message-ID: <9d8b5ced-5350-9201-079f-47cbb4f587b3@loongson.cn> Date: Fri, 11 Mar 2022 18:12:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:AQAAf9AxusylICtiOUoHAA--.3045S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKryrKrykZF1kZF45CFyfJFb_yoWDKrX_uF 4DCw1xu34UZ3yxJFs5t348XrnxJa1kX3s5Jry5Jws7X34fXFZIqF429rW0vwn3K3y3Cr47 u3sIva1fJrZIgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbI8YjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AK xVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvj xUcVWlDUUUU X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 39B3740019 X-Stat-Signature: m3sy5xegnk5ny5yjdjaux5dszi9c45f8 Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn X-HE-Tag: 1646993576-408081 X-Bogosity: Ham, tests=bogofilter, spamicity=0.022227, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/11/2022 05:55 PM, David Hildenbrand wrote: > On 11.03.22 10:51, maobibo wrote: >> >> >> On 03/11/2022 05:20 PM, David Hildenbrand wrote: >>> On 11.03.22 10:01, Bibo Mao wrote: >>>> collapse huge page is slow, specially when khugepaged daemon runs >>>> on different numa node with that of huge page. It suffers from >>>> huge page copying across nodes, also cache is not used for target >>>> node. With this patch, khugepaged daemon switches to the same numa >>>> node with huge page. It saves copying time and makes use of local >>>> cache better. >>> >>> Hi, >>> >>> just the usual question, do you have any performance numbers to back >>> your claims (e.g., "is slow, specially when") and proof that this patch >>> does the trick? >> With specint 2006 on loongarch 3C5000L 32core numa system, it improves >> about 6%. The page size is 16K and pmd page size is 32M, memory performance >> across numa node is obvious different. However I do not test it on x86 box. >> > > Thanks, can you add these details to the patch description? Surely, will do in next patch. regards bibo, mao > >