From: maobibo <maobibo@loongson.cn>
To: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/khugepaged: sched to numa node when collapse huge page
Date: Fri, 11 Mar 2022 18:12:53 +0800 [thread overview]
Message-ID: <9d8b5ced-5350-9201-079f-47cbb4f587b3@loongson.cn> (raw)
In-Reply-To: <caf087b4-b184-c45e-e212-87f0a573a4d0@redhat.com>
On 03/11/2022 05:55 PM, David Hildenbrand wrote:
> On 11.03.22 10:51, maobibo wrote:
>>
>>
>> On 03/11/2022 05:20 PM, David Hildenbrand wrote:
>>> On 11.03.22 10:01, Bibo Mao wrote:
>>>> collapse huge page is slow, specially when khugepaged daemon runs
>>>> on different numa node with that of huge page. It suffers from
>>>> huge page copying across nodes, also cache is not used for target
>>>> node. With this patch, khugepaged daemon switches to the same numa
>>>> node with huge page. It saves copying time and makes use of local
>>>> cache better.
>>>
>>> Hi,
>>>
>>> just the usual question, do you have any performance numbers to back
>>> your claims (e.g., "is slow, specially when") and proof that this patch
>>> does the trick?
>> With specint 2006 on loongarch 3C5000L 32core numa system, it improves
>> about 6%. The page size is 16K and pmd page size is 32M, memory performance
>> across numa node is obvious different. However I do not test it on x86 box.
>>
>
> Thanks, can you add these details to the patch description?
Surely, will do in next patch.
regards
bibo, mao
>
>
next prev parent reply other threads:[~2022-03-11 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 9:01 Bibo Mao
2022-03-11 9:20 ` David Hildenbrand
2022-03-11 9:51 ` maobibo
2022-03-11 9:55 ` David Hildenbrand
2022-03-11 10:12 ` maobibo [this message]
2022-03-11 19:08 ` Yang Shi
2022-03-14 0:46 ` maobibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8b5ced-5350-9201-079f-47cbb4f587b3@loongson.cn \
--to=maobibo@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox