From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88762C77B75 for ; Fri, 12 May 2023 11:02:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A21F6B0074; Fri, 12 May 2023 07:02:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252776B0075; Fri, 12 May 2023 07:02:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 141556B0078; Fri, 12 May 2023 07:02:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 04A376B0074 for ; Fri, 12 May 2023 07:02:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8A5CC0FBA for ; Fri, 12 May 2023 11:02:05 +0000 (UTC) X-FDA: 80781313410.03.1A7F6EA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 468CF1C0023 for ; Fri, 12 May 2023 11:02:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683889322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fhs6rH6nyL/hKcMEliIiVsJU4/txVxmEquGUm1qcUvo=; b=iiFn4ZV/0iYt0MKwhGOBaK5lK/7mVbm2WlIYj8+wmvy/MMkMHYJAp9X6KYIfdxN3re/LNm XdqlaL/AANRU2LZWqx7FSTRa7quG/M9m4YkgL3vLCwrcQ97sHqb4Qm+kY7wh5F6xgKDN2N n7fwIsZXhgECRIS9c0OnTVL8l8waw94= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683889322; a=rsa-sha256; cv=none; b=YAS+p4B5L2Ie/q0hpab4Bw16M6VTfs1rJobJAmGTfAnfdHybp486zIfVy7C7Kjg+gP5DgU pF/0jI9ghjEZUYJjq+gLzK1kR0VJgNhdz1nz09InARCRJNOL4svxFB/xJ3ASjvvp04ePX8 LFdN2Y/ahnC+RKVfkneT440NpTQPRa8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43FCFFEC; Fri, 12 May 2023 04:02:45 -0700 (PDT) Received: from [10.57.73.22] (unknown [10.57.73.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B01A3F67D; Fri, 12 May 2023 04:01:59 -0700 (PDT) Message-ID: <9d89ba3d-775f-426f-0956-0d002193bd4d@arm.com> Date: Fri, 12 May 2023 12:01:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code To: Zi Yan Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev References: <20230511132113.80196-1-ryan.roberts@arm.com> <20230511132113.80196-2-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 468CF1C0023 X-Stat-Signature: i9wndk6cg1iucgywuub4kxag7884hnmw X-HE-Tag: 1683889321-158135 X-HE-Meta: U2FsdGVkX18cCKD/AtvNZSPxzSWGp8XTWVEciynISgCEOzwiAEO1jGNratMSXaIvAPrlUcWM8+I7PF4b7WL1b5rplI4ROt+ybjDC0OL1VkMwbY5G+HJq7Th65ibCQjuXj45TfCqFHjVfVrrwK2vgow1VBQC38gTch5HUDxTmVSllLDV0vK/1PwjXFZvmzIQDlg+dekq0COx7CJUySBVz4j7r8dP5/u3hTkW1gIBwcFAyxIb+b/7I63kaWibwvd6e6Gt5MuR4cH/uY7ANvfLpIyuLf9xw9FT9Jx3cSlQJNItc7CAL4x6wsA8Eoeu8Atlv0osbwE2TzjqHFiLxBBrhO7DzJSJT83HfL+l2SGAS7oMQcaFMQNTne/2QWtKoKKXB1miZrCBV3+YzB10w4jow58hCLwzkyJHpVzfrSdZFC6pOI2yykGb/gkENKJIMHWSReSi5/q0isuXkoh98klZBTtQhBnCofGnX1XbR/dSxHzFZ9aYDIFknl0gkoYJ3jdVSHScAiHYo7aiXvhcLDXz+FFnvGpae/tKFQ5kgvv351cjBioGTW9ebi6MWO5Ky4muQaqVlUpFnU/WIZL72dExjlwXDhZBJT7WU7pyDQgoenlsdgmTNMXya5Ao8D13B71IwGVnLeSIS14W12pY4TqKXfbiO/+kKCZhaRkJz1OusCBQFEYL3SoUfatFupFERXcaP854Q1hyEATcK4t5eSfVbryKjC0UEna4/iCGvXssLaiPanBZsWgD9f8+16aP0rIVCavuX5UJSUQn3UX3Rn0dDYotjARDPl1h7qOZYNVmIxdkHooATUbEdWdI/nepny6TSkZYvDT2SpM3ka6RMp5l/+WyAvhPJCSLwq0JgPHxypUYAj/NaK2jlqN4ZoMfdqS91nS5u7nVPcJJ70PnN7gevbP+aH2E0hqjvdc0wEWgYfoRxD434CZQ60igyla+CbOuFLVD5WuDwRzoPkkaqtit E7wYmIlw 6+GQHt69w6StbTSYFruZtXQpDOWpDNqWjdifQyRTTsVTfFiASFlQSst4L1bbIaJIFGWSlZywBiUyLl4WPWv6cUwTwxwQBLZPdVrVmaIruu4E+16jGJGN7gUNjqKUJpxxE8XA++OGqpPxOaapQhb3UZM2Zyt2G/20X4yJipHw+W7Y930277eGk/ZEa+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/05/2023 16:00, Zi Yan wrote: > On 11 May 2023, at 9:21, Ryan Roberts wrote: > >> It is bad practice to directly set pte entries within a pte table. >> Instead all modifications must go through arch-provided helpers such as >> set_pte_at() to give the arch code visibility and allow it to validate >> (and potentially modify) the operation. >> >> Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") >> Signed-off-by: Ryan Roberts >> --- >> mm/vmalloc.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> > LGTM. Reviewed-by: Zi Yan Thanks for the reviews!