From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA08C4332F for ; Mon, 7 Mar 2022 23:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE9718D0002; Mon, 7 Mar 2022 18:14:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A98328D0001; Mon, 7 Mar 2022 18:14:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9883E8D0002; Mon, 7 Mar 2022 18:14:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 8BF168D0001 for ; Mon, 7 Mar 2022 18:14:32 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5631D60300 for ; Mon, 7 Mar 2022 23:14:32 +0000 (UTC) X-FDA: 79219146384.06.D59CD69 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id DEE9B1C000C for ; Mon, 7 Mar 2022 23:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=1RJl9gPUoZ5r0tpE3KAj5UTUngTysCjGJETPpOzuLSc=; b=VGTbphPW+44xgsldnOtrZRksPu 5zkcPB10d7stBVRUgLup1/+ZOqiUvtIR0i/gWWUtg27mYsPGBVQO/v8api9RAOMYi9/6JrrH1hHAF DMWqQrlOEJawA4SrKudJDam5qVxWoj3rc4BA1ynbsUY11vUBk5iN3VMwKlxSPpUUoYxG/s706r5pO GH5gsdudLQ8vOWfKGmnHrIu1e7g7nMu3DVDkrbqa1TpyJsRpiKj+D4hTOmVa00peZ5KqgBG9ZAFo8 TRSprjiHqeLkkD8RN18BUr+CfDxfs9t4a4uKRuy61DQfLrVZKYPbF9CrENHACF8akyc3Q7QrHL3aa /KeJgFLw==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRMYM-00FdR5-9S; Mon, 07 Mar 2022 23:14:10 +0000 Message-ID: <9d85050f-33c5-0cd0-3278-ca62f4ca098e@infradead.org> Date: Mon, 7 Mar 2022 15:14:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: mmotm 2022-03-06-20-33 uploaded (sound/soc/intel/boards/) Content-Language: en-US To: Pierre-Louis Bossart , Andrew Morton , broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org Cc: Liam Girdwood , ALSA Development Mailing List , Keyon Jie , Cezary Rojewski References: <20220307043435.251DBC340E9@smtp.kernel.org> <39c76613-3fb4-651b-1838-f460c4f76a17@infradead.org> <178c7536-7b54-5f73-b759-745db4fae2bc@linux.intel.com> From: Randy Dunlap In-Reply-To: <178c7536-7b54-5f73-b759-745db4fae2bc@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DEE9B1C000C X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VGTbphPW; spf=none (imf21.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Stat-Signature: jkdsif3b5r4zr6iywf7rwfxdcuik3kkk X-HE-Tag: 1646694870-458763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/7/22 13:54, Pierre-Louis Bossart wrote: > > > On 3/7/22 15:12, Randy Dunlap wrote: >> >> >> On 3/6/22 20:34, Andrew Morton wrote: >>> The mm-of-the-moment snapshot 2022-03-06-20-33 has been uploaded to >>> >>>     https://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> https://www.ozlabs.org/~akpm/mmotm/ >>> >>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus release (5.x >>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in >>> https://ozlabs.org/~akpm/mmotm/series >> >> on x86_64: >> >> ERROR: modpost: "sof_dai_get_bclk" [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined! >> ERROR: modpost: "sof_dai_get_mclk" [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko] undefined! >> >> >> Full randconfig file is attached. > > Thanks Randy for the report. Indeed there's a problem with the SND_SOC_INTEL_SOF_SSP_AMP_MACH option. It should be conditional on at least one Intel/SOF platform being selected, as all the other platforms are already. > > The following diff makes the problem go away: Ack. Works for me. (after ignoring the double-spaced lines :) Thanks. > > diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig > > index 6884ddf9edad..81e012c164b0 100644 > > --- a/sound/soc/intel/boards/Kconfig > > +++ b/sound/soc/intel/boards/Kconfig > > @@ -615,6 +615,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH > > > >  endif ## SND_SOC_SOF_JASPERLAKE > > > > +if SND_SOC_SOF_HDA_LINK > > + > >  config SND_SOC_INTEL_SOF_SSP_AMP_MACH > >         tristate "SOF with amplifiers in I2S Mode" > >         depends on I2C && ACPI > > @@ -631,6 +633,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH > >            with RT1308/CS35L41 I2S audio codec. > >            Say Y if you have such a device. > >            If unsure select "N". > > +endif ## SND_SOC_SOF_HDA_LINK > > > >  if SND_SOC_SOF_ELKHARTLAKE > > > -- ~Randy