From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A3ECA101E for ; Tue, 3 Sep 2024 06:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 365898D013E; Tue, 3 Sep 2024 02:26:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CC968D0139; Tue, 3 Sep 2024 02:26:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 119BA8D013E; Tue, 3 Sep 2024 02:26:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E165B8D0139 for ; Tue, 3 Sep 2024 02:26:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 57B21A77FB for ; Tue, 3 Sep 2024 06:26:02 +0000 (UTC) X-FDA: 82522441764.13.BE89E0F Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf11.hostedemail.com (Postfix) with ESMTP id DB36540006 for ; Tue, 3 Sep 2024 06:25:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725344655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=khbjSL9LKiRTCBVPKAO18p9gt+eKMVKZ3McaXkIKVHg=; b=B58ryT7dGS+3992c3eKgUQG4lYcbt9jbLMR82hcgTTCAi1FgrzrefYLZyLJjd5sLhWWPZ6 Wx/Py90ZV6NQ3zqAYAJsVjkTFGrZFwECmQba4A+topEgf2WZNXg+RsXeEWQLAsMv017ttG Brwp0/SWDzguUU1xfIr84zMuRy3V1M4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725344655; a=rsa-sha256; cv=none; b=y2iYqZ9W2jgFhIB9t6Ydu1PyorD29ctbjqYsCjnfbDCvIu1RtP8eZJYpNAcvzfQ/njuKe8 /vEYtgfjqO7JiSDUStGpKofTSOhIRtq/CcANkTs+NllXAm/ttGWabpcnVX8gy3kaI5eOdI IxU6SNxbdYbozjJ5r9F6Pn8Hx/NVijM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WybBr3K9dz1HHkC; Tue, 3 Sep 2024 14:22:28 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id A1EC81A016C; Tue, 3 Sep 2024 14:25:54 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Sep 2024 14:25:54 +0800 Message-ID: <9d844c72-bda6-4e28-b48c-63c4f8855ae7@huawei.com> Date: Tue, 3 Sep 2024 14:25:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper To: Willem de Bruijn , Andy Shevchenko , Jakub Kicinski CC: , , , , , , , , References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> <66d5cc19d34c6_613882942a@willemb.c.googlers.com.notmuch> Content-Language: en-US From: Hongbo Li In-Reply-To: <66d5cc19d34c6_613882942a@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500022.china.huawei.com (7.185.36.66) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DB36540006 X-Stat-Signature: n5y1dgxog6qgbkbta6nzarbt43comxqm X-Rspam-User: X-HE-Tag: 1725344758-880675 X-HE-Meta: U2FsdGVkX1/BiRpepYjkEdZYU7M1SirgQ2sDTT7Y5H8hFONQn23NwrKl9SuS6uqQsGttclQqui1eFLPDBSmOTjhq29t2YRbaob5yXD5/7Go4EALfAwJhbacr7asqzjjxL4aZrHirkrbsqH47bNKFVSA8h6Hqp0FXq13UPU0IK1cFdsTB+Ml8HOvfg2j/ZjOq60JCYfVlOIa670zHZV6PvVgWshqQ0eLvyrHoUFnx5W8uypneoLiQ35Cb+u2q6E9EjznUruz2l5ZcvPt4H4clByzqA3+Fw6NkXus6pGXhrWjv5ae04cSUl78YHIYQnw4I5ETN4z7NBxmrJ+HBHCmG0A6HWiYMMutgKrKAASqEbPx9/Vhsu5vEzmdptyjgfuVkREZjtIMzRfVXTOH2QU32oaROg4DTfpylu2CPrPju5zAs7WjOPdm/uM3JQnlo6DDwbs5Iu3D9KWi6F+VRV0gYc9TCRPy2IUQid7upw549yDhdqm664orhHnYcGqGKlvINK16NOUrYLdHp4n09BkHtxEaF4DLaMwcOhb5QbbQVg5tn2mFosuh6peECWySKxWiWnn2ML5PBX2sfg00WwL/Tyif90EYz1CbkgRjZlhJJmhPYNoVERlM11dvmrSu/gTAX4LAWymlqC2xPq9985MMYhTgRyv7VyiRdWjKXdqfOMqzQ5BF89E3+3I4Z7u+xmP4iqAVJy8c3zkUsa4NvCFfkdUL9W63nkdS7cpN6AY/eM/mRw2bOr3zRqA+aApn/Bb/C+BTIuBbALpkL5yVdM5tVzfrPiB6qW1OTORe6DUA04v1VuPU6wxvGHGsGWnIF/WmoIASgKHHWWi4LerkBV9pTd5qAJjQRrjAbyPkSjQlzP52UwYyPQZIoN7qGEUM9zgbzI8zVZiTcMH1Eze1X5/IXO16CZuzNbnbqbYLSrMXQb16PVeeojlRwulMNrFXajn1D3tUFuiT/9JZxG7Neshi 5qFvDUU2 ngldQY1J2SXGrikCIYY+0NZlfRDhE86hCDqT99u4osQySGz7V2kg6Orhat0aQtGtKpFJUceA31LewodZdkcdjzmO1Cr+2IYlq7vC/5bAkt8WnjKRMT24KZzKqTY8Yk8uY+6CgI4fveTvCquMFmJb6QcAZqaY+66jFoMljiUj7P3N4CgxMYFjBNpJAAHiKO3M076ukOlHaJfe/0CoxPeaFntz2BqWqy80m9ZrGakzNRSiJDnm7QWPv76sA+rYo8Z4HXYMJeKfjk4uasWsEwFrgwqpQkVotKkng4s7E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/2 22:30, Willem de Bruijn wrote: > Andy Shevchenko wrote: >> On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote: >>> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: >>>> Use str_disabled_enabled() helper instead of open >>>> coding the same. >> >> ... >> >>>> netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", >>>> - arg ? "disabled" : "enabled"); >>>> + str_disabled_enabled(arg)); >>> >>> You don't explain the 'why'. How is this an improvement? >>> nack on this and 2 similar networking changes you sent >> >> Side opinion: This makes the messages more unified and not prone to typos >> and/or grammatical mistakes. Unification allows to shrink binary due to >> linker efforts on string literals deduplication. > > This adds a layer of indirection. > > The original code is immediately obvious. When I see the new code I > have to take a detour through cscope to figure out what it does. If they have used it once, there is no need for more jumps, because it's relatively simple. Using a dedicated function seems very elegant and unified, especially for some string printing situations, such as disable/enable. Even in today's kernel tree, there are several different formats that appear: 'enable/disable', 'enabled/disabled', 'en/dis'. Thanks, Hongbo > > To me, in this case, the benefit is too marginal to justify that.