From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C141CCD1AB for ; Wed, 22 Oct 2025 20:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A7D8E0009; Wed, 22 Oct 2025 16:28:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CAA88E0002; Wed, 22 Oct 2025 16:28:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892728E0009; Wed, 22 Oct 2025 16:28:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 757598E0002 for ; Wed, 22 Oct 2025 16:28:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 114A088C4F for ; Wed, 22 Oct 2025 20:28:40 +0000 (UTC) X-FDA: 84026888400.29.0DB3FC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 911C3C0014 for ; Wed, 22 Oct 2025 20:28:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c69CDSku; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761164917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GlXuUkfNtXIjY5JQ2zXpNWAksNWcSCReHr3IsPBo+Gs=; b=MZZsBqa0zpc2An5WINGwszOwB5FOFSvfLGG3jEsjWYixmznzqbBGXAFMa+3j2LwiIPSMQZ 228AetTqw4G0XvNMMQE8L+eLH+NPWIpcg01iUM/QcqW1E5dMTl4hMQTv+UHvjXfxYoC+a5 OqI3S9u8fMxl5xiYAzKQB0VGFRxzqpQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761164917; a=rsa-sha256; cv=none; b=4F4Mhb6x2Aa4jweSemQlXqS2Sahyx+qKOlWDCIJjKm0XUuqW8Ne5Jpbb1xe6Zd1XmNJT2/ INC6BWhl1yRv6HgpsLYdiKHeX4etYlHElWlH4Dc2BVF2ffiXZmYJNPBm8Ac/UFANJmGMqn 9aeItMH27xkzzZ0bwuC0h/RTmL6HOhs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c69CDSku; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761164917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GlXuUkfNtXIjY5JQ2zXpNWAksNWcSCReHr3IsPBo+Gs=; b=c69CDSkuec832pLWXwvj5EqV05m1fgsIj62zd8EEnhdkireEJj9BvsXh+7c5l3uPfwif5s 701D4WCtGvbecx191leLV0CUOxb/3knHpHMVvdZw0K6FZnVrbWwNaa9Pm7K88Ww2CUuVp8 bXpj8ENGaaRtw/VTd/cAFuCNynvbpLc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-ZBIbwnPENj2eXSAviZsT_g-1; Wed, 22 Oct 2025 16:28:33 -0400 X-MC-Unique: ZBIbwnPENj2eXSAviZsT_g-1 X-Mimecast-MFC-AGG-ID: ZBIbwnPENj2eXSAviZsT_g_1761164913 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-40cfb98eddbso614830f8f.0 for ; Wed, 22 Oct 2025 13:28:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761164912; x=1761769712; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GlXuUkfNtXIjY5JQ2zXpNWAksNWcSCReHr3IsPBo+Gs=; b=elKtSOicRWTjNck22ztQzw13ncfGYIZXzOxnXuDzFVOLNohr3qpptPsxQunBA1gK48 0O+gYOfzpto9p74uSH82v/hthmKRob+hRBhfgVPZCoZStGl3G0llFutx4CqlfoVdhZKu YMQhTbdN9Ab8FbVpNzgL7f7N46S7YHy3BGYBrw7lhIMBwP03Qed/W/mnLljxoZj/JVMr R/kBueBLRRQdQj9itUoywZRmNnS1AXQCu9uWctigqnxyI5SZgyMSXIz6Q/bEDfa7Qqm6 nB82H+NHsi7BKI+hVOufDprFoBNBDS3MK19qU86Nyaxc5miCcDZqseWLu3oemCuZ3o1e yxTw== X-Gm-Message-State: AOJu0Yx86JXp5AO2Kh5xVihxSiDNy/zEtZYEL33YN23DcbWqgDFCqLk6 SsDqnkw7Zez2iV0HNmmno9HBEu5FFsNtORIGQtJQRnoW+GL+ewbBznrYurdKj7FsGUcqfUe8bfk TnkP8eXnV9qJJytYwtnaIJWnbpIIvesg/9VQ4knWYdKnZVmC00gQm X-Gm-Gg: ASbGncsGMCghE75s120MKJnm4SP/Km1/1MyJ3QKwVtAyyOqUoYWvcMbfUKyhkQKjWmW IF8Wkej0oYdAcReKN8mlOfQiCFtlmeJ6fMkjVKWPmgSiSfJS1woBn+gYcfO7CLPDWuOXXRQTs0B kHUb5Mt1ryih8F6BYOtwoj1VKhkThWFYtqn55fhzI0m4eIOu8WahI0OjjDgFVP8UgATnVgpAcIH RPe/iJfrO2qRU7MtIiwR1T0eq3f6+zKQRiaghkejoB3Hu0vZoI24tfurd59r8jHVRhfWJP02Dos Myn75RkT+jArRyNgAjkL7N1SSDkTVFZffJ9sWAOoqudvrCZxYctfTD9z03qAmXTAXqaiqeM0imx VZEbk88VVhRtZGkGxpj3rANt+Wqp7kmRvw9BONYwQibsKhdtQ67woZc+NEaC/cvO6TKJTqbd+m+ duHESU6975OXjKIy9Vkyfp0hnLB1w= X-Received: by 2002:a05:6000:26d1:b0:411:3c14:3ad9 with SMTP id ffacd0b85a97d-4285326f9b4mr3412135f8f.21.1761164912520; Wed, 22 Oct 2025 13:28:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFka2Y9lD52JJXLMCDqlmdPZZaWMhRe6ST9wXaWEQdAEBAgqSSsiyypuyAUeQLFgUECdAYJUQ== X-Received: by 2002:a05:6000:26d1:b0:411:3c14:3ad9 with SMTP id ffacd0b85a97d-4285326f9b4mr3412124f8f.21.1761164912049; Wed, 22 Oct 2025 13:28:32 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429897f546asm258006f8f.15.2025.10.22.13.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 13:28:30 -0700 (PDT) Message-ID: <9d6da187-e731-4eb2-84c6-77f91acb913f@redhat.com> Date: Wed, 22 Oct 2025 22:28:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v3 3/4] mm/huge_memory: optimize and simplify folio stat update after split To: Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev Cc: linux-mm@kvack.org, wang lian References: <20251021212142.25766-1-richard.weiyang@gmail.com> <20251021212142.25766-4-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251021212142.25766-4-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: W3gPvSw7HychG-icDZhk51FwSF1bKWrXW5If9Zm3KEs_1761164913 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 911C3C0014 X-Rspamd-Server: rspam02 X-Stat-Signature: au1skrzbqnw1y1a94xxm5afwz1ekpj3o X-HE-Tag: 1761164917-190987 X-HE-Meta: U2FsdGVkX1+uugA+2juFVhp++7jYJqbR4D+PnVkMrOJoqxyPisniJkpSyXBYLK939yHGlWqynb61wSvX5Q78ZRcdCwKHX7ZbzUqsdZBfv1h1Wrs8QdCtadqePRluxX280tC108joxDyvTZuUAY8Xtak+jOy+C5bfkOImwQTcc348Gb4kJCD6CizEuxsx3JHjJ10Uvx7acKdujzwWuUO8fWmFJt+UpHOwWJFpDxiAJPquLkF4NHrI5/syukJBctH9kukeBRJYuD7xX5JTH6zNOQQcmu/VDUX7diu/vmsrOYll5mbUC8a3A+bd+5yEzp4tNxrg9SFOTCUEf/CUiNPSBOzSnjSflp3h9PsYBB3XuEeldnxiplucdWxVN1qp2WH475XEQD6S/ZJ8/xMrhzJNhK3Hhc/QuoDTh4gMkdtE9Bh4p/m7KVKL7UGpDKKknXQSk2cHzSavDCL5uJr2DfFU+zv7AE7Q6nw00w8AVenBqqu9ldSVWk03WxL9cHozmA8EgRo7q+3BLRFPTEO7xolz1xza58SOVsAdX9HwrOa19Rmqd2HEWxTO9OKNUm7V9sPj46ZSu2obAwFd97b0B9xtdFsm9+Ow5ZqETYQvnhH9ACKB0Pvhr+3nb+IR0hyRLbfzeiJbnSLJ7LdUVW4/8NrnLSID/Zad60SyPH1k97ir/+zMwFTCNmZYCSTBtKT2doVo5sntwr9GrclSkdELq57xIXa902GOWdtlK6+FFuXSOmUOgq6VFEzgTy9640CNyyIpQ+DbSDKym5vmgbAeUy+GdFj3r558kd7OairQ/UYMj80IJZXXhbjk8ZJMe9hHMTHZvuO3+ay+O+vLRgGBCoBpMLgz55Yjm9xi0u5QorFd7Wdq9/zjirZntqZXoefDdUpLZPJtE/oQEKIeSCqw/bfEVJv66zaKWZUY5DwZmG2BlTFZ3pxWofQM9Ik6mM55YjiFXqUBYq9ixN5HH7YNeYy ob05osWz cPc8LQCdnEePF8DdwFQysqa+xCwfORhPZg35Js7D2rjkCtZCX7SduzJvdw2FSOoR+268j6AGHGl/Xfi3Z8vJmQRX4TcT/aJPGbCUBCyoZv0D9ohzGY5OSlwEIXsCA5HQ6ofoPhMke1d1LCTAj3///0nJRi6qKMFllCdFQLCIPmL8tk/WzvdmbAbabAQUrMHHgB6kUDfRU4d8vy+lO2vyJXmfRxJv95jDArvGbCJCHasUdtPJ/+aulwESBRAXdG5ngAUVoO3gzpeTS1ka15Gtt+9mGdelpSPaZOfjKpjJcgrN9/Nt5L6UFTZSXk1bLgUieVwft6S3Fg49xxZqoDtuoAYg5WS7XFJmdV63WrZZshMwQrQ1L8flAQb1nq0Lyc22/O6ko/PAd5GcBB3VJscp99ll72am1NRkHEwC4iJZJl9ixRwmdm+95yzvrr5ybyQaTV7IN9gDg4h4hzg6TmZqEKkLaRrSRsFqOQoefzp6SprPIX+Jut6AC7MOtSyzSS9ba5sMhPz+2RDZ075AQJQ87ngGIOYQIHgUzOeeJ6oNyZveFxVHRZX/yx+1cjgfrSUrEsyT7i42I+jMY64oJE1F/eMhgUvT//UVf1WL1ARxv4WXc5m0177TLMjLhZHSNyNscDvL2HRTL9+33FP5l1UHquAy1vc+xw7wpr8fWWc8F56Y99CcYQjnK29XKpmf+s6B2FWW9nnaVwmSJoFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.10.25 23:21, Wei Yang wrote: > The loop executed after a successful folio split currently has two > combined responsibilities: > > * updating statistics for the new folios > * determining the folio for the next split iteration. > > This commit refactors the logic to directly calculate and update folio > statistics, eliminating the need for the iteration step. > > We can do this because all necessary information is already available: > > * All resulting new folios have the same order, which is @split_order. > * The exact number of new folios can be calculated directly using > @old_order and @split_order. > * The folio for the subsequent split is simply the one containing > @split_at. > > By leveraging this knowledge, we can achieve the stat update more > cleanly and efficiently without the looping logic. > > Signed-off-by: Wei Yang > Cc: Zi Yan > Cc: wang lian > --- Acked-by: David Hildenbrand -- Cheers David / dhildenb