From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6F0D6EC06 for ; Fri, 29 Nov 2024 12:59:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2F36B0093; Fri, 29 Nov 2024 07:59:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6B496B0095; Fri, 29 Nov 2024 07:59:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96D56B0096; Fri, 29 Nov 2024 07:59:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 815496B0093 for ; Fri, 29 Nov 2024 07:59:17 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 466231C7E17 for ; Fri, 29 Nov 2024 12:59:17 +0000 (UTC) X-FDA: 82839138186.16.391DC64 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 6B6BC1A0010 for ; Fri, 29 Nov 2024 12:59:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DxJiXwST; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732885148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XcSCrZsrFnqSAWVc0CZcBqWIMg9FraNhIyn4BgkF2PI=; b=1OQJfn++XyFeC3EDEFTgNg5UaFspCMsgF6AUyh/Jq+AcUrc4ppXTU0hJtIa2x1USrdzrwm cOcAjHB97YsdwR4+CONmGvuiFwyd2osZf9Gmsqosnuosabfpxu+jyYQJVOX/9JGzz7zJGE mqVMYsNFR4MKPz0LB7sO+PZ7IsBRyEE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DxJiXwST; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732885148; a=rsa-sha256; cv=none; b=Wh9iQ+g77PoKKroVwie7z6KfOxKjgOTZOkMotHwtOp75fH7fFQ8hG/4pcBCo1ci1ePMt3d Iso6Bl+KYAgjWQ2PVdLxcULVAgKS5+Pweu1duQGoxE0n6gYceE8xf8u1ZIrITNda0j+Gdo aEjqVEYqIWzbWkRyu9Kss8qTXaL7+DU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732885150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XcSCrZsrFnqSAWVc0CZcBqWIMg9FraNhIyn4BgkF2PI=; b=DxJiXwSTiR8fJ2CKV+AJLY0bbEdC6U67pSA2D3exrOe9/17VMIlz/q9m2SOnDcHQ8E0ySI rhsxVi0yjWVEv6xbVJMiT/EmYIAphZK8HaGWVCuyEN8DoMN+aDWLL8mCyqzIjdTOVoUqUA j0ACbtdDETRBIY1g6oGWjkjzbRVTxoo= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-AHkNs9hZPy6FUPUuy-nl3g-1; Fri, 29 Nov 2024 07:59:09 -0500 X-MC-Unique: AHkNs9hZPy6FUPUuy-nl3g-1 X-Mimecast-MFC-AGG-ID: AHkNs9hZPy6FUPUuy-nl3g Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53de90d54f1so1664580e87.0 for ; Fri, 29 Nov 2024 04:59:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732885145; x=1733489945; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XcSCrZsrFnqSAWVc0CZcBqWIMg9FraNhIyn4BgkF2PI=; b=Yki9dFa5nJfWGApOt1Yw9B96mpOXo7iz3Wkfn3ttiw9LzyzE6S1bWL4PZBhMaQdYmU VoFIIEgAL3Ggdd7/SOPd1Ebt9ThfohLteEzbBAKagDARCGee6ktb8C9IW73gNheEnvfI gw4lQXIC+nUEtYLPydqI1KCGfdxYrYXpECAC0zaPjTVdSSdbr5adJDgIfEf3IFIPgaS/ +yNViXeodaQBAgtdnWqRxqYxqLUdfWkyYIIJRqSqiKN3/z7I2/2VRccb0lTcB6LsyM5I /yruX1CXHbAigmkOARQHgi9mawtCkOpC3IrObJw3YHTGVk8A2o/sn0YQjIwompRvUoua crTA== X-Forwarded-Encrypted: i=1; AJvYcCV3mkouCIF1lm+zkH3Gr0NC9HJu+47eyI88kzOHBuxNzZ95Z0dc7CfA5UDU57ld+vDpX0FhEeD/Mg==@kvack.org X-Gm-Message-State: AOJu0YySXACXWKwYxPZ7x8YS1cTUvzg8HpuPUM0i+FqAPhgqh1JLvpTS K9FiVbhWRHXnSUF6j9rp101mbbwewaM89f3v98/CJKk2+OXRGaJmOf0+nAKhoRXjyxchZ+RJTmw zN7LyWAuDiwTLkX13lv/5m9Cisy0HwPMkQJCfiAXj0wXl6u45 X-Gm-Gg: ASbGnctrYshYtJV4r5p8WIeJhUvGvznlLgnpx0IXjWyKCm8PjiCLkscoBLZ3ilWJuXu PRVaOvKhOHGpd+AqLNXsufT6DECLJddNlAJUgtbXMUHwMLJIzr7327glWEeEa4Z0vWKpnyJ2tN6 4LaHuRpZhTzykmA5pHgN5e+40djMlaIWwnzJRnPU5gX0Sy9TF3ohBJ+61YVUaaBUO8SSPM0MZuD etSITZD1LiuBnUH56Tib+I0atiXE6XSdHJJSRYUPc4uRw0Rdo0GQOivW4LSphhNBCogrS8Pcgw1 9ElFAD+scpVXJxG0U45KwODDKtWMPYjw/3aUIaqEGHh/mMlxmysnoK+QDGoy9Z2bLFhVr2FdNMl 5gA== X-Received: by 2002:a05:6512:2387:b0:53d:ee8d:9e60 with SMTP id 2adb3069b0e04-53df00d10d7mr6656800e87.14.1732885144714; Fri, 29 Nov 2024 04:59:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IH2a+Juq/9rxa2Z+aXTJn/KvbqThG58N7VlCAGh1Jbzk9FIUtrc1RDMd0vxssTYZeIi6kvRmQ== X-Received: by 2002:a05:6512:2387:b0:53d:ee8d:9e60 with SMTP id 2adb3069b0e04-53df00d10d7mr6656779e87.14.1732885144199; Fri, 29 Nov 2024 04:59:04 -0800 (PST) Received: from ?IPV6:2003:cb:c71c:a700:bba7:849a:ecf1:5404? (p200300cbc71ca700bba7849aecf15404.dip0.t-ipconnect.de. [2003:cb:c71c:a700:bba7:849a:ecf1:5404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0dbf95fsm51985305e9.15.2024.11.29.04.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 04:59:02 -0800 (PST) Message-ID: <9d6be5bd-ffb9-4a27-b56d-521cf6b7486e@redhat.com> Date: Fri, 29 Nov 2024 13:59:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf: map pages in advance To: Lorenzo Stoakes Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox References: <20241128113714.492474-1-lorenzo.stoakes@oracle.com> <9f9fd840-6421-43b5-9a12-edfa96e067cc@redhat.com> <1af66528-0551-4735-87f3-d5feadadf33a@lucifer.local> <926b3829-784f-47b8-9903-ea7b9ad484ac@redhat.com> <31e8202d-f3db-4dcd-a988-2f531b14e40f@lucifer.local> <84fed269-3f82-47f7-89cb-671fcee5a23a@redhat.com> <20241129122624.GH24400@noisy.programming.kicks-ass.net> <74be541b-22ad-42b5-b3c5-79b201e28f04@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7tIsnlSS1qSDi_OORbyaXDXsjeILpdNefCaFgRDdKto_1732885145 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6B6BC1A0010 X-Rspamd-Server: rspam12 X-Stat-Signature: xqgpoedtwkugore1zxqjd3yxewou7qub X-Rspam-User: X-HE-Tag: 1732885145-143622 X-HE-Meta: U2FsdGVkX1+MnRPOorOKRKejVcsVvie77dztMNqZNezZz6Wc5kDRxJwMsgb1fTlMmbnfIhi5vc/Rd0mgvOjcGteb3Ckh2UqZuST1Ekz9VEc9C5tJ/LEVFU84iYwzshKsTux34JFRhC3yWNF/zOEqhg1yKoCKnseEQwLASymK7zLDPJYtgqwfZRZC11nurQDzmL9v6v9RvH4Xn2LNfEd8BPdvwaxA2eC89C0860DBai8t97E+w/vsw99VQ/5rIgIxyszg3ANtr4IyWKgNDKgLBQy7jnqCb5Ul/UHSK8YDGX/UEaAd8n+KJ3PNmSOIxDhPpwWObcGR6W0gqcb0dal5xXHXg+De9BnIkzysHnHjbGtfVRD+kRJeomDJdAVLQcL1LzxDy0UYt88S4cNWKFN4Rxve0tmhGNgW3PW91da0wiG5HQbYY1TcnTR6I+4l4d3U2m/Zyl4elpgWst3gFVCkBs8iIcE700EzQWmkEIk+VqSpPYsWc5mfxk9DGxoUBVz7UsyOD+V0GJ7RbRpAM7uroFo2up49zePopwdVnxQlJefPKkjlYihBzhW8tQGNpDvERY89OHp/HDiK+kAAJM9tqMk1T4kw9tIART1GH19p/xJ9JGYwibuVBcZiYq1ZauXXepYSVIr57EBqwWDWERIekuq8NwSCOeuEoI5ZemCHmmfHgurYC4iP1H0qFrPLPn3opmYCnNS0BhpIyHwYjg486Bwfz0uG8HNBRSiPFw+cC4mg3/sNlPTY6XC0vC4kUm5rEpzXmB9zEBVqNEk3TlcSLB+VfzC9Vm8b6oEmpE9CnMNfRe0iIa5omZk+p0Na5J7sN1ujitXY0FQXmhpIaFEAsw72AKKwCRMhyWLe16e1W60lptI2J9+RgiPxrfgeKLMtJFVt7MR7LCOvMfS43U28BCaAzrDzb0+GwpZtg+WKjPCua5o3Q4Ni2kKErIonTisGpeF2LelryMbpDYfWp3q FfWYgWWQ vuma1Tk5m9pA7Vxpl+1HzUjMmd6B3jkNQRdxgr//ms6kxY7b8QQc7bjz/tdBzXAlJT6dXw/DRayccHei4dX3w+iF9Ahm7JVTZW8qKmjwi/0xnW2wXmN0D9s7CciL3tVzD0pNcRjzAB5GasmBOODX4lX9FzDlCbx3Iopi1cxp+0fMNSPKbh2mm1Q9+tR270Sgv0dgIi/IoiRw1NZtRn3k91EGLneyeM0slCnfpJRoKFQqfDtZTasd5hETXPIlAQF57TJDkNMVeh/zA/3IpMyvUFPSf+J7jvtVk1ySAJ7UuzBgSppxDG3iHKbN5JslBuvhdm5F7/5YyHURHdZaUl9CJhj3S7WTIrBk/IyigEmpbTWci70aKjGy1bwEGVg4+aY0gyrG6/9SiqhcWTm05Noex3msLAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.11.24 13:55, Lorenzo Stoakes wrote: > On Fri, Nov 29, 2024 at 01:45:42PM +0100, David Hildenbrand wrote: >> On 29.11.24 13:26, Peter Zijlstra wrote: >>> On Fri, Nov 29, 2024 at 01:12:57PM +0100, David Hildenbrand wrote: >>> >>>> Well, I think we simply will want vm_insert_pages_prot() that stops treating >>>> these things like folios :) . *likely* we'd want a distinct memdesc/type. >>>> >>>> We could start that work right now by making some user (iouring, >>>> ring_buffer) set a new page->_type, and checking that in >>>> vm_insert_pages_prot() + vm_normal_page(). If set, don't touch the refcount >>>> and the mapcount. >>>> >>>> Because then, we can just make all the relevant drivers set the type, refuse >>>> in vm_insert_pages_prot() anything that doesn't have the type set, and >>>> refuse in vm_normal_page() any pages with this memdesc. >>>> >>>> Maybe we'd have to teach CoW to copy from such pages, maybe not. GUP of >>>> these things will stop working, I hope that is not a problem. >>> >>> Well... perf-tool likes to call write() upon these pages in order to >>> write out the data from the mmap() into a file. > > I'm confused about what you mean, write() using the fd should work fine, how > would they interact with the mmap? I mean be making a silly mistake here write() to file from the mmap()'ed address range to *some* file. This will GUP the pages you inserted. GUP does not work on PFNMAP. -- Cheers, David / dhildenb