From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: "Jürgen Groß" <jgross@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
david.laight@aculab.com, Arnd Bergmann <arnd@kernel.org>,
willy@infradead.org, torvalds@linux-foundation.org,
Jason@zx2c4.com, hch@infradead.org,
andriy.shevchenko@linux.intel.com, pedro.falcato@gmail.com,
Mateusz Guzik <mjguzik@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: Build performance regressions originating from min()/max() macros
Date: Wed, 24 Jul 2024 09:31:27 +0100 [thread overview]
Message-ID: <9d62cd2d-a00b-4260-8ffb-0e0e4574f222@lucifer.local> (raw)
In-Reply-To: <16f51077-f525-4d3c-92ad-8a1ccc02e4ff@suse.com>
On Wed, Jul 24, 2024 at 10:14:12AM GMT, Jürgen Groß wrote:
> On 23.07.24 23:59, Lorenzo Stoakes wrote:
> > Arnd reported a significant build slowdown [0], which was bisected to the
> > series spanning commit 80fcac55385c ("minmax: relax check to allow
> > comparison between unsigned arguments and signed constants") to commit
> > 867046cc70277 ("minmax: relax check to allow comparison between unsigned
> > arguments and signed constants"), originating from the series "minmax:
> > Relax type checks in min() and max()." [1].
[snip]
> I can send a patch to simplify the problematic construct, but OTOH this
> will avoid only one particularly bad example.
Thanks, appreciated but I am a little concerned that we might get stuck in
whack-a-mole here a bit. I'm pretty sure we've had previous patches that
have addressed invocation points, but obviously the underlying issue are
these macros which will keep cropping up again and again.
>
>
> Juergen
next prev parent reply other threads:[~2024-07-24 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 21:59 Lorenzo Stoakes
2024-07-24 8:14 ` Jürgen Groß
2024-07-24 8:31 ` Lorenzo Stoakes [this message]
2024-07-24 9:40 ` Jürgen Groß
2024-07-24 9:43 ` Lorenzo Stoakes
2024-07-24 14:47 ` David Laight
2024-07-24 8:34 ` David Laight
2024-07-24 8:50 ` Arnd Bergmann
2024-07-24 8:44 ` Lorenzo Stoakes
2024-07-24 11:05 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d62cd2d-a00b-4260-8ffb-0e0e4574f222@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=david.laight@aculab.com \
--cc=hch@infradead.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=pedro.falcato@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox