From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32D2C3DA47 for ; Thu, 11 Jul 2024 10:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6BC86B007B; Thu, 11 Jul 2024 06:20:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1CD86B0085; Thu, 11 Jul 2024 06:20:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3786B0088; Thu, 11 Jul 2024 06:20:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A0AAF6B007B for ; Thu, 11 Jul 2024 06:20:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4BBF9804BC for ; Thu, 11 Jul 2024 10:20:12 +0000 (UTC) X-FDA: 82327076664.02.DA3A6E7 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by imf02.hostedemail.com (Postfix) with ESMTP id 3372880005 for ; Thu, 11 Jul 2024 10:20:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b=cXPjEjX6; spf=pass (imf02.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720693193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VusCKtflooo5piJ9a0SJFPaccOcKM3PeICzYGrcI0Yg=; b=QD3PmMuQTU6C9UZXj8+IgQW+bkNokK7JsnEoqRZVDRDMvzmTTjMT1MPzPonyh2Fmzs83ct hDsSWXbXYIORJNJ89LemdGjFb+2lVQXfMbQ029aWZaZML0PLZjyTv+o6DkvGMyDS0GLijR KKwD0frab/MXQT+PYRSGsv4FF+FgxXg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b=cXPjEjX6; spf=pass (imf02.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720693193; a=rsa-sha256; cv=none; b=o+2BaK7fpm0RS8Ica8OrrfyyHuL8P5diGCUXo5h8VfjA27kTqLCyi6M5PzHclumDh5gYUd YadeektATOLzbyGXtfL0wvPM0rbQadrwypEpMT2ODiqQuvWOfgRj+ks0G6XHRMlD8vYUFy PLELtja+i63vXL2/mgSjwalg4aploxk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VusCKtflooo5piJ9a0SJFPaccOcKM3PeICzYGrcI0Yg=; t=1720693209; x=1721298009; b=cXPjEjX69+etutzbjdLs721qau3Zdvy8ZV5sdjruaGnEeA+TsTT/u4t3BxdZhixy+9gxDJVdEsg 78NJRXmzIWgOD2+5T0mMa/llESDRqA4FV0AnufWC8eRpGe/aCQ0dTEQQHZAzrzDyJgpuxDvNUFQo5 j2Nd/h+potlKNYh683nYUFO4BMYwAeiWnFXwqUwdilqLPDG4mF+ZbaiMgrCip748BYL0vFmZHd/pP hWZ9S0jpEnZbOq82OVqeRL3JpygepW6eMYM/biGF829tuYaupCrkDS3vFe9rFw4nFLqAXAfaWDjem wDQ1fxVX37or+9+5AW8VnApIGqbpCd+tuslQ==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.98) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1sRquE-00000002HC1-1wfa; Thu, 11 Jul 2024 12:20:06 +0200 Received: from p5b13a475.dip0.t-ipconnect.de ([91.19.164.117] helo=[192.168.178.20]) by inpost2.zedat.fu-berlin.de (Exim 4.98) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1sRquE-00000000zJz-13jO; Thu, 11 Jul 2024 12:20:06 +0200 Message-ID: <9d5ea8fc23eab6fa6c1c444a5052cd8c5d4b513f.camel@physik.fu-berlin.de> Subject: Re: [PATCH 1/2] arch/sh: Remove code that handles memory-hotplug and memory-hotremove From: John Paul Adrian Glaubitz To: Oscar Salvador , linux-sh@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Geert Uytterhoeven Date: Thu, 11 Jul 2024 12:20:05 +0200 In-Reply-To: <20240518115808.8888-2-osalvador@suse.de> References: <20240518115808.8888-1-osalvador@suse.de> <20240518115808.8888-2-osalvador@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.164.117 X-ZEDAT-Hint: PO X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3372880005 X-Stat-Signature: i9ynrtz8zbxi8cyyxt6iizi5hfpajpen X-HE-Tag: 1720693208-745356 X-HE-Meta: U2FsdGVkX19PNiQxOos/kpqmHxYoDMGnEIdaMolhyoFOxgDC0fYfsUWXUZC+DC5orLuRIO9QRfsxNDRuFNFjdXkdEh6QUkc0riIAkkLW1IW64moId8B4T+QmAS2ACITPoh44cMVBWZVy83jFah9Akwtwc2nbQBiKpHy7T4QrdaEwP4HgdR7WWd6dhm0gLxPSBBfqQrZasXBkruy5/OdXGp5C93rqwZeFahxdzqEqZZfBFWkR83CbT6TBnLpWp3IwzYBuEb8E6RrLUFaQav502hTlZqTcZ/3AB7hpb/XIbnmXfpqia6CkX4cNxDctxf/A6ZaDyy+sf+3TxSv20bunUhcdE7quOYIg1GVCjOdlgoF/TtCViNV+SeSI++iOiRCNk3XevvnvmmjMGHeAeRL3YgTE/Tkn/kCtYjYNnfQqD81zuHvEJLdqFF7BD35a8Yz4Mos/4d4N9QPxhTrnpOK/YYwMjv/8EyIo8niHVdnFXw7MHu0VMnltYcGoY5g/L/QJLyg0YsXr8E6A7AMXbCWTYjY7JmqTsn8wgy0c+qXimviL5/9R5nkOTSAjwtKa5ZTuH+cXcQdFs6Omfp2lRtrBAyPKWmlhuM0lZ97iYvhwOaoM/UDp3fs9D9BVdDQ/VCj4Un5dsb2dCyF+MpkoMOlsrA8jmiTRTBjEoSeJeMt6NGfZGNlQP56gp8ivMDQGAf2xHoYaDJNavoM3TE6pcd4ZJFxme0Y6Wp5w8XN4Eg/sVRYGUqrsatuGKQ6qwXSrAq4OfaOSBUGXusNy/SPf2hO/Vty7kqSdzd6DfftqoU5lSLIy2fZwZZbjLtBesmSnVm3enARLElolxKvIhUT/cwfp9xyvSA96TEgCoGyU64P/V+bffWppDmuhkVnwJbzSChfCegBX7NhlpO9WQnyFExaP3WArmOpPD2J/KryqRqGAagtqRkriC24NTf38IiTW6ZAEIHO20Ygo8XN5xnqPPNs 6p0SJXsu /MHI7YpYnHbFEr68PnOUkEb3ActiBXeOXofIb9LK2jTdM79gvbDnkGrx/JqyKDNZARtEgdSVDVkYEMq1Wf3CaFCg9Sizgsauq2oWReDULcmnLf7RVjaNBvtS1hwI0I6s2tXSnulXF0KTqBF+FOml+wGxozcLCQejeeEJy636aXGd16wq9t/NFeAGKVkYqWs1P8oI0XxeDGbnSkBNScN3v2W/mvkmsbSmiMzBbV60AqmemQK3arWhCB3sXjhUsWZPjYcZji/fAOdJnB1XEVxUHRe6MjWYRylPb7nvXnR6i+/LvJU6IGkgZumJ4icOgfxmd8CJbDS9zWtM0LGPTVFdRwlpnSXuvmly7DB/emBjtue6rup0sZhm6twRrIw9FbDnxG3vDXK4SZuF/5/ko8etbcULgTajof0ElQRahKL9AsbgfgEh3yhtcQSXhCKecZ6OL7KzwkuV2SrtlhJM8r90nfgtA5y5XkM4hkYz6otUdWIPNnscXNod7tpsvX/EPifxd4uME X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 2024-05-18 at 13:58 +0200, Oscar Salvador wrote: > Since commit 7ec58a2b941ed889("mm/memory_hotplug: restrict > CONFIG_MEMORY_HOTPLUG to 64 bit"), we only support memory-hotplug on > 64bits platforms, but currently superH can only run on 32bit, so > remove the code that handles memory-hotplug and memory-hotremove as > that cannot work. >=20 > Signed-off-by: Oscar Salvador > --- > arch/sh/mm/init.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) >=20 > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index bf1b54055316..d1fe90b2f5ff 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -395,31 +395,3 @@ void __init mem_init(void) > =20 > mem_init_done =3D 1; > } > - > -#ifdef CONFIG_MEMORY_HOTPLUG > -int arch_add_memory(int nid, u64 start, u64 size, > - struct mhp_params *params) > -{ > - unsigned long start_pfn =3D PFN_DOWN(start); > - unsigned long nr_pages =3D size >> PAGE_SHIFT; > - int ret; > - > - if (WARN_ON_ONCE(params->pgprot.pgprot !=3D PAGE_KERNEL.pgprot)) > - return -EINVAL; > - > - /* We only have ZONE_NORMAL, so this is easy.. */ > - ret =3D __add_pages(nid, start_pfn, nr_pages, params); > - if (unlikely(ret)) > - printk("%s: Failed, __add_pages() =3D=3D %d\n", __func__, ret); > - > - return ret; > -} > - > -void arch_remove_memory(u64 start, u64 size, struct vmem_altmap *altmap) > -{ > - unsigned long start_pfn =3D PFN_DOWN(start); > - unsigned long nr_pages =3D size >> PAGE_SHIFT; > - > - __remove_pages(start_pfn, nr_pages, altmap); > -} > -#endif /* CONFIG_MEMORY_HOTPLUG */ Reviewed-by: John Paul Adrian Glaubitz Will pick this up later today. Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913