From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14FEDD1119B for ; Mon, 4 Nov 2024 02:25:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57EBF6B007B; Sun, 3 Nov 2024 21:25:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52CDC6B0082; Sun, 3 Nov 2024 21:25:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41BB26B0083; Sun, 3 Nov 2024 21:25:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 244306B007B for ; Sun, 3 Nov 2024 21:25:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8B901C0EE2 for ; Mon, 4 Nov 2024 02:25:41 +0000 (UTC) X-FDA: 82746820128.13.BD2CA47 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf27.hostedemail.com (Postfix) with ESMTP id D49C740009 for ; Mon, 4 Nov 2024 02:25:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=MtFT97g9; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730686920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9cmlej8OATRi4lM94Y98/vOaVDU8BB5/PiYbgOOWY8=; b=I2A18AOnGaHJ3/32c+xqqkV3ajnoaj2kzS30xsPjpBissPdde8Hh9fJYgFiOGMOVKQvpnJ rTQSYyjMPLAgPnAieWNAjzyAOO4B/pFqeiaYloWmxY6oy+J9jc2EWDTy0orgStDoXuxfM7 J2/qZz6Fzh8PB2+G96GgadJxA2vJzrQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=MtFT97g9; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730686920; a=rsa-sha256; cv=none; b=XXeCZ4rsYmB0e3brTmBJ4BCX1sxaIjaQyhFT7F9quAEcwQskuuK6KTJQ5Rr85FSFN89bYm EUrW7bEsxb2Q67OEeV+haqPDzJjHwpUAMhsMtjNmj/nvysDRX7y/Pbn15yXWj2jZDkyJca dpIt4OnCXembw14SAA0aK2MLlU/amtE= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1730687133; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/9cmlej8OATRi4lM94Y98/vOaVDU8BB5/PiYbgOOWY8=; b=MtFT97g9bmehaK/UC9WfYHXBMSQP0+FK/c1NWvF8eG6baDL2ppt1e+yXqlkR/sDl/gmCOb+9kjUXdg2fPqgPYKgM1XZQewUdo7ZEKYPEtA1TEiuclHEYLmzRP4hl/SpEWKgKTX7FRy7OYesVHrx+mbaFurALfLdz1nUqowpFbE0= Received: from 30.74.144.113(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WIZl5VU_1730687132 cluster:ay36) by smtp.aliyun-inc.com; Mon, 04 Nov 2024 10:25:32 +0800 Message-ID: <9d5ce0af-6fca-422f-b1f8-650879f8ff5a@linux.alibaba.com> Date: Mon, 4 Nov 2024 10:25:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] mm: move ``get_order_from_str()`` to internal.h To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , David Hildenbrand , Ryan Roberts , Lance Yang Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241101165719.1074234-2-mcanal@igalia.com> <20241101165719.1074234-5-mcanal@igalia.com> From: Baolin Wang In-Reply-To: <20241101165719.1074234-5-mcanal@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D49C740009 X-Stat-Signature: 68nzzzzq68p11mymshns45zsqisuttbj X-Rspam-User: X-HE-Tag: 1730687105-424289 X-HE-Meta: U2FsdGVkX1/PdgtVUQXzo6Ve11LpYguDMVcrJU3oZ0PmyLSyNvxZ/+YUpxs1i9lRRhz+W05PRUoUUNqyxgl+925t8gXp1b2ErwohHQVDTkL8wqU4k/304QG4n1AvpzmVWl5+j/KZKpt6yzAoDGIDXKFIRIknn0fj8oLuHpdO2DqbKht91XkHoIOGCypp4UPgam93UYxeuvqogSbTaFyVDcWo6iqVjqQ9vFRwwrpxF48buZx19dFrvgdbBRNnHPxBRE+oNUUeI0BtyA5NyHsfe7vK6F9uLN04BE8wlPEaza2e2aSt7/xmUHRRDZqkaRUdmtPBlALagnYRiuHrNxDveG22thjbrYIls4fRtUjd0POLCS7LOBH9QN/c/Fd5+F4RAkqDxbq+sfZ2uB7z1hCtsuXXwRL0ZZoXQUVJwg/mXKUm0fpmvjnQJkmqO6wB9EuoG0RGImTa6e9I3bc96hSyG93EC1zOg8BX/FtsGgSY3i/1plIoxgTvlX0Ez7Xtx6sxFG5oEjsaQpLhBPtzcfeLhrXdZ9oXZXApvNPRwBLfka57kul4J5G6HyKX1BseYWu8iW1D4yeIROwaiiLaq+VBFRHMxD72jIN1j8sYvkV/Voz86dWFoj06RnOYr32/aFp5U9kAg2+OK9PV7tSS3yvfCOLwIaO9Cl2LO4Lu9WUvLVGqzLica0ZnYQrDB0scRHPCh+kA8R8iuuOnpOd+zIKrp2ALBturx1Fsfq8Zq5fhV5SpuNdtUrLwBRtDLb83ljyyAGD5NRi388/PzKsS0wlUfu+4IxRbWIG5U8sq90xqCTN2acF1O1Q3DnNfr9TKXZgZTuZkJG8izfTphgBaMsqUfkieI4WTsnxY1Brcvu5iFpXwIvCbyrD63bMjA//446zgeb6as5G3PJmER43iKf9W7pKFhVn+KaSEMjxIBtKpN/jnY4ltVov0d9pOsgZYlWWkQXAyf0eYNLyicvQwMl8 nrPoOrQR H1HyLaiW3QY3H0HNrL4yY0X40yEQveyfnvFSDEci4WglWFYcT13iSkHa7jfKYiBb/YWLphLPbFPjfpDM66Dh8hXtgAj6ZvVAJu+Wy18aPxtaO6DSYOrJqavpmSaARGhF2AQT2tz2Gl84tzHNcTI5vGxIhRZWKb0c4QAYu5W1RnXp/Y47VB/uEhVSEmblcUtrRLxYhSior+468JZVxoKuBTf7zkzEyokoU6OfVBfLw6MK/Sisn3S40REuz/0nuZZ7jZIxTwGbQZynv6F9dLW9sOJg98ZIF65MxcklSamhKcuuPPpYe3sGlNg70B1YQQy6fqqCrxMvHtLSZVMiM5VX4pnutvlySlibxTFLiUCfROEsXYDQKEjjVwYzgB7SYmSdzY8UCIa6k3WhQxjxhuGCZBDVbAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/2 00:54, Maíra Canal wrote: > In order to implement a kernel parameter similar to ``thp_anon=`` for > shmem, we'll need the function ``get_order_from_str()``. > > Instead of duplicating the function, move the function to a shared > header, in which both mm/shmem.c and mm/huge_memory.c will be able to > use it. > > Signed-off-by: Maíra Canal > --- > mm/huge_memory.c | 38 +++++++++++++++----------------------- > mm/internal.h | 22 ++++++++++++++++++++++ > 2 files changed, 37 insertions(+), 23 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f92068864469..a6edbd8c4f49 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -958,26 +958,6 @@ static int __init setup_transparent_hugepage(char *str) > } > __setup("transparent_hugepage=", setup_transparent_hugepage); > > -static inline int get_order_from_str(const char *size_str) > -{ > - unsigned long size; > - char *endptr; > - int order; > - > - size = memparse(size_str, &endptr); > - > - if (!is_power_of_2(size)) > - goto err; > - order = get_order(size); > - if (BIT(order) & ~THP_ORDERS_ALL_ANON) > - goto err; > - > - return order; > -err: > - pr_err("invalid size %s in thp_anon boot parameter\n", size_str); > - return -EINVAL; > -} > - > static char str_dup[PAGE_SIZE] __initdata; > static int __init setup_thp_anon(char *str) > { > @@ -1007,10 +987,22 @@ static int __init setup_thp_anon(char *str) > start_size = strsep(&subtoken, "-"); > end_size = subtoken; > > - start = get_order_from_str(start_size); > - end = get_order_from_str(end_size); > + start = get_order_from_str(start_size, THP_ORDERS_ALL_ANON); > + end = get_order_from_str(end_size, THP_ORDERS_ALL_ANON); > } else { > - start = end = get_order_from_str(subtoken); > + start_size = end_size = subtoken; > + start = end = get_order_from_str(subtoken, > + THP_ORDERS_ALL_ANON); > + } > + > + if (start == -EINVAL) { > + pr_err("invalid size %s in thp_anon boot parameter\n", start_size); > + goto err; > + } > + > + if (end == -EINVAL) { > + pr_err("invalid size %s in thp_anon boot parameter\n", end_size); > + goto err; > } There are already checks for ‘start’ and ‘end’ below, and will print error messages if error occurs. So I suspect whether these repeated checks and error infor are helpful. Anyway, I don't have a strong preference. Reviewed-by: Baolin Wang