From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E484DC3DA6F for ; Fri, 25 Aug 2023 07:35:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57ABF28007F; Fri, 25 Aug 2023 03:35:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 505668E0011; Fri, 25 Aug 2023 03:35:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A4C328007F; Fri, 25 Aug 2023 03:35:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 268318E0011 for ; Fri, 25 Aug 2023 03:35:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EEEA61A04D8 for ; Fri, 25 Aug 2023 07:34:59 +0000 (UTC) X-FDA: 81161815518.24.85E8357 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id C739480006 for ; Fri, 25 Aug 2023 07:34:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jk4bdF3q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692948897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3hr5ed3v5MB4RdD55ipl/lNQ6Huad0rgnV+APlqR6H0=; b=HDAvhuEWovOy0aK/VmdYmE55M08KQLv46M80X2aTX89EZuNpMWtui/j6ds4HPSOJmC+/sr RSvllp7hUfQs3CQoucyfJriLflWHzZ+SuES2JwrJYiFpIMQ2aemP+QOPNQfqWeRrZF6udL RbltcixMSkeAhC/lEaRGOJMzI4a1EyU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jk4bdF3q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692948897; a=rsa-sha256; cv=none; b=FvptnokiLpFwNK/o/kWuYT8MH816tDkiz1Oh5+yi3JXF0BEQ60BPmmymSEm2zbqkDYsGsJ V+ODlcXlLOJNHPpBOr3T5ygM1leasahmGdl9TgtFvq3pvtwRnO/t3DkReWX2gteuCRsHDH j0Syf4y9Aff2JSQHcrz16zXjpLnGKPE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692948897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3hr5ed3v5MB4RdD55ipl/lNQ6Huad0rgnV+APlqR6H0=; b=Jk4bdF3qy0EiF1R98JPy1zCRbaSTm7db50HDYuHp2WGXjKuz17UlpjuUcD52srcgGFD0Kh JWAUiEuVx80GrMgBsrBqwgrF/X7b1TROk8+gd1As/Y8mO/S7UJkpNaI96LTCjbxEHg24Hu B97tUhBUq27lUqBa/SW94ysqDxdLsZc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-TXEY-GplPKmHg6Tg9bpIxw-1; Fri, 25 Aug 2023 03:34:55 -0400 X-MC-Unique: TXEY-GplPKmHg6Tg9bpIxw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31c5c47807aso473919f8f.1 for ; Fri, 25 Aug 2023 00:34:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692948894; x=1693553694; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3hr5ed3v5MB4RdD55ipl/lNQ6Huad0rgnV+APlqR6H0=; b=IPm1aVBWsa1lCwL/t9izclE7gYiMzD//h4ce6c3ZQOxEiMql0Bc1rO/Tk+P/eBIB2a /mUZwwLPNbuiLcwWJLTYhVRbepBKm8za1HxSWa8OtLvo23B97/CYYuLjjZ1+87FhrUMS 6ipiicelA54IUY4RqiAWbwlJwHGoKD8rZTQfYLBxLAQMUgPPeySWWFhWR7KI5XiW72rn CuJt6wMZw5VpGWX/AKGPSE3Sxu8qZ+YEWpYa68hiufh4VhdlRCw0v/jK41oCD2Guz0qY 0OTT6eyJwLCawQN9wszQW4pvjQ5DwVig7si8Kf7hfyeL5e76WjGXlsDNwyff6rCRYS9c 8Auw== X-Gm-Message-State: AOJu0YyXggDGonou06LF9ldem691vuKyS3i+Wn2/VL1eETFIeyU7qqnR 2q/GoNoj2W+MPZdj4WLz0AgoMFn1h/o8eKNFwVq9oXVeBkI+JI+HD5wlxKHvYmXtKzGO+Mn0Hrs jT5eZl8089i8= X-Received: by 2002:adf:ea81:0:b0:319:67da:ed68 with SMTP id s1-20020adfea81000000b0031967daed68mr14045898wrm.7.1692948894570; Fri, 25 Aug 2023 00:34:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIpQ1nfAQupYXXZPrppUT3I3qztcxsAxsv4Mnn3weDxbLdcqRhZ7C+qXgrHcgLJ88bzX97ww== X-Received: by 2002:adf:ea81:0:b0:319:67da:ed68 with SMTP id s1-20020adfea81000000b0031967daed68mr14045887wrm.7.1692948894209; Fri, 25 Aug 2023 00:34:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4? (p200300cbc70e9200ce93b5e68aa965d4.dip0.t-ipconnect.de. [2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4]) by smtp.gmail.com with ESMTPSA id w4-20020adfde84000000b003143b14848dsm1369585wrl.102.2023.08.25.00.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 00:34:53 -0700 (PDT) Message-ID: <9d4d0643-6a7e-22bf-1f54-19646bb7231e@redhat.com> Date: Fri, 25 Aug 2023 09:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() To: Vern Hao , akpm@linux-foundation.org Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vern Hao References: <20230825040848.1542-1-user@VERNHAO-MC1> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C739480006 X-Stat-Signature: ib5dk585d8y1yze8kxnfc7qfjn8js9zf X-Rspam-User: X-HE-Tag: 1692948897-116151 X-HE-Meta: U2FsdGVkX19ZWD/a5UNwznHqAL8jk99Td7k+UP7tYYlteXCJlV5OV3m/w60+S836qvfokjQgMUjzIVYDUOiEdJoXboOKPeeGEy/cFtcMRrgIxCjsuSc0MqYxnmd5gpZ+3zpz0yA0EcnAvGP4jjjxfWE0FbxPC2CZkYG/jZQww++hheDp3eU8sSj1zzWy5PAksgyj7xBhuQ7FfQFCJd77oTUNxs3H6o2EJ3IsXhy/9xm0SAAOarLHhBiNTcgRG9b4t47YFrUg7NfkELlPlklAzEqhHauRUKL8qd8kMvTzgCZF5vLdCB0/Nkc9wv5FmdpyQJ7wR5qbU4ZZQhVd5hAM3CrIH9yZzRrg/FUOFQ7zgyiJbqAoKKPAxYIhMXzJZb46wonAAlThAys1ePHOaizIbKQjMl4Ar0ND9c4tWyDHfyF/Scb+9o2wfVhbY69gtm7Zx4j6ySlFeiX74mt0xQ3HOBzUaYxchVaZmTLbFOH2OqbN6pl5XsigKJOCbykSeTKsxF2y5EhnPlBRyjqLNhbrXLLzRw5s4TLBkB5oeDQPxOBR3gFlybGpW/U8zNmHCBOYeCVnAQQdI/6Bm93f9sTadd+cVLztuqG/DHGawF1ACdxfbuYt2Z5uIVupGptfuDLRgQg3AZ8kP36WS4fnSmXCNZ/5YObwyL4/1Nq305nj1gsnaQeoUQxXBrXn9flKbi4DTBqTG4KoCTNu0Eh+fRHkhmfcI2SLxyxNmEQNn3a4bTvwwjQ8fa6SqxcA7nKourkLLjPP5Z2XA2CrY1c2V+W5O+C7cIB4b/WTmckv2UXSAxufgxZm3Wq/gi33bUBlyiMQdGwDiDWt3QBHUTmWFC/KnfZEqyEVijwFZTBWKs0zFtF7G1wom67O3bPQU9Zj7A8ZTh4107sE2tJsEPrjFMMsQOx7OKcIf/VHXRP/N++NkADJ4aB2kv5mGVQTta/cDQPUK878Upp5kSg+xvtClCP dnRhS2r5 7G07Q+w/+8D/1zXMsQXCMKd0KOwk4EtfZ5ePr0q4ZtjEWZNNJx2ySCvWEl6wVxShiyRENjGMOU1o/mefoks+oIfjXLsnYbJyxBe2MR4t7mShvujLcC6+IcWnKsLijP5mvyu4ZBNXypok3WPBEpJJoaP3rK0qOaBbHaGzoB/28h2XOeLUVF0iJKeRVGte516l8YYxgUVLR8z3kXQW9w4kqPDlpPMyIkuP7a+kLjWi8osE4tQA/p9yIa01Glbf4HPUahF8wrVnC4cMnps7vs8JBvSeyE3ucz9+WTi3Ks2NPx6UXWcZKAJEzONASvUOgvEF5d67sL9Wv79kz2zfyxCgynUzJSAkYVDdUkeIir3TRvnP7aoZRJ9tL53zGlMb0Oy/9rfXFaYXyVK+4dDp3EfYRp+ftUqfUSlMahi/oHwMiGzaO9GTbXaFMlpoaXb8QAekxgWQAUzP6rYwPIfyh+2+YRmKeXAOALeyQMI+zbrd8AM0Z90s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.08.23 09:31, Vern Hao wrote: > > 在 2023/8/25 15:12, David Hildenbrand 写道: >> On 25.08.23 06:08, Vern Hao wrote: >>> From: Vern Hao >>> >>> In skip_cma(), we can use folio_migratetype() to replace >>> get_pageblock_migratetype(). >>> >>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >> >> Why did you think "Fixes" was a good idea? >> > The skip_cma() contains the folio argument, and the folio_migratetype() > is already implemented in the kernel, so I think it's fine to keep it > consistent. If this doesn't actually *fix a bug*, then please don't add fixes and confuse people looking for actual bugfixes. See Documentation/process/submitting-patches.rst -- Cheers, David / dhildenb