From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCA0CD1284 for ; Tue, 9 Apr 2024 10:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3CD36B008A; Tue, 9 Apr 2024 06:58:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5A76B008C; Tue, 9 Apr 2024 06:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C188A6B0092; Tue, 9 Apr 2024 06:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9FDFD6B008A for ; Tue, 9 Apr 2024 06:58:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5FAB61C052A for ; Tue, 9 Apr 2024 10:58:48 +0000 (UTC) X-FDA: 81989695536.07.47EF09C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf28.hostedemail.com (Postfix) with ESMTP id 3C0A8C000B for ; Tue, 9 Apr 2024 10:58:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M351zSlO; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712660325; a=rsa-sha256; cv=fail; b=LWqt316h9zXXrCeik7SPlbXBEAOCezXHrKSbGOkbf2V52lSx2MlY0usf+aMkziFJLCsQQx o2LXrSWV+TAnoaLK/CC2jq57en998kTUm6vsKBS287TlQLk1+UWEUjoaSTLbR0iOoOUnf2 XtGVQZsFGA8TcxqlCuuDQ7wFMHcpAd4= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M351zSlO; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712660325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsNW3H704rSIqhSlBrVKfNm1dsPDCpc60fnt7V3eoJU=; b=IXXk6g4DM+hio8SYbrSRdlVwUKEwX1ODpWPKf+UE/VjOPnkV0MimSD91pTuFyM0lc9A0aA YFQ9bFOYaXSuHPHguT20cu3SXG+gIO9gh7pPzMBxffDtF5RxSDKakfUMpBNj7zAjbj1QiP N0Iwuw+wx42edLdONuqqGTgRCVJw6aI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712660325; x=1744196325; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=IEjYMJmQKerwtw+1zankp8cn6NjIFNhy+YVMKJCp9zc=; b=M351zSlOiW8ZG04MIADw8HW6wvwGpK/ODHoDQgVyZhs7P04DcG6oL3yA u5RT9qa+Xk17QN2hJL8UZrSNKjXP9xuFAMTxHw+E10jMhPirHKCtEuxgz 5pCembjl0zVpkIBAthNfZ/pha7u534PnX2S/dX2CUmcNMlu1K37Ex34HM CGOaO5q0SNlHWtHNQe6yRFZmpg36oYWGqqD5rILcXVQb9ySricgP37mov Ca+1j/TfYklHYTx+jM1mpQR48MuLu82VBKJkWYjLdfm1V1GJTW/MYI8uy eGxUnMfDWrXHNVUzojw5Sb7tviOyxlc+7z1/nc30LOp7eMJGi58bS/7h3 Q==; X-CSE-ConnectionGUID: 4f2olID6TMKYwMcpxziqzA== X-CSE-MsgGUID: vOJ0CT2VQT2znk3P7iMZwg== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11763515" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="11763515" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 03:58:43 -0700 X-CSE-ConnectionGUID: Cl3V8PrSSCypcFfEI/DHvQ== X-CSE-MsgGUID: tsl+h+B3QBGOyPQH9Skrgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="20082229" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Apr 2024 03:58:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Apr 2024 03:58:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Apr 2024 03:58:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Apr 2024 03:58:41 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Apr 2024 03:58:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAvXzt2RGbtp/uW6njiAmpc0brLeXdzuFHWBFtAn8zYjgPG9BQJTBKhf/zP94Ctc1v/ESNIV3V+gVYx2HlX8BB0M4br/BXHVHDeEXJCrsAU3Myk22JpiIFwuaP8MQV9YHqxyyGrOIJNGV6BAp0VR/PzT8XA3KGOXV7/MLsFmPJ29OHcNGlS5rZ/8hMCTd5UtqGypbGlwSwWO0fl7HWKTl8KoOj0DhAGJNPRVys8jI9/NSZAs7Ir2Nm2xGIYfeO09yastknhW92eklZKeM7li9JA24JVCchoj5djupKQk9GM1Xd9WlOuHVs/6gTCUE2Rrtu9SGE2vSW82uHK/MzZpLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OsNW3H704rSIqhSlBrVKfNm1dsPDCpc60fnt7V3eoJU=; b=NEjDi+gk9Lh1qugkbNhuiJ8J6w7uho4WZ2AOHBLPM1KTh08Ftn+FzKOYf9Uvc5Bwxdo7GRzGbx1z/ltghieJghfZNmVTW8Jr9A2/gNKVH0/wzqldDQeWiwc/U8vtKb984DuxJp3Jq+XeB+zeVhZyse2qEd/JwAxdvIOex+Pt3ltdraH7AkJ/vsVd/e5FTtI131nqpQmB34IJoA0rDI5rcVS2jhQFGjS/7pKwNxrfIRbNB8ON8W1xCx52jo5IMs2fVN18/02RGTmJxBP3/0dA4KC9KQdgRvaT7TJCsmbxCwN9GNNVQB4tV1WRn8BcULbdgqb//xmx0B1OwZEIfh2qJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by LV8PR11MB8770.namprd11.prod.outlook.com (2603:10b6:408:202::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Tue, 9 Apr 2024 10:58:39 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf%5]) with mapi id 15.20.7430.045; Tue, 9 Apr 2024 10:58:39 +0000 Message-ID: <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> Date: Tue, 9 Apr 2024 12:58:33 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management To: Alexander Lobakin CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> Content-Language: en-US From: Przemek Kitszel In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU7P194CA0026.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::23) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|LV8PR11MB8770:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H8N4Sb8e7DokwMxTgqCdfr58NlgGsVjcWmaFgx+ZxrDCPMsZfXSxKSTesqYp57t2fcVSio5J8H4yOud65ZYyT5PU717acECoGM80xP5QqOKWLAum0uzesTO+EX4RZ725+PBp/Ut76ijK1+AQKYb9HHUgfKo6VDMd3ZNtdAILNjSnII9QwMH1IbBTIQhooPlQsmlV8RjACYAY+5Hq04mYAbLYVcVSd30bUHYD3Gt7HA82WgpeM03peEM3V3cGX8MWygqgXumEkzwKwW4IxGKxoMvTC3qXPuTKlHu0zOLYoj2LAQA55nfp+FwCLkbzXF7CKjd//DG6oMT9rBlfaPQLu4NjmvtUDoMIwFb0wIH4IQ44XWe4qoJKwWkIgNia5gInDoOQtcmCcDtjgVFn3wDIGjUH1PsLNliWUHrRg2g9L2gjgRue6jTNCjg5yAWnwGBJjobziLuucLaWf/78HIgqAWOLg5AID2tWaF+QMqjrAp+GwsukpcAjUuCLOR2ti2+h2PRd460Ki8WetXpjATZG8gaQHn2JY8i7doKWjCjTP0v53RZmR+a2tfhe0bnddeVrYgSzwm27wKp40S9qu7FhRYtaQXGBFNpxnAOdkfuUEI8BcrqXo3QhTpDiX5jL0HiFqvHxN31KatfXsr5urYSex6wziMKDHHxQdaIiiP17crQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(366007)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yll1Risxd1lDdVhNV05OZy9NT001eU9IbHdVbzJYRmNtUVl6b3JUOXhITTQ2?= =?utf-8?B?Tk9oa1VmbHNCV3VPMkk0NzdpTGlDQTRTaWx6R2paZUoyYjE0bDR6ZTJvYU1P?= =?utf-8?B?SjFCajJIdkxycUQ2WThrZEdVVTlzazJXTElzSjR5SDA0M2hiemMvdng4Mmd1?= =?utf-8?B?TjlLTS93R0cxWTAyUFRRZFBoQXZCU0syWTFKRjB1UUpmdnBHQk5qOUg5MVR3?= =?utf-8?B?RDB2aXgvdGV2M0VIQkVJNkVmZ2FxMmcwaEVybVFzOFEvelJHNUFDVTRiSHZE?= =?utf-8?B?NU5JQWtCVU9mMGRjWGlGU29lUDZQU0g4OUVQZWxTUWFKVVJDQU9DYzdiUFdG?= =?utf-8?B?QmRpS3ExY3QvYWE3QktoUHRwNCtyb3VRQ2xBV0pIdmNydjZlYmVjQll1WG9H?= =?utf-8?B?OUFRdUxISllWazFUV3BLM251QndoZDBNLzM1djRWZENjMi9waWJlVWI4SFhp?= =?utf-8?B?WHFlbUdsV2FESkhCczZ2ekN5T29JNHdQSi8wU2RGZkFvT0tPNVBZTmoxSm03?= =?utf-8?B?cTZ0ZmRsYlVTb3ZoTC84Zmd3RXJlVEllenI1TG84cXkvMkdsaXpPV05iVlhq?= =?utf-8?B?STZVUTlWWUpkSmw4VTBDWjI5a05XVGhyVVZEKzUyNG52WWY1U1BiRlpXRmpo?= =?utf-8?B?WjFzdmRoY2ZGTXBHTzRCczFLWENRckRFc2MvSjZUN1FpWjUvLzNuZlpPeWor?= =?utf-8?B?TjJ2M1c1MHFvK2dPcHRjMHAvbG9wSGdyeXdHeUltSTVobHdxNzRJbmV3eDB1?= =?utf-8?B?dGZHUkhaNWIxRjQ3QjAxbGtTWXlOUVY3M2VuN01ON0ZRNVkxYnJiOUxzVkZk?= =?utf-8?B?a3g3M2N0cGE3MXlseVJPaklodGJqclhZZ0gvQzVEbnM0c29BaFRza2IvMUVk?= =?utf-8?B?TWsybFdBTjk4MXFJMUlwbEt0TDA5M204ZjNpZDIwUkhJN2QwTVRrdEptekNi?= =?utf-8?B?bDdqSHduaXZHNFhkV24yTmd3T1hnMXYwVjdZUUJkT0tWdEYrMndNQ0pVWXRk?= =?utf-8?B?YkRacEN5eHBINlcyVjBYd3RybWRFcjBsNDRyRzVkdGdLSDZuQjkyMk9rRTlS?= =?utf-8?B?WlNBU0NmancyQzFPVG9vdVpnVFRwOUNYZlZPdEdxM3BpSUh6RDI0Tmk5TlVh?= =?utf-8?B?V2hhQ1BiSytFc014b0dWNUcyc2JFYW50TlRYMWNkT0JBeWlOZjgrTmdPVGpk?= =?utf-8?B?Y2xqMnBPd1hsM2FsTDBuenNJcWhWWnY5V2ZFVUk0Q2ZqemdPa1lmditEYzZJ?= =?utf-8?B?ZllOdVpabDc1d25OOUlTUEVWeTQ4Ylc4RUs0OXREVzVXcXlDTzRlVUtYVGcx?= =?utf-8?B?TTJtaVcxVkJFR08wTXM0bitVelBjcVU1SUNUcWpUOXNqL1hhZU1mVmNjWGY1?= =?utf-8?B?alBpZklpdlNiQXFFQWt5T2ZUSmRQbWIzOERhSlFaLzVFSzlmZ2JnWUZRT25z?= =?utf-8?B?UXZyMGt3VlpPUkpiaW8waWI5c3RKQW5vTU14dkswNjVaVTljQlhCYWZmY1kw?= =?utf-8?B?RG1zc09RK2pLRHVSUE1vK2czenNwbjFWRzRCblhHbTBKUmZJS3NyZFhRVWhS?= =?utf-8?B?M3ZNU1BZSFJJdUdrd3JsdnlKUHIwV3lJUnlvR2F4d2FLTXJiczFlVUd5bkQv?= =?utf-8?B?VVBNUU5CTXdLMWRmV3lvR1ZSOGRVMmIvU2IrdG9JcTdYN25xc2ZYY2tBNHNi?= =?utf-8?B?cGNNNGppdmlXUnJsMGNpQzFvSU5LUkxON1N1bXVXKzRVOFBjak9PenJSQ2RB?= =?utf-8?B?T1V3RVQwSHhDZHVIM1c3YU1hK2twYzhoMmw2cWhZNUw4cW9tdkk1UGRQa21j?= =?utf-8?B?UXl4SUpxMkpRYWM1Nnc3aDVUaUpiVHFQQmUvUjRJMy9JK2RsUndDcXJDdzZn?= =?utf-8?B?ajdUaU5QT2xWMWVNK0hpRUZPaDVackJwM092MnVWbGlFNEtSSFFGdXRFbzZX?= =?utf-8?B?TndvN1RYS0s3STRGUmx1YlRhenhqL290RHI3Z1FlS3RKVnpsdDg4TWlqN2xl?= =?utf-8?B?djlUWlM1S2l4Y2JuaStKWnJYT09pZ1E1c1REMFlpUGNnWExTTFMyZmo3R3Fs?= =?utf-8?B?djBFa2JGYktOMWtuV3IyY3FGNjZqUlBBVWl1Q1lxdVBSMll0dXMyMTJSMDZu?= =?utf-8?B?NTlyK1EwU3dQcHM5RzZhUmFkTUkzZ2xKd0RLdGt2TGc5ZDRZcnAvcXJPaU5W?= =?utf-8?B?T3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cc0fb801-486f-4c0e-78a8-08dc58840360 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 10:58:39.6902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ry0XP7iV9JslJmY4pUGFZcKfVuUoTrf+zratjQTQryQOEtyQWNv1zUa76LFWidXaGVHmn1HJstwy33uXk9pDot5DQ44l+xwr/+PZiMQgzQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8770 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3C0A8C000B X-Stat-Signature: gtosg9hjy51fcqg5c911q1s7uc4rhk8t X-HE-Tag: 1712660324-563369 X-HE-Meta: U2FsdGVkX1/GTMdHzX0h7siRcyl5qrkaAlxqRGJDxHAc21Gw+EjJyFhS9dYyYQ7/HfR4Hre/HG28w/XswwVMcjH+qY7HInadYVP1dgPkSx4zkwi7LNwSdQzIWUaEAB2ZPtKUAQ+X3idx1j4IgJomlPO2nrZJaBP10ElN0Va64VKpQ9vbQV8bIsPU9T+0g4ZdB3ic78h6cKdmhiI7hxy1qxvhJkcr1Teyx3Sy3oieExEvjFRtuGhiWQ3puAXWAEboXFpmADHaolYVkGOmfl6dwn6WiaEBkP5N9MjxCDKBOODTDOBGLwcLFAjhuCPMPCugnXQgZRr/Ck/1Q91pktgm3/MhANdnslNaQF2XsRYBO75ecSZexbcrNBgQu+rOJ0+chuLYGXDYan9UzaoNyyCxIPdxRDMpCMeA1ywnevlwRcQ1JHs5y0NPQ0K/yMDvyhxYwsvs0OZHrzyrMfaFK0yiHBe+Hq1ksT9ZSYkbacab8JCNYYHgkqviI2Ij/JwbH9BtRNfkHKBsygyZwCdnoUyev7FB9c+u8tU/GWCyUMpV2XKj18tagEht5Rta2SwqzpYdOL5Jza3Uxoxbmid2O+kIC5AkL8Kak++F5k2aIX6kd0J229jr2n8w1Qgg6zExk/5TzyiImFMTBuEK1R4cTxc0Tt9FOrbV+Bl/ha42atJqs4/hFC4ZBcE/rHASNpGqrg96BkuDFmr9Mj4f0HEIx/FZ7Dz9UECYzUDg9+UG82vnSl6/666I6vBsemXja6Df2rnBF6C7U9lpbAEdAS4o6rrlgmZC0w5ooDXgHQqYzyb90DXlIa4Nv0ZNaq2jmXaAIXQCCSJUTNeorbEbEnHaO1NJjOet55j527ZVowqzgX6a8/jSd241LokpDvcu6TJYJhp0IIheW/rHxgOO93hkUUNbHaPtM6sBErRiMq1Z+TUvythUi39bMWnYAFh4dPpXsuccDQesbVRTtPKmGXVZDip vZ6pxrsJ yRTXB8kRgCMNf2EdS1oIM6FnBc5ElkZsKnXPB8ZilwXnKBlo7iRs0V2BZJDEpfO6J5J/LxaI2wpzksyoqqG9GOxTmuuQNO4khtDtSeVqhKAqwD6od+PT0uaVueKOYVAfHkNLFHWmevIsDYH1iEHpzcZNFxm/9ECMFw3trhv9P0tlwUWR8x6U1+MMu82Rh1Ls8MxdXY/azmE3MmBwJCendP3pZmYodQQHXnPDrX/zpLIGBTYHvzr+RsGt5qGacHBmIkVyviJNn59A2pGDcrRjg+CBtqxauf3bR7fEi1l0GVfq2JRwm2PWqjmdo/h5C/VPJHuIKWNVjU3xg2wlBZbihxFr/EdEoYMDZ0nojIkPojuvPIh9U6ARn+ooHxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/24 11:09, Alexander Lobakin wrote: > From: Przemek Kitszel > Date: Fri, 5 Apr 2024 12:32:55 +0200 > >> On 4/4/24 17:44, Alexander Lobakin wrote: >>> Add a couple intuitive helpers to hide Rx buffer implementation details > > [...] > >>> +struct libeth_fqe { >>> +    struct page        *page; >>> +    u32            offset; >>> +    u32            truesize; >>> +} __aligned_largest; >>> + >>> +/** >>> + * struct libeth_fq - structure representing a buffer queue >>> + * @fp: hotpath part of the structure >>> + * @pp: &page_pool for buffer management >>> + * @fqes: array of Rx buffers >>> + * @truesize: size to allocate per buffer, w/overhead >>> + * @count: number of descriptors/buffers the queue has >>> + * @buf_len: HW-writeable length per each buffer >>> + * @nid: ID of the closest NUMA node with memory >>> + */ >>> +struct libeth_fq { >>> +    struct_group_tagged(libeth_fq_fp, fp, >>> +        struct page_pool    *pp; >>> +        struct libeth_fqe    *fqes; >>> + >>> +        u32            truesize; >>> +        u32            count; >>> +    ); >>> + >>> +    /* Cold fields */ >>> +    u32            buf_len; >>> +    int            nid; >>> +}; >> >> [...] >> >> Could you please unpack the meaning of `fq` and `fqe` acronyms here? > > Rx: > > RQ -- receive queue, on which you get Rx DMA complete descriptors > FQ -- fill queue, the one you fill with free buffers > FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever > > Tx: > > SQ -- send queue, the one you fill with buffers to transmit > SQE -- send queue element, i.e. "iavf_tx_buffer" > CQ -- completion queue, on which you get Tx DMA complete descriptors > > XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk > > I know that rxq, txq, bufq, complq is more common since it's been used > for years, but I like these "new" ones more :> > Thank you, that sounds right. If you happen to sent v10, a bit of code comment with this info would be useful ;) >> >> otherwise the whole series is very good for me, thank you very much! >> > > Thanks, > Olek