From: Alejandro Colomar <alx@kernel.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, linux-mm@kvack.org,
Vahid Noormofidi <vnoormof@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Carsten Grohmann <carstengrohmann@gmx.de>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] man5/tmpfs.5: fix typo in reference to CONFIG_TRANSPARENT_HUGEPAGE
Date: Thu, 20 Jul 2023 10:03:46 +0200 [thread overview]
Message-ID: <9d32d536-b30d-f6b8-d9a9-da8d62dc49a9@kernel.org> (raw)
In-Reply-To: <bab9c86c-03b4-f766-378c-e391ac99992a@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1556 bytes --]
Hi John,
On 2023-07-19 22:13, John Hubbard wrote:
> On 7/19/23 12:59, Alejandro Colomar wrote:
>> On 2023-07-19 04:05, John Hubbard wrote:
>>> In commit 462a385e9a2 ("tmpfs.5: Document current mount options"), there
>>> is a reference to CONFIG_TRANSPARENT_HUGE_PAGECACHE. However, that
>>> option was removed from the kernel via commit 396bcc5299c2 ("mm: remove
>>> CONFIG_TRANSPARENT_HUGE_PAGECACHE"), a couple of years later.
>>>
>>> The net effect is that CONFIG_TRANSPARENT_HUGEPAGE is now used in all
>>> the remaining places in the kernel where
>>> CONFIG_TRANSPARENT_HUGE_PAGECACHE had previously been used.
>>>
>>> This has caused some minor confusion at the man page level, though. So
>>> let's fix it by updating the man page to also refer to
>>> CONFIG_TRANSPARENT_HUGEPAGE.
>>>
>>> Reported-by: Vahid Noormofidi <vnoormof@nvidia.com>
>>> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
>>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: Carsten Grohmann <carstengrohmann@gmx.de>
>>> Cc: Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>
>> Accident here :-)
>>
>
> Yes. :) Michael Kerrisk, could you change that line for me
> to just be a Cc, for Mike Frysinger?
>
> Or, let me know if you'd prefer a re-send of the patch instead.
I can change it. Don't worry. I'll review it later.
Thanks,
Alex
>
>
> thanks,
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-20 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 2:05 John Hubbard
2023-07-19 19:59 ` Alejandro Colomar
2023-07-19 20:13 ` John Hubbard
2023-07-20 8:03 ` Alejandro Colomar [this message]
2023-07-28 19:04 ` Alejandro Colomar
2023-07-28 19:18 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d32d536-b30d-f6b8-d9a9-da8d62dc49a9@kernel.org \
--to=alx@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=carstengrohmann@gmx.de \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=vapier@gentoo.org \
--cc=vnoormof@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox