From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A80C47DB3 for ; Wed, 31 Jan 2024 18:42:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806B38D0003; Wed, 31 Jan 2024 13:42:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B6CE8D0006; Wed, 31 Jan 2024 13:42:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6579D8D0003; Wed, 31 Jan 2024 13:42:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E08D6B008C for ; Wed, 31 Jan 2024 13:42:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1395F80448 for ; Wed, 31 Jan 2024 18:42:51 +0000 (UTC) X-FDA: 81740477742.02.90350A1 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf23.hostedemail.com (Postfix) with ESMTP id 1FC8A140003 for ; Wed, 31 Jan 2024 18:42:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=vd4o7ecu; dmarc=none; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.44 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706726569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZgL5P8g30IZu5klPkGNY/NRSwCJ5aP7SFCOzIS4LR8E=; b=ErAghDhenhfOXfWc9ZKe/JFKKmW2zud6ZFlbTVHsLRSVMommzE28dtsb3og98wgrQ/KRAj oVPErssEXUh7cQgFNykOJA5hUPRC3+O1ZzuZtr1lXVsFHN+sH/PPolgUSGYyMJz+H34+SJ NtBkhrBMWsBP1Bnljl00CrvBzQowjEo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=vd4o7ecu; dmarc=none; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.44 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706726569; a=rsa-sha256; cv=none; b=sF9eMOpbmspCy2Fca/7e+Vu66/FrRRXnIBecxi6xcs+spCJmQnxhnPr3ovFXgje1vXhuOI XjP96G1dyfZ8KruMOnWalUPIaRmaG7Y7BqQk8UrAJNp5T7RvPgfQsDKUa3VCsOFbYncPy3 4rOw+JaDkPijLWTZ2vU7cWyU3/wORdQ= Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7bf3283c18dso425939f.0 for ; Wed, 31 Jan 2024 10:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1706726568; x=1707331368; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZgL5P8g30IZu5klPkGNY/NRSwCJ5aP7SFCOzIS4LR8E=; b=vd4o7ecuPeGnW4vOSSfm9+UMImMLNnxJMLB6Ykkz8GGDxFV28nbrJk+o+HJvDtdtFg CRSMw9avFNrzll++9ejyYP8VVJH4rg0NCSo6gOVuRh88f0uOu+KOJLyVG9N6O0v24lR3 RPPoQC2XXFiOTt73z4Ef+XTZ2wkFC2P0xVCs72fyP4kH1fPVSomOCtlw79juQrfXAW5Q zAIiNwrvyUc1uPkIV5SQudBWRVAz3fIO4jJWdGifs7VJkr6OYEUbsLojYGEpBPsq6DIe 1Y8Ivi9reNpYrWSNImMH3duckFacaUt263sdqFnX/DBb5DUqk5MN1Kt60buVI7GKOFEa M4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706726568; x=1707331368; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZgL5P8g30IZu5klPkGNY/NRSwCJ5aP7SFCOzIS4LR8E=; b=fg8/IAY0RK1kYPu8HKVcLE/1tkynJttFnz7QzGxfN7uT+R0sWAMi0t60EhB4s3ykEi +13wO+CN73ahEsAvFMWGvTjdqXamH/Wo4pgI2CG1l99p1yW5DjW+8dnC4ndUMA/L44Ky X09MRzTWxRj2q05yH9cZXBoMaGxYtI8re0KZxyzbhUxj5/cirKuRRrEOA6y2F17gbjNC XLxXnnXvbkuEa10n8u59xm0sw/zWoIsM//xrudFu7gEdb19O+XKdGToadOpy9U9WMCrC JwhZiO6vnrnzp1LtiZtBJxOrr/gyfE6s5fTdJb99PE42bRUKU5B4v/7zlLL8v4sCQJeh u21g== X-Gm-Message-State: AOJu0YwCxalJlubw3zoHFnMBsTc1gviOs3si5Acuag4QORfzrUt6Fl9s 6K9XwJmqKcJYa9zsS8F976chAVWMXO2Sv54JknO+KdXM7pj2gD9vD7np5/WUIqQ= X-Google-Smtp-Source: AGHT+IFDK/JhsIHBaCKUbglY7f+q7PzhFMFkcVFU4b2TomNZpKjKx05Soo4VP27ZNNL1f2oQZHc+4w== X-Received: by 2002:a5e:db49:0:b0:7bf:b18e:fccc with SMTP id r9-20020a5edb49000000b007bfb18efcccmr444783iop.1.1706726568053; Wed, 31 Jan 2024 10:42:48 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id a14-20020a6b660e000000b007bf7be3dd69sm3327513ioc.7.2024.01.31.10.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 10:42:47 -0800 (PST) Message-ID: <9d2f99d8-ecd2-413e-b910-18e05239a2b8@kernel.dk> Date: Wed, 31 Jan 2024 11:42:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [block/mq] 574e7779cf: fio.write_iops -72.9% regression Content-Language: en-US To: Bart Van Assche , kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Oleksandr Natalenko , Johannes Thumshirn , linux-block@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com References: <202401312320.a335db14-oliver.sang@intel.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1FC8A140003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dt5w6rq8b9kpxsfdghpzz81h9b99e68o X-HE-Tag: 1706726568-537553 X-HE-Meta: U2FsdGVkX19EBwHRf6Hmw8WocmB79WO5lnG6vsY/IWmf7zA6NvDgz2OtlcTlX5xsB3Liu55yBnjEBoLSrg1wrQVXrPfbSHGDOONa5ua+r4GAE9jE1L2bxvIGw6nrnMCbn+ZNhPBt4C9pPB3mIde7dBfssetpkFOLKFlTD8YtmWfvv4XXIn3v8p4pyYNY7nGqYXWdg8vR13bgWDh9UJsOZG247cRVCjQ1pOgkKqE8Ris7lN2iwGrx5O3l8EjhsA2UuH08W56tvOihJvC0z7bQ+50AR6alptJNhxSbUK9YZpDlGCMOFWLoRkIWdIGItc2kchrA549OprsC8/DmfAoJX2q7IkyPH7V5x9YDuUH2o+gQumd4Vo7OwCfLHDWtT4LEHbzrW1k7a9OmzHcEqrZpx5fdGhaVep5fJ5zTZolUQQyqQlyu5dcTLAmFOsS13xTBbkXKB//+ZnOX9kr/KENpSqKuCE1A4s2s4bwGyc2rfVDE0/tBv53B0mLSvRIEJPgeRBTMOThDDse8G5tLTKtQAjJ2CRRfIoFZVER9JW0fDExmAcvXslQeV3ExBjJncl5RTfuh9Flq2xp9ZTFf7lFvhVSYrpK3m0zmoSjhqpa2PH3vcIAFmI6LfrcjWn41Uf6SLfD+HIc/C5KHql4zzmPLEiJ66LKrmBBWAVcsZNhYEgVrAX+Y1n94VsC5r/TmYKpnBnjm9Dm+7WjdjfPQhCD9XM+jgiwUH1IcPzpWFT3ZKihYpCnS8tZbrAueTInM33S+kAtPggxW7hdWIgrgnPjftgLGlmv+eQ3OyL1xT3KcLIsAqcvJ1D4/vaP4YQD6TkuI0oGSmtgAsL00uQAlBOyt5hvqVPKm/nYxtadYoNMygsdqwhh/jqD7fb5yGMUzBvkSkXDkRuTqHRfPsl9dZngI4OqzCod2/7jeQB6Z933HnzF1zT8qTNGEtYJj5z0m0gS3FuQCfI2r1E1fRe7SzKI uCGTFgBa eprErq5AI0DEiQGP8xnpRG92yQkLSlkx3j1nfzfFWSZLrNCeMRp4PCYNGTUBvbvCEnL+FAFx16+MAqDshMNgBH66J0zIEk9wZQkINICTmwGNHD/e7r5488UHFWHmsoqzdr/Fhf5/Kk9OHPpKMwFF1uR7bqCBencz1BlUGYLV0Kxs/j0IwE/EA3Ov/wRg9JutUx8Gf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/31/24 11:17 AM, Bart Van Assche wrote: > On 1/31/24 07:42, kernel test robot wrote: >> kernel test robot noticed a -72.9% regression of fio.write_iops on: >> >> >> commit: 574e7779cf583171acb5bf6365047bb0941b387c ("block/mq-deadline: use separate insertion lists") >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master >> >> testcase: fio-basic >> test machine: 64 threads 2 sockets Intel(R) Xeon(R) Gold 6346 CPU @ 3.10GHz (Ice Lake) with 256G memory >> parameters: >> >> runtime: 300s >> disk: 1HDD >> fs: xfs >> nr_task: 100% >> test_size: 128G >> rw: write >> bs: 4k >> ioengine: io_uring >> direct: direct >> cpufreq_governor: performance > > The actual test is available in this file: > https://download.01.org/0day-ci/archive/20240131/202401312320.a335db14-oliver.sang@intel.com/repro-script > > I haven't found anything in that file for disabling merging. Merging > requests decreases IOPS. Does this perhaps mean that this test is > broken? It's hard to know as nothing in this email or links include the actual output of the job... But if it's fio IOPS, then those are application side and don't necessarily correlate to drive IOPS due to merging. Eg for fio iops, if it does 4k sequential and we merge to 128k, then the fio perceived iops will be 32 times larger than the device side. I'll take a look, but seems like there might be something there. By inserting into the other list, the request is also not available for merging. And the test in question does single IOs at the time. -- Jens Axboe