From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5987AC10F1A for ; Tue, 7 May 2024 03:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B93296B007B; Mon, 6 May 2024 23:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1C296B0082; Mon, 6 May 2024 23:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCA56B0083; Mon, 6 May 2024 23:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7ACA66B007B for ; Mon, 6 May 2024 23:26:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0E2A0120CB9 for ; Tue, 7 May 2024 03:26:29 +0000 (UTC) X-FDA: 82090162098.11.0208EAC Received: from out0-207.mail.aliyun.com (out0-207.mail.aliyun.com [140.205.0.207]) by imf23.hostedemail.com (Postfix) with ESMTP id 799BA140003 for ; Tue, 7 May 2024 03:26:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=InSS4+iD; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf23.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.207 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715052387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5G08kj7fI6VhU0nVl7AlR+J897u+++S/y5nHUajrQj8=; b=pCjPeLIG11vOOeKpWz0RqSaIan+vhtbj0J1Y2EglB7LU2iZl6Bp6MgN0RwuUB6CJ5Mhl4b izdILmiiit+3+vOiMYKFCEVJ6e2jvt4VFJTFzPhUNZky7NjPBQCcd/2P1pn2M7tzIhfyDI W43jxHN+3lRsqIkYpwSmegbGC53pQUI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=InSS4+iD; dmarc=pass (policy=quarantine) header.from=antgroup.com; spf=pass (imf23.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.207 as permitted sender) smtp.mailfrom=libang.li@antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715052387; a=rsa-sha256; cv=none; b=IcrjaYWqsY6Evc1s8DyrkrqGZIM0agBTtfcsE4Y5/ordItPrH7JmRBiKr+njfLAJxP8zL5 0vkGHOGNEZ4doxFSNU4zZIhmRgP+MgrwGyGKUTBrzjYIVfuUs9y0XKo+XeZN+teKq9hyvn 5vixFR0vac9RTa8Hgx6fyUKlf/Roldw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1715052383; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=5G08kj7fI6VhU0nVl7AlR+J897u+++S/y5nHUajrQj8=; b=InSS4+iDdw/tM0dM/yWN8z/3y4CqpStn8d/q6w/4/f/WIcOQZiLjni2z+y0I+rl6smRzfTDKcRfrS5E3JY7nRuVFm5x8QfehJOqZjN95nIRaTnR8EZfZjA3Xao57N065ggrWBb6Lah+s8/rhO5slEvlZsHvP+hbdu9ty9H1II/k= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047187;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---.XU6c0Rr_1715052381; Received: from 30.230.85.161(mailfrom:libang.li@antgroup.com fp:SMTPD_---.XU6c0Rr_1715052381) by smtp.aliyun-inc.com; Tue, 07 May 2024 11:26:22 +0800 Message-ID: <9d251090-ed68-49a2-9e94-7347b71367b3@antgroup.com> Date: Tue, 07 May 2024 11:26:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm: Add update_mmu_tlb_range() To: Lance Yang Cc: akpm@linux-foundation.org, chenhuacai@kernel.org, tsbogend@alpha.franken.de, paul.walmsley@sifive.com, palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, david@redhat.com, ryan.roberts@arm.com, libang.linux@gmail.com References: <20240506155120.83105-1-libang.li@antgroup.com> <20240506155120.83105-6-libang.li@antgroup.com> Content-Language: en-US From: "Bang Li" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: ymi8moojsb7bod9177ebt6ud1rxhwkpt X-Rspam-User: X-Rspamd-Queue-Id: 799BA140003 X-HE-Tag: 1715052386-639347 X-HE-Meta: U2FsdGVkX1+QHW3BzerMR4QxpmYkN23c++3tdWb0hAunhK8TP7RCo6xgHuTIAbXYj68BioWnjnhXGs7Z+Mp8r9JNfKk+dOzrRuU1glu1W6+8a3/JjCOFUHE/Mb1Oe27gAF6jG0dH4UBgPFM1jq9NjpC3GyZreXCzNwECXsET4q9CgR5ok1LK6JbcGQHavsGbnuUc5Geij60o9s//0QvVYWducmUDr5U0P9YTl0rrWyihHe+QLh6Pxj6641gYXTBkBz/RMk9xE2zwT9E/NGIBYFmS9m0MA2eeWN+CMHezDAEj+Mv2GECfxgLe942UKkruNNBEjnQ8GtoRYY9njbQGKZcgOYgMjREN02v6bntVUMCmQ9T/b1gfP4n+IIT1DqGKxAyNryAAVe2ALgTnvWlDf4sugM/FYSvBAKrvFh43u3lAk33yNQ0Gchm9FvWvGDdxEQEwY9uSCFZhRNw0/ph9mpMULEIJSGEd8GLHqQPdJ4mSZreraGtbF3m0D9bpNLW3iiZJM921nik3o00+VVJxQE5eMFgPM8YC0ovL19jOPbiYBt2HXa8w+Td6kzjJZptYrBqbpV4bSQVH7HWuLNSjRttp0tAC/tQ6WUVibJlcoE/gU+4L2iB/JO7Y6j91ir7rkfi4h3yoFX3fZvOSRLz+X1drPTgU9Y3VFkKNzKcbNedOCmuHO2ir9mTk3vXppAeFlKX1Uf3Nn8PKQUt41hyM3a73fgNsgh+Qf+ztCq8XNyVveEPV3aATCVRLi5pnIjmEYQiB9OW8FlRr9Lt7BWHiCIVfiArrcEb9XSPRwt0UvyaueYfOXq0eL7dmc7w1KHPL9Wool/1mOIWmi97Ea2uYMAtdBePKfZrRVYjTpQUp/LujK3RdWWbBIvlkvv+Hjklm1D9Tfg09+dTTHXaj1BeEFo1iXgzTWlCiihNJZJ7KpQu65DWFhCHINT+Mnir+uTSWTmThtNY9cautF/uv4/v ZfX+Ufr5 roRLTUcAbluH/z8oPKGI/MF7dK88+fPe3NQfg0MU7s3KhutXy50ORC/8+/ZXD4rzpE9l6/L7lWTbzNUibck1vBZ98iuwcpVNl2ILgLh78Zn9oeJdyxeOGfSrjmh6IVdAHOZsiYF9tCFJyvDLMI/chTt1MfHEsJLbW9WzGqYCxlQm1KPjm7EUsfG3ntACz1eJ/VV0RC5R95h7wcWKV1xVXrU3GWtFLuu1zxDm+orqvBBpXFoEU2If6UlSy5NalqFhS3aivWwXvtuClSPQOyZz1F/BgPLDOfYLLaOdT9ObGNQr/OVy090Zo8iir8S3TOqhHK+iAEizF60ZyDyvFHXxJ3d9xwSYTKCJWV3yQMB76WGjVvyGASWdfc4/FC/XjmPIm59c92LcIgtABL9r0vY7G5clJUh9gl26s5nIRmYYS/Vj4/2gCSmxhoKCqtvrYE55VunhvYYF1oDQJ/5KgnJZJEP6P5nCfq8CJwMkz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Lance, Thanks for taking time to review! On 2024/5/7 0:07, Lance Yang wrote: > On Mon, May 6, 2024 at 11:52 PM Bang Li wrote: >> >> After the commit 19eaf44954df ("mm: thp: support allocation of anonymous >> multi-size THP"), it may need to batch update tlb of an address range >> through the update_mmu_tlb function. We can simplify this operation by >> adding the update_mmu_tlb_range function, which may also reduce the >> execution of some unnecessary code in some architectures. >> >> Signed-off-by: Bang Li >> --- >> include/linux/pgtable.h | 8 ++++++++ >> mm/memory.c | 4 +--- >> 2 files changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h >> index 18019f037bae..869bfe6054f1 100644 >> --- a/include/linux/pgtable.h >> +++ b/include/linux/pgtable.h >> @@ -737,6 +737,14 @@ static inline void update_mmu_tlb(struct vm_area_struct *vma, >> #define __HAVE_ARCH_UPDATE_MMU_TLB >> #endif >> >> +#ifndef __HAVE_ARCH_UPDATE_MMU_TLB_RANGE > > IIRC, the contemporary practice is to define a macro with the same name > as the function if it is being overridden. The macro __HAVE_ARCH_UPDATE_MMU_TLB_RANGE defined here is aligned with the macro __HAVE_ARCH_UPDATE_MMU_TLB corresponding to the update_mmu_tlb function. IMO, it should be better to use my method in this case. Thanks, Bang > > Thanks, > Lance > >> +static inline void update_mmu_tlb_range(struct vm_area_struct *vma, >> + unsigned long address, pte_t *ptep, unsigned int nr) >> +{ >> +} >> +#define __HAVE_ARCH_UPDATE_MMU_TLB_RANGE >> +#endif >> + >> /* >> * Some architectures may be able to avoid expensive synchronization >> * primitives when modifications are made to PTE's which are already >> diff --git a/mm/memory.c b/mm/memory.c >> index eea6e4984eae..2d53e29cf76e 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -4421,7 +4421,6 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >> vm_fault_t ret = 0; >> int nr_pages = 1; >> pte_t entry; >> - int i; >> >> /* File mapping without ->vm_ops ? */ >> if (vma->vm_flags & VM_SHARED) >> @@ -4491,8 +4490,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >> update_mmu_tlb(vma, addr, vmf->pte); >> goto release; >> } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) { >> - for (i = 0; i < nr_pages; i++) >> - update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i); >> + update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages); >> goto release; >> } >> >> -- >> 2.19.1.6.gb485710b >>