From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30125C25B75 for ; Thu, 23 May 2024 20:02:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 964336B0088; Thu, 23 May 2024 16:02:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93C3E6B0095; Thu, 23 May 2024 16:02:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78CE96B0099; Thu, 23 May 2024 16:02:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54E8D6B0088 for ; Thu, 23 May 2024 16:02:09 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 08DDE80736 for ; Thu, 23 May 2024 20:02:09 +0000 (UTC) X-FDA: 82150731978.11.7EDDF6E Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf02.hostedemail.com (Postfix) with ESMTP id 96A0B8000E for ; Thu, 23 May 2024 20:02:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=AS3LxvcA; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SqsKWv36; spf=pass (imf02.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1716494525; a=rsa-sha256; cv=pass; b=bijkxJG0MQZVFtzmaiRYIluelB1/Ezl3i3rDupNpjsD8VOqiImlQGW3v96Q3aiB0fvhrsH E6nUhfgbDPS2TJ+IkP/agYVKPQC8Jq/w3rCQjy3z6yzwE8CKf+/UlYkplf8waWa0y8kKpV xdQbKx9ORfH2Yd6JhOf9tcl0eDOblJ4= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=AS3LxvcA; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SqsKWv36; spf=pass (imf02.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716494525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xzfvSPl3BAVzHCVnuOS3c920oV5qu20aTVx+5Glh9rQ=; b=CNLsopyWSKGtdfK54BCreSVqa/I7uKIn3AEh/qD0C0vxfW4KNTdJ1XruSV/jvFpOnGVPMQ knvtFOBGiDQZPdZ370xfjE94mPXGBF3y9anwiksV2mpoAHwqDteWJwsLa32HTOtmR0L98h OlJjLj3UXzj4SEA8fyya8zulqjgwgMg= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44NJ1QR4021934; Thu, 23 May 2024 20:02:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=xzfvSPl3BAVzHCVnuOS3c920oV5qu20aTVx+5Glh9rQ=; b=AS3LxvcAHPpSsP1udYFVMsas0ZCxpr+SHea8xYdLc3Gzw9/ZXZj62hqnDzI8kv3gRAT0 u8tAjG/3R9JWpMYBiLEiOWMUyiKgZxxmL59OKAZIGfFXnilqg7WGNOumfI0hGLPtYF6i d89DmAqyc8MqkhSw9yO6ewXxSHhBN0W+5Y29QQkNi9/fIHsbcnCX4LxZ4uUaqTVhXUcT reTmGWmvjmrayKOiojlC62M/AyD6uQnWoJqHECz30mrK1d1KJO/9/qTrDmUP6LwVIc7o Vt/XR5+J7bb3DmTiizpngC+vonE6v7eL08ax2iM03FmfEr2+Y2kzV9DGGksKC3rMKAQ1 QQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3y6mvvb1gu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 May 2024 20:01:59 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 44NIO704038031; Thu, 23 May 2024 20:01:58 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3y6jsh2pum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 May 2024 20:01:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NX5oYIboYuR1nHoYNrxDlOHGFFgDhAMEWxxzR/boCkuRDLeV4u+hWoQDNq+i9ATHMAzNPr1DUqmh7Y38OWt+3YE/YJsaGj4TEYtz1Hr/ZH151ibu0NZ0qJOscEP/ILNIk9Dna8DRXguR2UeJpVciJDBv06+SwHLZCJliDVoLVTkRQFvivFiElh9G2on25PrdlEMx1UW9zDJjqIgp37vpReHF6/AQITBk/wDa5HXzFjfjRQUKH/JKgaPOsoY2HxUPZPg3dqADJk1Ki4yiao9qdDlmnotLuWVurpiS7ppLAIrmXvXy7xxiG6BDJ9Ii4F/hNUexilsAQRxDhk53zAjMNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xzfvSPl3BAVzHCVnuOS3c920oV5qu20aTVx+5Glh9rQ=; b=KwCS5IEcDzReMIbSUBUcMP+DyuK61Vdcl12dV/Ia8T/KLF0LwL4DcOuW8DTKedIjNJDWbWvBljj5U7FiKrNPZLADPKeSldDx0KBQdAksZUgzdmben9zQ8hCZHP3Ypq2DjUHl+OpsMM3q77qBBTUfLgx1ogux5XL+mb9ahMd+wcA6EjsHLaDKM+k6VaR6gb5U72GCONPS7mAwS9/GooKn0sjpmICCKu0jC0CPc3k+OtK9cOZNEagogXP3C8z/mTJvao4M8u/ZTEsozKaWsWS3WlGxW5WPOcNBhVOW+W68rtmiKyAlwZ2KKyVC+yUiNjADLbdIA+RHe2hpNkfYCEyTLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xzfvSPl3BAVzHCVnuOS3c920oV5qu20aTVx+5Glh9rQ=; b=SqsKWv36Ij6hjzTPVnHTlnUoAJruPAThLqI/Rw4os5ZrU9BLloupvsJNSF0aAtEsX7Tmq8Gk5HPU1FHY0FgNbFxNYQnW2Dhke53EtgReAD9jKy1RpkQ1Acx3FN0aN/XgYlYtbf48dMhtMegNp3zWlZIjAL3Ym1FRhbz9Wz2aR3E= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by DS0PR10MB6149.namprd10.prod.outlook.com (2603:10b6:8:c7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Thu, 23 May 2024 20:01:55 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7611.016; Thu, 23 May 2024 20:01:54 +0000 Message-ID: <9d217b1a-c11f-4fd7-ae81-c704268da2ab@oracle.com> Date: Thu, 23 May 2024 13:01:50 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] mm/memory-failure: send SIGBUS in the event of thp split fail To: Miaohe Lin , nao.horiguchi@gmail.com, akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240521235429.2368017-1-jane.chu@oracle.com> <20240521235429.2368017-6-jane.chu@oracle.com> Content-Language: en-US From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR08CA0006.namprd08.prod.outlook.com (2603:10b6:208:239::11) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|DS0PR10MB6149:EE_ X-MS-Office365-Filtering-Correlation-Id: fda850dd-b24a-4563-4eb6-08dc7b633195 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OUhGejhLT1VndC8raVhadFpGVzQ5c1JPUjFaelJaZCt3YktNQy9VRXc3OUQw?= =?utf-8?B?N0xvMDVHbnhPVW1oTzYydGZMZko0aVRqZUduVDNLSjJRK1B6L2g2UXU5WDVw?= =?utf-8?B?ZzVtNkZiYml2VHo2ZTA0UEpGcmN1enhwbERXN0lWN1VFM2ZheEQ0cVo0dnl6?= =?utf-8?B?TVNQeDVmcVBxMzhBRDhNcjc4RTNOalUzR1lkVC8wYy8yaHFVdXNPWGJ3RDZv?= =?utf-8?B?K3FVOUlSeEFCTXNPSmg2V1gyK29ZSksyeXBMWW1JanBMTDIzNVRSU2hKT0xp?= =?utf-8?B?RzV6SlB2b0NjNWpCOG5HVnlNbkhoaXRMTDhhNW9IRDQvRFdJL2QxTjFVcGNt?= =?utf-8?B?Nmw5czV6cFFTSTRmbjhPak8rdTNOV0l0a1RQc0xYYlg4ZlJma2t0dG0vTFUr?= =?utf-8?B?ZjVIZG5ZbzJpNXlraWpkVFJGSElZUEtlNmxLakJXaG1aS2RZVlNVYkhoc21F?= =?utf-8?B?NjNRRVRaY2pnbEFhZlduSnZCQ2xnckkzWVZaSzcwbkcweGJ1cG1nbUVjRmFw?= =?utf-8?B?T3lMWTVrRnk2STRUclg3ZFBsTzJVWWpjajhQVDlBMUNjRnpId0l1Y0ZqN0RE?= =?utf-8?B?bXk5R1hkaDNPUzkvdHVaZTdSRHZHNWRxb0hwcW54R3VwaTVCVmtxMGdORCs0?= =?utf-8?B?M3ZTNTlVZlo5UFNPNXdCTVhPb2xFc0kyMHh1Z3Ezc0k0cU5SWHk1eTBwMzZ1?= =?utf-8?B?THY4U1FTSkVneWVZeHhGWitpTDY4TnNtZHJZNUh2U0hZT1NWbHZQRk9rbk9o?= =?utf-8?B?V0FZeGpjME1HazV3aU9JSEFpZHhFN1FyeEVWMmowam80NGwxRUlUdHhOcFdQ?= =?utf-8?B?dDFBOEVxNFNDVEc1ZlVyN1p2UzBxWVVHZ1czdlZzUzBqdmwrc3djYUFYOWdr?= =?utf-8?B?RGlYSWJ3aU1WY0JETTBSMWZ0a3QwakwwbVI1Y2huS0M5Um53N3EybEdjcllC?= =?utf-8?B?dDVQYUgzK3hIMjU1cENrRzhRQjlmb0luTnRoUXh3YUlVR25JRE1aaGFFZW1h?= =?utf-8?B?VVZHSnVlMCs5ek5GdFRhVi9CbWtPK2R2VmlyV2tIT2dVZ0JlMy9YVTh4Ukpj?= =?utf-8?B?TzdTc0pPaWUvVDJHQndYeGpqSFJza1NwemZEeDJxbmk2M3dTWHNvZ1I0TlF6?= =?utf-8?B?YWZHZVBUR1RYZFkyRndnUDFwemNlZ0ZtSnYwVVpzWmYzc0dqUjJlc2hwbWw0?= =?utf-8?B?eXhtTEZzR2ROcHR0Y1lpWUQySWRoZFNCTzh2SjNqUm9zREtUMjJxdFhmN2lI?= =?utf-8?B?dGszeTJ1Mm5WbUt5TmozQlJOenF4V2EzQzA0TlR2SkVPRXJwd3dFTENsbVho?= =?utf-8?B?QjJjb0FrWlNPSy8waU04U3V1K2tYTVoyN3QyK3N6MlNCNjVLUjAyOUlUVHkr?= =?utf-8?B?b1p5cGFsYTFoVXRldEtMQURycXlFMGprcjhRZmN3U0JNbEkxOFcwSjhuWEYy?= =?utf-8?B?ajVNWlZoM1E4WUVRMjFjam03dHVSYW9RVjlZRVVkaTVGYTJUUHhyRGF1ODJy?= =?utf-8?B?d3A4aWRwRm1FazJoR1RsY3locjhHZWlZbWtUMHAwKzIrek5TQ1FYQlptYUxp?= =?utf-8?B?cG4xaG5kQVBtU0xxWVJXRmQ2cnVVeTFCbFNNcXpQcG1pNlY3YndJSVNaTFNO?= =?utf-8?B?ZjdXdkJDRWdTaFdURlpGSUtvd1drdUJTY2VLQmdlZThDaVB4QkgxTWFsbk1R?= =?utf-8?B?dWVvdVd4WmM2akkxbTlTclQvOHZIVlA0ZkxwQU1SK3ovU3lxUkE5ay9nPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk9xbEM1ZHNhRXBXZFlSMWxJekVtZFhlb1BRaDR4SU1GeC8ydlJEZmJZbldC?= =?utf-8?B?K3BheXd2c05OWmQ2a3ZpY1hKWjhXVzA1UzV1SWtIMzRPMVZ0elVFQ3FjWDdU?= =?utf-8?B?MWNhT3BjdklubHNGVjZBczdkYUNLaTJnM2tZZlp2NFdLeGN4bjFidWdXU0FX?= =?utf-8?B?SzNMYitEdjlMZGlKWUNza1VWeU5qbmZ1NWprK0JmcERoLzBJSG9zaGl6Ynp5?= =?utf-8?B?c1VoSkh5QlUzRnJYVVFod1N4eFYxSDBVaFZnYjJXYjlreTg4TFA4U2Z5Q01O?= =?utf-8?B?RDg1VXR0V3gvQXh1YmQrYmRtbGN4cVVEK3RRUEdCSC9zbW5kNTBZKzd6SFBR?= =?utf-8?B?UmxxWGFuOENRUDB5WENHM3pqdnd4VHQ2TStLSEdOL0ZmTmhDdFFPYkpPa0NS?= =?utf-8?B?bTFyK2c2SXd1UGFYSXFLd2VIcmxRSWN6VkFLcWd6ejZIeGVLK1lmeDVSZlEy?= =?utf-8?B?QXd4YWhtMG5rWnZCWVV5WHNPaHN1TTRlcUtYNDBhM2RzRUFpdnhBbTJSNEJE?= =?utf-8?B?Zk4va1M1MEVyTm5QeFR5VFNYQkpxOUhhTVd1cjVYYW8xeWcrNXl3eEFxUGVq?= =?utf-8?B?cnlIbWtJNkw0K1owanZTZGs4LzVDM2dNVW12WnZyMTB0MHRPYnhjOUdYQTZD?= =?utf-8?B?ZzFEbUhlcUl2TGlVa1ZGKzliTTFEbU9sU2pjUmdGR1ZBQnFGMXZ3Y0Zla3N1?= =?utf-8?B?NnkycW13U1ZoOUc5b25yejJ5Wnh2WE5IbnlEclQwSFcwSUszK250ekZ1cStq?= =?utf-8?B?ZjdNN0hqZ3ZIMy9ieTZFempIQWd4U2l2OTJjM0ZHRVNWSEdUZmdIQkhiZG9V?= =?utf-8?B?cWE4a1R1UzV0Ukd6VHRzbjBmQkhqa2J1ZE5NeXo2MTZqTlNBd0JkZTQzTjRV?= =?utf-8?B?SnlMc2lXOGFhQUwvaUFOcmgyN1BGOWtKWUtOeG5TVEl6WmVWclRFZVhyb0p5?= =?utf-8?B?aVFkTnhxM1V4QStyMUJtRnEvek45ck4vTWV4TmtzZk9xNzFscEI3RnJVdDJY?= =?utf-8?B?QXkxTVA1UG1UKzJQSVRrWUIzVkh6eUhueFJHb1dWckcxUzBmWWhNYjI1Q0dy?= =?utf-8?B?czVsM01seVdlTU9RZU8vRmJGWlltR3VYMGpkdlhZZmhBTkJyZUxmSWVreDY5?= =?utf-8?B?Nk9xd1VBYUpBNGZBcmppUVdCZUZjeVdHanpjVkFVcGNFM3ZnQjd0TExDUDRu?= =?utf-8?B?OVZjOG1aYzYrQm5saG01Y1d2R09HMXpRc2xJdlVTSkxMYUx1M0ZzOGlYQ0dZ?= =?utf-8?B?OHhscitsNVhieXUzQnZTdy90YVhmek9KcWxPOFRCWlFXaDdrTHVreGtDeWhw?= =?utf-8?B?NEREQ2hqWFI4WE8wbXFCOTBWMW9mUW5LTmtuWWdhdlRDUHZYU2lyZ3NJU21r?= =?utf-8?B?ams0NElIYzdEL2dia2FDVmRsSUxPcHU5NlhKZkRTalBOTklRZ01KcWZCell0?= =?utf-8?B?cDN2WEVRTC9XYkthMjlVaTZ0UGM0QVorU0dKa3ZIUTVQaFJVTk1PME42aVZD?= =?utf-8?B?c2dqcmdrT29tSlpXYmhUYUR0WitSSEhsUTN6ZWcvMERxZm9mbWpKSnNtK3ZF?= =?utf-8?B?akhCVXZtUVhqK25pTmorWWhweEVHTGhiUThCK1ExeFdZUmtCcTZIejlRc0x3?= =?utf-8?B?N2szSGZxSzk4NGZtZ1JIQWlCT3VsOHNTVlg3VjM1ZFZOaVpJdm5xN2hsakIr?= =?utf-8?B?RWFsSldPOFZFRG9sSm84TnlqUXpDbTRrdjlQUzEyV3BpQ2tKZm0zd1ptUHls?= =?utf-8?B?MlpOVkc4cXZIeW9Ra0NiM0dpTHVXRmJseC9MbVhkaUkwaENIT0ZkV1N2bG02?= =?utf-8?B?a0JyREhxV2drSVdVVXhBdEgrOElmUzJSdTJrT3huMDREWENjelg4YXpyU29O?= =?utf-8?B?eU8xa2N5am1mZkx5WTVuZHJWeVdtd1pSR3BHZHBqUXFtbU5LWU16SE51ZlBy?= =?utf-8?B?akYzd3dhbWM4TlRMbG9uMjhUVXhIYVl6ZDNsQ0xvc0thZWRoZHZoOEZNZ2hm?= =?utf-8?B?MGFVcnFMTWpvZmtWd2NBY1lKWkI5N1dKVkpHd21LVDdhVFE5dHV4UWFUQnA4?= =?utf-8?B?bHh4c3M3WG1FVDdaUFd5WmdoNnZzbHBjSG9DN1QyRmJ5T1JHeWQ3NCtpblRP?= =?utf-8?Q?LNTslnrwy4acER7LPfROKOXUm?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ja5L/IcAG+tvkL9BjkaXDkdxMcIF5OjZsJBa9q3+GtIcZGmj+0xuOlw1uwKTyIppFtf9wDh8+EzudvxUgIxSf8pskf3kdIGGESaB8ryWtaPDzaqstuy1F7e352RYxliv2MfJH/i3CI17ti0Gr2ddFiC1OLIr0deJ8ffQCmvxB03tzq3Mi8dq8osL6PuP0SLjma0maE5Y61Kkd1FXcxCGtxIvhfZrL1+0EXH5WovBi1x3NV+QscMlFi1cirIvlnNsFRF2EWcbRNXN3Vt7HWkyN64qgMDjO2p/FdYTIzUzndHKxnySRKbLiq2u61088di41+v5QeTryUiWE4IINckGx+4Mi0qiQkX3XqlTdxJCcGOroS78FIYYNFiY8SJM1Jo/JChf8YGMkIaKzk/wiM/KK+0D3pRu7ldwI9fmWS+aUHdC9MURPnD3a/AwQJJdxrswjydQiuJHgZfOYHbjRkkONou15t+cMDhYW6+f2Wm/NIe/q89jkkD8o/yLkNO0EqDoWDmxd06naO/APKQrh4o1f5JyXjIV7OnbUZMkE+liioGVz9zEY9KdicBtEZAoTd+2FDmOy0gHZw37jrgQFoDEP1TDc3Fh+T+kyjvey74Jg/Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda850dd-b24a-4563-4eb6-08dc7b633195 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 20:01:54.5237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9QRhk5ZKrUpD3MUqpgUV5+SlnmFWOSS5Ws2w2W/RYRozRsA9mE5LzUS4Hhon6jewfdvYshmb5rnRJzmvYoxB8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6149 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-23_11,2024-05-23_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405230138 X-Proofpoint-ORIG-GUID: f4BWqgr6GTnX8Xa2qbNGvtizObR-nNiM X-Proofpoint-GUID: f4BWqgr6GTnX8Xa2qbNGvtizObR-nNiM X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 96A0B8000E X-Stat-Signature: x7c65nietw1wwdbajdneyxbtptbmxxyu X-HE-Tag: 1716494525-421219 X-HE-Meta: U2FsdGVkX1+4PbfsHE8qBhxwwEXGb3ViygLGl6XXaBH7OUGq/BM7/zMtdlg+ief1URWofzun6kJOh65doNchkFeZ6pI8xLhz5rP89CSWHllBF7BJMb4yO1o3OQtYGpxL1YfmmgXRGBLiHm+Y9wfxpxcSrHIl5WnQHAoc7vp6uGF8Vz7bE2GCdRWuW4FLthdNyIXseL/5I9SNvE4zH1uQIU7sBckIFj8W6mfg6G8z6qvk4GO6cwjL9VHJXLq4sV7MdYKMQjgXqUCbBdHSHi3HN+LxJq1Z+BkQQumvQgZRt3THBl9PwA1qqkAeEo0w9ahg8iwtiZJx9zyTrzIrdr0RuQLCWw+Zz1ngYYyPJ2dOy+3Du6IuKXvW+WYYw3apQPN9l9o97O8pJEXilTJafqZsFt2QHrORaYdmpWt2V5x3naIH8Tf99wvnXtdyGX2o5H3of8t2OSVb5g55CbBH/Fx0I+IF129mgy2uY99dogpCr39OoZ7UjtTZCETUbJqyi9RlYY0f7v1Itufv++QNKMSeMzWn35IPXaGKeIkHJruWOfELVG1heDy8Y5Ic6oiX+ffksMfNfrMfR5tgNPDH2DjVI4jDQNTbzBGmcne92u9KzAvXNEi6UabeibTon3u4tzXEb3SsDF30VOpuJQq0Bo9teKrmy8xaZt6wRfmFR1UHmjhIEQR9EWHDmo7ag7TzWhk8q6ZfnFIiKJ80XtctxhTceRrr6TAAQY6z6QA0LjerHSRyJe5ZomcmE2L8icMZyyyHLoh6sRPUj4FdY2rSXKnGvmrk6ijVAHxf26zMNQvPqDaotpBcPUcead+bVnYn3dCraNlmUoR6EklRo2bW6o51VuAFgS+eHmOOth/AkOFaR0lWLxrYpVJSMWILYSapI4bd6QpU61OeNhVGQ9xvs4BuogVZEDzAr1+AJuDf9qRZWTzMcZQhfRHPQ/Oh0f+Y4Ml5dMA47Gm0brbSi/uEy6D zS027DSs qGOsJz4EZUHr9k+aqNXUWIrBkIGtHGMQNja+XfYHJy+P+lA5XXskZlnuwGMR6w/mwDEhZpvJjERk/YPIDvj+88u41+GZO18pQFE1PUCbaj+poAMhN4cgPEfPwYxb0LF3WGB4O8stESUrX0x/X6MKCE2FnYOqTQTR12bzozQ+MFVyfYqOiWEBCdKuMwK23AdgYv/m2nL9rjzqi9dNvipcE8iJvJx9hMZ5VCbv2m6rbIiFSbimDx/A9W+YwpEsBnqYLbfMID0NDpFfpmP7LtijNh3iCkPvCQJi2Opy49hEvGnELXAjiwd+4nJZbj1Q4b9tgx2rY9woww7qPsQYShEqI5ZxcVbnM0KZXK8+LifP5gjeu+tJmUeMFjFjbttKJgWyRD1owyEbmOyQAoRya9oW6Mr0t24tUkjKOqOqr0eg10BBML0l6eN5Owt5uNQgyb+PHiUv5FiKtAmy0iVRWiU9RF8xNpr0ucLXMVJjSVjUcrlHybXR6LjsMW7UC3GgSnu/R225urr2omccMgg9NhZRgn1VYWj/5BFgS7pCJVymPbgo/coeQ0u+C3jszkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/22/2024 8:02 PM, Miaohe Lin wrote: > On 2024/5/22 7:54, Jane Chu wrote: >> While handling hwpoison in a THP page, it is possible that >> try_to_split_thp_page() fails. For example, when the THP page has >> been RDMA pinned. At this point, the kernel cannot isolate the >> poisoned THP page, all it could do is to send a SIGBUS to the user >> process with meaningful payload to give user-level recovery a chance. >> > Thanks for your patch. > >> Signed-off-by: Jane Chu >> --- >> mm/memory-failure.c | 35 ++++++++++++++++++++++++++++++----- >> 1 file changed, 30 insertions(+), 5 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 794196951a04..a14d56e66902 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1706,7 +1706,12 @@ static int identify_page_state(unsigned long pfn, struct page *p, >> return page_action(ps, p, pfn); >> } >> >> -static int try_to_split_thp_page(struct page *page) >> +/* >> + * When 'release' is 'false', it means that if thp split has failed, >> + * there is still more to do, hence the page refcount we took earlier >> + * is still needed. >> + */ >> +static int try_to_split_thp_page(struct page *page, bool release) >> { >> int ret; >> >> @@ -1714,7 +1719,7 @@ static int try_to_split_thp_page(struct page *page) >> ret = split_huge_page(page); >> unlock_page(page); >> >> - if (unlikely(ret)) >> + if (ret && release) >> put_page(page); > Is "unlikely" still needed? I'd say not, because this code is not on performance sensitive code path. >> >> return ret; >> @@ -2187,6 +2192,24 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, >> return rc; >> } >> >> +/* >> + * The calling condition is as such: thp split failed, page might have >> + * been RDMA pinned, not much can be done for recovery. >> + * But a SIGBUS should be delivered with vaddr provided so that the user >> + * application has a chance to recover. Also, application processes' >> + * election for MCE early killed will be honored. >> + */ >> +static int kill_procs_now(struct page *p, unsigned long pfn, int flags, >> + struct folio *folio) >> +{ >> + LIST_HEAD(tokill); >> + >> + collect_procs(folio, p, &tokill, flags & MF_ACTION_REQUIRED); >> + kill_procs(&tokill, true, pfn, flags); >> + >> + return -EHWPOISON; >> +} >> + >> /** >> * memory_failure - Handle memory failure of a page. >> * @pfn: Page Number of the corrupted page >> @@ -2328,8 +2351,10 @@ int memory_failure(unsigned long pfn, int flags) >> * page is a valid handlable page. >> */ >> folio_set_has_hwpoisoned(folio); >> - if (try_to_split_thp_page(p) < 0) { >> - res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED); >> + if (try_to_split_thp_page(p, false) < 0) { >> + res = kill_procs_now(p, pfn, flags, folio); > No strong opinion but we might remove the return value of kill_procs_now as > it always return -EHWPOISON? We could simply set res to -EHWPOISON here. I like that, will change. > > Besides from above possible nits, this patch looks good to me. > Acked-by: Miaohe Lin > Thanks. Thank! -jane > . >