From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8C2C7EE2F for ; Thu, 25 May 2023 23:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71C63900004; Thu, 25 May 2023 19:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CC2B900002; Thu, 25 May 2023 19:04:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 593BC900004; Thu, 25 May 2023 19:04:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 47CE2900002 for ; Thu, 25 May 2023 19:04:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F628AE98E for ; Thu, 25 May 2023 23:04:37 +0000 (UTC) X-FDA: 80830308594.26.23201EF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 5C105120010 for ; Thu, 25 May 2023 23:04:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jPAS+ejc; spf=pass (imf29.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685055875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hjPp075hzr580R3egSz3Ia1aM8rtNXsyjD2jD8ybOsc=; b=UWLksyf6h/LFo9DuG6AFMdOwM9m7LZvuIxYNRBhaHVmjhEUKkYt2w8DY5USVItQlxTqAXG 26CZmSPTeVCALOYvJDzf5HZzWzjPgzvw0yph1zrW1/DOMjJfeADzfWx3Aa/fR0SZaKQSYJ K9L88lV/9WjVAslo5qXSEynhFjohwy4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685055875; a=rsa-sha256; cv=none; b=dpgleHRPtVznEAchOp3KEakHjVFcTvm8aFGZxjotZVjBS+8YtK9p9qstbsVaHpx1dUvGQN 8JDJCqC+CiQ4294w0cNdZH43cw4mB+NUtAA9MsBMzT5uku8Qefifwaz7Utk5xFj72mRkED cSzVV8HrACJgfpFngcksHDv+x4BKJ+o= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jPAS+ejc; spf=pass (imf29.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E79860AAD; Thu, 25 May 2023 23:04:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E110C433EF; Thu, 25 May 2023 23:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685055872; bh=XdOmX0J4cMjw/F8WqcmMWlj3q2i0+z3j4UltRDsxXas=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jPAS+ejc27tlKAjqH0sSeK26lSC+pzZBMxMiVfvfOGF3r7Xaj2BNyzz1O9GohGZiQ gH7vJKASVwfO4wv4I6YddGKdksSLzjyfaY08n8v5lJC3UbQe16EkR1GJUjo1m+SNCP TkU50vJ9HnhrSL1H0TnqmdjwU/066gcw2iPvp7BH1eLhfKZd5u+kPftBCn81ahKWcJ PTeXWWf8bK2A07eIxJBXJOagUJ3tNg406KzzcOUPqhG6yworxHonCLGzqrIkPONcLo AGUL+jSnREV1cguhgYPm7Txv8qLIvG39Bk1708mGINY6gd+DdRYSx6szcAt4YGZmcf JiMHWtr+il98A== Message-ID: <9d1a3d1a-b726-5144-4911-de6b77d9bf02@kernel.org> Date: Fri, 26 May 2023 08:04:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] zonefs: Call zonefs_io_error() on any error from filemap_splice_read() To: Matthew Wilcox , David Howells Cc: Naohiro Aota , Johannes Thumshirn , Christoph Hellwig , Al Viro , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@kvack.org References: <3788353.1685003937@warthog.procyon.org.uk> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: o4h4wqttqu16jf7kgh1bwi64grcrpbkz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C105120010 X-Rspam-User: X-HE-Tag: 1685055873-557846 X-HE-Meta: U2FsdGVkX19wlPz2tW6sXe//lZhbc+DKaIadhzwMxErqtMxAVE3ZkHfHvckgsouprFM5AXWYABpEB36eYAIDmrAqS+pwqa7Pt8Tf9duZFegY1CRFN40JtKAO96FlVrDboIZbDH9W/NK+gElRasNj7l5WhMsFX3O5JdSRU4Ej3v7hobGsQVjfdm8+KN3LFxn+ceRNz1rPLs5tv183WSxcCAa1fE3Jnre+t8wAyvKwvAIVNNEoL2u+UukBX3jLbV4KWld5ampjlA94HcYhqSMBVw4qXlFvajflUuvwjxsLn22XaKvmSfxaaNNVaWsLItjNXFFRmePvmpe26HouTL+H3d1tp+t7WC3DmlDw99TatlP/nORmu1qNRYs0V3B96bZ58EMttO4LeFWhic7rhb9KSDwavm0bALwYJRYTF1p/NHjosTL5dCHrrS/owb7y+vhYfdakphPLSu7r7IifWJUBAZ/OXbR/YTAbesGrFDkr9bBozTsAbNzVo42AerAy0rD4bgQrG7HSM819SzGOPTXkfVPbrHkTruD167Fo/ckqXaKD84V0EfhNhTw+mE02c7hndVFAfuGC1S9VzAxD6MRumw5KKqcR/4Y6902+Vl/t2VvlCfw03bZ3abSc3SXqrp8JSIhMc0m7xchjD/uNAnGTy7e0/WuSyog5TOcSAxVlccHNgyGcbHePSzxMLOfAnjeBIqoZYW3Eu99iKBR7Gi7LhakOBtrGXmow2FmjBkylNvgtODIRgphxyQBBEo5/OFtpzyc6fFJIL8TzJLEyeluy7L/sRD33FCaUCs7DpB/jQXTAQZsz0x3dAJ3ILSAhTTW85Z0+sGtXg8U7+tLb8IGaGeaneZpNqAFeU4/IdWDFoBxDC1ajPQiY77G8M7QMtN8QQCNPZoqYsrMLFA7d+ui7VA6fZd7FT8vBxtjjzcL+Jd7CA/YGLSLrGHerbP8WV4+WhnvHYC3fl7UqeUQ48rF Rc9KxuSy tQvrGI4R1WHqpARgP0iNnQU0rdgpZAT9tGOVNy9lamFt+MJZso8/BdAp2latOVcm6mqVm86aKcNNe8Ow4KRa30rHe7Z+i/ql6cqces7QQPhdOU081XqqGepznKfZopmbifGoIMl5XBfB/1fnsW/K3IMilGXbARb+Bo2Nve8kRJ48GkQm7jcN6rAM5dw38A8B9jfv9/OFrYbG7Eu/v9cPVbEmqrxs+6YwOVcqdQ17SG1HFoP8CzWI6cIVZxLyOG/p4RyIS5zbGeQ2PoO8Jf5TRfkjtKcWo7zlvUdD0t5aFEeixMOCbjD3tdYU9vJY0XJ1459QwMhyS9NbydGuUbMp7GYRo9ffiSocDnZ3RaXEUGju7IVVPYP5KeRVwzSTcN4i9yPm4f28URVtlujcFuWza67Qry+4tq7MplySpdUSWK10Rn6E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/26/23 00:21, Matthew Wilcox wrote: > On Thu, May 25, 2023 at 09:38:57AM +0100, David Howells wrote: >> >> Call zonefs_io_error() after getting any error from filemap_splice_read() >> in zonefs_file_splice_read(), including non-fatal errors such as ENOMEM, >> EINTR and EAGAIN. >> >> Suggested-by: Damien Le Moal >> Link: https://lore.kernel.org/r/5d327bed-b532-ad3b-a211-52ad0a3e276a@kernel.org/ > > This seems like a bizarre thing to do. Let's suppose you got an > -ENOMEM. blkdev_report_zones() is also likely to report -ENOMEM in > that case, which will cause a zonefs_err() to be called. Surely > that can't be the desired outcome from getting -ENOMEM! Right... What I want to make sure here is that the error we get is not the result of a failed IO. Beside EIO, are there any other cases ? I can think of at least: 1) -ETIMEDOUT -> the drive is not responding. In this case, calling zonefs_io_error() may not be useful either. 2) -ETIME: The IO was done with a duration limit (e.g. active time limit) and was aborted by the drive because it took too long. Calling zonefs_io_error() for this case is also not useful. But I am thinking block layer (blk_status_t to errno conversion) here. Does the folio code *always* return EIO if it could not get a page/folio, regardless of the actual bio status ? -- Damien Le Moal Western Digital Research