From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597A3C3DA7A for ; Mon, 2 Jan 2023 16:03:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DBE28E0002; Mon, 2 Jan 2023 11:03:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88BEF8E0001; Mon, 2 Jan 2023 11:03:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754748E0002; Mon, 2 Jan 2023 11:03:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 684D38E0001 for ; Mon, 2 Jan 2023 11:03:42 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 42030806C1 for ; Mon, 2 Jan 2023 16:03:42 +0000 (UTC) X-FDA: 80310329484.27.8C9A5E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 57D23A0007 for ; Mon, 2 Jan 2023 16:03:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GVMCRVkT; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672675420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vOa79JPMLDtsJKawOFwbLFa6Ffx1txwujF+5HHldqzI=; b=W1GexfjC85uNwPkIbPm2gLPXCOe+c+9+/5jaUxvUHPlm+BogRqyKv7QuUnOOiL8ifpC8zM RdgXUhI4TRKQzy4Z/MmBODJkqQ+sf7zDQhUZaNTxQ5p63j3Kt4UAgNZay2von2fmhc1xr7 yX8UQYLVApj6csrlVecb9xPjTcKPU50= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GVMCRVkT; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672675420; a=rsa-sha256; cv=none; b=Ldwh+dXt5EZhUDlN663JzHd5QOHUtTWVIXxAi78L1l4QuqEGwXQd47f8ooJljq8MA5u+F1 rTG6PDVXIG3znUfMeYWOg3qoPewQiQKV+HZ5ExA05HITqvgIeSWS+3HopxFfTEP3Obt8Ng veoU9QnUhYVTQPIERRZB95a34w58Pok= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672675417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vOa79JPMLDtsJKawOFwbLFa6Ffx1txwujF+5HHldqzI=; b=GVMCRVkTxDmvrIdHHUlPIZC49Sb6JwSzm9+8zefEfnGwBRsPjkYzjdCW7Wtmpr9E4puZqh nsH59UQ0OHWPlNkOgo4NAczEUI0RqbwOUFGjp+VvIzRwflipeiO5Holyr4UuaobDjcqMp9 /8U2mLkx9LHlcG5oXpa+D8HWEXwwCLY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-187-guohVwiQMTqd_d03Mqbjew-1; Mon, 02 Jan 2023 11:03:34 -0500 X-MC-Unique: guohVwiQMTqd_d03Mqbjew-1 Received: by mail-wm1-f69.google.com with SMTP id n8-20020a05600c294800b003d1cc68889dso6462458wmd.7 for ; Mon, 02 Jan 2023 08:03:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vOa79JPMLDtsJKawOFwbLFa6Ffx1txwujF+5HHldqzI=; b=BuxpoolHaEv03YExGTuP7E6HmTwUtzcgNb5RLuABEkPw3vNiiLPkTkc6jBPsy1L7MF RYVUtmEHHu6V6UY+yUzWiVl2M5ziKF7PXnPsT2bFTJdX0oVUcuc8M1d16ptkvQ5iAaSb vXxmqyDiHXb8+BiM8lka5keczZtrIoH7KPzJLALL4qYLyOfFUJX5Eca9DRPINBMKJNub 5Jej/yaiU96lNQMUd/t0tJxLlauV0a4zSgb8MsHmpdTjCGEo6x4oDJPXBXnYRgoKAGwr TRmxIMP56J3eL6nFg9AbR/0rNEmVbz4NqvMo+v/T1QLXL2g+67JADabxDkSghmViqhqK MinA== X-Gm-Message-State: AFqh2kqrhxLlooZM5xUCVUNM9SIi6bAm7v3NnT5EaTtkbsKV5qY2dXk+ nbUp9ffRXV+pyPBRQYZhkDBurG6/UFteoLF7ye8YiKEGY+r2fwoQSCOzh4iuvPGkOLOG4WKapmR e7/0zNHFpxUY= X-Received: by 2002:a05:600c:1c8e:b0:3d2:4234:e8fe with SMTP id k14-20020a05600c1c8e00b003d24234e8femr29586075wms.19.1672675413526; Mon, 02 Jan 2023 08:03:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXvG4zXrWfeob47kId+BpVCv03evMMJAXlMCfRO2OVPhWP+j17yOmecGedHKT9737Wy4/mGwUw== X-Received: by 2002:a05:600c:1c8e:b0:3d2:4234:e8fe with SMTP id k14-20020a05600c1c8e00b003d24234e8femr29586058wms.19.1672675413247; Mon, 02 Jan 2023 08:03:33 -0800 (PST) Received: from ?IPV6:2003:cb:c703:500:9382:2e5a:fea:8889? (p200300cbc703050093822e5a0fea8889.dip0.t-ipconnect.de. [2003:cb:c703:500:9382:2e5a:fea:8889]) by smtp.gmail.com with ESMTPSA id q16-20020a05600c46d000b003d1f3e9df3csm48584006wmo.7.2023.01.02.08.03.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 08:03:32 -0800 (PST) Message-ID: <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com> Date: Mon, 2 Jan 2023 17:03:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test To: Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vlastimil Babka , Jakub Matena , Matthew Wilcox , Mel Gorman , Michal Hocko References: <420e491062db9151504aef5661c8a2d928ef6bd7.1672675224.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <420e491062db9151504aef5661c8a2d928ef6bd7.1672675224.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 57D23A0007 X-Stat-Signature: xskyaqs1rxzhwgmpi49exinhzcpyett8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672675418-213675 X-HE-Meta: U2FsdGVkX1/o7nxw5X3brWR0IukTAHtaQQdpzq2g9TUm3LVb3gP+UPeaJ166Kd4B9gMbPyNTYww2YOhG92WiIALzFfYmvgbfG+epLag51TBu0VIIaqfJuBLpL4eQkkXTx43VFJE9q0M0WYPerb1nBHUiA7ncMATAAJLyZ5EICxmQ2VTMicWUcu9629jt7eUxjXufloji28FwtjXNwW5RwiXxdmZWoMdt2XtIESzTjI/MTVJm3SpIDQIf9SD1KQhhB7ySFIm+F1vQcD80igrE9Wgh/kmvrdlIfr/unimWQlC0jdGHQilKwOqrOqR7M3y4OToUSre7tZeIt0STJqrF8/mV+CZyQ/hKfUErPGwLCsj3NOwydCKfmJMCxPIn/NYbsk3pL8CwTF3gb0yb+lZMfhH+ZqUYb+/762+/0NGtQak6p5g2DPGM0ReOQ6y4Ej+YYgkW3viBefW5C+DnGTWKe/Q8n/1RTLyPZXMe66IU+v51VQH/zOKQfvC+4mQYcqN8Rw0m0KT0pD5PUIJ/zvX2Wg06PGzL1SyQPAIePqmzWDC+RxbUDx4i/hmhdt/+9L7R/4GnFtPzidwE8/QXcLJkZQivW4INnfBBkZV0uepqH8N10uTVidzkbAfjEpiSEpFg314QX2vmN9x1f+chLL4G+XLSLXlc28eFVvM+z0SdPO758MwHAKIgxFPSyC8KK9l5V6uPfUecE+LET0b8Y+5ApE8K2K4kYtbB5SAnbPQpO+isceLB3jQ+6vbLBfGIlO+m5HhjeDBRkiMvuhVzQaWNRT/3wqViJBKFZSRLXFeJL5musTEX9IytZyDq0j4VypyTQ7YahS/C3JcEk0EloyRYVXR461OUBTbz+84hZDC7k8BiM45hTzVTAlHh0jojl9NOWrY+v9+nfTVhur0MYbUBzWhObKZ/cZBsvHb/RJ/24T8lZg3yARo6fhuSjFnRos/LmCPwu8Z6jykFpIezsWW 9/8k2HfG 0ZXk9SS3NWhi3LAP1IL25omD+0Qn+rljB5DrTy8d1bvgQi0V05oxZYF9gQIpiHYgUfGOXnG5O0pWC1l1M4aHi8GMDrk9XJYr8l2pIScdEtykLNMBE0lijC+E8IsEIsR1+oVl9cV0TQbdA/f4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > - mremap_expand_merge(page_size); > + maps_fp = fopen("/proc/self/maps", "r"); > + if (maps_fp == NULL) { > + ksft_print_msg("Failed to read /proc/self/maps: %s\n", strerror(errno)); > + exit(KSFT_FAIL); > + } else { With the exit() in place, the else branch is implicit and the else can be dropped. > + mremap_expand_merge(maps_fp, page_size); > + mremap_expand_merge_offset(maps_fp, page_size); > + > + fclose(maps_fp); > + } > > if (run_perf_tests) { > ksft_print_msg("\n%s\n", Thanks! Acked-by: David Hildenbrand -- Thanks, David / dhildenb