From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vlastimil Babka <vbabka@suse.cz>,
Jakub Matena <matenajakub@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test
Date: Mon, 2 Jan 2023 17:03:31 +0100 [thread overview]
Message-ID: <9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com> (raw)
In-Reply-To: <420e491062db9151504aef5661c8a2d928ef6bd7.1672675224.git.lstoakes@gmail.com>
> - mremap_expand_merge(page_size);
> + maps_fp = fopen("/proc/self/maps", "r");
> + if (maps_fp == NULL) {
> + ksft_print_msg("Failed to read /proc/self/maps: %s\n", strerror(errno));
> + exit(KSFT_FAIL);
> + } else {
With the exit() in place, the else branch is implicit and the else can
be dropped.
> + mremap_expand_merge(maps_fp, page_size);
> + mremap_expand_merge_offset(maps_fp, page_size);
> +
> + fclose(maps_fp);
> + }
>
> if (run_perf_tests) {
> ksft_print_msg("\n%s\n",
Thanks!
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-02 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:01 Lorenzo Stoakes
2023-01-02 16:03 ` David Hildenbrand [this message]
2023-01-02 16:09 ` Lorenzo Stoakes
2023-01-02 16:10 ` David Hildenbrand
2023-01-02 16:16 ` Lorenzo Stoakes
2023-01-02 16:20 ` David Hildenbrand
2023-01-02 16:22 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d13393a-d203-23de-30ae-4d6476a94fd7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox