From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5207BC0015E for ; Wed, 9 Aug 2023 14:00:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53286B0072; Wed, 9 Aug 2023 10:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A03556B0075; Wed, 9 Aug 2023 10:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F23F8E0001; Wed, 9 Aug 2023 10:00:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E64D6B0072 for ; Wed, 9 Aug 2023 10:00:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 557EFC0F1A for ; Wed, 9 Aug 2023 14:00:40 +0000 (UTC) X-FDA: 81104726640.09.2CDD469 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 88E9812005B for ; Wed, 9 Aug 2023 14:00:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H+xSgxVt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691589634; a=rsa-sha256; cv=none; b=ZrV+4RziFnlNpjYxfPpx8pooLDW2ujIIwAod5o9Os6X5DVr794qYndEz2+q6QgRLcv0RwQ BPfQr0K1u5PSpl5dUyH6X73XE3v8AusxYg8RGihgGag8GsiAcMFDMrKBduq8Xr8+cS/FpP SKWjNC7p6LY8ZVVYiByWm6JgQ7/l2Xo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H+xSgxVt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691589634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aluolLqCzcz4OLmT1ULBFqNwssRR0Xduy3gDjygn/A8=; b=SlGU3nqSqTv3yB/xHoWMZ37OXeodmN1v0q0iP9uk349JVsCLY6k67kllxaXtDaC0ZBTz/T YqWSel2O/0x1OR6xiB744+PoidMtVvpmSfQTJt7ybWkUz2x4TcAr1188+N0vyJfDNZT/xl j5Hg1jFQv9o5ct6x7R08X/bNIoJ5XUY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691589633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aluolLqCzcz4OLmT1ULBFqNwssRR0Xduy3gDjygn/A8=; b=H+xSgxVtwy1KjHY0xT8jKRr7Xjtqk+6QZ/yfqTTTPAh1+qbcUDjlkQIBqAgQZc/jXXExOu I46Y15rb1XNj11u0R7VMoAO7PsgYbLfM3qrqZ1/2ZTve1svXSqqn1kdMeRhTvIxJIhzlls Utik3NKHCzIeKRpNPyeQJl66SlkBd/M= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-5eCNwC0gMaGf0CRAa1vf-g-1; Wed, 09 Aug 2023 10:00:32 -0400 X-MC-Unique: 5eCNwC0gMaGf0CRAa1vf-g-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3176eb6babbso496962f8f.1 for ; Wed, 09 Aug 2023 07:00:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691589631; x=1692194431; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aluolLqCzcz4OLmT1ULBFqNwssRR0Xduy3gDjygn/A8=; b=HLZe1ZbSXRrJCLPTre5Y9N5+Pg7RHly41ymzHJqR29gTO2vD1NH9MPf3W7oKg/l+jq ejcsOdNaLM91IbuOQaC2BFwKJNaCsS5jMHvKHxVZ8nLIH/VY5CgR10VMT8v1VPds1kP4 cZ826dXLAUipFCLZ/3fSt8ma39Xe282UXWiIst2AIbUUwQsD+50d86ziLXsEb8D3gGAx VelTljaHMWnWpCX45ySlzJAZiDpglYHpv/flHxWvRC5RxUP+MHXi6iekRirLuwhmJ2B8 L3S22ZCQ0Vj6OU1Kv2Cd7SNyhy8Re+C8yFRygRQdxcNSqTBWGKMzkArsDOGC287Gj9St NRfw== X-Gm-Message-State: AOJu0YzDgQ3POgLsUuA+plYJ/xgwIXPOSjZCZ+dHm+wUbnPe4iBHB0bp fFu3wvyb6uqkZSJwnALPfH/57c4PcwOih1auMQXbspeHi8xTh6FyzVmcMZiti7V/eXPdlMV9YrE hyH157dCyWiY= X-Received: by 2002:adf:fcc4:0:b0:314:3369:df57 with SMTP id f4-20020adffcc4000000b003143369df57mr10478161wrs.5.1691589630824; Wed, 09 Aug 2023 07:00:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHq8eyODQkiCXu0pqsZC3bKXH5wWt/tpXu5a4c1dvrP2vcV295Iz5h7sZWgfaI/eIBurDamdQ== X-Received: by 2002:adf:fcc4:0:b0:314:3369:df57 with SMTP id f4-20020adffcc4000000b003143369df57mr10478140wrs.5.1691589630391; Wed, 09 Aug 2023 07:00:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6800:9933:28db:f83a:ef5? (p200300cbc70e6800993328dbf83a0ef5.dip0.t-ipconnect.de. [2003:cb:c70e:6800:9933:28db:f83a:ef5]) by smtp.gmail.com with ESMTPSA id c17-20020adffb11000000b00317efb41e44sm8029944wrr.18.2023.08.09.07.00.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 07:00:29 -0700 (PDT) Message-ID: <9d109a43-78a3-dee4-5aaa-385bdfe4bcb3@redhat.com> Date: Wed, 9 Aug 2023 16:00:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible To: Charan Teja Kalla , akpm@linux-foundation.org, zhaoyang.huang@unisoc.com, yuzhao@google.com, surenb@google.com, kaleshsingh@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 88E9812005B X-Stat-Signature: z78n68ymduxgkrutr8aknozcwmhk7ij6 X-HE-Tag: 1691589634-568605 X-HE-Meta: U2FsdGVkX19j52xFhOhNh28p0lgIV+WQEpGziEvisLf3LXofuP6KwZpit2fsXh3/zHvmrZZuFBcU/TIhGivyDqVMYwSTFv6qsEircvq56DQCM85q1xxWuLbq2U97yRT+dXYsrfFcTgdOlnaaTFCLIkdlGsqUPec2qXE8YHJX4F6+QazN61qbcz4KS06vQTVLCriqBFmB5ui/JWIRRIdIfkm3U+hX5IN/3K2E71CXzjfq4sCH9WsBjw+GWzXH630U8flApHVkw2G+MvO9pzey485ZFQPJVxBTLowb+Ihw4jtC90Rj4ZHwQFiT1seUIfRxveTLga968PrUS1LmpGMmQvxV7qOxWhybJq8aMkN/7BqIJQS/rD3nitXwdnk4VAOeSUuhkkv1Hj2NCxApsEiTiGWpxBuWGiTV9Oe/B644LrHq7FNg7RHyCQ3EHVtxUQMtyDXOiEtJ+7vN/ZbOSDUn6BkDQZFF9rsItZw/KqboW9Kh4xF90nLNzKBC5dI5U9BP1PW6JRWgAfM8StjutRUpRv5gb8KaiYYBn9ne6f4eQcrAfpIHIG2iWPCv1WufomPDGpZGQh1C3yeGivXUS+dS1h6bmypP+rU9eET9LGYG5D4j1vGihL+F0NAYvxPKEkRhmIwNE3QPV7QpNL9vJvpXUqHCz2UTKcNZQcs63HPSlHONRK07NGSf7q1S3GL9N99iZlD8Rz8fQMjkUmzx99oTLir26a+hynknzNALzBEohhZgpBHxfqgnIUjGxZjJhsWjtfBI5XnHWy9iMcF/dRGXNZQoD/hA6RuWqGjOE7YUFMU5O/2xAesA0GNPmaZoOHuPV5nJp7WWZPS3ZtucQwZoYpOdPbMR08bhCEmctKJ1kWG44xLyET4DkVHZ6k6TYU401GIs3cz4/VHacSXdZQdpVTy4pAM4yUUORO8nrPTe2sDmgdpuUQ9ACXAIskG6bL+AGz6zLhbqx/QDKvVdcwu O/pXDEWx rlw9v0o1p0qeRFkApFiNUVUii5RBLGv9mC6E2GEhUBUI1uzhGo9v3DhgCML4qGXVDz77wgRN5atD0w1H4WdE99F3WkU7UgNwC2JYDzy5nv8yVfmABcf3A2ggbt8vyM4Mqu1Kd4+YXpoG+9/cFgcXSAFiwnZCEuTpiReZx+gs2DJ/ZfQWxIyI4FbDn13/HarsjOv6ZyEQLN+9DEWALRO5OZU/hu/2OfLlOEhNbgT1BNmJcMUADj08nadHWH4gsq1yUT1xy/MuGQSm7HH+6+IogiT8jJJMu5RPzYxtcUVKwiEkgbpiq/aB2AAIqIR2LbERKBv/vN9R2FcGSmZQYWMPYB+LBmDV0OtdrkH+TfPeFU1Vm+OEjo2M97reJAEWp/Sp4+3QEXainLNrc7oXU4tGQiadW4vmKc/aa49ldb6nOFLrKB6JhFG0aLcgBkXCke4K8mwvh X-Bogosity: Ham, tests=bogofilter, spamicity=0.018721, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.08.23 10:05, Charan Teja Kalla wrote: > This patch is based on the commit 5da226dbfce3("mm: skip CMA pages when > they are not available") which skips cma pages reclaim when they are not > eligible for the current allocation context. In mglru, such pages are > added to the tail of the immediate generation to maintain better LRU > order, which is unlike the case of conventional LRU where such pages are > directly added to the head of the LRU list(akin to adding to head of the > youngest generation in mglru). > > No observable issue without this patch on MGLRU, but logically it make > sense to skip the CMA page reclaim when those pages can't be satisfied > for the current allocation context. > > Signed-off-by: Charan Teja Kalla > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index b4329f9..6cbe921 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4943,7 +4943,7 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, struct scan_c > } > > /* ineligible */ > - if (zone > sc->reclaim_idx) { > + if (zone > sc->reclaim_idx || skip_cma(folio, sc)) { > gen = folio_inc_gen(lruvec, folio, false); > list_move_tail(&folio->lru, &lrugen->folios[gen][type][zone]); > return true; Makes sense to me. -- Cheers, David / dhildenb