From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 255B1C433FE for ; Mon, 28 Nov 2022 08:18:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB33D6B0072; Mon, 28 Nov 2022 03:18:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B62766B0073; Mon, 28 Nov 2022 03:18:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A01DC6B0074; Mon, 28 Nov 2022 03:18:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 90D216B0072 for ; Mon, 28 Nov 2022 03:18:55 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53E8BA09F2 for ; Mon, 28 Nov 2022 08:18:55 +0000 (UTC) X-FDA: 80182150230.08.F260934 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 5FF6240009 for ; Mon, 28 Nov 2022 08:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669623533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=S+oFkjKVP3mckzd7VBbvH1QuZTZol0q9wTWffdsPiXu+2nmhjaLmPhu8ziCyV0KCioRPJI 5JQ7Ka6QTT7w/TcDd4C3+oasgr3fATIDGVWRdSU8qp6A71RrRGJewLWoV59J4JHfMOQ3z1 2VHUt/gcI6faTsrG8illEYtRpXcU/30= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-332-pJdNp5XXNcuPRz1qkqq8Tw-1; Mon, 28 Nov 2022 03:18:51 -0500 X-MC-Unique: pJdNp5XXNcuPRz1qkqq8Tw-1 Received: by mail-wm1-f72.google.com with SMTP id p14-20020a05600c204e00b003cf4cce4da5so3487444wmg.0 for ; Mon, 28 Nov 2022 00:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=wJc0VQuy293sxOk9EWw0wql95C8oKZfojse8cGwhwZzusR1VvL93J2NrwOMSMnYY9t 3EqEbO/oKlnujufPTkop5WRlnqkC1EQewfiyzsX0p46yS+gqkWyWT762X+ddPSJr9qZv GxeqJAXu0xT9ml9z7lReBSman90vMmUJw3q9NZiX8IA623STZsOR1qqyeRWdrcJCE8p2 pBu3+WoVpAZyoT8FCJdp2KwtM0sLTmtRuPgYwah8TkqtXScM/3FcjrW0jnPaaOpjcGeL j1/FOEf9jLhMuAF1C0LwEnf1HB53hapGByb44TkUQpe4O52JstxYbarvjrJK/1VlT1Ny xVQw== X-Gm-Message-State: ANoB5pkAuWdySprisANfxC2ZW/mx7kFhjmTkHSnIEZ8xUUUEe0+gJgHE LdlP1iL+mb6vvWPQlmvOvSX450DQF+CSoeQNJgkhjWVEzuNbgfgOBHmtI8tCoBEN3SDotBg/Q5H +EWWDHVSLt34= X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262280wmq.152.1669623530584; Mon, 28 Nov 2022 00:18:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5KFgnMS9OgeX6iNUgB1p0xskb3yOxviUW4FnLaUffslFm3du7Shktyf0rRUHCATZ7f+3nFJA== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr36262220wmq.152.1669623530122; Mon, 28 Nov 2022 00:18:50 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b003a2f2bb72d5sm22518102wmo.45.2022.11.28.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:18:49 -0800 (PST) Message-ID: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> Date: Mon, 28 Nov 2022 09:18:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> From: David Hildenbrand Organization: Red Hat In-Reply-To: <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669623535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ueiNL/RrPlD3vRod9MDAxJpgFwmJj0Jyg8USWk7yPz8=; b=JWzNzKTi4oEhJgrl1jFgvbIE8xByalwnGjgylnMn1isHzVIGU8uIMgwO+CUOLxlheW60jM s9YinoalqV1eemjuvtuh6DJl7ns4w/p7p3yjwmpzAbXdnZqUpRMRw1edu+EmyyQ9iBeDj/ OT1mpWiPTJemQ/lvcE+E7FyGA9oKqxc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S+oFkjKV; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669623535; a=rsa-sha256; cv=none; b=6yTPz4F1JSu/NnyUb5TbvxD4UH1WD4/7CwhZ+OX5+hp3Uj/m6U2dGCZz4nF4UlCBXpVGRT p5z3N+nJcM8wDHmllq5+2V4/IC3TE6j0Imy6miTDa9iA/4mpIqOi8Ol7dH+t0oiV9OiiQj M4nTLgT3PwmCf/mWu09aef1NsKgGeRk= X-Rspamd-Queue-Id: 5FF6240009 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S+oFkjKV; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ys6gukep854n3jirknjawzfsrkhxw35d X-HE-Tag: 1669623534-983314 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.11.22 09:17, Hans Verkuil wrote: > Hi David, > > On 27/11/2022 11:35, David Hildenbrand wrote: >> On 16.11.22 11:26, David Hildenbrand wrote: >>> FOLL_FORCE is really only for ptrace access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), get_vaddr_frames() currently pins all pages writable as a >>> workaround for issues with read-only buffers. >>> >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are >>> always writable"). Let's just remove it. >>> >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could >>> again be set depending on the DMA direction. >>> >>> Cc: Hans Verkuil >>> Cc: Marek Szyprowski >>> Cc: Tomasz Figa >>> Cc: Marek Szyprowski >>> Cc: Mauro Carvalho Chehab >>> Signed-off-by: David Hildenbrand >>> --- >>>   drivers/media/common/videobuf2/frame_vector.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c >>> index 542dde9d2609..062e98148c53 100644 >>> --- a/drivers/media/common/videobuf2/frame_vector.c >>> +++ b/drivers/media/common/videobuf2/frame_vector.c >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, >>>       start = untagged_addr(start); >>>         ret = pin_user_pages_fast(start, nr_frames, >>> -                  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, >>> +                  FOLL_WRITE | FOLL_LONGTERM, >>>                     (struct page **)(vec->ptrs)); >>>       if (ret > 0) { >>>           vec->got_ref = true; >> >> >> Hi Andrew, >> >> see the discussion at [1] regarding a conflict and how to proceed with >> upstreaming. The conflict would be easy to resolve, however, also >> the patch description doesn't make sense anymore with [1]. > > Might it be easier and less confusing if you post a v2 of this series > with my patch first? That way it is clear that 1) my patch has to come > first, and 2) that it is part of a single series and should be merged > by the mm subsystem. > > Less chances of things going wrong that way. > > Just mention in the v2 cover letter that the first patch was added to > make it easy to backport that fix without being hampered by merge > conflicts if it was added after your frame_vector.c patch. Yes, that's the way I would naturally do, it, however, Andrew prefers delta updates for minor changes. @Andrew, whatever you prefer! Thanks! -- Thanks, David / dhildenb