From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9465C433DB for ; Tue, 2 Feb 2021 22:19:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2362464F3F for ; Tue, 2 Feb 2021 22:19:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2362464F3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9EA916B0006; Tue, 2 Feb 2021 17:19:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 998A26B006C; Tue, 2 Feb 2021 17:19:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85F686B006E; Tue, 2 Feb 2021 17:19:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 692706B0006 for ; Tue, 2 Feb 2021 17:19:24 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 39ED4180AD81A for ; Tue, 2 Feb 2021 22:19:24 +0000 (UTC) X-FDA: 77774745048.11.lock03_3008b2c275ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 187A9180F8B80 for ; Tue, 2 Feb 2021 22:19:24 +0000 (UTC) X-HE-Tag: lock03_3008b2c275ce X-Filterd-Recvd-Size: 2337 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 22:19:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 52F0F64EDA; Tue, 2 Feb 2021 22:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612304362; bh=sqKuQs7jQgfFKC1Q1g879kjxuInD33WZU6Kyi8Egc/s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZHIzuLiLZYUnhnmDOcDkihUadtik/Hl9/62tXeZxuBIZgmOeS5F6w2tafqAP9+RSZ 6tWnZR37PWEVFo9PFkg1HgUWpn5JNwQDPvox5Agspa/bGIPaDin7dCYN3Cv7KUqX1z uRwiO1hUPHlwldfUNapMM+0VrhDzAtJJBbauqoEVSaT6BvR1W91fn8/nBjuex7dy2P WMEzO80pm1v98Zx1ZthQcdGieCx5WpkeDVKrhsnfEbTssOqX5Ydjur1svvVpPrx2Zi KgTid3VeyZx7fqVuxizToCDvnnvlbPUQKvghI1RCaky/X3JbrZ7w3xuyEh+0o1jWh9 Joo9Jikwe236Q== Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed To: Kees Cook Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, john.ogness@linutronix.de, akinobu.mita@gmail.com References: <20210202201846.716915-1-timur@kernel.org> <202102021351.AEDE896AB3@keescook> From: Timur Tabi Message-ID: <9ce56a1c-9ea6-996b-84c6-cfde908c2ecd@kernel.org> Date: Tue, 2 Feb 2021 16:19:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202102021351.AEDE896AB3@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/2/21 3:52 PM, Kees Cook wrote: >> A large warning message is displayed if this option is enabled, >> because unhashed addresses, while useful for debugging, exposes >> kernel addresses which can be a security risk. > Linus has expressly said "no" to things like this in the past: > https://lore.kernel.org/lkml/CA+55aFwieC1-nAs+NFq9RTwaR8ef9hWa4MjNBWL41F-8wM49eA@mail.gmail.com/ Maybe I misunderstood, but I thought this is what Vlastimil, Petr, Sergey, John, and Steven asked for.