From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25426C678D4 for ; Tue, 7 Mar 2023 10:22:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73073280001; Tue, 7 Mar 2023 05:22:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0DF6B0074; Tue, 7 Mar 2023 05:22:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A89A280001; Tue, 7 Mar 2023 05:22:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4D8806B0073 for ; Tue, 7 Mar 2023 05:22:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1958480CD3 for ; Tue, 7 Mar 2023 10:22:25 +0000 (UTC) X-FDA: 80541712650.10.CF03C17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id C80BD14000F for ; Tue, 7 Mar 2023 10:22:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JhxT2o6K; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678184542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H/IPZqHOoz7jiojxziiZXAo+iRRmEKFV9o6Kto64+sI=; b=zknjYNNqtmt79DuAzu+FRc3d0gfJd8huWpq76MV3yLAjSIzdryFLPrnMR2CcYZJCkumNbM ELTQi0oE9Lp9l1niwxTAanVFCgy/yyp37tr4C5ZYmaotXzkWLQvmM0N4hHXujuBicmZSvW zLV+pmQP4PkrmxnrZ+3RQnRYrHdq4zs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JhxT2o6K; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678184542; a=rsa-sha256; cv=none; b=XP00QbSA1BIjKVOcKw2HVvpajFAEZQ999e1rMluQnfzoUwusImAI6Q6dmmOIzAiPqglbHe z9liJ53s/jY1dvnxR+oz9CjQyWLDrfgOdBBE0X4xj8YIwJf1NuRhaQDPKGLxM6Ry1Mzo79 arhZksn0GE1nXvW+H+cO1FTPZinLwzQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678184542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/IPZqHOoz7jiojxziiZXAo+iRRmEKFV9o6Kto64+sI=; b=JhxT2o6KMG1ramiX4xI8zSuhYbWU75bhc97b5xk7T2JBhzsn+WmeoD5WdRvjBDi+sCVTFK UoPNOmVsS2YdtPjwetrv/h/c8gSbv2xkRPTOrbMALlvwR8ezXodOidhEtrTIdYzpszqh/n 05ikZq8HG4YC7XlQzv2/633ustqL2/4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-Yi6nyPxAOQqFmnaPIHkS6g-1; Tue, 07 Mar 2023 05:22:19 -0500 X-MC-Unique: Yi6nyPxAOQqFmnaPIHkS6g-1 Received: by mail-wr1-f69.google.com with SMTP id bx25-20020a5d5b19000000b002c7ce4ce3c3so2089362wrb.13 for ; Tue, 07 Mar 2023 02:22:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678184538; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H/IPZqHOoz7jiojxziiZXAo+iRRmEKFV9o6Kto64+sI=; b=d8WBynPvJxv5LUzGdUBPUKHu6Q3pzvw8Asdqtog2xBAXlkY58KkQmi+aL9HIROIZj/ hjEvFOL05nenr5EbiI+XWQ9m+2RKDhgGnyyeGyvgoscOXVTDfIEMrNVciLxbEc4Ch3Dp BUvQyTLooconnL+a+EUUhkVgW9wYmHffpUvCm25OXkkU4EIp1B848k9t+g4tGRdpznGo wb9VL537yIFXJ4CrarNio9o0VB5X/Amw6+dCIQS33HE8TU9zK8kTjnZXIVjDgZ9Scbsh g8HUu+jCBxRU62Yv1PS8tbRLonen2qts4GfsJp9bQYknUxISBravDOcz5toUr7mvvvSr SKKg== X-Gm-Message-State: AO0yUKVg+XVAf98yj9N3RMjHM+ttxBUuIhPfgd0wkoqLMiQqmpJLKBUY aosfTb83TspW5H5W2QER94VRkEnIccTjoqUnW0uHpFlGC8ufyxnGHAdI3cUY4ceHdLPveUcqKIN NdgIGQmmXI/I= X-Received: by 2002:a5d:5452:0:b0:2ce:50a9:6d8e with SMTP id w18-20020a5d5452000000b002ce50a96d8emr6603681wrv.20.1678184537904; Tue, 07 Mar 2023 02:22:17 -0800 (PST) X-Google-Smtp-Source: AK7set/i5Nv1U3NOAuCbE4btJ9ZAiOioRnHyw6o9C90eWaBZTs9BfvSsigkdVvJPs3CCoLRzMZNrMw== X-Received: by 2002:a5d:5452:0:b0:2ce:50a9:6d8e with SMTP id w18-20020a5d5452000000b002ce50a96d8emr6603670wrv.20.1678184537566; Tue, 07 Mar 2023 02:22:17 -0800 (PST) Received: from ?IPV6:2003:cb:c707:a100:e20:41da:c49b:8974? (p200300cbc707a1000e2041dac49b8974.dip0.t-ipconnect.de. [2003:cb:c707:a100:e20:41da:c49b:8974]) by smtp.gmail.com with ESMTPSA id a17-20020a056000101100b002c553e061fdsm12270849wrx.112.2023.03.07.02.22.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Mar 2023 02:22:17 -0800 (PST) Message-ID: <9ce5434e-4c19-cb34-d3fa-99738c265b03@redhat.com> Date: Tue, 7 Mar 2023 11:22:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] selftests/mm: fix split huge page tests To: Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Zach O'Keefe References: <20230306160907.16804-1-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230306160907.16804-1-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C80BD14000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: pp8x5w8za65ayd16ctcxfgt4qc6n6wep X-HE-Tag: 1678184542-460600 X-HE-Meta: U2FsdGVkX18hhQREMRXkHWcM8SfrslYp0cngMb/D70Xxq+JsbpQzB+zLcovq4sEF+d/UqIfWwPo/YQ1mwK/oxMStNgc/Erbl36bBUmZDvKaDeKp+KV+AaMFJj8b4jd87tGnU3deiSlpatKaRItsVOQvMuNG/X21XIRruy6MhOb7sDEqN2fPMIInwWuGrzmUcqNJ5yc5yoNwsmWdWwkFdUf0+BU/1rFxA9AESzHNZS5PryiD8r9mTbO3n7EQUh876YOa60KGv7c2fBM4+viW9B66vdJEAbAIA/ll0m1+KOfp1iYzMNHU5f0QQL8sX5AKHGbz1UBkreZGPCGHif8G6QXtCiIJo/mRZz5hyreeFc0NBuYn88/VfShW2QEgx774TmcjdbzeFCB3UnXwiPLS2X4T9rbdeEns45gFbKRO653CPB+Ed1yIDdT1zr1TOCHJU/z9yiM55xEJr5B4dvP73dJZWbIl28+kx79b8nrBXoRNzeOwDftxODCmsbQ0xM7vSitbZ9ThDiXPGQjIJq4vJSFrG/Ul9KMVEDwFiuKTZXftItpnqO4z7jLduALlApmt9uVQ6LiS/D/eAi6jcm3kGCVlS4wTYpirRB+I5UsGJ2Iglkkg9JaQhc8keOwEHJK2JaenZYMRq5qHh+4zC2WDTy206LVT1phS+vKNCu3UZi35nliZ2yPG/373+7vHa5fl/Qb7zQHP0tQ1PYJNLBMrXt4CCF+xXUXzixB43KOHA/ol3C11uUpdHT/uWI4eWhYAqZ4nffdNIlpmjByeU8DuFZVGN9YL/an/uMkyPPUUWODmPbgoZyng0Ouz6xAbpqdyoOh/qXoB/Uz9sFZuvvteZjHGoL0TlhCd2P8VVPgH1kElpWzSl52/KXPQM4ms4vrMCYI7MGdao6Q5VGnasrTpE+9V/Aa10Zr0t7oMUMG9IepHY532hsEdtTVLqThfAbmYATCfGPmIQotTiVQW+MSH OmAugcMw pPm02R279bK8MfW5FxpFM4FhKsp4hxZObCT2LPf9KJvpiX7AYsR8xnxEi3s3bl+l6MEA4O6zBn+oxxKrxpeJcCWUfFSMYlV2TdgNG25i57oQi0dR5aSc8m9lLliyks2z1cdtLFsuzqakP/HqD8u72towLlJKgoJ1pzrfPyYtInsxjlNiiGqT2Y56E/jpmQA1ODDFU7SlRE0jXPmI6EinPvtNf2MYtiatR9Wbj/jvHRoQ6dJXwnlK2zU9Dw8EUCxwzLNzRWUYwhp53ugF75HIAZAFm0nxMGViWkyuFBNV/Vd+1ZOG7mT1XaW21r6SOMHNAmZoOCXA1E1p8a6VaRSdoEvq6nbno2/SR3LGn7G8BuXPj2Zj3WqbR5LaiFcr4qW+yG0D8x/rRxVgwS2xsp8X40te86tpWnAOpgEGQ8b1jZeRkLIkdUPpAItjNaf0KCkIQ+7PHSt/2PL2b3HHCLfnsoXOIyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.03.23 17:09, Zi Yan wrote: > From: Zi Yan > > Fixed two inputs to check_anon_huge() and one if condition, so the tests > work as expected. > > Fixes: c07c343cda8e ("selftests/vm: dedup THP helpers") > Signed-off-by: Zi Yan > Cc: Zach O'Keefe > --- > tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index 76e1c36dd9e5..b8558c7f1a39 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -106,7 +106,7 @@ void split_pmd_thp(void) > for (i = 0; i < len; i++) > one_page[i] = (char)i; > > - if (!check_huge_anon(one_page, 1, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 4, pmd_pagesize)) { > printf("No THP is allocated\n"); > exit(EXIT_FAILURE); > } > @@ -122,7 +122,7 @@ void split_pmd_thp(void) > } > > > - if (check_huge_anon(one_page, 0, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 0, pmd_pagesize)) { > printf("Still AnonHugePages not split\n"); > exit(EXIT_FAILURE); > } > @@ -169,7 +169,7 @@ void split_pte_mapped_thp(void) > for (i = 0; i < len; i++) > one_page[i] = (char)i; > > - if (!check_huge_anon(one_page, 1, pmd_pagesize)) { > + if (!check_huge_anon(one_page, 4, pmd_pagesize)) { > printf("No THP is allocated\n"); > exit(EXIT_FAILURE); > } Hard to read. It should probably be "get_huge_anon()" to then check for the value in the caller manually. Negative value could be used as an indicator for an error obtaining the value. Anyhow, was briefly confused about the 4 ("magic value" also apprearing in "size_t len = 4 * pmd_pagesize;") but it seems to be the right thing to do. Acked-by: David Hildenbrand -- Thanks, David / dhildenb